)]}'
{"rally/plugins/openstack/scenarios/designate/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3c318b49746d18a3ab6a76931ed9a1ba1343074b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def _update_domain(self, domain):"},{"line_number":52,"context_line":"        \"\"\"Update designate domain."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param domain: domain"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        domain[\"description\"] \u003d \"updated domain\""},{"line_number":57,"context_line":"        domain[\"email\"] \u003d \"updated@random.name\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_37c7cf46","line":54,"updated":"2015-12-16 11:19:39.000000000","message":"designate domain","commit_id":"e9e5389d0296e3729c10ac9c334836e7a641c0bd"},{"author":{"_account_id":19811,"name":"maheshy","email":"mahesh_y@persistent.co.in"},"change_message_id":"081af141c046aba85b309e5a286c0c645a6029c4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def _update_domain(self, domain):"},{"line_number":52,"context_line":"        \"\"\"Update designate domain."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param domain: domain"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        domain[\"description\"] \u003d \"updated domain\""},{"line_number":57,"context_line":"        domain[\"email\"] \u003d \"updated@random.name\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_f690a297","line":54,"in_reply_to":"5a710552_37c7cf46","updated":"2015-12-17 11:34:58.000000000","message":"Done","commit_id":"e9e5389d0296e3729c10ac9c334836e7a641c0bd"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3c318b49746d18a3ab6a76931ed9a1ba1343074b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        :param domain: domain"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        domain[\"description\"] \u003d \"updated domain\""},{"line_number":57,"context_line":"        domain[\"email\"] \u003d \"updated@random.name\""},{"line_number":58,"context_line":"        self.clients(\"designate\").domains.update(domain)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @atomic.optional_action_timer(\"designate.create_record\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_7710f7a8","line":57,"updated":"2015-12-16 11:19:39.000000000","message":"Why you change this lines? Domain by which you update existing domain was passed through params","commit_id":"e9e5389d0296e3729c10ac9c334836e7a641c0bd"},{"author":{"_account_id":19811,"name":"maheshy","email":"mahesh_y@persistent.co.in"},"change_message_id":"081af141c046aba85b309e5a286c0c645a6029c4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        :param domain: domain"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        domain[\"description\"] \u003d \"updated domain\""},{"line_number":57,"context_line":"        domain[\"email\"] \u003d \"updated@random.name\""},{"line_number":58,"context_line":"        self.clients(\"designate\").domains.update(domain)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @atomic.optional_action_timer(\"designate.create_record\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_f65502c6","line":57,"in_reply_to":"5a710552_7710f7a8","updated":"2015-12-17 11:34:58.000000000","message":"Hi Roman,\n\nThanks for your comments. \nAs domain is created in scenario (basic.py) and passing the same object without updating the parameters to _update_domain in utils.py. Hence updating the parameters in _update_domain in utils.py.\n\nThanks,\nMahesh","commit_id":"e9e5389d0296e3729c10ac9c334836e7a641c0bd"}],"tests/unit/plugins/openstack/scenarios/designate/test_utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"ae5236fd0c1597fa578cee74ea88480aa4adf127","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        scenario._update_domain(domain)"},{"line_number":77,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":78,"context_line":"                                       \"designate.update_domain\")"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @ddt.data("},{"line_number":81,"context_line":"        {},"},{"line_number":82,"context_line":"        {\"data\": \"127.0.0.1\"})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_15dca444","line":79,"updated":"2015-12-21 16:05:27.000000000","message":"Actually the most important check is missed:\n\n self.clients(\"designate\").domains.update.assert_called_once_with( ... )","commit_id":"1cca34a9efc2b3d56097a146ea3e78935c0cc26a"},{"author":{"_account_id":19811,"name":"maheshy","email":"mahesh_y@persistent.co.in"},"change_message_id":"38ab4e1c7910d43abfdeb7b9050c39dc181a5697","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        scenario._update_domain(domain)"},{"line_number":77,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":78,"context_line":"                                       \"designate.update_domain\")"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @ddt.data("},{"line_number":81,"context_line":"        {},"},{"line_number":82,"context_line":"        {\"data\": \"127.0.0.1\"})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_7e160b4d","line":79,"in_reply_to":"3a7e1126_15dca444","updated":"2015-12-22 08:49:32.000000000","message":"Done","commit_id":"1cca34a9efc2b3d56097a146ea3e78935c0cc26a"},{"author":{"_account_id":19811,"name":"maheshy","email":"mahesh_y@persistent.co.in"},"change_message_id":"545ae30e81a54d110da8ec8f42069f52760c883b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        scenario._update_domain(domain)"},{"line_number":77,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":78,"context_line":"                                       \"designate.update_domain\")"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @ddt.data("},{"line_number":81,"context_line":"        {},"},{"line_number":82,"context_line":"        {\"data\": \"127.0.0.1\"})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_d3337860","line":79,"in_reply_to":"3a7e1126_15dca444","updated":"2015-12-22 08:43:46.000000000","message":"Hi Alexander,\nThanks for yor comment.\n\nI have added the specified check in test_update_domain.\n\nThank You, \nMahesh","commit_id":"1cca34a9efc2b3d56097a146ea3e78935c0cc26a"}]}