)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a31acab05f66b40cc0f906032678f00518e9774a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-12-25 18:11:13 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add base class for task exporter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3365f8dc5237a75041e902787a88e7d8896d7abe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a7b0d38_d3dafa4b","line":8,"updated":"2015-12-28 10:33:07.000000000","message":"Implements: task_and_verification_export.rst","commit_id":"d76b63949eb387d9728bd65f9a5e22cb596ec748"}],"doc/specs/in-progress/task_and_verification_export.rst":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a31acab05f66b40cc0f906032678f00518e9774a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"-----------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Primary assignee:"},{"line_number":90,"context_line":"rvasilets \u003crvasilets@mirantis.com\u003e"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Work Items"},{"line_number":93,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a7b0d38_d3ce7a2d","line":90,"updated":"2015-12-28 10:33:07.000000000","message":"Put a blank line between L89 and L90 to have your name on separate line in HTML format","commit_id":"d76b63949eb387d9728bd65f9a5e22cb596ec748"}],"rally/task/exporter.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a31acab05f66b40cc0f906032678f00518e9774a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"         Export results of the task to the task storage."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param task: task object"},{"line_number":42,"context_line":"        :param connection_string: string used to connect"},{"line_number":43,"context_line":"                                  to the external system"},{"line_number":44,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_56e7d810","line":42,"updated":"2015-12-28 10:33:07.000000000","message":"Maybe URL?","commit_id":"d76b63949eb387d9728bd65f9a5e22cb596ec748"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c12d93b12ee3795c9e4044ecfd19275927214f1e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"         Export results of the task to the task storage."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param task: task object"},{"line_number":42,"context_line":"        :param connection_string: string used to connect"},{"line_number":43,"context_line":"                                  to the external system"},{"line_number":44,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_0f05ae12","line":42,"in_reply_to":"1a7b0d38_56e7d810","updated":"2015-12-28 16:37:39.000000000","message":"It could be not only url. And this name is proved in spec","commit_id":"d76b63949eb387d9728bd65f9a5e22cb596ec748"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c1480432b52fa18349ce0faecabbb2b293032101","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class TaskExporter(plugin.Plugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def export(self, task, connection_string):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"         Export results of the task to the task storage."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_7ecf4029","line":38,"updated":"2016-01-05 13:26:50.000000000","message":"Using connection_string as parameter makes instantiation useless since everything is inside one method, for example:\n\n  FooTaskExporter(TaskExporter):\n    def export((self, task, connection_string):\n      # some implementation\n\n  foo \u003d FooTaskExporter()\n  foo.export(task1, \"http://user:pass@foosvc/import\")\n  foo.export(task2, \"http://user:pass@foosvc/import\")\n  foo.export(task3, \"http://user:pass@foosvc/import\")\n  foo.export(task4, \"http://user:pass@foosvc/import\")\n  foo.export(task5, \"http://user:pass@foosvc/import\")\n\nHowever this would be more efficient usage of OOP:\n\n  foo \u003d FooTaskExporter(\"http://user:pass@foosvc/import\")\n  foo.export(task1)\n  foo.export(task2)\n  foo.export(task3)\n  foo.export(task4)\n  foo.export(task5)","commit_id":"ef2f9f7084393e4e78f35a485d8450d42b31d88c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4a639ce7949fb63de98f37a3a04a5279690b238b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class TaskExporter(plugin.Plugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def export(self, task, connection_string):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"         Export results of the task to the task storage."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_16bdc8b6","line":38,"in_reply_to":"fa69d971_7ecf4029","updated":"2016-01-05 14:16:06.000000000","message":"This is signature that was specified in spec https://review.openstack.org/#/c/241596/5","commit_id":"ef2f9f7084393e4e78f35a485d8450d42b31d88c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"700c93e178155365cb5a55839fd4b4718dd73820","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class TaskExporter(plugin.Plugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def export(self, task, connection_string):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"         Export results of the task to the task storage."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_f2b52dd0","line":38,"updated":"2016-01-27 14:16:38.000000000","message":"So this won\u0027t work for us in long term. \n\nWe should accept here task_uuid, because basically in some cases you won\u0027t be able to keep all data of all task in memory","commit_id":"09dd80af96a17a82dc649b30325abeb1a222c06c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2cf6409c0fb9c4fa79f04d9527eaa7f198c9e23e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class TaskExporter(plugin.Plugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def export(self, task, connection_string):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"         Export results of the task to the task storage."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_b019dc24","line":38,"in_reply_to":"7a5de9d1_f2b52dd0","updated":"2016-02-08 13:31:34.000000000","message":"Agree. I was made task_uuid first, but then I looked at the spec at changed)","commit_id":"09dd80af96a17a82dc649b30325abeb1a222c06c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"51b8515de6621483a08da2ffdb8b4ca54ddfa5c5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"         Export results of the task to the task storage."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :param task_uuid: uuid of task object"},{"line_number":43,"context_line":"        :param connection_string: string used to connect"},{"line_number":44,"context_line":"                                  to the external system"},{"line_number":45,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_0b550f1c","line":42,"updated":"2016-02-09 16:59:01.000000000","message":"uuid of task results","commit_id":"64c8dec913c65ae90cb9489f207bc3d16a03f841"}],"rally/verification/exporter.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c1480432b52fa18349ce0faecabbb2b293032101","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":34,"context_line":"@configure(name\u003d\"base_verify_exporter\")"},{"line_number":35,"context_line":"class VerifyExporter(plugin.Plugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def export(self, uuid, connection_string):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_d9da064c","line":35,"updated":"2016-01-05 13:26:50.000000000","message":"Maybe s/Verify/Verification/ ?\n\n1) \u0027verify\u0027 is a verb\n2) in Rally, \u0027verification\u0027 is preferred term","commit_id":"ef2f9f7084393e4e78f35a485d8450d42b31d88c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4a639ce7949fb63de98f37a3a04a5279690b238b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":34,"context_line":"@configure(name\u003d\"base_verify_exporter\")"},{"line_number":35,"context_line":"class VerifyExporter(plugin.Plugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def export(self, uuid, connection_string):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_36ab2c77","line":35,"in_reply_to":"fa69d971_d9da064c","updated":"2016-01-05 14:16:06.000000000","message":"This name was taken from spec","commit_id":"ef2f9f7084393e4e78f35a485d8450d42b31d88c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"51b8515de6621483a08da2ffdb8b4ca54ddfa5c5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class VerifyExporter(plugin.Plugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def export(self, uuid, connection_string):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"         Export results of the task to the task storage."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_8b3fbfd5","line":38,"updated":"2016-02-09 16:59:01.000000000","message":"verification_uuid","commit_id":"64c8dec913c65ae90cb9489f207bc3d16a03f841"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"51b8515de6621483a08da2ffdb8b4ca54ddfa5c5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"         Export results of the task to the task storage."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :param uuid: uuid of verification"},{"line_number":43,"context_line":"        :param connection_string: string used to connect"},{"line_number":44,"context_line":"                                  to the external system"},{"line_number":45,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_eb051314","line":42,"updated":"2016-02-09 16:59:01.000000000","message":"verification_uuid: uuid of verification results","commit_id":"64c8dec913c65ae90cb9489f207bc3d16a03f841"}],"tests/unit/task/test_exporter.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a31acab05f66b40cc0f906032678f00518e9774a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_task_export(self):"},{"line_number":30,"context_line":"        fake_exporter \u003d TestExporter()"},{"line_number":31,"context_line":"        self.assertRaises(NotImplementedError,"},{"line_number":32,"context_line":"                          fake_exporter.export, \"fake_task\", \"fake_connection\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_b662bc3c","line":31,"updated":"2015-12-28 10:33:07.000000000","message":"Does this tests anything? class TestExporter is a part of tests, not testing code, but we do not write tests for tests.\n\nI think the correct test case is ensure that we can not instantiate exporter.TaskExporter since this is an abstract class, and then prove that overriding method `export\u0027 allows instantiation:\n\n class TestExporter(exporter.TaskExporter):\n\n     def export(self, task, connection_string):\n         pass\n\n\n class ExporterTestCase(test.TestCase):\n\n    def test_task_export(self):\n        self.assertRaises(TypeError, exporter.TaskExporter)\n        TestExporter()","commit_id":"d76b63949eb387d9728bd65f9a5e22cb596ec748"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c1480432b52fa18349ce0faecabbb2b293032101","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tests.unit import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@plugin.configure(name\u003d\"test_exporter\")"},{"line_number":21,"context_line":"class TestExporter(exporter.TaskExporter):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def export(self, task, connection_string):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_7980baf7","line":20,"updated":"2016-01-05 13:26:50.000000000","message":"Maybe exporter.configure?","commit_id":"ef2f9f7084393e4e78f35a485d8450d42b31d88c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4a639ce7949fb63de98f37a3a04a5279690b238b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tests.unit import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@plugin.configure(name\u003d\"test_exporter\")"},{"line_number":21,"context_line":"class TestExporter(exporter.TaskExporter):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def export(self, task, connection_string):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_1696283f","line":20,"in_reply_to":"fa69d971_7980baf7","updated":"2016-01-05 14:16:06.000000000","message":"Possibly","commit_id":"ef2f9f7084393e4e78f35a485d8450d42b31d88c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"700c93e178155365cb5a55839fd4b4718dd73820","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_task_export(self):"},{"line_number":29,"context_line":"        self.assertRaises(TypeError, exporter.TaskExporter)"},{"line_number":30,"context_line":"        TestExporter()"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_3d59eb35","line":30,"updated":"2016-01-27 14:16:38.000000000","message":"this should be split to 2 different test cases","commit_id":"09dd80af96a17a82dc649b30325abeb1a222c06c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2cf6409c0fb9c4fa79f04d9527eaa7f198c9e23e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_task_export(self):"},{"line_number":29,"context_line":"        self.assertRaises(TypeError, exporter.TaskExporter)"},{"line_number":30,"context_line":"        TestExporter()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_50866814","line":30,"in_reply_to":"fa69d971_3d59eb35","updated":"2016-02-08 13:31:34.000000000","message":"ok","commit_id":"09dd80af96a17a82dc649b30325abeb1a222c06c"}],"tests/unit/verification/test_exporter.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"700c93e178155365cb5a55839fd4b4718dd73820","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_task_export(self):"},{"line_number":30,"context_line":"        self.assertRaises(TypeError, exporter.VerifyExporter)"},{"line_number":31,"context_line":"        TestExporter()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_f2dc4d1a","line":31,"updated":"2016-01-27 14:16:38.000000000","message":"and what does this test? hM?","commit_id":"09dd80af96a17a82dc649b30325abeb1a222c06c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"85f3bf45922c24d9cea890b1182b8441c2925dc0","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_task_export(self):"},{"line_number":30,"context_line":"        self.assertRaises(TypeError, exporter.VerifyExporter)"},{"line_number":31,"context_line":"        TestExporter()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_f249ad8f","line":31,"in_reply_to":"7a5de9d1_f2dc4d1a","updated":"2016-01-27 14:22:45.000000000","message":"This proves that class TestExporter can be instantiated without errors, but its base class (abstract) can\u0027t","commit_id":"09dd80af96a17a82dc649b30325abeb1a222c06c"}]}
