)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"22f7c421f26eb94c8bb23acfad7ecabc512344d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add task exporter to the file system"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the first task exporter plugin. It used to import rally task"},{"line_number":10,"context_line":"results to the file in json format."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I25117933ac0881453a001d96600d4c95e6064fff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"fa0719c6_f87b3826","line":9,"updated":"2016-03-23 14:20:36.000000000","message":"It used to export?","commit_id":"6bf9db872764c7c6767ce329b3191fd5e0101e88"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ae54aefe27d91a9c5a535c013c2c7825bce3bdf5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add task exporter to the file system"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the first task exporter plugin. It used to import rally task"},{"line_number":10,"context_line":"results to the file in json format."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I25117933ac0881453a001d96600d4c95e6064fff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"fa0719c6_8933cc13","line":9,"in_reply_to":"fa0719c6_f87b3826","updated":"2016-03-23 14:53:14.000000000","message":"Done","commit_id":"6bf9db872764c7c6767ce329b3191fd5e0101e88"}],"rally/cli/commands/task.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2cdab7f97bac51e1c17641043f8bd3ef8e1d47fe","unresolved":false,"context_lines":[{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        task \u003d api.Task.get(uuid)"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        def get_plugin_name(connection_string):"},{"line_number":755,"context_line":"            return \"filesystem_exporter\""},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"        client \u003d exporter.TaskExporter.get(get_plugin_name("}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_9a2e84f9","line":754,"updated":"2016-01-06 16:01:58.000000000","message":"Here we will get right name of exporter plugin from connection string","commit_id":"b8f535aeb988a60852acc71d5ce5133c10ce7bdd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c9bb97a4ce27b8c5e2bc54c99c4c529a112c9f5c","unresolved":false,"context_lines":[{"line_number":787,"context_line":"        :param connection_string: string used to connect to the task storage"},{"line_number":788,"context_line":"                                  system"},{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        plugin_name \u003d rutils.get_exporter_name(connection_string)"},{"line_number":791,"context_line":"        client \u003d exporter.TaskExporter.get(plugin_name)()"},{"line_number":792,"context_line":"        print(_(\"Instantiate %s task export client.\") % plugin_name)"},{"line_number":793,"context_line":"        client.export(uuid, connection_string)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bae84128_7b3a18cf","line":790,"updated":"2016-02-19 12:18:53.000000000","message":"I\u0027m in doubts that connection_string is a good way to determine exported plugin name.\n\nFor example, let we have two external systems:\n\n System A: connection_string is http://foocompany.example.org/tasks/\n (accepts task data in CSV)\n System B: connection_string is http://barcompany.example.org/tasks/\n (accepts task data in JSON)\n\nHow Rally can determine which task results format to use (CSV/JSON) from the connection string?","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"25f1c268f2789ad1a94203f33971b5fdb871eecf","unresolved":false,"context_lines":[{"line_number":787,"context_line":"        :param connection_string: string used to connect to the task storage"},{"line_number":788,"context_line":"                                  system"},{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        plugin_name \u003d rutils.get_exporter_name(connection_string)"},{"line_number":791,"context_line":"        client \u003d exporter.TaskExporter.get(plugin_name)()"},{"line_number":792,"context_line":"        print(_(\"Instantiate %s task export client.\") % plugin_name)"},{"line_number":793,"context_line":"        client.export(uuid, connection_string)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_b4053a12","line":790,"in_reply_to":"5aef4532_1890d8eb","updated":"2016-03-09 16:45:45.000000000","message":"Possibly you might assume file:///\u003cpath\u003e with 3 slashes?","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"145390c7c80ec00e9884efae6c600dbe2f389ca3","unresolved":false,"context_lines":[{"line_number":787,"context_line":"        :param connection_string: string used to connect to the task storage"},{"line_number":788,"context_line":"                                  system"},{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        plugin_name \u003d rutils.get_exporter_name(connection_string)"},{"line_number":791,"context_line":"        client \u003d exporter.TaskExporter.get(plugin_name)()"},{"line_number":792,"context_line":"        print(_(\"Instantiate %s task export client.\") % plugin_name)"},{"line_number":793,"context_line":"        client.export(uuid, connection_string)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_1890d8eb","line":790,"in_reply_to":"bae84128_7b3a18cf","updated":"2016-03-08 22:28:41.000000000","message":"Alex, you missed the point of this connection string. \n\nconnection string is like connection string for sqlalchemy. It starts from the name of plugin.\n\n   plugin_name://\u003cuser\u003e:\u003cpwd\u003e@\u003cfull_address\u003e:\u003cport\u003e/\u003cpath\u003e\n\nso in our case we will have\n\n   file://\u003cpath\u003e\n\n   testrail://some_user:some_pwd@mirantis.testrail.com\n\n   and so on","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"145390c7c80ec00e9884efae6c600dbe2f389ca3","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                                  system"},{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        plugin_name \u003d rutils.get_exporter_name(connection_string)"},{"line_number":791,"context_line":"        client \u003d exporter.TaskExporter.get(plugin_name)()"},{"line_number":792,"context_line":"        print(_(\"Instantiate %s task export client.\") % plugin_name)"},{"line_number":793,"context_line":"        client.export(uuid, connection_string)"},{"line_number":794,"context_line":"        print(_(\"Task %(uuid)s results was exported to %(connection)s using \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_3b366ee6","line":791,"updated":"2016-03-08 22:28:41.000000000","message":"This looks bad. \n\n  exporter \u003d exporter.TaskExporter.get(plugin_name)(connection_string)\n  exporter.export(uuid)\n\n  or keep export as a static method (which is bad)\n\n  exporter \u003d exporter.Task.Exporter.get(plugin_name)","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f4eac43c6ba40b276a2c277338245dcc7378b864","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                                  system"},{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        plugin_name \u003d rutils.get_exporter_name(connection_string)"},{"line_number":791,"context_line":"        client \u003d exporter.TaskExporter.get(plugin_name)()"},{"line_number":792,"context_line":"        print(_(\"Instantiate %s task export client.\") % plugin_name)"},{"line_number":793,"context_line":"        client.export(uuid, connection_string)"},{"line_number":794,"context_line":"        print(_(\"Task %(uuid)s results was exported to %(connection)s using \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_5456765c","line":791,"in_reply_to":"5aef4532_3b366ee6","updated":"2016-03-09 16:52:34.000000000","message":"As I understand you want to see:\n  exporter \u003d exporter.TaskExporter.get(plugin_name(connection_string)\n  exporter.export(uuid)","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1748825471aec4b825a6fa422a13101801f62ea6","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                                  system"},{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        plugin_name \u003d rutils.get_exporter_name(connection_string)"},{"line_number":791,"context_line":"        client \u003d exporter.TaskExporter.get(plugin_name)()"},{"line_number":792,"context_line":"        print(_(\"Instantiate %s task export client.\") % plugin_name)"},{"line_number":793,"context_line":"        client.export(uuid, connection_string)"},{"line_number":794,"context_line":"        print(_(\"Task %(uuid)s results was exported to %(connection)s using \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_d94f2d32","line":791,"in_reply_to":"5aef4532_3b366ee6","updated":"2016-03-10 11:44:02.000000000","message":"client.export(uuid, connection_string)\nThose approach was taken from the spec. So as I understand we want to kepp connection string in the instance and and to pass ot to the export function(in spec we pass) \n\nhttps://review.openstack.org/#/c/241596/5/doc/specs/in-progress/task_and_verification_export.rst","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"abc056cb77aebda3e8e46bfc255b29dc10bf4139","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                                  system"},{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        plugin_name \u003d rutils.get_exporter_name(connection_string)"},{"line_number":791,"context_line":"        client \u003d exporter.TaskExporter.get(plugin_name)()"},{"line_number":792,"context_line":"        print(_(\"Instantiate %s task export client.\") % plugin_name)"},{"line_number":793,"context_line":"        client.export(uuid, connection_string)"},{"line_number":794,"context_line":"        print(_(\"Task %(uuid)s results was exported to %(connection)s using \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_d2c1b1e5","line":791,"in_reply_to":"5aef4532_d94f2d32","updated":"2016-03-10 17:37:18.000000000","message":"Roman,\n\nNope it is not what I am asking. \nWhy we need such strange named method: plugin_name? \n\n  \u003e\u003e\u003e from urlparse import urlparse\n  \u003e\u003e\u003e o \u003d urlparse(\u0027file://somefile.json\u0027)\n  \u003e\u003e\u003e o\n  ParseResult(scheme\u003d\u0027file\u0027, netloc\u003d\u0027somefile.json\u0027, path\u003d\u0027\u0027, params\u003d\u0027\u0027, query\u003d\u0027\u0027, fragment\u003d\u0027\u0027)\n\n\n  exporter \u003d exporter.TaskExporter.get(o[\"scheme\"])(connection_string)","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"145390c7c80ec00e9884efae6c600dbe2f389ca3","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        plugin_name \u003d rutils.get_exporter_name(connection_string)"},{"line_number":791,"context_line":"        client \u003d exporter.TaskExporter.get(plugin_name)()"},{"line_number":792,"context_line":"        print(_(\"Instantiate %s task export client.\") % plugin_name)"},{"line_number":793,"context_line":"        client.export(uuid, connection_string)"},{"line_number":794,"context_line":"        print(_(\"Task %(uuid)s results was exported to %(connection)s using \""},{"line_number":795,"context_line":"                \"%(name)s plugin.\") % {"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_3b4dce6c","line":792,"updated":"2016-03-08 22:28:41.000000000","message":"there is no need in printing this message, you will print it after you finish the work","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"145390c7c80ec00e9884efae6c600dbe2f389ca3","unresolved":false,"context_lines":[{"line_number":790,"context_line":"        plugin_name \u003d rutils.get_exporter_name(connection_string)"},{"line_number":791,"context_line":"        client \u003d exporter.TaskExporter.get(plugin_name)()"},{"line_number":792,"context_line":"        print(_(\"Instantiate %s task export client.\") % plugin_name)"},{"line_number":793,"context_line":"        client.export(uuid, connection_string)"},{"line_number":794,"context_line":"        print(_(\"Task %(uuid)s results was exported to %(connection)s using \""},{"line_number":795,"context_line":"                \"%(name)s plugin.\") % {"},{"line_number":796,"context_line":"                    \"uuid\": uuid,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_1bb6123d","line":793,"updated":"2016-03-08 22:28:41.000000000","message":"Where is nice message for end users in next cases: \n\n  - Connection string has wrong format \n  - There is no plugin for specified connection string\n  - No access to backend \n  - Problems during exporting task results","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"22f7c421f26eb94c8bb23acfad7ecabc512344d2","unresolved":false,"context_lines":[{"line_number":732,"context_line":"            client.export(uuid)"},{"line_number":733,"context_line":"        except IOError as e:"},{"line_number":734,"context_line":"            if e.errno \u003d\u003d errno.EACCES:"},{"line_number":735,"context_line":"                print (_(\"Permission denied to write to the file %s.\") %"},{"line_number":736,"context_line":"                       client.get_path())"},{"line_number":737,"context_line":"                raise"},{"line_number":738,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa0719c6_b8470076","line":735,"updated":"2016-03-23 14:20:36.000000000","message":"This is not necessary. print (e) is enough in any case. Also it may be useful to call log.exception() if debug is on.","commit_id":"6bf9db872764c7c6767ce329b3191fd5e0101e88"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"be12a2066b273cda7f9a909f17765ee33cc959fc","unresolved":false,"context_lines":[{"line_number":711,"context_line":"                   required\u003dTrue,"},{"line_number":712,"context_line":"                   help\u003d\"Connection url to the task export system.\")"},{"line_number":713,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":714,"context_line":"    def export(self, uuid, connection_string):"},{"line_number":715,"context_line":"        \"\"\"Export task results to the custom task\u0027s exporting system."},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        :param uuid: UUID of the task"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_0eb93fcc","line":714,"updated":"2016-03-24 15:30:52.000000000","message":"Maybe add @envutils.with_default_task_id ?","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f61edd2d46d7737dec4fb9aee4715988c97a7a78","unresolved":false,"context_lines":[{"line_number":711,"context_line":"                   required\u003dTrue,"},{"line_number":712,"context_line":"                   help\u003d\"Connection url to the task export system.\")"},{"line_number":713,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":714,"context_line":"    def export(self, uuid, connection_string):"},{"line_number":715,"context_line":"        \"\"\"Export task results to the custom task\u0027s exporting system."},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        :param uuid: UUID of the task"}],"source_content_type":"text/x-python","patch_set":22,"id":"da0c15f0_849e8c54","line":714,"in_reply_to":"fa0719c6_0eb93fcc","updated":"2016-03-25 14:54:36.000000000","message":"I use `uuid` as a required field to explicitly ask user to enter uuid","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f28dc12359d31bd72ab5fccdb467146e9d2dd2a4","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        :param connection_string: string used to connect to the system"},{"line_number":719,"context_line":"        \"\"\""},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        parsed_obj \u003d urlparse.urlparse(connection_string)"},{"line_number":722,"context_line":"        try:"},{"line_number":723,"context_line":"            client \u003d exporter.TaskExporter.get(parsed_obj.scheme)("},{"line_number":724,"context_line":"                connection_string)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_5df2cb06","line":721,"updated":"2016-03-24 15:35:52.000000000","message":"You do not need to import urlparse for obtaining scheme, simple split(\":\") is enough:\n\n plugin_name \u003d connection_string.split(\":\")[0]","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f61edd2d46d7737dec4fb9aee4715988c97a7a78","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        :param connection_string: string used to connect to the system"},{"line_number":719,"context_line":"        \"\"\""},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        parsed_obj \u003d urlparse.urlparse(connection_string)"},{"line_number":722,"context_line":"        try:"},{"line_number":723,"context_line":"            client \u003d exporter.TaskExporter.get(parsed_obj.scheme)("},{"line_number":724,"context_line":"                connection_string)"}],"source_content_type":"text/x-python","patch_set":22,"id":"da0c15f0_640538c1","line":721,"in_reply_to":"fa0719c6_5df2cb06","updated":"2016-03-25 14:54:36.000000000","message":"Boris asked me to use urlparse for this purpose where its possible","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"be12a2066b273cda7f9a909f17765ee33cc959fc","unresolved":false,"context_lines":[{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        parsed_obj \u003d urlparse.urlparse(connection_string)"},{"line_number":722,"context_line":"        try:"},{"line_number":723,"context_line":"            client \u003d exporter.TaskExporter.get(parsed_obj.scheme)("},{"line_number":724,"context_line":"                connection_string)"},{"line_number":725,"context_line":"        except exceptions.InvalidConnectionString as e:"},{"line_number":726,"context_line":"            if logging.is_debug():"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_0ee01fcc","line":723,"updated":"2016-03-24 15:30:52.000000000","message":"This should check if we have actually any plugin name (\"scheme\" is empty)\n\n$ rally task export --uuid b6ae22d6-6db2-4568-b08b-e4928bfe951b --connection foo\n2016-03-24 16:27:21.143 23209 WARNING rally.common.logging [-] \u0027set\u0027 is deprecated in Rally v0.3.2: Use types.convert() instead\nThere is no plugin with name:  in any of namespace.\nPlease check your connection string.","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"be12a2066b273cda7f9a909f17765ee33cc959fc","unresolved":false,"context_lines":[{"line_number":726,"context_line":"            if logging.is_debug():"},{"line_number":727,"context_line":"                LOG.exception(e)"},{"line_number":728,"context_line":"            print (e)"},{"line_number":729,"context_line":"            return (1)"},{"line_number":730,"context_line":"        except exceptions.PluginNotFound as e:"},{"line_number":731,"context_line":"            if logging.is_debug():"},{"line_number":732,"context_line":"                LOG.exception(e)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_6ecf1b56","line":729,"updated":"2016-03-24 15:30:52.000000000","message":"return 1\n\n(1) \u003d\u003d 1\n\nreturn is not callable, this is a key word","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f61edd2d46d7737dec4fb9aee4715988c97a7a78","unresolved":false,"context_lines":[{"line_number":726,"context_line":"            if logging.is_debug():"},{"line_number":727,"context_line":"                LOG.exception(e)"},{"line_number":728,"context_line":"            print (e)"},{"line_number":729,"context_line":"            return (1)"},{"line_number":730,"context_line":"        except exceptions.PluginNotFound as e:"},{"line_number":731,"context_line":"            if logging.is_debug():"},{"line_number":732,"context_line":"                LOG.exception(e)"}],"source_content_type":"text/x-python","patch_set":22,"id":"da0c15f0_2ffdd93a","line":729,"in_reply_to":"fa0719c6_6ecf1b56","updated":"2016-03-25 14:54:36.000000000","message":"Done","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"be12a2066b273cda7f9a909f17765ee33cc959fc","unresolved":false,"context_lines":[{"line_number":741,"context_line":"            print (e)"},{"line_number":742,"context_line":"            return (1)"},{"line_number":743,"context_line":"        print(_(\"Task %(uuid)s results was successfully exported to %(\""},{"line_number":744,"context_line":"                \"connection)s using %(name)s plugin.\") % {"},{"line_number":745,"context_line":"                    \"uuid\": uuid,"},{"line_number":746,"context_line":"                    \"connection\": connection_string,"},{"line_number":747,"context_line":"                    \"name\": parsed_obj.scheme"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_1115e29a","line":744,"updated":"2016-03-24 15:30:52.000000000","message":"plugin name should be omitted because it is already mentioned in connection string:\n\n\n$ rally task export --uuid b6ae22d6-6db2-4568-b08b-e4928bfe951b --connection file-exporter:////tmp/foo.json\n2016-03-24 16:43:46.749 23346 WARNING rally.common.logging [-] \u0027set\u0027 is deprecated in Rally v0.3.2: Use types.convert() instead\nTask b6ae22d6-6db2-4568-b08b-e4928bfe951b results was successfully exported to file-exporter:////tmp/foo.json using file-exporter plugin.","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":20196,"name":"Piyush","email":"piyush2011257@gmail.com","username":"pirsriva"},"change_message_id":"83250e1595847b2b295c9366579381774b38aa4b","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        fileutils.update_globals_file(\"RALLY_TASK\", task_id)"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"    @cliutils.args(\"--uuid\", dest\u003d\"uuid\", type\u003dstr,"},{"line_number":708,"context_line":"                   required\u003dTrue,"},{"line_number":709,"context_line":"                   help\u003d\"UUID of a the task.\")"},{"line_number":710,"context_line":"    @cliutils.args(\"--connection\", dest\u003d\"connection_string\", type\u003dstr,"},{"line_number":711,"context_line":"                   required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":26,"id":"da0c15f0_0d7d5ce7","line":708,"updated":"2016-03-26 18:39:03.000000000","message":"I think this is not needed.\n\nThis will make \"uuid\" as keyword argument i.e. users can use \"rally task export\" command in the following way ONLY-\nrally task export --uuid \u003cUUID\u003e --connection \u003cconn_string\u003e.\n\nI\u0027d prefer to keep it as a positional argument instead of keyword argument format as used in https://github.com/openstack/rally/blob/master/rally/cli/commands/task.py#L203 for \"task start\" command and https://github.com/openstack/rally/blob/master/rally/cli/commands/task.py#L153 for \"task validate\" command.\n\nKeeping it as positional argument will allow users to use the same command in a simpler formats including BOTH- \nrally task export \u003cUUID\u003e \u003cconn_string\u003e and \nrally task export --uuid \u003cUUID\u003e --connection \u003cconn_string\u003e","commit_id":"105c9b47c2587a5c775cf065f52633cc12b6ed80"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9da01ddaf31a412cbc96d9e7b94b767796a161ba","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        fileutils.update_globals_file(\"RALLY_TASK\", task_id)"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"    @cliutils.args(\"--uuid\", dest\u003d\"uuid\", type\u003dstr,"},{"line_number":708,"context_line":"                   required\u003dTrue,"},{"line_number":709,"context_line":"                   help\u003d\"UUID of a the task.\")"},{"line_number":710,"context_line":"    @cliutils.args(\"--connection\", dest\u003d\"connection_string\", type\u003dstr,"},{"line_number":711,"context_line":"                   required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":26,"id":"da0c15f0_75c0ffe0","line":708,"in_reply_to":"da0c15f0_0d7d5ce7","updated":"2016-03-28 13:58:24.000000000","message":"I don\u0027t know how to do this for now. Maybe you could suggest exact change that will do this stuff for this command? I will try to merge it without position args stuff and will fix it in the next patch. Looks like there is somewhere bug in our parser stuff. Thanks for review.","commit_id":"105c9b47c2587a5c775cf065f52633cc12b6ed80"},{"author":{"_account_id":20196,"name":"Piyush","email":"piyush2011257@gmail.com","username":"pirsriva"},"change_message_id":"83250e1595847b2b295c9366579381774b38aa4b","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                   required\u003dTrue,"},{"line_number":709,"context_line":"                   help\u003d\"UUID of a the task.\")"},{"line_number":710,"context_line":"    @cliutils.args(\"--connection\", dest\u003d\"connection_string\", type\u003dstr,"},{"line_number":711,"context_line":"                   required\u003dTrue,"},{"line_number":712,"context_line":"                   help\u003d\"Connection url to the task export system.\")"},{"line_number":713,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":714,"context_line":"    def export(self, uuid, connection_string):"}],"source_content_type":"text/x-python","patch_set":26,"id":"da0c15f0_4d8754d7","line":711,"updated":"2016-03-26 18:39:03.000000000","message":"Same as for Line 708","commit_id":"105c9b47c2587a5c775cf065f52633cc12b6ed80"}],"rally/common/utils.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7a21eb17cd61c75f484d8feec995a6dfc7103f8c","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            return"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"def get_exporter_name(self, connection_string):"},{"line_number":541,"context_line":"    \"\"\"Return exporter plugin name by connection string."},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    By default would be returned \u0027filesystem_exporter\u0027. This plugin"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_33023770","line":540,"updated":"2016-03-02 09:22:12.000000000","message":"connection_string is not used here.","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"145390c7c80ec00e9884efae6c600dbe2f389ca3","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            return"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"def get_exporter_name(self, connection_string):"},{"line_number":541,"context_line":"    \"\"\"Return exporter plugin name by connection string."},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    By default would be returned \u0027filesystem_exporter\u0027. This plugin"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_18a73850","line":540,"in_reply_to":"7af24918_33023770","updated":"2016-03-08 22:28:41.000000000","message":"This is very wrong place to have this method. \n\nYou should have this method in base export plugin","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"145390c7c80ec00e9884efae6c600dbe2f389ca3","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                                  exporter\u0027s system"},{"line_number":548,"context_line":"        :returns: str, name of the exporter plugin"},{"line_number":549,"context_line":"    \"\"\""},{"line_number":550,"context_line":"    return \"filesystem_exporter\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_987188e3","line":550,"updated":"2016-03-08 22:28:41.000000000","message":"Why this is hardcoded ? \n\nIt looks like:\n\n   def random(): \n       return 4","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"}],"rally/plugins/common/exporter/file_system.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c9bb97a4ce27b8c5e2bc54c99c4c529a112c9f5c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@configure(name\u003d\"filesystem_exporter\")"},{"line_number":33,"context_line":"class FileExporter(exporter.TaskExporter):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def export(self, uuid, connection_string):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bae84128_9b527cdc","line":32,"updated":"2016-02-19 12:18:53.000000000","message":"This means that we dump data to filesystem, but data format is alvays JSON. What plugin name would be used for writing CSV to filesystem? Or YAML?\n\nI think we should care about data format as well, not only on how we deliver the data.","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"145390c7c80ec00e9884efae6c600dbe2f389ca3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@configure(name\u003d\"filesystem_exporter\")"},{"line_number":33,"context_line":"class FileExporter(exporter.TaskExporter):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def export(self, uuid, connection_string):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_7beab610","line":32,"in_reply_to":"bae84128_9b527cdc","updated":"2016-03-08 22:28:41.000000000","message":"The plugin name is very bad: \n\n  - It is too long, imagine every userd will have to write \"filesystem_exporter\" to use this, I won\u0027t personally write such long names and use such crappy interface \n\n  - There is standard way to describe file connection string \"file://\" why we are inventing wheels? \n\n\nAlex, you are not right, there is no problem specific in connection string what output format you would like to have\n\nwe can have connection string like: \n\n   file://\u003cfile_name\u003e.\u003ctype\u003e and use this type to pick wrong format.\n\nimho this is only the right way to handle things","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"145390c7c80ec00e9884efae6c600dbe2f389ca3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"@configure(name\u003d\"filesystem_exporter\")"},{"line_number":33,"context_line":"class FileExporter(exporter.TaskExporter):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def export(self, uuid, connection_string):"},{"line_number":36,"context_line":"        \"\"\"Export results of the task to the file."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param uuid: uuid of the task object"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_5ba53ab3","line":35,"updated":"2016-03-08 22:28:41.000000000","message":"where is validation that connection_string is valid?? \n\nParsing of connection string should be done in base method in __init__ method (and it\u0027s better to do in only once)","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c9bb97a4ce27b8c5e2bc54c99c4c529a112c9f5c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        for x in task.get_results()]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        if task_results:"},{"line_number":51,"context_line":"            res \u003d json.dumps(task_results, sort_keys\u003dTrue, indent\u003d4)"},{"line_number":52,"context_line":"            LOG.debug(\"Got the task %s results.\" % uuid)"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            LOG.debug(\"Task %s results \""}],"source_content_type":"text/x-python","patch_set":10,"id":"bae84128_3dad2832","line":51,"updated":"2016-02-19 12:18:53.000000000","message":"Just recommendation: consider about using \"json.dump(open(\u003cpath\u003e, \"w+\"), task_results)\" - this will do the whole job at once","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c9bb97a4ce27b8c5e2bc54c99c4c529a112c9f5c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if task_results:"},{"line_number":51,"context_line":"            res \u003d json.dumps(task_results, sort_keys\u003dTrue, indent\u003d4)"},{"line_number":52,"context_line":"            LOG.debug(\"Got the task %s results.\" % uuid)"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            LOG.debug(\"Task %s results \""},{"line_number":55,"context_line":"                      \"would be available when it will finish.\" % uuid)"},{"line_number":56,"context_line":"        output_file \u003d os.path.expanduser(connection_string)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bae84128_1de8247c","line":53,"updated":"2016-02-19 12:18:53.000000000","message":"I do not think this condition is actually required.\n\nIf we expect user to run export for task that is being running, then we can check task status explicitly if it has  status \"finished\".\n\nMaybe task has already failed for some reason so there ar eno results, so we should not print message \"... when it will finish.\" in this case","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"145390c7c80ec00e9884efae6c600dbe2f389ca3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if task_results:"},{"line_number":51,"context_line":"            res \u003d json.dumps(task_results, sort_keys\u003dTrue, indent\u003d4)"},{"line_number":52,"context_line":"            LOG.debug(\"Got the task %s results.\" % uuid)"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            LOG.debug(\"Task %s results \""},{"line_number":55,"context_line":"                      \"would be available when it will finish.\" % uuid)"},{"line_number":56,"context_line":"        output_file \u003d os.path.expanduser(connection_string)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_db9f8a4e","line":53,"in_reply_to":"bae84128_1de8247c","updated":"2016-03-08 22:28:41.000000000","message":"Alex, This must not be handled here, otherwise we will have to this work in every patch. \n\nI believe this should be done as a special arguments for CLI export command. That will decide what to do.","commit_id":"5fa744aadd1fbe9a71d024f97ec0a8c1a332bade"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"22f7c421f26eb94c8bb23acfad7ecabc512344d2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        file:///\u003cpath\u003e.\u003ctype\u003e"},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if self.connection_string is None or self.get_plugin_name() !\u003d ("},{"line_number":46,"context_line":"                \"file-exporter\"):"},{"line_number":47,"context_line":"            raise exceptions.InvalidConnectionString("},{"line_number":48,"context_line":"                \"It should be `file-exporter:///\u003cpath\u003e.\u003ctype\u003e`.\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa0719c6_b35a8128","line":45,"updated":"2016-03-23 14:20:36.000000000","message":"self.get_plugin_name() !\u003d \"file-exporter\"\n\nHow can this be possible?","commit_id":"6bf9db872764c7c6767ce329b3191fd5e0101e88"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"22f7c421f26eb94c8bb23acfad7ecabc512344d2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                \"It should be `file-exporter:///\u003cpath\u003e.\u003ctype\u003e`.\")"},{"line_number":49,"context_line":"        parse_obj \u003d urlparse.urlparse(self.connection_string)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # NOTE(rvasilets): Will add be added in the future more formats"},{"line_number":52,"context_line":"        available_formats \u003d (\"json\",)"},{"line_number":53,"context_line":"        available_formats_str \u003d \", \".join(available_formats)"},{"line_number":54,"context_line":"        if self.connection_string is None or parse_obj.path \u003d\u003d \"\":"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa0719c6_13b24d4c","line":51,"updated":"2016-03-23 14:20:36.000000000","message":"\"Will add be added\"?\n\nThis note is not necessary at all","commit_id":"6bf9db872764c7c6767ce329b3191fd5e0101e88"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ae54aefe27d91a9c5a535c013c2c7825bce3bdf5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                \"It should be `file-exporter:///\u003cpath\u003e.\u003ctype\u003e`.\")"},{"line_number":49,"context_line":"        parse_obj \u003d urlparse.urlparse(self.connection_string)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # NOTE(rvasilets): Will add be added in the future more formats"},{"line_number":52,"context_line":"        available_formats \u003d (\"json\",)"},{"line_number":53,"context_line":"        available_formats_str \u003d \", \".join(available_formats)"},{"line_number":54,"context_line":"        if self.connection_string is None or parse_obj.path \u003d\u003d \"\":"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa0719c6_446199d2","line":51,"in_reply_to":"fa0719c6_13b24d4c","updated":"2016-03-23 14:53:14.000000000","message":"For those who will ask me to delete `available_formats` and if only for one value","commit_id":"6bf9db872764c7c6767ce329b3191fd5e0101e88"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"22f7c421f26eb94c8bb23acfad7ecabc512344d2","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                         \"full_duration\": x[\"data\"][\"full_duration\"]}"},{"line_number":81,"context_line":"                        for x in task.get_results()]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # NOTE(rvasilets): Will add be added in the future more formats"},{"line_number":84,"context_line":"        if self.get_type() \u003d\u003d \"json\":"},{"line_number":85,"context_line":"            if task_results:"},{"line_number":86,"context_line":"                res \u003d json.dumps(task_results, sort_keys\u003dTrue, indent\u003d4)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa0719c6_73daa94d","line":83,"updated":"2016-03-23 14:20:36.000000000","message":"ditto","commit_id":"6bf9db872764c7c6767ce329b3191fd5e0101e88"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"22f7c421f26eb94c8bb23acfad7ecabc512344d2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                res \u003d json.dumps(task_results, sort_keys\u003dTrue, indent\u003d4)"},{"line_number":87,"context_line":"                LOG.debug(\"Got the task %s results.\" % uuid)"},{"line_number":88,"context_line":"            else:"},{"line_number":89,"context_line":"                LOG.debug(\"Task %s results \""},{"line_number":90,"context_line":"                          \"would be available when it will finish.\" % uuid)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        output_file \u003d os.path.expanduser(self.get_path())"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa0719c6_13cd2d66","line":89,"updated":"2016-03-23 14:20:36.000000000","message":"What user will see when trying to export results of unifinished task without debug? It seems he will see nothing and get empty file.","commit_id":"6bf9db872764c7c6767ce329b3191fd5e0101e88"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ae54aefe27d91a9c5a535c013c2c7825bce3bdf5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                res \u003d json.dumps(task_results, sort_keys\u003dTrue, indent\u003d4)"},{"line_number":87,"context_line":"                LOG.debug(\"Got the task %s results.\" % uuid)"},{"line_number":88,"context_line":"            else:"},{"line_number":89,"context_line":"                LOG.debug(\"Task %s results \""},{"line_number":90,"context_line":"                          \"would be available when it will finish.\" % uuid)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        output_file \u003d os.path.expanduser(self.get_path())"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa0719c6_44b8792a","line":89,"in_reply_to":"fa0719c6_13cd2d66","updated":"2016-03-23 14:53:14.000000000","message":"Yes. My fault, I will print proper msg","commit_id":"6bf9db872764c7c6767ce329b3191fd5e0101e88"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"be12a2066b273cda7f9a909f17765ee33cc959fc","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if self.connection_string is None:"},{"line_number":46,"context_line":"            raise exceptions.InvalidConnectionString("},{"line_number":47,"context_line":"                \"It should be `file-exporter:///\u003cpath\u003e.\u003ctype\u003e`.\")"},{"line_number":48,"context_line":"        parse_obj \u003d urlparse.urlparse(self.connection_string)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        available_formats \u003d (\"json\",)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_5411085c","line":47,"updated":"2016-03-24 15:30:52.000000000","message":"Is anywhere mentioned that this form (three slashes) expects relative path? (look at my comment in TaskExporter.get_path)\n\nso for absolute path we must add extra (fourth) slash","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f61edd2d46d7737dec4fb9aee4715988c97a7a78","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if self.connection_string is None:"},{"line_number":46,"context_line":"            raise exceptions.InvalidConnectionString("},{"line_number":47,"context_line":"                \"It should be `file-exporter:///\u003cpath\u003e.\u003ctype\u003e`.\")"},{"line_number":48,"context_line":"        parse_obj \u003d urlparse.urlparse(self.connection_string)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        available_formats \u003d (\"json\",)"}],"source_content_type":"text/x-python","patch_set":22,"id":"da0c15f0_4a0abbd3","line":47,"in_reply_to":"fa0719c6_5411085c","updated":"2016-03-25 14:54:36.000000000","message":"Do we need to mention this? After the third slash you may specify absolute(full) path or relative as usual. For example:\n  connection_string \u003d file-exporte:////user/home/file_name.json \n  then get_path() will return /user/home/file_name.json \n\n  or connection_string \u003d file-exporte:///~/user/home/file_name.json\n  get_path() will return ~/user/home/file_name.json\n\nSo what type of the path to use https://en.wikipedia.org/wiki/Path_%28computing%29 full or relative is you decision, no problem.","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4735d767de18e99898b1f1f4617f23c12ee7f3d1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                raise exceptions.RallyException(msg)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        output_file \u003d os.path.expanduser(self.get_path())"},{"line_number":91,"context_line":"        with open(output_file, \"w\") as f:"},{"line_number":92,"context_line":"            LOG.debug(\"Writing task %s results to the %s.\" % ("},{"line_number":93,"context_line":"                uuid, self.connection_string))"},{"line_number":94,"context_line":"            f.write(res)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_e3b85c2c","line":91,"updated":"2016-03-24 15:59:18.000000000","message":"Look at the error below, there we have two issues:\n - ~ is not expanded into home directory\n - probably directory \"~path/to/some/\" is absent, but file file.json definitely does not exist because we should create it, so the message is confusing\n\n$ rally task export --uuid b6ae22d6-6db2-4568-b08b-e4928bfe951b --connection file-exporter:///~path/to/some/file.json\n2016-03-24 17:47:20.475 23793 WARNING rally.common.logging [-] \u0027set\u0027 is deprecated in Rally v0.3.2: Use types.convert() instead\n[Errno 2] No such file or directory: u\u0027~path/to/some/file.json\u0027","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"68fbadf3563dfba5169fc8a1d80d857e0c4979aa","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                raise exceptions.RallyException(msg)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        output_file \u003d os.path.expanduser(self.get_path())"},{"line_number":91,"context_line":"        with open(output_file, \"w\") as f:"},{"line_number":92,"context_line":"            LOG.debug(\"Writing task %s results to the %s.\" % ("},{"line_number":93,"context_line":"                uuid, self.connection_string))"},{"line_number":94,"context_line":"            f.write(res)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_63b56c7c","line":91,"in_reply_to":"fa0719c6_a305c446","updated":"2016-03-24 16:08:50.000000000","message":"Yes, my fault about ~, but there is a second issue still valid","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f976ef7084767c540f83d57d54efa29eb7bcdc40","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                raise exceptions.RallyException(msg)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        output_file \u003d os.path.expanduser(self.get_path())"},{"line_number":91,"context_line":"        with open(output_file, \"w\") as f:"},{"line_number":92,"context_line":"            LOG.debug(\"Writing task %s results to the %s.\" % ("},{"line_number":93,"context_line":"                uuid, self.connection_string))"},{"line_number":94,"context_line":"            f.write(res)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_a305c446","line":91,"in_reply_to":"fa0719c6_e3b85c2c","updated":"2016-03-24 16:07:43.000000000","message":"This is wrong usage of ~","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8ee02bc64535a89ccc8cb991eb0f05d199359feb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                available_formats_str)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, connection_string):"},{"line_number":59,"context_line":"        self.connection_string \u003d connection_string"},{"line_number":60,"context_line":"        self.path \u003d os.path.expanduser(urlparse.urlparse("},{"line_number":61,"context_line":"            connection_string).path[1:])"},{"line_number":62,"context_line":"        self.type \u003d connection_string.split(\".\")[-1]"}],"source_content_type":"text/x-python","patch_set":23,"id":"da0c15f0_896337b1","line":59,"updated":"2016-03-25 16:15:41.000000000","message":"remove this line (this is already implemented in super(...).__init__()","commit_id":"b95b82793bd20c114abc5a10182b7fc5ba699b88"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8ee02bc64535a89ccc8cb991eb0f05d199359feb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.type \u003d connection_string.split(\".\")[-1]"},{"line_number":63,"context_line":"        self.validate()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        super(FileExporter, self).__init__(connection_string)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def export(self, uuid):"},{"line_number":68,"context_line":"        \"\"\"Export results of the task to the file."}],"source_content_type":"text/x-python","patch_set":23,"id":"da0c15f0_0949e731","line":65,"updated":"2016-03-25 16:15:41.000000000","message":"Move this to L59","commit_id":"b95b82793bd20c114abc5a10182b7fc5ba699b88"}],"rally/task/exporter.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a8fbf23d221b9dbffe9a91709d77984a2e6a5735","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class TaskExporter(plugin.Plugin):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, connection_string):"},{"line_number":39,"context_line":"        self.connection_string \u003d connection_string"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @abc.abstractmethod"},{"line_number":42,"context_line":"    def export(self, task_uuid):"}],"source_content_type":"text/x-python","patch_set":22,"id":"da0c15f0_be7481cf","line":39,"updated":"2016-03-25 11:37:46.000000000","message":"I would recommend to improve this method and save here a result of parsing of connection string:\n\n  self.connection \u003d urlparse.urlparse(connection_string)","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"be12a2066b273cda7f9a909f17765ee33cc959fc","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        :returns: str, path to the file in the system"},{"line_number":81,"context_line":"        \"\"\""},{"line_number":82,"context_line":"        return urlparse.urlparse(self.connection_string).path[1:]"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_94d1e025","line":82,"updated":"2016-03-24 15:30:52.000000000","message":"Cutting first sign (slash?) looks wrong, because path becomes corrupted.\n\nFor example, connection_string is scheme:///path/to/file\nso we have path \"path/to/file\" (relative path!)\n\nbut this is absolute path \"/path/to/file\"! so  we have absolutely different result.\n\nhttps://en.wikipedia.org/wiki/File_URI_scheme","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d834583448fb4ba54d9b143d33b6f848099ec761","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        :returns: str, path to the file in the system"},{"line_number":81,"context_line":"        \"\"\""},{"line_number":82,"context_line":"        return urlparse.urlparse(self.connection_string).path[1:]"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_633a8ce8","line":82,"in_reply_to":"fa0719c6_94d1e025","updated":"2016-03-24 16:09:37.000000000","message":"Ok, I will add get_path to the file-exporter class","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"864f48dbed9be863b01c3af0b28b3af487a5faf7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def validate(self):"},{"line_number":50,"context_line":"        \"\"\"Used to validate connection string.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_plugin_name(self):"},{"line_number":53,"context_line":"        \"\"\"Return exporter plugin name from connection string."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        The format of `connection_string` is"}],"source_content_type":"text/x-python","patch_set":26,"id":"da0c15f0_377974c9","line":52,"updated":"2016-03-28 11:09:38.000000000","message":"This method:\n\n - not needed (use Plugin classmethod get_name() for this purpose)\n - not used within this patch\n\nI propose to remove it","commit_id":"105c9b47c2587a5c775cf065f52633cc12b6ed80"}],"tests/unit/plugins/common/exporter/test_file_system.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"68fbadf3563dfba5169fc8a1d80d857e0c4979aa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                          \"fake_uuid\")"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @ddt.data("},{"line_number":80,"context_line":"        {\"connection\": \"\"},"},{"line_number":81,"context_line":"        {\"connection\": None},"},{"line_number":82,"context_line":"        {\"connection\": \"file-exporter:///fake_path.json\"},"},{"line_number":83,"context_line":"        {\"connection\": \"file-exporter:///fake_path.fake\"},)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_83f7e0d1","line":80,"updated":"2016-03-24 16:08:50.000000000","message":"just add here key \"raises:\" exceptions.InvalidConnectionString","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"68fbadf3563dfba5169fc8a1d80d857e0c4979aa","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        {\"connection\": \"file-exporter:///fake_path.fake\"},)"},{"line_number":84,"context_line":"    @ddt.unpack"},{"line_number":85,"context_line":"    def test_file_exporter_validate(self, connection):"},{"line_number":86,"context_line":"        if (connection \u003d\u003d \"\" or connection is None or"},{"line_number":87,"context_line":"            connection \u003d\u003d \"file-exporter:///fake_path.fake\" or ("},{"line_number":88,"context_line":"                connection \u003d\u003d \"fake:///fake_path.json\")):"},{"line_number":89,"context_line":"            self.assertRaises(exceptions.InvalidConnectionString,"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_e39e9c61","line":86,"updated":"2016-03-24 16:08:50.000000000","message":"Use exception from DDT (see my comment above):\n\n if raises:\n     self.assertRaises(raises, file_system.FileExporter, connection)\n else:\n     ...","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d14fb7580996cd220d4d42ab6063227a393011cf","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        {\"connection\": \"file-exporter:///fake_path.fake\"},)"},{"line_number":84,"context_line":"    @ddt.unpack"},{"line_number":85,"context_line":"    def test_file_exporter_validate(self, connection):"},{"line_number":86,"context_line":"        if (connection \u003d\u003d \"\" or connection is None or"},{"line_number":87,"context_line":"            connection \u003d\u003d \"file-exporter:///fake_path.fake\" or ("},{"line_number":88,"context_line":"                connection \u003d\u003d \"fake:///fake_path.json\")):"},{"line_number":89,"context_line":"            self.assertRaises(exceptions.InvalidConnectionString,"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_75052344","line":86,"in_reply_to":"fa0719c6_e39e9c61","updated":"2016-03-24 16:24:06.000000000","message":"Example:\n\nhttps://github.com/openstack/rally/blob/master/tests/unit/cli/test_cliutils.py#L118\n\nhttps://github.com/openstack/rally/blob/master/tests/unit/cli/test_cliutils.py#L122-L123","commit_id":"1340c03163118245f8f34930c69a43b06bfc9657"}]}
