)]}'
{"tests/hacking/checks.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9d4af8936b06fcc56f9f11d40470a08feefe26e2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\"\"\", re.X)"},{"line_number":62,"context_line":"re_raises \u003d re.compile("},{"line_number":63,"context_line":"    r\"\\s:raise[^s] *.*$|\\s:raises *:.*$|\\s:raises *[^:]+$\")"},{"line_number":64,"context_line":"re_import_db_from_cli \u003d re.compile(r\"^from rally.common import db\")"},{"line_number":65,"context_line":"re_import_objects_from_cli \u003d re.compile(r\"^from rally.common import objects\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_b578ab90","line":64,"updated":"2016-01-04 12:58:24.000000000","message":"why `from_cli\u0027? This regex 1) can be potentially reused by another check which is not related to cli, and 2) naming is confusing - regex is actually about importing \"from common\"","commit_id":"2148a9238084e64a7c568060a646bc4c4f443114"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ebdd481ad94680ff351bff5b9a8b5eaf4b948b03","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\"\"\", re.X)"},{"line_number":62,"context_line":"re_raises \u003d re.compile("},{"line_number":63,"context_line":"    r\"\\s:raise[^s] *.*$|\\s:raises *:.*$|\\s:raises *[^:]+$\")"},{"line_number":64,"context_line":"re_import_db_from_cli \u003d re.compile(r\"^from rally.common import db\")"},{"line_number":65,"context_line":"re_import_objects_from_cli \u003d re.compile(r\"^from rally.common import objects\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_5821669e","line":64,"in_reply_to":"fa69d971_b578ab90","updated":"2016-01-04 13:19:35.000000000","message":"\u003ewhy `from_cli\u0027? \n\nAs you can see from rules 360,361, these variables are used to check that db and object modules are not imported from cli module. We have not other restrictions for import such modules modules, when it will appear, I\u0027ll not against renaming of these variables.","commit_id":"2148a9238084e64a7c568060a646bc4c4f443114"}]}
