)]}'
{"rally/task/functional.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"4bf76dd43acdb28bb07150a64fa47b21eba5058c","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class FunctionalMixin(testtools.TestCase):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    # Simulate normal testools run."},{"line_number":22,"context_line":"    _testMethodName \u003d \"test\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # Backward-compatible `assertIsNotInstance` method."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_dafbb879","line":21,"updated":"2016-01-06 02:10:17.000000000","message":"Thank you for this patch, however there were really strong reasons why we didn\u0027t use testtools. Unfortunately there is no comments in code that explains situtation.\n\n\nSo the reasons were: \n\n  - Rally production code will work with testing tools code that is not designed to be used in production. \n\n  - Rally code will depend on bunch of new libs that are introduced by testtools and testools it self, which means: \n\n  -- More code that you are depending code and you have to know \n  -- More time is required to install your tool \n  -- More space is required consumed by your tool \n\n  - We will inherit base classes like Scenario \u0026 Context from testtools.TestCase that will make these classes really hard to learn, like when you run dir(base.Scenario) you\u0027ll see billions of methods inside it\n\n  - It will make unclear for end users what exceptions are raised and they will be unittest exceptions during the production isntead of rally assertation exceptions \n\n\n\nSo, including everything above.\n\nWe are reducing about 50 lines of very simple and straightforward code from Rally code it self, but we are adding about 12k lines of code from testtols and making base Rally framework class tree way more complicated. \n\nI really like to use libs when they make sense, like for example \"request\" but in this case we will use just 0.4% of testools that are very simple. \n\nMaybe you can just make this comment instead of this patch, so we will avoid in future such kind of refactorings.","commit_id":"9d504b02dfd31fe68a2362a51a4de9f1a5ad7a1a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"4640e197fd0eb94b6d0638b33bc61402e87fc550","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Note that the Rally core team deliberately decided not to use an"},{"line_number":23,"context_line":"    existing framework for this such a `testtools`."},{"line_number":24,"context_line":"    See https://review.openstack.org/#/c/263759/ for details."},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _concatenate_message(self, default, extended):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_85506c33","line":24,"updated":"2016-01-25 11:39:15.000000000","message":"Thank you for patch.\n\nCould you paste please here details. This review can be deleted in future","commit_id":"173b93b1b79d8cf9df7022728e3484d6ea4c1598"},{"author":{"_account_id":18364,"name":"Raphaël Badin","email":"rabadin@cisco.com","username":"rvba"},"change_message_id":"279a9896ea53fad0e05b4de6482c20b6d5229c76","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Note that the Rally core team deliberately decided not to use an"},{"line_number":23,"context_line":"    existing framework for this such a `testtools`."},{"line_number":24,"context_line":"    See https://review.openstack.org/#/c/263759/ for details."},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _concatenate_message(self, default, extended):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_da339af4","line":24,"in_reply_to":"9a68dd71_85506c33","updated":"2016-01-25 12:33:59.000000000","message":"Sure, done. I\u0027ve reformulated the reasons you gave me for rejecting this a little for clarity.","commit_id":"173b93b1b79d8cf9df7022728e3484d6ea4c1598"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"763e782e57a46c7d51a0cd5825be63d7d6a63e92","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      time required to install Rally, more disk space required by Rally."},{"line_number":32,"context_line":"    - Classes like Scenario \u0026 Context are inherit from testtools.TestCase that"},{"line_number":33,"context_line":"      makes these classes really hard to learn (for instance:"},{"line_number":34,"context_line":"      running dir(base.Scenario) you cann see a ton of methods inside it)"},{"line_number":35,"context_line":"    - It won\u0027t be clear for end users what exceptions are raised: there are"},{"line_number":36,"context_line":"      going to be unittest exceptions raised during production runs instead of"},{"line_number":37,"context_line":"      Rally assertation exceptions."}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_c5ff1b64","line":34,"range":{"start_line":34,"start_character":37,"end_line":34,"end_character":41},"updated":"2016-01-26 03:17:10.000000000","message":"cannot","commit_id":"44baf86fe3304e038390145c0caa5492867bc63d"},{"author":{"_account_id":18364,"name":"Raphaël Badin","email":"rabadin@cisco.com","username":"rvba"},"change_message_id":"a4e9ab09ea11ba123bdac17c253b0adbf3713e4c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      time required to install Rally, more disk space required by Rally."},{"line_number":32,"context_line":"    - Classes like Scenario \u0026 Context are inherit from testtools.TestCase that"},{"line_number":33,"context_line":"      makes these classes really hard to learn (for instance:"},{"line_number":34,"context_line":"      running dir(base.Scenario) you cann see a ton of methods inside it)"},{"line_number":35,"context_line":"    - It won\u0027t be clear for end users what exceptions are raised: there are"},{"line_number":36,"context_line":"      going to be unittest exceptions raised during production runs instead of"},{"line_number":37,"context_line":"      Rally assertation exceptions."}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_7c691d25","line":34,"range":{"start_line":34,"start_character":37,"end_line":34,"end_character":41},"in_reply_to":"9a68dd71_c5ff1b64","updated":"2016-01-26 09:44:45.000000000","message":"s/cann/can/ done.","commit_id":"44baf86fe3304e038390145c0caa5492867bc63d"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"06307da3319d10ff5bb679e3c25eb5d56794f403","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    - Rally code depends on a bunch of new libs introduced by testtools and"},{"line_number":30,"context_line":"      testtools itself, which means: more code on which Rally is dependent,"},{"line_number":31,"context_line":"      more time required to install Rally, more disk space required by Rally."},{"line_number":32,"context_line":"    - Classes like Scenario \u0026 Context are inherit from testtools.TestCase that"},{"line_number":33,"context_line":"      makes these classes really hard to learn (for instance:"},{"line_number":34,"context_line":"      running dir(base.Scenario) you cannot see a ton of methods inside it)"},{"line_number":35,"context_line":"    - It won\u0027t be clear for end users what exceptions are raised: there are"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_97ce2b59","line":32,"range":{"start_line":32,"start_character":42,"end_line":32,"end_character":49},"updated":"2016-01-27 13:59:41.000000000","message":"inherited","commit_id":"58ce6ee41188ba0f17dc6e69862f11d03caf8df9"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"06307da3319d10ff5bb679e3c25eb5d56794f403","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    - Classes like Scenario \u0026 Context are inherit from testtools.TestCase that"},{"line_number":33,"context_line":"      makes these classes really hard to learn (for instance:"},{"line_number":34,"context_line":"      running dir(base.Scenario) you cannot see a ton of methods inside it)"},{"line_number":35,"context_line":"    - It won\u0027t be clear for end users what exceptions are raised: there are"},{"line_number":36,"context_line":"      going to be unittest exceptions raised during production runs instead of"},{"line_number":37,"context_line":"      Rally assertion exceptions."},{"line_number":38,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_d7390343","line":35,"range":{"start_line":35,"start_character":72,"end_line":35,"end_character":75},"updated":"2016-01-27 13:59:41.000000000","message":"there are going to be -- not sure what do you really mean\nMaybe: unittest exceptions are going to be raised instead of... ?","commit_id":"58ce6ee41188ba0f17dc6e69862f11d03caf8df9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cc13d13e2a31b8fc5589b1c9cc833168756328d4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    The Rally core team deliberately decided not to use an existing framework"},{"line_number":23,"context_line":"    for this such a `testtools`."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    The reasons given in the (negative) review that proposed to use testtools\u0027"},{"line_number":26,"context_line":"    assertions were that such a change would introduce the following problems:"},{"line_number":27,"context_line":"    - Rally production code works with testing tools code that is not designed"},{"line_number":28,"context_line":"      to be used in production."}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_cee7fbe2","line":25,"updated":"2016-01-28 11:39:36.000000000","message":"Lines 25-26 are hard to read for me, I think they are redundant and can be replaced with something very short, even with \"Reasons are:\"","commit_id":"5a1732188163d6966db97db24133cde651a0ed14"}],"tests/unit/task/test_functional.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"29f9e8f605eb246fd7537644348227964fc31452","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_implements_assertions(self):"},{"line_number":29,"context_line":"        self.assertThat("},{"line_number":30,"context_line":"            dir(scenario.Scenario()),"},{"line_number":31,"context_line":"            matchers.ContainsAll(["},{"line_number":32,"context_line":"                \"assertEqual\","},{"line_number":33,"context_line":"                \"assertNotEqual\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_9f6c6b36","line":30,"updated":"2016-01-05 15:16:14.000000000","message":"This (and the tests below) depend on scenario.Scenario implementing FunctionalMixin. Would it be better to create a dummy class just in this test module instead of using Scenario?","commit_id":"3a401722df5c3d4a4936898b2db076fe9fbd7914"},{"author":{"_account_id":18364,"name":"Raphaël Badin","email":"rabadin@cisco.com","username":"rvba"},"change_message_id":"2566c2a19ab5b809a3bdcc66976ccb064702276b","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_implements_assertions(self):"},{"line_number":29,"context_line":"        self.assertThat("},{"line_number":30,"context_line":"            dir(scenario.Scenario()),"},{"line_number":31,"context_line":"            matchers.ContainsAll(["},{"line_number":32,"context_line":"                \"assertEqual\","},{"line_number":33,"context_line":"                \"assertNotEqual\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_8a8bc7c2","line":30,"in_reply_to":"fa69d971_9f6c6b36","updated":"2016-01-05 15:35:07.000000000","message":"I considered it but since this is a mixin that\u0027s only there to extend scenario.Scenario, I thought it was better to test the Scenario class directly.  I\u0027ve added a comment to that effect.","commit_id":"3a401722df5c3d4a4936898b2db076fe9fbd7914"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"29f9e8f605eb246fd7537644348227964fc31452","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            int,"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_returns_none_when_instance_does_not_matche_type(self):"},{"line_number":59,"context_line":"        random_str \u003d uuid.uuid4()"},{"line_number":60,"context_line":"        self.assertIsNone("},{"line_number":61,"context_line":"            scenario.Scenario().assertIsNotInstance(random_str, int))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_bf328f5c","line":58,"updated":"2016-01-05 15:16:14.000000000","message":"s/matche/match/","commit_id":"3a401722df5c3d4a4936898b2db076fe9fbd7914"},{"author":{"_account_id":18364,"name":"Raphaël Badin","email":"rabadin@cisco.com","username":"rvba"},"change_message_id":"2566c2a19ab5b809a3bdcc66976ccb064702276b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            int,"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_returns_none_when_instance_does_not_matche_type(self):"},{"line_number":59,"context_line":"        random_str \u003d uuid.uuid4()"},{"line_number":60,"context_line":"        self.assertIsNone("},{"line_number":61,"context_line":"            scenario.Scenario().assertIsNotInstance(random_str, int))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_caad3f85","line":58,"in_reply_to":"fa69d971_bf328f5c","updated":"2016-01-05 15:35:07.000000000","message":"Fixed.","commit_id":"3a401722df5c3d4a4936898b2db076fe9fbd7914"}]}
