)]}'
{"tests/hacking/checks.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f1f04b022718f1ee8c9ecd5dd8b4b2f825b29af9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    r\"\\s:raise[^s] *.*$|\\s:raises *:.*$|\\s:raises *[^:]+$\")"},{"line_number":64,"context_line":"re_db_import \u003d re.compile(r\"^from rally.common import db\")"},{"line_number":65,"context_line":"re_objects_import \u003d re.compile(r\"^from rally.common import objects\")"},{"line_number":66,"context_line":"re_dict_get_with_none \u003d re.compile(r\"\\.get\\(\\\"*\\w+\\\"*, None\\)\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def skip_ignored_lines(func):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_208ff024","line":66,"updated":"2016-01-18 23:22:38.000000000","message":"I don\u0027t like this hack. This potentially causes a bugs.  It matched also not dictionary get() methods. For example:\n  obj \u003d MyClass()\n  obj.get()","commit_id":"a9e2d45abe0e4546e1bf8ab79d4582573daf5e96"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"1bbefcadc2af8a0f4b932465932e189d688baf8f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    r\"\\s:raise[^s] *.*$|\\s:raises *:.*$|\\s:raises *[^:]+$\")"},{"line_number":64,"context_line":"re_db_import \u003d re.compile(r\"^from rally.common import db\")"},{"line_number":65,"context_line":"re_objects_import \u003d re.compile(r\"^from rally.common import objects\")"},{"line_number":66,"context_line":"re_dict_get_with_none \u003d re.compile(r\"\\.get\\(\\\"*\\w+\\\"*, None\\)\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def skip_ignored_lines(func):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_ee059713","line":66,"in_reply_to":"9a68dd71_8e7e5b68","updated":"2016-01-25 04:01:12.000000000","message":"Understand ! Updated without hacking rule !","commit_id":"a9e2d45abe0e4546e1bf8ab79d4582573daf5e96"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"d2c8028a30ad6dda0b8404bfa5c3e9f81c2f17e3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    r\"\\s:raise[^s] *.*$|\\s:raises *:.*$|\\s:raises *[^:]+$\")"},{"line_number":64,"context_line":"re_db_import \u003d re.compile(r\"^from rally.common import db\")"},{"line_number":65,"context_line":"re_objects_import \u003d re.compile(r\"^from rally.common import objects\")"},{"line_number":66,"context_line":"re_dict_get_with_none \u003d re.compile(r\"\\.get\\(\\\"*\\w+\\\"*, None\\)\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def skip_ignored_lines(func):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_69c1532e","line":66,"in_reply_to":"ba63e191_208ff024","updated":"2016-01-19 01:00:50.000000000","message":"Thanks for the review.\n\nCould you explain a little more about What issue could it cause ?\n\nI do not think I have fully understand it.","commit_id":"a9e2d45abe0e4546e1bf8ab79d4582573daf5e96"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"a2affd71f3d80a5f407e714aa73a2c2fedecc20f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    r\"\\s:raise[^s] *.*$|\\s:raises *:.*$|\\s:raises *[^:]+$\")"},{"line_number":64,"context_line":"re_db_import \u003d re.compile(r\"^from rally.common import db\")"},{"line_number":65,"context_line":"re_objects_import \u003d re.compile(r\"^from rally.common import objects\")"},{"line_number":66,"context_line":"re_dict_get_with_none \u003d re.compile(r\"\\.get\\(\\\"*\\w+\\\"*, None\\)\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def skip_ignored_lines(func):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_8e7e5b68","line":66,"in_reply_to":"ba63e191_69c1532e","updated":"2016-01-25 03:10:21.000000000","message":"In Roman\u0027s example, obj is an instance of MyClass, not a dict. And sometime obj.get(xx, None) would happen and None is meaningful here. So your hack here would make mistakes","commit_id":"a9e2d45abe0e4546e1bf8ab79d4582573daf5e96"}]}