)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a5319a288713eb73bba5976785669d21fb050e26","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Piyush Raman \u003cpirsriva@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-25 12:11:01 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for listing subnets, routers and floatingIPs to NeutronWrapper class and listing floatingIPs to NovaNetworkWrapper."},{"line_number":8,"context_line":"This extends capability for NetworkWrapper in Rally"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I205a0cd9bc0ee0f0bcac69ae359866a942ca08b4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_411c8869","line":7,"updated":"2016-01-26 00:40:47.000000000","message":"Too long. All specific detail shouldn\u0027t be in the title.","commit_id":"f9bf957cca9129efb32f4ee004c9be80a0594e52"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"f02ad7778847652078424dece79cebd8c7cb85c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add list subnets/routers/FIPs to NetworkWrapper"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I205a0cd9bc0ee0f0bcac69ae359866a942ca08b4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a5ae5dd_6df78959","line":9,"updated":"2016-02-05 17:12:33.000000000","message":"This needs a Closes-Bug clause as well, although the bug in question is almost certainly invalid as it gives no use case for the methods it claims are \"missing.\"","commit_id":"23e56a2b24ead8b1cbda4aef79b199a50d54e8f2"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"f23d60b7e75918dda7277d262f6c24dce1e22317","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def _list_subnets(self):"},{"line_number":157,"context_line":"        \"\"\"Returns user subnetworks list.\"\"\""},{"line_number":158,"context_line":"        net_wrapper \u003d self._get_network_wrapper()"},{"line_number":159,"context_line":"        return net_wrapper.list_subnets()"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @atomic.action_timer(\"neutron.update_subnet\")"},{"line_number":162,"context_line":"    def _update_subnet(self, subnet, subnet_update_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_39677e4e","line":159,"updated":"2016-02-01 06:12:21.000000000","message":"you may forget add [\"subnets\"] here :)","commit_id":"326c098ae3e1a8c3fa4ce1912cffffecc67dc5c2"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"80b90045cc6ff47ca88b5936ed8d9111f6ca847c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def _list_subnets(self):"},{"line_number":157,"context_line":"        \"\"\"Returns user subnetworks list.\"\"\""},{"line_number":158,"context_line":"        net_wrapper \u003d self._get_network_wrapper()"},{"line_number":159,"context_line":"        return net_wrapper.list_subnets()"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @atomic.action_timer(\"neutron.update_subnet\")"},{"line_number":162,"context_line":"    def _update_subnet(self, subnet, subnet_update_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_39a089f4","line":159,"in_reply_to":"7a5de9d1_39677e4e","updated":"2016-02-03 09:38:53.000000000","message":"@Kun, return value from wrapper usually differs from return value of related neutron client api","commit_id":"326c098ae3e1a8c3fa4ce1912cffffecc67dc5c2"}],"rally/plugins/openstack/wrappers/network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a5319a288713eb73bba5976785669d21fb050e26","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \"\"\"List networks.\"\"\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @abc.abstractmethod"},{"line_number":104,"context_line":"    def list_floatingips(self):"},{"line_number":105,"context_line":"        \"\"\"List floatingips.\"\"\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_413328f6","line":104,"updated":"2016-01-26 00:40:47.000000000","message":"please rename it to list_floating_ips","commit_id":"f9bf957cca9129efb32f4ee004c9be80a0594e52"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a5319a288713eb73bba5976785669d21fb050e26","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    def list_routers(self):"},{"line_number":415,"context_line":"        return self.client.list_routers()[\"routers\"]"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def list_floatingips(self):"},{"line_number":418,"context_line":"        return self.client.list_floatingips()[\"floatingips\"]"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def create_port(self, network_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_59c23854","line":417,"updated":"2016-01-26 00:40:47.000000000","message":"please rename it to list_floating_ips","commit_id":"f9bf957cca9129efb32f4ee004c9be80a0594e52"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"80b90045cc6ff47ca88b5936ed8d9111f6ca847c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    def list_floating_ips(self):"},{"line_number":193,"context_line":"        fips_list \u003d [self._marshal_floatingip_object(n)"},{"line_number":194,"context_line":"                     for n in self.client.floating_ips.list()]"},{"line_number":195,"context_line":"        return {\"floatingips\": fips_list}"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def create_floating_ip(self, ext_network\u003dNone, **kwargs):"},{"line_number":198,"context_line":"        \"\"\"Allocate a floating ip from the given nova-network pool"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_393169a3","line":195,"updated":"2016-02-03 09:38:53.000000000","message":"{\"some_key\": \u003cdata\u003e} is neutron client api style for return value. As you see, wrapper does no use this style, for example L410, L430\n\nUse this (similar to L189):\n\n return [self._marshal_floatingip_object(n)\n         for n in self.client.floating_ips.list()]","commit_id":"326c098ae3e1a8c3fa4ce1912cffffecc67dc5c2"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"13873896df004231afa413450b09f5d81a66fbe1","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                \"fixed_ip\": fip_obj.fixed_ip,"},{"line_number":158,"context_line":"                \"instance_id\": fip_obj.instance_id,"},{"line_number":159,"context_line":"                \"ip\": fip_obj.ip,"},{"line_number":160,"context_line":"                \"pool\": fip_obj.pool}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def create_network(self, tenant_id, **kwargs):"},{"line_number":163,"context_line":"        \"\"\"Create network."}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_6d1b09cb","line":160,"updated":"2016-02-05 17:11:09.000000000","message":"This should be used in create_floating_ip() as well to keep return values consistent.","commit_id":"23e56a2b24ead8b1cbda4aef79b199a50d54e8f2"}],"tests/unit/plugins/openstack/scenarios/neutron/test_utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"80b90045cc6ff47ca88b5936ed8d9111f6ca847c","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    def test_list_routers(self):"},{"line_number":288,"context_line":"        scenario \u003d utils.NeutronScenario(context\u003dself.context)"},{"line_number":289,"context_line":"        routers \u003d [mock.Mock()]"},{"line_number":290,"context_line":"        \"\"\""},{"line_number":291,"context_line":"        self.clients(\"neutron\").list_routers.return_value \u003d {"},{"line_number":292,"context_line":"            \"routers\": routers}"},{"line_number":293,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_993f3d25","line":290,"updated":"2016-02-03 09:38:53.000000000","message":"Remove this tricky comment :)","commit_id":"326c098ae3e1a8c3fa4ce1912cffffecc67dc5c2"}],"tests/unit/plugins/openstack/wrappers/test_network.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"80b90045cc6ff47ca88b5936ed8d9111f6ca847c","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        wrap.create_port \u003d mock.Mock(return_value\u003d{\"id\": \"port_id\"})"},{"line_number":451,"context_line":"        wrap.client.create_floatingip \u003d mock.Mock("},{"line_number":452,"context_line":"            return_value\u003d{\"floatingip\": {\"id\": \"fip_id\","},{"line_number":453,"context_line":"                                         \"floating_ip_address\": \"fip_ip\"}})"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        self.assertRaises(ValueError, wrap.create_floating_ip)"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_27870063","side":"PARENT","line":453,"updated":"2016-02-03 09:38:53.000000000","message":"Why this indentation is changed? This is a \"hanging bracket\" indentation for {\"id\": \"fip_id\", \"floating_ip_address\": \"fip_ip\"}, not for {\"floatingip\": \u003cvalue\u003e}","commit_id":"1831d47c3de0b813d924d8b28ac7b50e5eb8b0f4"}]}
