)]}'
{"rally/plugins/openstack/cleanup/base.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d6569afcde832b88f178955362140f2e1ed7ba3d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return self.raw_resource.id"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def name(self):"},{"line_number":102,"context_line":"        \"\"\"Returns name of resource.\"\"\""},{"line_number":103,"context_line":"        return self.raw_resource.name"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def is_deleted(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_8a19288b","line":102,"updated":"2016-02-22 13:31:35.000000000","message":"Does this mean that None is appropriate return value?","commit_id":"9086c3d00a95e22e805cf79885c66b1d1a5326ab"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"3aa33036897c10642eaa3bf93d4edae3443d5006","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return self.raw_resource.id"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def name(self):"},{"line_number":102,"context_line":"        \"\"\"Returns name of resource.\"\"\""},{"line_number":103,"context_line":"        return self.raw_resource.name"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def is_deleted(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_15e7f0b0","line":102,"in_reply_to":"bae84128_8a19288b","updated":"2016-02-22 19:34:58.000000000","message":"Yes, since some resources don\u0027t have names. Docstring has been updated.","commit_id":"9086c3d00a95e22e805cf79885c66b1d1a5326ab"}],"rally/plugins/openstack/cleanup/manager.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2b48f3add91df67daf45b567c7fec721c0b977d3","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        msg_kw \u003d {"},{"line_number":75,"context_line":"            \"uuid\": resource.id(),"},{"line_number":76,"context_line":"            \"name\": resource.name(),"},{"line_number":77,"context_line":"            \"service\": resource._service,"},{"line_number":78,"context_line":"            \"resource\": resource._resource"},{"line_number":79,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_a489c828","line":76,"range":{"start_line":76,"start_character":12,"end_line":76,"end_character":36},"updated":"2016-02-16 15:50:15.000000000","message":"In [1]: \"%s\" % None\nOut[1]: \u0027None\u0027\n\nThe message from L81 will include \"None\" word if resource doesn\u0027t have name. Let\u0027s write here something like\n\n    \"name\": resource.name() or \"\", \n\nor change message/name method","commit_id":"1c4c36b3aea564442be6dcc1da5bc841a4bee95a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bbb181651b4188ba0488e8108817903300a05c5d","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        msg_kw \u003d {"},{"line_number":75,"context_line":"            \"uuid\": resource.id(),"},{"line_number":76,"context_line":"            \"name\": resource.name(),"},{"line_number":77,"context_line":"            \"service\": resource._service,"},{"line_number":78,"context_line":"            \"resource\": resource._resource"},{"line_number":79,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_e1fe1d37","line":76,"range":{"start_line":76,"start_character":12,"end_line":76,"end_character":36},"in_reply_to":"dae33548_a489c828","updated":"2016-02-16 16:53:21.000000000","message":"Done","commit_id":"1c4c36b3aea564442be6dcc1da5bc841a4bee95a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d6569afcde832b88f178955362140f2e1ed7ba3d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        msg_kw \u003d {"},{"line_number":79,"context_line":"            \"uuid\": resource.id(),"},{"line_number":80,"context_line":"            \"name\": resource.name() or \"\","},{"line_number":81,"context_line":"            \"service\": resource._service,"},{"line_number":82,"context_line":"            \"resource\": resource._resource"},{"line_number":83,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_2af9fc4d","line":80,"updated":"2016-02-22 13:31:35.000000000","message":"can resource.name() return non-basestring boolean false (None, 0, ...)? Maybe expect name() to return basestring in all cases?","commit_id":"9086c3d00a95e22e805cf79885c66b1d1a5326ab"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"3aa33036897c10642eaa3bf93d4edae3443d5006","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        msg_kw \u003d {"},{"line_number":79,"context_line":"            \"uuid\": resource.id(),"},{"line_number":80,"context_line":"            \"name\": resource.name() or \"\","},{"line_number":81,"context_line":"            \"service\": resource._service,"},{"line_number":82,"context_line":"            \"resource\": resource._resource"},{"line_number":83,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_b06f282a","line":80,"in_reply_to":"bae84128_2af9fc4d","updated":"2016-02-22 19:34:58.000000000","message":"I\u0027m not sure; permitting None to be returned will allow us to distinguish between \"this resource has an empty name\" (name \u003d \"\") and \"this resource is not nameable\" (name \u003d None).","commit_id":"9086c3d00a95e22e805cf79885c66b1d1a5326ab"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9d8cc9b9403a8a2d2ca33e61718477c4ff7260dc","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        msg_kw \u003d {"},{"line_number":76,"context_line":"            \"uuid\": resource.id(),"},{"line_number":77,"context_line":"            \"name\": resource.name(),"},{"line_number":78,"context_line":"            \"service\": resource._service,"},{"line_number":79,"context_line":"            \"resource\": resource._resource"},{"line_number":80,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":13,"id":"5aef4532_7d1e4164","line":77,"updated":"2016-03-08 15:17:45.000000000","message":"Why this line is different from patch-set #10 ?","commit_id":"6eb505ecbc810efd8334d5730d8cd88f748e7d14"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b8b4de2788c0fcf125d58cb149ce13814dd474da","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        msg_kw \u003d {"},{"line_number":76,"context_line":"            \"uuid\": resource.id(),"},{"line_number":77,"context_line":"            \"name\": resource.name(),"},{"line_number":78,"context_line":"            \"service\": resource._service,"},{"line_number":79,"context_line":"            \"resource\": resource._resource"},{"line_number":80,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":13,"id":"5aef4532_0c71cce0","line":77,"in_reply_to":"5aef4532_7d1e4164","updated":"2016-03-08 16:01:22.000000000","message":"That\u0027s a good question, and I have no idea. Fixed.","commit_id":"6eb505ecbc810efd8334d5730d8cd88f748e7d14"}],"rally/plugins/openstack/cleanup/resources.py":[{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"a9a99c0581b878815639975953ec2e4da58478c3","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        return self.raw_resource"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def name(self):"},{"line_number":568,"context_line":"        return self.raw_resource[\"name\"]"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def delete(self):"},{"line_number":571,"context_line":"        delete_method \u003d getattr(self._manager(), \"delete_%s\" % self._resource)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5aef4532_f081214f","line":568,"range":{"start_line":568,"start_character":0,"end_line":568,"end_character":40},"updated":"2016-03-07 11:56:10.000000000","message":"Just want to be sure this is as intended. Is SwiftMixin::id() really a dict?","commit_id":"adcd838cde08a0a919e26650c49f759d13d4c569"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e0e8cf25517f53db16208b1027902443737f6506","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        return self.raw_resource"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def name(self):"},{"line_number":568,"context_line":"        return self.raw_resource[\"name\"]"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def delete(self):"},{"line_number":571,"context_line":"        delete_method \u003d getattr(self._manager(), \"delete_%s\" % self._resource)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5aef4532_4ba02491","line":568,"range":{"start_line":568,"start_character":0,"end_line":568,"end_character":40},"in_reply_to":"5aef4532_f081214f","updated":"2016-03-07 12:28:06.000000000","message":"Good catch. Looking at the code below, it seems to be a list of either [container name, object name] or [container name]. That\u0027s a little odd IMO, but it\u0027s definitely not a dict. I\u0027ll update this.","commit_id":"adcd838cde08a0a919e26650c49f759d13d4c569"}]}