)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e449d3b0d54cf630202c04812ec98b6441de1c11","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Verify] Don\u0027t create new flavor when flavor already exists"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is a flavor with RAM \u003d 64MB or RAM \u003d 128MB in the cloud,"},{"line_number":10,"context_line":"Tempest resources context will not create a new flavor and will use"},{"line_number":11,"context_line":"the existing one for tests."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a5de9d1_f9000668","line":9,"updated":"2016-02-01 06:04:40.000000000","message":"This sentence looks like no matter what you done in config if there are in a system flavors with exactly 64mb and 128mb RAM, then we will not able to create the new one. I think we should Add such words as: \"For example..\", \"if in config we tries to create a new flavor with ram 64mb... and in the cloud already exists flavor with...\"","commit_id":"f92b56e99c3f01ee6e4b6689bcb9913953fdb206"}],"rally/verification/tempest/config.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e449d3b0d54cf630202c04812ec98b6441de1c11","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            if flavor.ram \u003d\u003d flv_ram:"},{"line_number":419,"context_line":"                LOG.debug(\"Using flavor \u0027%s\u0027 because \""},{"line_number":420,"context_line":"                          \"its RAM equals to %dMB\" % (flavor.name, flavor.ram))"},{"line_number":421,"context_line":"                return flavor"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        params \u003d {"},{"line_number":424,"context_line":"            \"name\": self.generate_random_name(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_39a8de8c","line":421,"updated":"2016-02-01 06:04:40.000000000","message":"is it normal that you could return flavor with needed ram but vcpus woulв be be 4 and disk 20, for example? I suggest to check also vcpus and disk.","commit_id":"f92b56e99c3f01ee6e4b6689bcb9913953fdb206"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4d176d2f50526a2cb0b8d7bdb5c3641e027027f","unresolved":false,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        return image"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def _discover_or_create_flavor(self, flv_ram):"},{"line_number":441,"context_line":"        novaclient \u003d self.clients.nova()"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        LOG.debug(\"Trying to discover a flavor with the following \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_a7660027","line":440,"updated":"2016-02-16 10:29:09.000000000","message":"If it would be useful in the future to discover_or_create_flavor not only with ram but also with vcpus and disk etc, then this is the right moment to add those abilities)","commit_id":"545523597d358f151f51a5c5eed968a5656e983a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a4264f9b75dcf645356116b36dabaa40520d933f","unresolved":false,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        return image"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def _discover_or_create_flavor(self, flv_ram):"},{"line_number":441,"context_line":"        novaclient \u003d self.clients.nova()"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        LOG.debug(\"Trying to discover a flavor with the following \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_09da4d78","line":440,"in_reply_to":"dae33548_a7660027","updated":"2016-02-16 15:37:23.000000000","message":"Yes, it makes sense.","commit_id":"545523597d358f151f51a5c5eed968a5656e983a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4d176d2f50526a2cb0b8d7bdb5c3641e027027f","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        novaclient \u003d self.clients.nova()"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        LOG.debug(\"Trying to discover a flavor with the following \""},{"line_number":444,"context_line":"                  \"properties: RAM \u003d %dMB, CPU \u003d 1, disk \u003d 0GB\" % flv_ram)"},{"line_number":445,"context_line":"        for flavor in novaclient.flavors.list():"},{"line_number":446,"context_line":"            if (flavor.ram \u003d\u003d flv_ram"},{"line_number":447,"context_line":"                    and flavor.vcpus \u003d\u003d 1 and flavor.disk \u003d\u003d 0):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_4778d4c4","line":444,"range":{"start_line":444,"start_character":42,"end_line":444,"end_character":43},"updated":"2016-02-16 10:29:09.000000000","message":"Its better to rename \u0027CPU\u0027 to \u0027VCPUs\u0027.","commit_id":"545523597d358f151f51a5c5eed968a5656e983a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a4264f9b75dcf645356116b36dabaa40520d933f","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        novaclient \u003d self.clients.nova()"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        LOG.debug(\"Trying to discover a flavor with the following \""},{"line_number":444,"context_line":"                  \"properties: RAM \u003d %dMB, CPU \u003d 1, disk \u003d 0GB\" % flv_ram)"},{"line_number":445,"context_line":"        for flavor in novaclient.flavors.list():"},{"line_number":446,"context_line":"            if (flavor.ram \u003d\u003d flv_ram"},{"line_number":447,"context_line":"                    and flavor.vcpus \u003d\u003d 1 and flavor.disk \u003d\u003d 0):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_a94ec16c","line":444,"range":{"start_line":444,"start_character":42,"end_line":444,"end_character":43},"in_reply_to":"dae33548_4778d4c4","updated":"2016-02-16 15:37:23.000000000","message":"Done","commit_id":"545523597d358f151f51a5c5eed968a5656e983a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4d176d2f50526a2cb0b8d7bdb5c3641e027027f","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                          \"flavor \u0027{0}\u0027 for the tests\".format(flavor.name))"},{"line_number":450,"context_line":"                return flavor"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        LOG.debug(\"There is no flavor with the mentioned properties\")"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        params \u003d {"},{"line_number":455,"context_line":"            \"name\": self.generate_random_name(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_0a6ff1c5","line":452,"updated":"2016-02-16 10:29:09.000000000","message":"Add the dot please  to the end of the sentence.","commit_id":"545523597d358f151f51a5c5eed968a5656e983a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a4264f9b75dcf645356116b36dabaa40520d933f","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                          \"flavor \u0027{0}\u0027 for the tests\".format(flavor.name))"},{"line_number":450,"context_line":"                return flavor"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        LOG.debug(\"There is no flavor with the mentioned properties\")"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        params \u003d {"},{"line_number":455,"context_line":"            \"name\": self.generate_random_name(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_4900d5aa","line":452,"in_reply_to":"dae33548_0a6ff1c5","updated":"2016-02-16 15:37:23.000000000","message":"The thing is that no debug message in the TempestResourcesContext class has a dot at the end. So let\u0027s leave it as it is for consistency :)","commit_id":"545523597d358f151f51a5c5eed968a5656e983a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4d176d2f50526a2cb0b8d7bdb5c3641e027027f","unresolved":false,"context_lines":[{"line_number":458,"context_line":"            \"disk\": 0"},{"line_number":459,"context_line":"        }"},{"line_number":460,"context_line":"        LOG.debug(\"Creating flavor \u0027%s\u0027 with the following properties: RAM \""},{"line_number":461,"context_line":"                  \"\u003d %dMB, CPU \u003d 1, disk \u003d 0GB\" % (params[\"name\"], flv_ram))"},{"line_number":462,"context_line":"        flavor \u003d novaclient.flavors.create(**params)"},{"line_number":463,"context_line":"        self._created_flavors.append(flavor)"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e77008df","line":461,"updated":"2016-02-16 10:29:09.000000000","message":"Its better to rename \u0027CPU\u0027 to \u0027VCPUs\u0027.","commit_id":"545523597d358f151f51a5c5eed968a5656e983a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a4264f9b75dcf645356116b36dabaa40520d933f","unresolved":false,"context_lines":[{"line_number":458,"context_line":"            \"disk\": 0"},{"line_number":459,"context_line":"        }"},{"line_number":460,"context_line":"        LOG.debug(\"Creating flavor \u0027%s\u0027 with the following properties: RAM \""},{"line_number":461,"context_line":"                  \"\u003d %dMB, CPU \u003d 1, disk \u003d 0GB\" % (params[\"name\"], flv_ram))"},{"line_number":462,"context_line":"        flavor \u003d novaclient.flavors.create(**params)"},{"line_number":463,"context_line":"        self._created_flavors.append(flavor)"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e958c934","line":461,"in_reply_to":"dae33548_e77008df","updated":"2016-02-16 15:37:23.000000000","message":"Done","commit_id":"545523597d358f151f51a5c5eed968a5656e983a"}]}