)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0f8d0012a221fc0d88fce630f723cfb367b26611","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-02-09 04:43:38 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log instance console to vmtasks scenarios"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib7556f9382d9219027ec0651036553c3f33b8295"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a57f1b5_c4bb9e74","line":8,"updated":"2016-02-09 18:06:21.000000000","message":"Please add some details here about why you made this patch/why its needed","commit_id":"b745f89c41b79d4eee90ccb2cd2398f9a051fbda"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"88220fa45871ec1e79f130985c58175be6d0511e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log VM console when Rally fails to connect to VM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib7556f9382d9219027ec0651036553c3f33b8295"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Log VM console when Rally fails to connect to VM"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a57f1b5_df3beecf","line":9,"updated":"2016-02-11 15:03:47.000000000","message":"Delete this.","commit_id":"a20696f7e0b42295c8119a7a989b766fe01452d9"}],"rally/common/sshutils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"39db60f273847456ceff36f8a9f9d5a64e0e969c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    pass"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class SSHTimeout(SSHError):"},{"line_number":80,"context_line":"    pass"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_37f1fb01","line":79,"updated":"2016-02-05 08:10:06.000000000","message":"Please move SSHTimeout and SSHError to exceptions to rally/exceptions","commit_id":"b7d046099d5bd234546feeb3c189c11d9d285195"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"39db60f273847456ceff36f8a9f9d5a64e0e969c","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                LOG.debug(\"Ssh is still unavailable: %r\" % e)"},{"line_number":264,"context_line":"                time.sleep(interval)"},{"line_number":265,"context_line":"            if time.time() \u003e (start_time + timeout):"},{"line_number":266,"context_line":"                raise exceptions.SSHTimeoutWaitingException(host\u003dself.host)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _put_file_sftp(self, localpath, remotepath, mode\u003dNone):"},{"line_number":269,"context_line":"        client \u003d self._get_client()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_57f6f7f9","line":266,"updated":"2016-02-05 08:10:06.000000000","message":"Please use this exception instead SSHTimeout all where in this file","commit_id":"b7d046099d5bd234546feeb3c189c11d9d285195"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0f8d0012a221fc0d88fce630f723cfb367b26611","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            message \u003d (\"Exception %(exception_type)s was raised \""},{"line_number":121,"context_line":"                       \"during connect to %(user)s@%(host)s:%(port)s. \""},{"line_number":122,"context_line":"                       \"Exception value is: %(exception)r\")"},{"line_number":123,"context_line":"            error_message \u003d message % {\"exception\": e,"},{"line_number":124,"context_line":"                                       \"user\": self.user,"},{"line_number":125,"context_line":"                                       \"host\": self.host,"},{"line_number":126,"context_line":"                                       \"port\": self.port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_4a3a57cf","line":123,"updated":"2016-02-09 18:06:21.000000000","message":"We don\u0027t like local variables that are used only once(in Rally command)","commit_id":"b745f89c41b79d4eee90ccb2cd2398f9a051fbda"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0f8d0012a221fc0d88fce630f723cfb367b26611","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                                            \"\u0027%(cmd)s\u0027 on host %(host)s\" %"},{"line_number":217,"context_line":"                                            args)"},{"line_number":218,"context_line":"            if e:"},{"line_number":219,"context_line":"                raise exceptions.SSHError(message\u003d\"Socket error.\")"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        exit_status \u003d session.recv_exit_status()"},{"line_number":222,"context_line":"        if 0 !\u003d exit_status and raise_on_error:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_6a79532f","line":219,"updated":"2016-02-09 18:06:21.000000000","message":"We could pass here the same constraction as in line 123. Therefore we will be able to move building of msg into rally/exception.py","commit_id":"b745f89c41b79d4eee90ccb2cd2398f9a051fbda"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0f8d0012a221fc0d88fce630f723cfb367b26611","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                LOG.debug(\"Ssh is still unavailable: %r\" % e)"},{"line_number":257,"context_line":"                time.sleep(interval)"},{"line_number":258,"context_line":"            if time.time() \u003e (start_time + timeout):"},{"line_number":259,"context_line":"                raise exceptions.SSHTimeout(message\u003d\"Timeout waiting for \""},{"line_number":260,"context_line":"                                                    \"\u0027%s\u0027\" % self.host)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def _put_file_sftp(self, localpath, remotepath, mode\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_0a90df94","line":259,"updated":"2016-02-09 18:06:21.000000000","message":"Please move \"Timeout waiting for \u0027%s\u0027\" to rally/exceptions.py","commit_id":"b745f89c41b79d4eee90ccb2cd2398f9a051fbda"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d04dd4fe26462f1212eb306bff525249db37300c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                return key_class.from_private_key(key)"},{"line_number":104,"context_line":"            except paramiko.SSHException as e:"},{"line_number":105,"context_line":"                errors.append(e)"},{"line_number":106,"context_line":"        raise exceptions.SSHError(message\u003d\"Invalid pkey: %s\" % (errors))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _get_client(self):"},{"line_number":109,"context_line":"        if self._client:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_d1c1fa2f","line":106,"range":{"start_line":106,"start_character":43,"end_line":106,"end_character":50},"updated":"2016-02-10 09:51:07.000000000","message":"Not using kwarg, i.e. just\n exceptions.SSHError(\"Invalid pkey: %s\" % (errors))\nis plain and simple and works.\n\n\u0027message\u003d\u0027 only clutters the string.","commit_id":"52bdffd25be7aa4ade9f104cd32f352aed7c4f2a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d04dd4fe26462f1212eb306bff525249db37300c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                             \"port\": self.port,"},{"line_number":127,"context_line":"                                             \"exception_type\": type(e)}"},{"line_number":128,"context_line":"            self._client \u003d False"},{"line_number":129,"context_line":"            raise exceptions.SSHError(message\u003derror_message)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def close(self):"},{"line_number":132,"context_line":"        self._client.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_31fe4e6c","line":129,"range":{"start_line":129,"start_character":46,"end_line":129,"end_character":59},"updated":"2016-02-10 09:51:07.000000000","message":"The same is here. Old variant (except adding a new pkg name) was better.","commit_id":"52bdffd25be7aa4ade9f104cd32f352aed7c4f2a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d04dd4fe26462f1212eb306bff525249db37300c","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            if timeout and (time.time() - timeout) \u003e start_time:"},{"line_number":214,"context_line":"                args \u003d {\"cmd\": cmd, \"host\": self.host}"},{"line_number":215,"context_line":"                raise exceptions.SSHTimeout(timeout_message\u003d\"executing command\""},{"line_number":216,"context_line":"                                            \" \u0027%(cmd)s\u0027 on host %(host)s\" %"},{"line_number":217,"context_line":"                                            args)"},{"line_number":218,"context_line":"            if e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_b1fc7e3f","line":215,"range":{"start_line":215,"start_character":0,"end_line":215,"end_character":79},"updated":"2016-02-10 09:51:07.000000000","message":"Just having inherited parameter \u0027message\u0027 instead of added \u0027timeout_message\u0027 will keep things more reusable and flexible and readable. And will allow not using a kwarg at all.","commit_id":"52bdffd25be7aa4ade9f104cd32f352aed7c4f2a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d04dd4fe26462f1212eb306bff525249db37300c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                                            args)"},{"line_number":218,"context_line":"            if e:"},{"line_number":219,"context_line":"                error_message \u003d \"Socket error.\""},{"line_number":220,"context_line":"                raise exceptions.SSHError(message\u003derror_message)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        exit_status \u003d session.recv_exit_status()"},{"line_number":223,"context_line":"        if 0 !\u003d exit_status and raise_on_error:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_717926fc","line":220,"range":{"start_line":220,"start_character":0,"end_line":220,"end_character":64},"updated":"2016-02-10 09:51:07.000000000","message":"The same as L129. And a separate variable \u0027error_message\u0027 is redundant here.","commit_id":"52bdffd25be7aa4ade9f104cd32f352aed7c4f2a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d04dd4fe26462f1212eb306bff525249db37300c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            details \u003d fmt % {\"cmd\": cmd, \"status\": exit_status}"},{"line_number":226,"context_line":"            if stderr_data:"},{"line_number":227,"context_line":"                details +\u003d \" Last stderr data: \u0027%s\u0027.\" % stderr_data"},{"line_number":228,"context_line":"            raise exceptions.SSHError(message\u003ddetails)"},{"line_number":229,"context_line":"        return exit_status"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def execute(self, cmd, stdin\u003dNone, timeout\u003d3600):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_d1a7ba4d","line":228,"range":{"start_line":228,"start_character":0,"end_line":228,"end_character":54},"updated":"2016-02-10 09:51:07.000000000","message":"The same as L129","commit_id":"52bdffd25be7aa4ade9f104cd32f352aed7c4f2a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d04dd4fe26462f1212eb306bff525249db37300c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                LOG.debug(\"Ssh is still unavailable: %r\" % e)"},{"line_number":258,"context_line":"                time.sleep(interval)"},{"line_number":259,"context_line":"            if time.time() \u003e (start_time + timeout):"},{"line_number":260,"context_line":"                raise exceptions.SSHTimeout(timeout_message\u003d\"waiting for \""},{"line_number":261,"context_line":"                                            \"\u0027%s\u0027\" % self.host)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def _put_file_sftp(self, localpath, remotepath, mode\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_d1901aef","line":260,"range":{"start_line":260,"start_character":44,"end_line":260,"end_character":59},"updated":"2016-02-10 09:51:07.000000000","message":"The same as L215","commit_id":"52bdffd25be7aa4ade9f104cd32f352aed7c4f2a"}],"rally/exceptions.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"39db60f273847456ceff36f8a9f9d5a64e0e969c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    msg_fmt \u003d _(\"Unable to create Tempest config file: %(message)s\")"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class SSHTimeoutWaitingException(RallyException):"},{"line_number":244,"context_line":"    msg_fmt \u003d _(\"Timeout waiting for \u0027%(host)s\u0027\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_17c4ff8e","line":243,"updated":"2016-02-05 08:10:06.000000000","message":"I\u0027d prefer SSHTimeout name. It is more cute and shorter","commit_id":"b7d046099d5bd234546feeb3c189c11d9d285195"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0f8d0012a221fc0d88fce630f723cfb367b26611","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class SSHTimeout(RallyException):"},{"line_number":244,"context_line":"    msg_fmt \u003d _(\"%(message)s\")"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"class SSHError(RallyException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_0a553fc5","line":244,"updated":"2016-02-09 18:06:21.000000000","message":"Please add here some template for messages. Look how it is in other exceptions.","commit_id":"b745f89c41b79d4eee90ccb2cd2398f9a051fbda"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d04dd4fe26462f1212eb306bff525249db37300c","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class SSHTimeout(RallyException):"},{"line_number":244,"context_line":"    msg_fmt \u003d _(\"Timeout %(message)s\")"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"class SSHError(RallyException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_d1b6da3c","line":244,"range":{"start_line":244,"start_character":0,"end_line":244,"end_character":38},"updated":"2016-02-10 09:51:07.000000000","message":"I think \u0027Timeout\u0027 inside the msg_fmt brings a little value here. It reduces readability and adds indirection both here and in places where SSHTimeout is raised. I\u0027d rather keep it plain  _(\"%(message)s\")","commit_id":"52bdffd25be7aa4ade9f104cd32f352aed7c4f2a"}],"rally/plugins/openstack/scenarios/vm/vmtasks.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"39db60f273847456ceff36f8a9f9d5a64e0e969c","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                exceptions.SSHTimeoutWaitingException):"},{"line_number":186,"context_line":"            \"\"\""},{"line_number":187,"context_line":"            Get VM console logs using \"nova console-log\""},{"line_number":188,"context_line":"            to help in Debugging PING failure"},{"line_number":189,"context_line":"            \"\"\""},{"line_number":190,"context_line":"            console_logs \u003d self._get_server_console_output(server)"},{"line_number":191,"context_line":"            LOG.debug(\"VM console logs:\\n%s\", console_logs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_978f8f29","line":188,"updated":"2016-02-05 08:10:06.000000000","message":"\"to help in Debugging PING failure\" its redundant here","commit_id":"b7d046099d5bd234546feeb3c189c11d9d285195"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"39db60f273847456ceff36f8a9f9d5a64e0e969c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            Get VM console logs using \"nova console-log\""},{"line_number":188,"context_line":"            to help in Debugging PING failure"},{"line_number":189,"context_line":"            \"\"\""},{"line_number":190,"context_line":"            console_logs \u003d self._get_server_console_output(server)"},{"line_number":191,"context_line":"            LOG.debug(\"VM console logs:\\n%s\", console_logs)"},{"line_number":192,"context_line":"            raise"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_97bd4fb9","line":190,"updated":"2016-02-05 08:10:06.000000000","message":"How many lines it will output. Maybe better to use exact length of output to not to garbage logs","commit_id":"b7d046099d5bd234546feeb3c189c11d9d285195"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0f8d0012a221fc0d88fce630f723cfb367b26611","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                exceptions.SSHTimeout):"},{"line_number":189,"context_line":"            \"\"\""},{"line_number":190,"context_line":"            Get VM console logs using \"nova console-log\""},{"line_number":191,"context_line":"            \"\"\""},{"line_number":192,"context_line":"            console_logs \u003d self._get_server_console_output(server,"},{"line_number":193,"context_line":"                                                           length)"},{"line_number":194,"context_line":"            LOG.debug(\"VM console logs:\\n%s\", console_logs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_0ae53fa7","line":191,"updated":"2016-02-09 18:06:21.000000000","message":"Why here is docstring? Please remove its redundant here","commit_id":"b745f89c41b79d4eee90ccb2cd2398f9a051fbda"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d04dd4fe26462f1212eb306bff525249db37300c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                               use_floating_ip\u003dTrue,"},{"line_number":59,"context_line":"                               force_delete\u003dFalse,"},{"line_number":60,"context_line":"                               wait_for_ping\u003dTrue,"},{"line_number":61,"context_line":"                               length\u003dNone,"},{"line_number":62,"context_line":"                               **kwargs):"},{"line_number":63,"context_line":"        \"\"\"Boot a server, run a script that outputs JSON, delete the server."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_8e9a8313","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":43},"updated":"2016-02-10 09:51:07.000000000","message":"Please give the variable a bit more descriptive name, like \u0027max_log_length\u0027.","commit_id":"52bdffd25be7aa4ade9f104cd32f352aed7c4f2a"}]}
