)]}'
{"rally/cli/commands/task.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b75717b8475d0efe540511d6ef95f7beb393baeb","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        tasks \u003d kwargs.get(\"tasks\", []) or list(args)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        if not tasks:"},{"line_number":560,"context_line":"            print(_(\"ERROR: At least one task must be specified\"),"},{"line_number":561,"context_line":"                  file\u003dsys.stderr)"},{"line_number":562,"context_line":"            return 1"},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_3427aa13","line":560,"range":{"start_line":560,"start_character":20,"end_line":560,"end_character":66},"updated":"2016-04-25 00:30:01.000000000","message":"Why we started to print to stderr. Earlier we have just raise proper exception.\nBetter to add here some help message about the format of usage","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8008dcebbd2a07e050c11976d8381fe60ba1bb5a","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        tasks \u003d kwargs.get(\"tasks\", []) or list(args)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        if not tasks:"},{"line_number":560,"context_line":"            print(_(\"ERROR: At least one task must be specified\"),"},{"line_number":561,"context_line":"                  file\u003dsys.stderr)"},{"line_number":562,"context_line":"            return 1"},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_f259bd5c","line":560,"range":{"start_line":560,"start_character":20,"end_line":560,"end_character":66},"in_reply_to":"1a122d0e_3427aa13","updated":"2016-04-25 10:26:11.000000000","message":"* print to stderr - this is a common approach for commands, I do not know why this approach was chosen, however it also works\n\n* The format is given in L552, however this message can be extended with some explanation","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"24e560efb253bd2e3702cecce7ec949acabf884f","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        tasks \u003d kwargs.get(\"tasks\", []) or list(args)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        if not tasks:"},{"line_number":560,"context_line":"            print(_(\"ERROR: At least one task must be specified\"),"},{"line_number":561,"context_line":"                  file\u003dsys.stderr)"},{"line_number":562,"context_line":"            return 1"},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_7788fa22","line":560,"range":{"start_line":560,"start_character":20,"end_line":560,"end_character":66},"in_reply_to":"1a122d0e_51150e99","updated":"2016-04-25 12:22:16.000000000","message":"What change do you propose?","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"427d3cce88114e4f57f9f08dc3836c61ea268f65","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        tasks \u003d kwargs.get(\"tasks\", []) or list(args)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        if not tasks:"},{"line_number":560,"context_line":"            print(_(\"ERROR: At least one task must be specified\"),"},{"line_number":561,"context_line":"                  file\u003dsys.stderr)"},{"line_number":562,"context_line":"            return 1"},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_51150e99","line":560,"range":{"start_line":560,"start_character":20,"end_line":560,"end_character":66},"in_reply_to":"1a122d0e_f259bd5c","updated":"2016-04-25 12:18:37.000000000","message":"Better to write in consistent way","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b75717b8475d0efe540511d6ef95f7beb393baeb","unresolved":false,"context_lines":[{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        results \u003d []"},{"line_number":565,"context_line":"        for task_id in tasks:"},{"line_number":566,"context_line":"            if os.path.exists(os.path.expanduser(task_id)):"},{"line_number":567,"context_line":"                with open(os.path.expanduser(task_id), \"r\") as inp_js:"},{"line_number":568,"context_line":"                    task_results \u003d json.load(inp_js)"},{"line_number":569,"context_line":"                    for result in task_results:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_f45a5282","line":566,"updated":"2016-04-25 00:30:01.000000000","message":"From the help msg \"UUIDs of tasks, or JSON files with task results\"\nBut then a bit confused by:\nfor task_id in tasks:\n            if os.path.exists(os.path.expanduser(task_id))\nIn both cases this wrong arguments for expanduser. It takes as argument path to the file and there passes variable with name task_id\u003d)\n\nAlso `if os.path.exists` return True for directory. I think that this is not the proper behavior. Hence this test is absent in unit tests","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"427d3cce88114e4f57f9f08dc3836c61ea268f65","unresolved":false,"context_lines":[{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        results \u003d []"},{"line_number":565,"context_line":"        for task_id in tasks:"},{"line_number":566,"context_line":"            if os.path.exists(os.path.expanduser(task_id)):"},{"line_number":567,"context_line":"                with open(os.path.expanduser(task_id), \"r\") as inp_js:"},{"line_number":568,"context_line":"                    task_results \u003d json.load(inp_js)"},{"line_number":569,"context_line":"                    for result in task_results:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_d14f5ebc","line":566,"in_reply_to":"1a122d0e_2d47584c","updated":"2016-04-25 12:18:37.000000000","message":"\"If there is a file named like task UUID\" - I mean other thing. I have specified the path and in the code the path \"mypath/bla\" would be stored inside variable with name that doesn\u0027t show me that the path inside - task_id. Also there is a mention that we could pass \"JSON file\" but \"path to JSON file\" would be more right","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"24e560efb253bd2e3702cecce7ec949acabf884f","unresolved":false,"context_lines":[{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        results \u003d []"},{"line_number":565,"context_line":"        for task_id in tasks:"},{"line_number":566,"context_line":"            if os.path.exists(os.path.expanduser(task_id)):"},{"line_number":567,"context_line":"                with open(os.path.expanduser(task_id), \"r\") as inp_js:"},{"line_number":568,"context_line":"                    task_results \u003d json.load(inp_js)"},{"line_number":569,"context_line":"                    for result in task_results:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_979cb65e","line":566,"in_reply_to":"1a122d0e_d14f5ebc","updated":"2016-04-25 12:22:16.000000000","message":"Maybe rename s/task_id/task_id_or_path/ ?","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8008dcebbd2a07e050c11976d8381fe60ba1bb5a","unresolved":false,"context_lines":[{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        results \u003d []"},{"line_number":565,"context_line":"        for task_id in tasks:"},{"line_number":566,"context_line":"            if os.path.exists(os.path.expanduser(task_id)):"},{"line_number":567,"context_line":"                with open(os.path.expanduser(task_id), \"r\") as inp_js:"},{"line_number":568,"context_line":"                    task_results \u003d json.load(inp_js)"},{"line_number":569,"context_line":"                    for result in task_results:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_2d47584c","line":566,"in_reply_to":"1a122d0e_f45a5282","updated":"2016-04-25 10:26:11.000000000","message":"If there is a file named like task UUID - this file fill be taken instead of obtaining task from DB - this behaviour seems to be correct.\n\nos.path.exists() for directory - good catch, os.path.isfile() looks more reasonable","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b75717b8475d0efe540511d6ef95f7beb393baeb","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            if kwargs.get(\"open_it\"):"},{"line_number":604,"context_line":"                webbrowser.open_new_tab(\"file://\" + os.path.realpath(out))"},{"line_number":605,"context_line":"        else:"},{"line_number":606,"context_line":"            print(result)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    @cliutils.args(\"--tasks\", dest\u003d\"tasks\", nargs\u003d\"+\","},{"line_number":609,"context_line":"                   help\u003d\"UUIDs of tasks, or JSON files with task results\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_744f62bd","line":606,"updated":"2016-04-25 00:30:01.000000000","message":"Why I got html got after I tried first this command in the simplest way?) http://pastebin.com/n8DqerTU It frightening","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"24e560efb253bd2e3702cecce7ec949acabf884f","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            if kwargs.get(\"open_it\"):"},{"line_number":604,"context_line":"                webbrowser.open_new_tab(\"file://\" + os.path.realpath(out))"},{"line_number":605,"context_line":"        else:"},{"line_number":606,"context_line":"            print(result)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    @cliutils.args(\"--tasks\", dest\u003d\"tasks\", nargs\u003d\"+\","},{"line_number":609,"context_line":"                   help\u003d\"UUIDs of tasks, or JSON files with task results\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_d7c58e3d","line":606,"in_reply_to":"1a122d0e_37c96279","updated":"2016-04-25 12:22:16.000000000","message":"What should be done in case of missing \"--out\" ? Write to file {{task_id}}.html ?","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8008dcebbd2a07e050c11976d8381fe60ba1bb5a","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            if kwargs.get(\"open_it\"):"},{"line_number":604,"context_line":"                webbrowser.open_new_tab(\"file://\" + os.path.realpath(out))"},{"line_number":605,"context_line":"        else:"},{"line_number":606,"context_line":"            print(result)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    @cliutils.args(\"--tasks\", dest\u003d\"tasks\", nargs\u003d\"+\","},{"line_number":609,"context_line":"                   help\u003d\"UUIDs of tasks, or JSON files with task results\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_ada888dc","line":606,"in_reply_to":"1a122d0e_744f62bd","updated":"2016-04-25 10:26:11.000000000","message":"Because you did not specified \"--out\" :)\n\nYou have json from \"rally task results\" and this is normal.\n\nOf course we can change this behaviour.","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"427d3cce88114e4f57f9f08dc3836c61ea268f65","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            if kwargs.get(\"open_it\"):"},{"line_number":604,"context_line":"                webbrowser.open_new_tab(\"file://\" + os.path.realpath(out))"},{"line_number":605,"context_line":"        else:"},{"line_number":606,"context_line":"            print(result)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    @cliutils.args(\"--tasks\", dest\u003d\"tasks\", nargs\u003d\"+\","},{"line_number":609,"context_line":"                   help\u003d\"UUIDs of tasks, or JSON files with task results\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_37c96279","line":606,"in_reply_to":"1a122d0e_ada888dc","updated":"2016-04-25 12:18:37.000000000","message":"I think we should. This is totally confuse","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"87fdf5330165a6e8176c11dfb6c0c28bbb031311","unresolved":false,"context_lines":[{"line_number":583,"context_line":"                               \"result\": x[\"data\"][\"raw\"],"},{"line_number":584,"context_line":"                               \"load_duration\": x[\"data\"][\"load_duration\"],"},{"line_number":585,"context_line":"                               \"full_duration\": x[\"data\"][\"full_duration\"]},"},{"line_number":586,"context_line":"                    api.Task.get(task_id).get_results())"},{"line_number":587,"context_line":"            else:"},{"line_number":588,"context_line":"                print(_(\"ERROR: Invalid UUID or file name passed: %s\")"},{"line_number":589,"context_line":"                      % task_id, file\u003dsys.stderr)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_4953d739","line":586,"updated":"2016-05-25 07:57:08.000000000","message":"in future, as you will start work on aaS we would need to do better job here and not download all results to client side. However, at the moment it\u0027s irrelevant.","commit_id":"b7fa1422f6de7a0543f54cbbd379dafda351f263"}],"rally/task/processing/plot.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b75717b8475d0efe540511d6ef95f7beb393baeb","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                               (\"max\", charts.streaming.MaxComputation()),"},{"line_number":253,"context_line":"                               (\"avg\", charts.streaming.MeanComputation())):"},{"line_number":254,"context_line":"                for k, v in total[stat]:"},{"line_number":255,"context_line":"                    if isinstance(v, (float,) + six.integer_types):"},{"line_number":256,"context_line":"                        comp.add(v)"},{"line_number":257,"context_line":"                self._tasks[key][\"stat\"][stat] \u003d comp.result()"},{"line_number":258,"context_line":"            del self._tasks[key][\"data\"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_544506b1","line":255,"updated":"2016-04-25 00:30:01.000000000","message":"Why you added this line? Looks like you need here only to check whether we got None or not","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8008dcebbd2a07e050c11976d8381fe60ba1bb5a","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                               (\"max\", charts.streaming.MaxComputation()),"},{"line_number":253,"context_line":"                               (\"avg\", charts.streaming.MeanComputation())):"},{"line_number":254,"context_line":"                for k, v in total[stat]:"},{"line_number":255,"context_line":"                    if isinstance(v, (float,) + six.integer_types):"},{"line_number":256,"context_line":"                        comp.add(v)"},{"line_number":257,"context_line":"                self._tasks[key][\"stat\"][stat] \u003d comp.result()"},{"line_number":258,"context_line":"            del self._tasks[key][\"data\"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_cd5864fd","line":255,"in_reply_to":"1a122d0e_544506b1","updated":"2016-04-25 10:26:11.000000000","message":"1) Not `None\u0027 but `str\u0027\n2) Filtering by excluding types is potentially buggy - what if we add new type into values for some reason?\nThis is potentially possible: https://github.com/openstack/rally/blob/e811456c7bfb0a36a7b17590261dc0d5c746f29a/rally/task/processing/charts.py#L343-L344\n\nBut we know that numeric types are OK","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"}],"tests/ci/rally-gate.sh":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"66bd4f9568d6db2b2af0920763ab14c27681e9dc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    --compare-with-list resources_at_start.txt\\"},{"line_number":91,"context_line":"        | gzip \u003e rally-plot/resources_diff.txt.gz"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":". $BASE/new/rally/tests/ci/trends.sh"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"exit $retval"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a122d0e_7c491bd0","line":93,"updated":"2016-04-23 03:56:17.000000000","message":"This is really bad idea.\n\nWe are adding to **all jobs** in **all projects** random script, that runs random test. \n\nFirst of all why we need this check here? we have dsvm-cli job for such puprose. \n\nThe sedond why everybody in OpenStack needs to run this?","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b75717b8475d0efe540511d6ef95f7beb393baeb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    --compare-with-list resources_at_start.txt\\"},{"line_number":91,"context_line":"        | gzip \u003e rally-plot/resources_diff.txt.gz"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":". $BASE/new/rally/tests/ci/trends.sh"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"exit $retval"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a122d0e_54d7c6ec","line":93,"in_reply_to":"1a122d0e_7c491bd0","updated":"2016-04-25 00:30:01.000000000","message":"Agree, we have functional tests for that","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8008dcebbd2a07e050c11976d8381fe60ba1bb5a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    --compare-with-list resources_at_start.txt\\"},{"line_number":91,"context_line":"        | gzip \u003e rally-plot/resources_diff.txt.gz"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":". $BASE/new/rally/tests/ci/trends.sh"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"exit $retval"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a122d0e_4d1bb41b","line":93,"in_reply_to":"1a122d0e_7c491bd0","updated":"2016-04-25 10:26:11.000000000","message":"Will remove this","commit_id":"32850b732a984c1f556a80087bccca365de0f24a"}]}
