)]}'
{"rally/common/utils.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"1517141ac6d9667cf37ff6ef1d7eeb6693535c48","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    all_threads \u003d collections.deque()"},{"line_number":520,"context_line":"    while True:"},{"line_number":521,"context_line":"        if bool(all_threads) is False:"},{"line_number":522,"context_line":"            timeout \u003d None"},{"line_number":523,"context_line":"        else:"},{"line_number":524,"context_line":"            thread_ident, deadline \u003d all_threads[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_38446cb5","line":521,"updated":"2016-02-05 19:48:11.000000000","message":"Why not just:\n\n    if not all_threads:\n        ...\n\nSame question applies to all other changes as well.","commit_id":"2ba4b1fdf77a6688ccbf1a2c1f5e44c7654d0a87"}],"rally/task/utils.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"99d9b55a11cb5460acc1642343e5b3348fe7c365","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    ready_statuses \u003d set([s.upper() for s in ready_statuses or []])"},{"line_number":189,"context_line":"    failure_statuses \u003d set([s.upper() for s in failure_statuses or []])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    if (ready_statuses \u0026 failure_statuses):"},{"line_number":192,"context_line":"        raise ValueError("},{"line_number":193,"context_line":"            \"Can\u0027t wait for resource\u0027s %s status. Ready and Failure\""},{"line_number":194,"context_line":"            \"statuses conflict.\" % resource_repr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_9b41da65","line":191,"updated":"2016-02-05 20:24:48.000000000","message":"This is a funny way to say:\n\n    if ready_statuses or failure_statuses:\n\nIMO that\u0027s more obvious and more readable, and is probably cheaper than computing a set intersection, too.","commit_id":"30fd2aaac4950f7426b8e847cadd35b075c41407"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"c452a07ece055c7b1299bfa09d57c7edcc32aea1","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                         \"tuple\")"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    # make all statuses upper case"},{"line_number":188,"context_line":"    ready_statuses \u003d set([s.upper() for s in ready_statuses or []])"},{"line_number":189,"context_line":"    failure_statuses \u003d set([s.upper() for s in failure_statuses or []])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    if (ready_statuses or failure_statuses):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_658bf01f","line":188,"range":{"start_line":188,"start_character":28,"end_line":188,"end_character":33},"updated":"2016-02-08 09:38:08.000000000","message":"Please don\u0027t use a list comprehension to create set.\nThis should just be set(s.upper() for s in ready_statuses or []) or {s.upper() for s in ready_statuses or []}","commit_id":"22dae10e6d16c7127eb6ea717be5a9989c3c5e97"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"c452a07ece055c7b1299bfa09d57c7edcc32aea1","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    # make all statuses upper case"},{"line_number":188,"context_line":"    ready_statuses \u003d set([s.upper() for s in ready_statuses or []])"},{"line_number":189,"context_line":"    failure_statuses \u003d set([s.upper() for s in failure_statuses or []])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    if (ready_statuses or failure_statuses):"},{"line_number":192,"context_line":"        raise ValueError("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_057b1c29","line":189,"range":{"start_line":189,"start_character":29,"end_line":189,"end_character":30},"updated":"2016-02-08 09:38:08.000000000","message":"ditto","commit_id":"22dae10e6d16c7127eb6ea717be5a9989c3c5e97"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2c031f4baa031287ca2432a3179195485797598c","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    ready_statuses \u003d set([s.upper() for s in ready_statuses or []])"},{"line_number":189,"context_line":"    failure_statuses \u003d set([s.upper() for s in failure_statuses or []])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    if (ready_statuses or failure_statuses):"},{"line_number":192,"context_line":"        raise ValueError("},{"line_number":193,"context_line":"            \"Can\u0027t wait for resource\u0027s %s status. Ready and Failure\""},{"line_number":194,"context_line":"            \"statuses conflict.\" % resource_repr)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_99053012","line":191,"updated":"2016-02-08 12:30:08.000000000","message":"here should be \u0026 otherwise this is not intersection of sets just first not None set","commit_id":"22dae10e6d16c7127eb6ea717be5a9989c3c5e97"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"515265995d8bebfa226631443520d9415508a35f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    ready_statuses \u003d set([s.upper() for s in ready_statuses or []])"},{"line_number":189,"context_line":"    failure_statuses \u003d set([s.upper() for s in failure_statuses or []])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    if (ready_statuses or failure_statuses):"},{"line_number":192,"context_line":"        raise ValueError("},{"line_number":193,"context_line":"            \"Can\u0027t wait for resource\u0027s %s status. Ready and Failure\""},{"line_number":194,"context_line":"            \"statuses conflict.\" % resource_repr)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_b91cac6a","line":191,"in_reply_to":"5a5ae5dd_99053012","updated":"2016-02-08 12:30:56.000000000","message":"http://ideone.com/7tCVNp","commit_id":"22dae10e6d16c7127eb6ea717be5a9989c3c5e97"}]}
