)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2e57392b9c07ccf1fafb9446acc4c9c78ee1e40e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add V3 support for Keystone scenarios"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new KeystoneV3Basic scenario is available which has the same API as"},{"line_number":10,"context_line":"KeystoneBasic but translates the calls into a V3 client."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The existing configuration has been kept as similar as possible, with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"dae33548_d30821dc","line":9,"updated":"2016-02-16 12:44:19.000000000","message":"This class name is outdated - there is no KeystoneV3Basic within this patch set","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"680b9a5e80b45317583035ad813558a9317661ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add V3 support for Keystone scenarios"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new KeystoneV3Basic scenario is available which has the same API as"},{"line_number":10,"context_line":"KeystoneBasic but translates the calls into a V3 client."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The existing configuration has been kept as similar as possible, with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"dae33548_7bde2840","line":9,"in_reply_to":"dae33548_d30821dc","updated":"2016-02-17 01:44:00.000000000","message":"Done","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a1aca727be308cd8499f74b2054eb6190a570cc6","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The client version can be specified with the api_versions context"},{"line_number":19,"context_line":"config in tasks."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I01e71ea07d3523ed849fed3d55fb6890e98542d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"bae84128_86c33c8a","line":20,"updated":"2016-02-24 23:38:56.000000000","message":"I suppose, this change can address https://bugs.launchpad.net/rally/+bug/1469897","commit_id":"029df32b8f970a2d480f8aa7ec9f06420fb1a0e1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"810b6bc52bb1aecf3a13ef95545eda34186e2336","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The client version can be specified with the api_versions context"},{"line_number":19,"context_line":"config in tasks."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I01e71ea07d3523ed849fed3d55fb6890e98542d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"bae84128_0649ec8e","line":20,"in_reply_to":"bae84128_86c33c8a","updated":"2016-02-24 23:54:50.000000000","message":"also, see https://bugs.launchpad.net/rally/+bug/1466801","commit_id":"029df32b8f970a2d480f8aa7ec9f06420fb1a0e1"}],"rally-jobs/rally-keystone-api-v3.yaml":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2e57392b9c07ccf1fafb9446acc4c9c78ee1e40e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        failure_rate:"},{"line_number":61,"context_line":"          max: 0"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  KeystoneBasic.create_and_list_tenants:"},{"line_number":64,"context_line":"    -"},{"line_number":65,"context_line":"      args: {}"},{"line_number":66,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dae33548_b3bf5dfa","line":63,"updated":"2016-02-16 12:44:19.000000000","message":"Why not \"KeystoneBasic.create_and_list_projects\" ?","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c1219e5b29c61e414cb18b70316f32d72ec03ff6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        failure_rate:"},{"line_number":61,"context_line":"          max: 0"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  KeystoneBasic.create_and_list_tenants:"},{"line_number":64,"context_line":"    -"},{"line_number":65,"context_line":"      args: {}"},{"line_number":66,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dae33548_a16063a6","line":63,"in_reply_to":"dae33548_1eea4edb","updated":"2016-02-17 12:54:27.000000000","message":"Thank you for great work, this patch is cool.\n\nFrom my point of view, we are close to get this patch complete.\n\nHowever I see some issues:\n\n * this file (rally-keystone-api-v3.yaml) looks not required at all, since we are using on gates v3 by default, so you can apply changes to rally.yaml.\n\n * Usage of *_project api looks important (at least because we have this api added). I\u0027m planning to investigate how we can implement this","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"ab23ac9c499ac70de4463bacfdc4536271e3546d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        failure_rate:"},{"line_number":61,"context_line":"          max: 0"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  KeystoneBasic.create_and_list_tenants:"},{"line_number":64,"context_line":"    -"},{"line_number":65,"context_line":"      args: {}"},{"line_number":66,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dae33548_8151df38","line":63,"in_reply_to":"dae33548_a16063a6","updated":"2016-02-17 13:04:45.000000000","message":"Thanks for the compliment, I appreciate it.\n\nI thought the gates used v2.0? At least that\u0027s what I thought I saw in the logs. Please note that if you don\u0027t specify api_versions the client version will be chosen based on the URL in the deployment definition. If there\u0027s no URL keystonelib usually picks v3.\n\nThe _project API won\u0027t be hard to add in the basic.py file as we can just define new methods and call the old ones. I am guessing that the way I was doing to try and shortcut everything didn\u0027t cause the configuration decorator to register the method somewhere.","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"680b9a5e80b45317583035ad813558a9317661ea","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        failure_rate:"},{"line_number":61,"context_line":"          max: 0"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  KeystoneBasic.create_and_list_tenants:"},{"line_number":64,"context_line":"    -"},{"line_number":65,"context_line":"      args: {}"},{"line_number":66,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dae33548_bbcf107e","line":63,"in_reply_to":"dae33548_b3bf5dfa","updated":"2016-02-17 01:44:00.000000000","message":"It doesn\u0027t actually work for some reason, the tests won\u0027t pick up the extra name and fail. I suspect the decorator isn\u0027t copied with the assignment.  I\u0027ve removed the extra definitions for now.","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"ed29b7987ea76b91c55f78b1af4c50a0d144d33d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        failure_rate:"},{"line_number":61,"context_line":"          max: 0"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  KeystoneBasic.create_and_list_tenants:"},{"line_number":64,"context_line":"    -"},{"line_number":65,"context_line":"      args: {}"},{"line_number":66,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dae33548_eeb25d93","line":63,"in_reply_to":"dae33548_bbcf107e","updated":"2016-02-17 11:15:22.000000000","message":"I think we have to do something with that. It looks not good to implement \"*_project\" api for v3 but using \"*_tenant\" instead","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"b0fa216d2c6f2e1d5ab7f69686dc3e0088085983","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        failure_rate:"},{"line_number":61,"context_line":"          max: 0"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  KeystoneBasic.create_and_list_tenants:"},{"line_number":64,"context_line":"    -"},{"line_number":65,"context_line":"      args: {}"},{"line_number":66,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dae33548_1eea4edb","line":63,"in_reply_to":"dae33548_eeb25d93","updated":"2016-02-17 12:38:46.000000000","message":"This is a bit of a rabbit hole, because you\u0027re still going to have the various task configs using tenant everywhere. It might be better to add \u0027project\u0027 properly in a second branch otherwise this one is going to get even bigger.","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"}],"rally/osclients.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"11b2ddc5a0fdd6c5651f6c09fb09243de9000d87","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        ]"},{"line_number":224,"context_line":"        # NOTE(bigjools): If forcing a v2.0 URL then you cannot specify"},{"line_number":225,"context_line":"        # domain-related info, or the service discovery will fail."},{"line_number":226,"context_line":"        v2_versions \u003d (2, \"v2\", \"2\", \"v2.0\")"},{"line_number":227,"context_line":"        if \"v2.0\" not in args[\"auth_url\"] and version not in v2_versions:"},{"line_number":228,"context_line":"            auth_arg_list.extend("},{"line_number":229,"context_line":"                [\"user_domain_name\", \"domain_name\", \"project_domain_name\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_d0fcd6b9","line":226,"updated":"2016-02-08 14:18:54.000000000","message":"Nit: make this a class variable instead of defining it on every call. (The same could be done with auth_arg_list, too.)","commit_id":"49fa98ffb3cdfe7f772979e561351fc7758a7064"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"36b54936363389b42c067d4ed29df005a3c8572e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        ]"},{"line_number":224,"context_line":"        # NOTE(bigjools): If forcing a v2.0 URL then you cannot specify"},{"line_number":225,"context_line":"        # domain-related info, or the service discovery will fail."},{"line_number":226,"context_line":"        v2_versions \u003d (2, \"v2\", \"2\", \"v2.0\")"},{"line_number":227,"context_line":"        if \"v2.0\" not in args[\"auth_url\"] and version not in v2_versions:"},{"line_number":228,"context_line":"            auth_arg_list.extend("},{"line_number":229,"context_line":"                [\"user_domain_name\", \"domain_name\", \"project_domain_name\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_1d99fe1f","line":226,"in_reply_to":"5a5ae5dd_d0fcd6b9","updated":"2016-02-09 03:09:16.000000000","message":"Good point, done. auth_arg_list needs to stay though as it is changed depending on being v2 or not.","commit_id":"49fa98ffb3cdfe7f772979e561351fc7758a7064"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2e57392b9c07ccf1fafb9446acc4c9c78ee1e40e","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        args[\"session\"] \u003d self._get_session(auth\u003dauth)"},{"line_number":235,"context_line":"        return client.Client(version\u003dversion, **args)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _override_url(self, version):"},{"line_number":238,"context_line":"        \"\"\"If version is specified, remove any version from the auth_url."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        The keystone Client code requires that auth_url be the root url"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_ed0f4786","line":237,"updated":"2016-02-16 12:44:19.000000000","message":"I can not find actual usage of \"version\" within this method","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"680b9a5e80b45317583035ad813558a9317661ea","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        args[\"session\"] \u003d self._get_session(auth\u003dauth)"},{"line_number":235,"context_line":"        return client.Client(version\u003dversion, **args)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _override_url(self, version):"},{"line_number":238,"context_line":"        \"\"\"If version is specified, remove any version from the auth_url."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        The keystone Client code requires that auth_url be the root url"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_dba9347d","line":237,"in_reply_to":"dae33548_ed0f4786","updated":"2016-02-17 01:44:00.000000000","message":"Done","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2e57392b9c07ccf1fafb9446acc4c9c78ee1e40e","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        The keystone Client code requires that auth_url be the root url"},{"line_number":241,"context_line":"        if a version override is used."},{"line_number":242,"context_line":"        \"\"\""},{"line_number":243,"context_line":"        url \u003d parse.urlparse(self.credential.auth_url)"},{"line_number":244,"context_line":"        # NOTE(bigjools): This assumes that non-versioned URLs have no"},{"line_number":245,"context_line":"        # path component at all."}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_3c783fc4","line":242,"updated":"2016-02-16 12:44:19.000000000","message":":param version: ...","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"680b9a5e80b45317583035ad813558a9317661ea","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        The keystone Client code requires that auth_url be the root url"},{"line_number":241,"context_line":"        if a version override is used."},{"line_number":242,"context_line":"        \"\"\""},{"line_number":243,"context_line":"        url \u003d parse.urlparse(self.credential.auth_url)"},{"line_number":244,"context_line":"        # NOTE(bigjools): This assumes that non-versioned URLs have no"},{"line_number":245,"context_line":"        # path component at all."}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_3bde6011","line":242,"in_reply_to":"dae33548_3c783fc4","updated":"2016-02-17 01:44:00.000000000","message":"I\u0027ve removed version.","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2e57392b9c07ccf1fafb9446acc4c9c78ee1e40e","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        If this object was constructed with a version in the api_info"},{"line_number":257,"context_line":"        then that will be used unless the version parameter is passed."},{"line_number":258,"context_line":"        \"\"\""},{"line_number":259,"context_line":"        scenario_version \u003d self.api_info.get("},{"line_number":260,"context_line":"            self.get_name(), {}).get(\"version\")"},{"line_number":261,"context_line":"        if scenario_version is not None:"},{"line_number":262,"context_line":"            version \u003d scenario_version"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_7b35b1d8","line":259,"updated":"2016-02-16 12:44:19.000000000","message":"Let\u0027s make this a bit simple:\n\nversion \u003d self.api_info.get(\n    self.get_name(),\n    {}).get(\"version\", version)","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"680b9a5e80b45317583035ad813558a9317661ea","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        If this object was constructed with a version in the api_info"},{"line_number":257,"context_line":"        then that will be used unless the version parameter is passed."},{"line_number":258,"context_line":"        \"\"\""},{"line_number":259,"context_line":"        scenario_version \u003d self.api_info.get("},{"line_number":260,"context_line":"            self.get_name(), {}).get(\"version\")"},{"line_number":261,"context_line":"        if scenario_version is not None:"},{"line_number":262,"context_line":"            version \u003d scenario_version"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_369677f0","line":259,"in_reply_to":"dae33548_7b35b1d8","updated":"2016-02-17 01:44:00.000000000","message":"Well I deliberately did it the way I did as I think this style obfuscates what\u0027s going on a little. But OK, I\u0027ll change it.","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"952bf43ff72e541a99581fbdc7eb2b403fcfecdd","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        return super(OSClient, cls).get(name, namespace)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"@configure(\"keystone\", supported_versions\u003d(2, \"v2\", \"2\", \"v2.0\", 3, \"v3\", \"3\"))"},{"line_number":212,"context_line":"class Keystone(OSClient):"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    v2_versions \u003d (2, \"v2\", \"2\", \"v2.0\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_5c805e8b","line":211,"range":{"start_line":211,"start_character":42,"end_line":211,"end_character":78},"updated":"2016-02-17 13:35:23.000000000","message":"There is no need to support such number of formats. It would be more user-friendly if all clients listed in this module support equal format, so let\u0027s support just 2 and 3","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"58854337181a37f3754707820579fefab754d654","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        return super(OSClient, cls).get(name, namespace)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"@configure(\"keystone\", supported_versions\u003d(2, \"v2\", \"2\", \"v2.0\", 3, \"v3\", \"3\"))"},{"line_number":212,"context_line":"class Keystone(OSClient):"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    v2_versions \u003d (2, \"v2\", \"2\", \"v2.0\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_7738ddef","line":211,"range":{"start_line":211,"start_character":42,"end_line":211,"end_character":78},"in_reply_to":"dae33548_5c805e8b","updated":"2016-02-17 13:45:44.000000000","message":"I was duplicating all the versions that the keystoneclient itself supports, but I can go to 2 and 3.","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"952bf43ff72e541a99581fbdc7eb2b403fcfecdd","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        # Use the version in the api_info if provided, otherwise fall"},{"line_number":260,"context_line":"        # back to the passed version (which may be None, in which case"},{"line_number":261,"context_line":"        # keystoneclient chooses)."},{"line_number":262,"context_line":"        version \u003d self.api_info.get("},{"line_number":263,"context_line":"            self.get_name(),"},{"line_number":264,"context_line":"            {}).get(\"version\", version)"},{"line_number":265,"context_line":"        new_kw \u003d {"},{"line_number":266,"context_line":"            \"timeout\": CONF.openstack_client_http_timeout,"},{"line_number":267,"context_line":"            \"insecure\": self.credential.insecure,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_d7a3a9fe","line":264,"range":{"start_line":262,"start_character":8,"end_line":264,"end_character":39},"updated":"2016-02-17 13:35:23.000000000","message":"it duplicates self.choose_version method. Please, look at other clients implementation.\nAlso, in case of keystoneclient, I found that choose_version should be changed a bit( https://review.openstack.org/#/c/235360/9/rally/osclients.py )","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"14dc3d8a458cee10bb07dcabd3ea0606953dad22","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        # Use the version in the api_info if provided, otherwise fall"},{"line_number":260,"context_line":"        # back to the passed version (which may be None, in which case"},{"line_number":261,"context_line":"        # keystoneclient chooses)."},{"line_number":262,"context_line":"        version \u003d self.api_info.get("},{"line_number":263,"context_line":"            self.get_name(),"},{"line_number":264,"context_line":"            {}).get(\"version\", version)"},{"line_number":265,"context_line":"        new_kw \u003d {"},{"line_number":266,"context_line":"            \"timeout\": CONF.openstack_client_http_timeout,"},{"line_number":267,"context_line":"            \"insecure\": self.credential.insecure,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_726aabef","line":264,"range":{"start_line":262,"start_character":8,"end_line":264,"end_character":39},"in_reply_to":"dae33548_3219437a","updated":"2016-02-17 13:57:33.000000000","message":"\u003eThat was always returning a value which I don\u0027t want - I specifically want it left at None if not specified anywhere, which leaves keystoneclient free to choose based on the deployment URL.\n\nchoose_version will return None if there is no default version. Currently, it returns a string \"None\" and it should be fixed(see a change from link above)\n\n\u003eAlso choose_version is using str() which is going to blow up if it gets an encoded string.\n\nWe have a validation of input data, so we should not have a problem with encoding stuff.","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"10c7e28d5a6fa7481c1e2e3c655b72f19d31c5b6","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        # Use the version in the api_info if provided, otherwise fall"},{"line_number":260,"context_line":"        # back to the passed version (which may be None, in which case"},{"line_number":261,"context_line":"        # keystoneclient chooses)."},{"line_number":262,"context_line":"        version \u003d self.api_info.get("},{"line_number":263,"context_line":"            self.get_name(),"},{"line_number":264,"context_line":"            {}).get(\"version\", version)"},{"line_number":265,"context_line":"        new_kw \u003d {"},{"line_number":266,"context_line":"            \"timeout\": CONF.openstack_client_http_timeout,"},{"line_number":267,"context_line":"            \"insecure\": self.credential.insecure,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_8e2a888e","line":264,"range":{"start_line":262,"start_character":8,"end_line":264,"end_character":39},"in_reply_to":"dae33548_726aabef","updated":"2016-02-17 23:57:05.000000000","message":"choose_version will still override with the default_version (this is what I saw happening in my testing). I don\u0027t want that behaviour here.  I see the fix, I can throw that in as a drive-by if you want?","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7333f17b5648fcc014195da095b106699989f9e9","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        # Use the version in the api_info if provided, otherwise fall"},{"line_number":260,"context_line":"        # back to the passed version (which may be None, in which case"},{"line_number":261,"context_line":"        # keystoneclient chooses)."},{"line_number":262,"context_line":"        version \u003d self.api_info.get("},{"line_number":263,"context_line":"            self.get_name(),"},{"line_number":264,"context_line":"            {}).get(\"version\", version)"},{"line_number":265,"context_line":"        new_kw \u003d {"},{"line_number":266,"context_line":"            \"timeout\": CONF.openstack_client_http_timeout,"},{"line_number":267,"context_line":"            \"insecure\": self.credential.insecure,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_63bd83d7","line":264,"range":{"start_line":262,"start_character":8,"end_line":264,"end_character":39},"in_reply_to":"dae33548_8e2a888e","updated":"2016-02-18 11:58:41.000000000","message":"If there is no default version, it will return just None.","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"58854337181a37f3754707820579fefab754d654","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        # Use the version in the api_info if provided, otherwise fall"},{"line_number":260,"context_line":"        # back to the passed version (which may be None, in which case"},{"line_number":261,"context_line":"        # keystoneclient chooses)."},{"line_number":262,"context_line":"        version \u003d self.api_info.get("},{"line_number":263,"context_line":"            self.get_name(),"},{"line_number":264,"context_line":"            {}).get(\"version\", version)"},{"line_number":265,"context_line":"        new_kw \u003d {"},{"line_number":266,"context_line":"            \"timeout\": CONF.openstack_client_http_timeout,"},{"line_number":267,"context_line":"            \"insecure\": self.credential.insecure,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_3219437a","line":264,"range":{"start_line":262,"start_character":8,"end_line":264,"end_character":39},"in_reply_to":"dae33548_d7a3a9fe","updated":"2016-02-17 13:45:44.000000000","message":"Actually it doesn\u0027t. That was always returning a value which I don\u0027t want - I specifically want it left at None if not specified anywhere, which leaves keystoneclient free to choose based on the deployment URL.\n\nAlso choose_version is using str() which is going to blow up if it gets an encoded string.","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"22de2b2d314a3e10342a27e4e113444a87d5ab52","unresolved":false,"context_lines":[{"line_number":211,"context_line":"@configure(\"keystone\", supported_versions\u003d(\"2\", \"3\"))"},{"line_number":212,"context_line":"class Keystone(OSClient):"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    v2_versions \u003d (2, \"v2\", \"2\", \"v2.0\")"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def keystone(self, *args, **kwargs):"},{"line_number":217,"context_line":"        raise exceptions.RallyException(_(\"Method \u0027keystone\u0027 is restricted \""}],"source_content_type":"text/x-python","patch_set":10,"id":"dae33548_340bb3d7","line":214,"range":{"start_line":214,"start_character":4,"end_line":214,"end_character":40},"updated":"2016-02-18 12:00:02.000000000","message":"we don\u0027t need to support all this types:)","commit_id":"82900090f3e1a3188d8d44083d1633292213bd75"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"22de2b2d314a3e10342a27e4e113444a87d5ab52","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"\"\"Return a keystone client."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        :param version: Keystone API version, can be one of:"},{"line_number":254,"context_line":"            (2, \"v2\", \"2\", \"v2.0\", 3, \"v3\", \"3\")"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        If this object was constructed with a version in the api_info"},{"line_number":257,"context_line":"        then that will be used unless the version parameter is passed."}],"source_content_type":"text/x-python","patch_set":10,"id":"dae33548_7411bb03","line":254,"range":{"start_line":254,"start_character":11,"end_line":254,"end_character":48},"updated":"2016-02-18 12:00:02.000000000","message":"same here","commit_id":"82900090f3e1a3188d8d44083d1633292213bd75"}],"rally/plugins/openstack/scenarios/keystone/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8cea30476bc7cfe4a38954b0593cdc9ee3aa7351","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    @atomic.action_timer(\"keystone.create_user\")"},{"line_number":287,"context_line":"    def _user_create(self, email\u003dNone, **kwargs):"},{"line_number":288,"context_line":"        \"\"\"Creates keystone user with random name."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        :param kwargs: Other optional parameters to create users like"},{"line_number":291,"context_line":"                        \"tenant_id\", \"enabled\"."},{"line_number":292,"context_line":"        :returns: keystone user instance"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_281d350f","line":289,"updated":"2016-02-11 15:57:11.000000000","message":":param email: ...","commit_id":"fa6130c01d199c44b7f6e9833b2bc428a9885ac8"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"b25799c194ffba5769cf465866fa66c6eefb66d9","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    @atomic.action_timer(\"keystone.create_user\")"},{"line_number":287,"context_line":"    def _user_create(self, email\u003dNone, **kwargs):"},{"line_number":288,"context_line":"        \"\"\"Creates keystone user with random name."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        :param kwargs: Other optional parameters to create users like"},{"line_number":291,"context_line":"                        \"tenant_id\", \"enabled\"."},{"line_number":292,"context_line":"        :returns: keystone user instance"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_8cb9bd7b","line":289,"in_reply_to":"3a57f1b5_281d350f","updated":"2016-02-11 23:37:54.000000000","message":"Done","commit_id":"fa6130c01d199c44b7f6e9833b2bc428a9885ac8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8cea30476bc7cfe4a38954b0593cdc9ee3aa7351","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        for i in range(users_per_tenant):"},{"line_number":321,"context_line":"            name \u003d self.generate_random_name()"},{"line_number":322,"context_line":"            password \u003d name"},{"line_number":323,"context_line":"            email \u003d name + \"@rally.me\""},{"line_number":324,"context_line":"            self.keystone_admin.users.create("},{"line_number":325,"context_line":"                name\u003dname, password\u003dpassword, email\u003demail,"},{"line_number":326,"context_line":"                default_project\u003dtenant.id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_a8be05d2","line":323,"updated":"2016-02-11 15:57:11.000000000","message":"@rally.example.org looks better because @rally.me could be a real domain","commit_id":"fa6130c01d199c44b7f6e9833b2bc428a9885ac8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"64e23d216bb2d0688a960bfb47a7d4781a3154cf","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        for i in range(users_per_tenant):"},{"line_number":321,"context_line":"            name \u003d self.generate_random_name()"},{"line_number":322,"context_line":"            password \u003d name"},{"line_number":323,"context_line":"            email \u003d name + \"@rally.me\""},{"line_number":324,"context_line":"            self.keystone_admin.users.create("},{"line_number":325,"context_line":"                name\u003dname, password\u003dpassword, email\u003demail,"},{"line_number":326,"context_line":"                default_project\u003dtenant.id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_b80ce5ec","line":323,"in_reply_to":"3a57f1b5_0ca62d53","updated":"2016-02-12 08:14:20.000000000","message":"This does not look critical at all, so let\u0027s keep this unchanged (however the change should not affect anything as well)","commit_id":"fa6130c01d199c44b7f6e9833b2bc428a9885ac8"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"b25799c194ffba5769cf465866fa66c6eefb66d9","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        for i in range(users_per_tenant):"},{"line_number":321,"context_line":"            name \u003d self.generate_random_name()"},{"line_number":322,"context_line":"            password \u003d name"},{"line_number":323,"context_line":"            email \u003d name + \"@rally.me\""},{"line_number":324,"context_line":"            self.keystone_admin.users.create("},{"line_number":325,"context_line":"                name\u003dname, password\u003dpassword, email\u003demail,"},{"line_number":326,"context_line":"                default_project\u003dtenant.id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_0ca62d53","line":323,"in_reply_to":"3a57f1b5_a8be05d2","updated":"2016-02-11 23:37:54.000000000","message":"I kept it the same as the one in the V2 scenario. If we change one we should change both, but I was wary of breaking anything that might depend on this. What do you think?","commit_id":"fa6130c01d199c44b7f6e9833b2bc428a9885ac8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2e57392b9c07ccf1fafb9446acc4c9c78ee1e40e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # Delegate access of non-generic calls to the right client."},{"line_number":49,"context_line":"        # NOTE(bigjools): If you get recursion depth errors, it means"},{"line_number":50,"context_line":"        # you tried to access a non-existent attribute of this class, or"},{"line_number":51,"context_line":"        # the attribute raised an exception itself, so check your code."},{"line_number":52,"context_line":"        return getattr("},{"line_number":53,"context_line":"            self, \"_{version}{name}\".format("},{"line_number":54,"context_line":"                version\u003dself.version, name\u003dname))"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_dcb313e8","line":51,"updated":"2016-02-16 12:44:19.000000000","message":"Extra \"hasattr()\" check should prevent recursions","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"680b9a5e80b45317583035ad813558a9317661ea","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # Delegate access of non-generic calls to the right client."},{"line_number":49,"context_line":"        # NOTE(bigjools): If you get recursion depth errors, it means"},{"line_number":50,"context_line":"        # you tried to access a non-existent attribute of this class, or"},{"line_number":51,"context_line":"        # the attribute raised an exception itself, so check your code."},{"line_number":52,"context_line":"        return getattr("},{"line_number":53,"context_line":"            self, \"_{version}{name}\".format("},{"line_number":54,"context_line":"                version\u003dself.version, name\u003dname))"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_31a201af","line":51,"in_reply_to":"dae33548_dcb313e8","updated":"2016-02-17 01:44:00.000000000","message":"Good point, I normally eschew hasattr as it swallows exceptions but it works well here.","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2e57392b9c07ccf1fafb9446acc4c9c78ee1e40e","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        \"\"\""},{"line_number":262,"context_line":"        # NOTE(bigjools): I\u0027m not sure what tasks depend on this check"},{"line_number":263,"context_line":"        # so leaving it in place even though it should delegate."},{"line_number":264,"context_line":"        if self.keystone_admin.version in [\"v3\"]:"},{"line_number":265,"context_line":"            self.keystone_admin.users.update(user_id, password\u003dpassword)"},{"line_number":266,"context_line":"        else:"},{"line_number":267,"context_line":"            self.keystone_admin.users.update_password(user_id, password)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_70a4aba5","line":264,"updated":"2016-02-16 12:44:19.000000000","message":"I think this condition must be removed.\n\nThis patch would not make a sense if it could be possible to have this method called having v3 client","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"680b9a5e80b45317583035ad813558a9317661ea","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        \"\"\""},{"line_number":262,"context_line":"        # NOTE(bigjools): I\u0027m not sure what tasks depend on this check"},{"line_number":263,"context_line":"        # so leaving it in place even though it should delegate."},{"line_number":264,"context_line":"        if self.keystone_admin.version in [\"v3\"]:"},{"line_number":265,"context_line":"            self.keystone_admin.users.update(user_id, password\u003dpassword)"},{"line_number":266,"context_line":"        else:"},{"line_number":267,"context_line":"            self.keystone_admin.users.update_password(user_id, password)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_519d0558","line":264,"in_reply_to":"dae33548_70a4aba5","updated":"2016-02-17 01:44:00.000000000","message":"You\u0027re right. I was possible at one point when I was refactoring but not any more.","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"952bf43ff72e541a99581fbdc7eb2b403fcfecdd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.keystone_admin \u003d self.admin_clients(\"keystone\")"},{"line_number":40,"context_line":"        self.keystone \u003d self.clients(\"keystone\")"},{"line_number":41,"context_line":"        version \u003d self.keystone_admin.version"},{"line_number":42,"context_line":"        if version not in (\"v2.0\", \"v3\"):"},{"line_number":43,"context_line":"            raise NotImplementedError("},{"line_number":44,"context_line":"                \"Keystone API version %s is not implemented\" % version)"},{"line_number":45,"context_line":"        self.version \u003d version.replace(\"v2.0\", \"v2\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_37c4955d","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":41},"updated":"2016-02-17 13:35:23.000000000","message":"does it possible such cases?","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"10c7e28d5a6fa7481c1e2e3c655b72f19d31c5b6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.keystone_admin \u003d self.admin_clients(\"keystone\")"},{"line_number":40,"context_line":"        self.keystone \u003d self.clients(\"keystone\")"},{"line_number":41,"context_line":"        version \u003d self.keystone_admin.version"},{"line_number":42,"context_line":"        if version not in (\"v2.0\", \"v3\"):"},{"line_number":43,"context_line":"            raise NotImplementedError("},{"line_number":44,"context_line":"                \"Keystone API version %s is not implemented\" % version)"},{"line_number":45,"context_line":"        self.version \u003d version.replace(\"v2.0\", \"v2\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_e9834e54","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":41},"in_reply_to":"dae33548_3202e30b","updated":"2016-02-17 23:57:05.000000000","message":"No, that\u0027s exactly what the client object returns in each API case.","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"58854337181a37f3754707820579fefab754d654","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.keystone_admin \u003d self.admin_clients(\"keystone\")"},{"line_number":40,"context_line":"        self.keystone \u003d self.clients(\"keystone\")"},{"line_number":41,"context_line":"        version \u003d self.keystone_admin.version"},{"line_number":42,"context_line":"        if version not in (\"v2.0\", \"v3\"):"},{"line_number":43,"context_line":"            raise NotImplementedError("},{"line_number":44,"context_line":"                \"Keystone API version %s is not implemented\" % version)"},{"line_number":45,"context_line":"        self.version \u003d version.replace(\"v2.0\", \"v2\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_929dafbe","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":41},"in_reply_to":"dae33548_37c4955d","updated":"2016-02-17 13:45:44.000000000","message":"I\u0027m sorry I don\u0027t understand your question.  v2.0 and v3 are what the keystoneclient.version returns.","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"14dc3d8a458cee10bb07dcabd3ea0606953dad22","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.keystone_admin \u003d self.admin_clients(\"keystone\")"},{"line_number":40,"context_line":"        self.keystone \u003d self.clients(\"keystone\")"},{"line_number":41,"context_line":"        version \u003d self.keystone_admin.version"},{"line_number":42,"context_line":"        if version not in (\"v2.0\", \"v3\"):"},{"line_number":43,"context_line":"            raise NotImplementedError("},{"line_number":44,"context_line":"                \"Keystone API version %s is not implemented\" % version)"},{"line_number":45,"context_line":"        self.version \u003d version.replace(\"v2.0\", \"v2\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_3202e30b","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":41},"in_reply_to":"dae33548_929dafbe","updated":"2016-02-17 13:57:33.000000000","message":"rephrased: Does it possible that keystoneclient.version can be different from \"v2.0\" and \"v3\"?","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"952bf43ff72e541a99581fbdc7eb2b403fcfecdd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \"Keystone API version %s is not implemented\" % version)"},{"line_number":45,"context_line":"        self.version \u003d version.replace(\"v2.0\", \"v2\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __getattr__(self, name):"},{"line_number":48,"context_line":"        # Delegate access of non-generic calls to the right client."},{"line_number":49,"context_line":"        attr \u003d \"_{version}{name}\".format(version\u003dself.version, name\u003dname)"},{"line_number":50,"context_line":"        if not hasattr(self, attr):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_97064184","line":47,"updated":"2016-02-17 13:35:23.000000000","message":"It duplicates the efford of keystone wrapper - provide one interface for different versions of APIs. Please look here - https://github.com/openstack/rally/blob/master/rally/plugins/openstack/wrappers/keystone.py#L228-L237","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"10c7e28d5a6fa7481c1e2e3c655b72f19d31c5b6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \"Keystone API version %s is not implemented\" % version)"},{"line_number":45,"context_line":"        self.version \u003d version.replace(\"v2.0\", \"v2\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __getattr__(self, name):"},{"line_number":48,"context_line":"        # Delegate access of non-generic calls to the right client."},{"line_number":49,"context_line":"        attr \u003d \"_{version}{name}\".format(version\u003dself.version, name\u003dname)"},{"line_number":50,"context_line":"        if not hasattr(self, attr):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_2981b6c3","line":47,"in_reply_to":"dae33548_0d7fbe15","updated":"2016-02-17 23:57:05.000000000","message":"OK fair enough, my lack of overall Rally knowledge is a problem here as I didn\u0027t think about those other objects.  Question for you though - when you\u0027re setting context do you really care about which API version it\u0027s using? I suspect in most if not all cases you just want the dependency set up and you don\u0027t care how. What you care about is the scenario\u0027s details.\n\nIn my testing I can make it switch versions that things like the User context uses by using a different deployment URL, despite what api_versions says on the scenario task configs.\n\nAlso one more thing, I think it\u0027s probably a bit ambitious to try and make all the APIs look the same via a wrapper. You can get away with it in some instances, but as you have found there are some underlying problems like the different Role etc objects which needed the namedtuple hack. There are also other instances where the API may clash and you need to choose one or the other because of different arg requirements.\n\nI actually think it\u0027s a better solution to make each context object handle its own API versioning requirements. We can refactor stuff between scenario/context/etc as required as and when it comes up. That way, there\u0027s no wrangling of fake objects needed and the code becomes much simpler, especially in the case where the same op in different APIs has different arg requirements.  It\u0027s not like new APIs get added all the time either.\n\nI would like to see the spec you have if you can link it please?","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7333f17b5648fcc014195da095b106699989f9e9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \"Keystone API version %s is not implemented\" % version)"},{"line_number":45,"context_line":"        self.version \u003d version.replace(\"v2.0\", \"v2\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __getattr__(self, name):"},{"line_number":48,"context_line":"        # Delegate access of non-generic calls to the right client."},{"line_number":49,"context_line":"        attr \u003d \"_{version}{name}\".format(version\u003dself.version, name\u003dname)"},{"line_number":50,"context_line":"        if not hasattr(self, attr):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_562f5f3e","line":47,"in_reply_to":"dae33548_2981b6c3","updated":"2016-02-18 11:58:41.000000000","message":"https://review.openstack.org/#/c/172831/ was updated a long time ago. Last week we discussed with Boris P (boris-42) the future of wrappers. He wants to update(actually rewrite) a spec in near future, but he don\u0027t have enough time for it now. :(\n\nThe main idea(btw, it was discussed based on keystone wrapper) looks like:\n\n    class KeystoneService(BaseServiceClass):\n        def __init__(version):\n             self.impl \u003d KeystoneV2() if version \u003d\u003d 2 else KeystoneV3()\n       \n       def create_project():\n            result \u003d self.impl.create_project()\n            # handle the difference between result of different APIs\n            return result\n\n\nKeystoneService class will include only methods, which are exist in both APIs and handle the difference between input args and output result. It will be used in Context, Validation, not-keystone scenarios and etc. In other words, it will be used in all places where we don\u0027t want to care about api version and expect that it will work for every supported version. For example, if I setup VolumeGenerator(cinder context), I expect that it will work for both V1 and V2. But even if we don\u0027t want to care about api versions in context, sometimes we still need it. For example, endpoints of each service can be discovered via service catalog by service_type. In case of using Cinder V2 in context, we need to specify volumev2 service_type via api_versions context and \"2\" version. This applies to all non-default service types and versions.\n\nKeystoneV2 and KeystoneV3 classes will implement the full APIs for each version without compatibility with another version. These classes will be used in those places, where we need to check the right feature for right version.\n\nNow, we are at the point, when refactoring of wrappers, scenario utils is a high priority thing and it would be nice to do not write hacks in different places, so it would be easier to switch to new entity \"Service\".","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"14dc3d8a458cee10bb07dcabd3ea0606953dad22","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \"Keystone API version %s is not implemented\" % version)"},{"line_number":45,"context_line":"        self.version \u003d version.replace(\"v2.0\", \"v2\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __getattr__(self, name):"},{"line_number":48,"context_line":"        # Delegate access of non-generic calls to the right client."},{"line_number":49,"context_line":"        attr \u003d \"_{version}{name}\".format(version\u003dself.version, name\u003dname)"},{"line_number":50,"context_line":"        if not hasattr(self, attr):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_0d7fbe15","line":47,"in_reply_to":"dae33548_526b2785","updated":"2016-02-17 13:57:33.000000000","message":"Wrappers were designed to be used not only in scenarios, but in all rally components(context, validation and etc). I agreed that it has not ideal interface and we have the spec on review about future of wrappers(I will share a link a bit later, so you will be able to share your opinion about it), but now it would be nice to solve same issues in one way(we have wrapper for glance v1/v2, cinder v1/v2).","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"58854337181a37f3754707820579fefab754d654","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \"Keystone API version %s is not implemented\" % version)"},{"line_number":45,"context_line":"        self.version \u003d version.replace(\"v2.0\", \"v2\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __getattr__(self, name):"},{"line_number":48,"context_line":"        # Delegate access of non-generic calls to the right client."},{"line_number":49,"context_line":"        attr \u003d \"_{version}{name}\".format(version\u003dself.version, name\u003dname)"},{"line_number":50,"context_line":"        if not hasattr(self, attr):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_526b2785","line":47,"in_reply_to":"dae33548_97064184","updated":"2016-02-17 13:45:44.000000000","message":"I\u0027m sorry but the wrappers are awful, I have deliberately not copied that approach. In particular they are unnecessarily adding an extra layer of abstraction that is better done in the scenario, and it\u0027s also constructing namedtuples as fake roles, users, projects, and scenarios which is totally unnecessary with this approach as we just use native client objects which will Just Work.\n\nThe keystone wrapper should now be removed as this approach provides the single interface far more simply.","commit_id":"baf5ea8f6e55e6d4cea0e7873c644d4cd781c581"}],"samples/tasks/scenarios/keystone/create-tenant_v3.json":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2e57392b9c07ccf1fafb9446acc4c9c78ee1e40e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"KeystoneBasic.create_tenant\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {},"},{"line_number":5,"context_line":"            \"runner\": {"}],"source_content_type":"application/json","patch_set":8,"id":"dae33548_539251a0","line":2,"updated":"2016-02-16 12:44:19.000000000","message":"Why not \"KeystoneBasic.create_project\"? I saw this method defined in basic.py L78","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"680b9a5e80b45317583035ad813558a9317661ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"KeystoneBasic.create_tenant\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {},"},{"line_number":5,"context_line":"            \"runner\": {"}],"source_content_type":"application/json","patch_set":8,"id":"dae33548_b1f9f182","line":2,"in_reply_to":"dae33548_539251a0","updated":"2016-02-17 01:44:00.000000000","message":"Same as previous comment","commit_id":"0e11d628ccdf6f645602d9701fea56aad932279e"}],"tests/unit/test_osclients.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"11b2ddc5a0fdd6c5651f6c09fb09243de9000d87","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.assertIs(client, self.ksc_client.Client())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @ddt.data("},{"line_number":177,"context_line":"        {},"},{"line_number":178,"context_line":"        {\"version\": \"2\"},"},{"line_number":179,"context_line":"        {\"version\": \"v2\"},"},{"line_number":180,"context_line":"        {\"version\": \"v2.0\"},"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_90f17e97","line":177,"updated":"2016-02-08 14:18:54.000000000","message":"Since this dataset is explicitly ignored below, why not just remove it?","commit_id":"49fa98ffb3cdfe7f772979e561351fc7758a7064"},{"author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"change_message_id":"36b54936363389b42c067d4ed29df005a3c8572e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.assertIs(client, self.ksc_client.Client())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @ddt.data("},{"line_number":177,"context_line":"        {},"},{"line_number":178,"context_line":"        {\"version\": \"2\"},"},{"line_number":179,"context_line":"        {\"version\": \"v2\"},"},{"line_number":180,"context_line":"        {\"version\": \"v2.0\"},"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_fdbae270","line":177,"in_reply_to":"5a5ae5dd_90f17e97","updated":"2016-02-09 03:09:16.000000000","message":"Ooof, how did I miss that!  Thanks.","commit_id":"49fa98ffb3cdfe7f772979e561351fc7758a7064"}]}
