)]}'
{"doc/specs/in-progress/pluggable_validators.rst":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"00e3d3dc8b3f212519c47843cbc36f7a5151669a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Need to create Validator, plugin base class, for all validators that would be"},{"line_number":36,"context_line":"inherited from plugin.Plugin. All other validators should be inherited from it."},{"line_number":37,"context_line":"Also validator\u0027s stuff in the engine be move under plugin base"},{"line_number":38,"context_line":"(https://github.com/openstack/rally/blob/master/rally/task/engine.py#L188-L278)"},{"line_number":39,"context_line":"Move all currently created validators under plugin base. Split them into"},{"line_number":40,"context_line":"OpenStack related and not."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bae84128_88c049e2","line":38,"updated":"2016-02-25 13:40:24.000000000","message":"1) Use RestructuredText hyperlink (`Text\u003chttp://address\u003e_`)\n\n2) Referring master branch can cause code shift if there will be changes committed to engine.py before L188. To avoid this, refer code of specific commit (any recent commit in master branch)\n\nSo I would recommend something like that:\n\n... be move under `plugin base \u003chttps://github.com/openstack/rally/blob/be8cd7bff6de9b3e83dd31005ae5d07ca1c86b9e/rally/task/engine.py#L188-L278\u003e`_","commit_id":"2e28192a0f0c838631eeec4aaad61918f0420a93"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"76c32f6efbd98d7cc45be1713a90e6ed5689621f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Need to create Validator, plugin base class, for all validators that would be"},{"line_number":36,"context_line":"inherited from plugin.Plugin. All other validators should be inherited from it."},{"line_number":37,"context_line":"Also validator\u0027s stuff in the engine be move under plugin base"},{"line_number":38,"context_line":"(https://github.com/openstack/rally/blob/master/rally/task/engine.py#L188-L278)"},{"line_number":39,"context_line":"Move all currently created validators under plugin base. Split them into"},{"line_number":40,"context_line":"OpenStack related and not."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aed3d3a_7b3784b0","line":38,"updated":"2016-02-26 14:15:47.000000000","message":"I think I\u0027d like to see a little more detail about how the validators will be called from the task engine.","commit_id":"2e28192a0f0c838631eeec4aaad61918f0420a93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"00e3d3dc8b3f212519c47843cbc36f7a5151669a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    @configure(name\u003d\"base_validator\")"},{"line_number":66,"context_line":"    class Validator(plugin.Plugin):"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        def __init__(self, **kwargs):"},{"line_number":69,"context_line":"            pass"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        @abc.abstractmethod"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bae84128_036ffa92","line":68,"updated":"2016-02-25 13:40:24.000000000","message":"Remove this method\n\n1) this does nothing\n2) this even does not call super(plugin.Plugin, self).__init__() so class will not work at all","commit_id":"2e28192a0f0c838631eeec4aaad61918f0420a93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"00e3d3dc8b3f212519c47843cbc36f7a5151669a","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        @abc.abstractmethod"},{"line_number":72,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"},{"line_number":73,"context_line":"            pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        def add(name, **kwargs):"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bae84128_031d3a0f","line":73,"updated":"2016-02-25 13:40:24.000000000","message":"replace `pass\u0027 with docsting which describes method args","commit_id":"2e28192a0f0c838631eeec4aaad61918f0420a93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"00e3d3dc8b3f212519c47843cbc36f7a5151669a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        def add(name, **kwargs):"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            validator \u003d Validator.get(name)(**kwargs)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bae84128_03925a57","line":76,"updated":"2016-02-25 13:40:24.000000000","message":"I guess this mehod should be classmethod","commit_id":"2e28192a0f0c838631eeec4aaad61918f0420a93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"00e3d3dc8b3f212519c47843cbc36f7a5151669a","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        def add(name, **kwargs):"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            validator \u003d Validator.get(name)(**kwargs)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            def decorator(p):"},{"line_number":81,"context_line":"                p._meta_setdefault(\"validators_v2\", [])"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bae84128_237cbe1f","line":78,"updated":"2016-02-25 13:40:24.000000000","message":"if classmethod, then `cls.get(name)(**kwargs)\u0027","commit_id":"2e28192a0f0c838631eeec4aaad61918f0420a93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"00e3d3dc8b3f212519c47843cbc36f7a5151669a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            return wrapper"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        def validate(plugin, deployment, cfg, plugin_cfg):"},{"line_number":89,"context_line":"            results \u003d []"},{"line_number":90,"context_line":"            cache \u003d {}"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bae84128_e3e656e7","line":88,"updated":"2016-02-25 13:40:24.000000000","message":"1) This duplicates abstract method `validate\u0027 given above at L72\n\n2) Never re-assign name which is imported - here `plugin\u0027 is imported module, use another name","commit_id":"2e28192a0f0c838631eeec4aaad61918f0420a93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"00e3d3dc8b3f212519c47843cbc36f7a5151669a","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        def validate(plugin, deployment, cfg, plugin_cfg):"},{"line_number":89,"context_line":"            results \u003d []"},{"line_number":90,"context_line":"            cache \u003d {}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"            for v in p._meta_get(\"validators_v2\"):"},{"line_number":93,"context_line":"                results.append("}],"source_content_type":"text/x-rst","patch_set":2,"id":"bae84128_83c02ae2","line":90,"updated":"2016-02-25 13:40:24.000000000","message":"This is probably a mistake, `cache\u0027 should be set up somewhere out of this method, for example in __init__()","commit_id":"2e28192a0f0c838631eeec4aaad61918f0420a93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"00e3d3dc8b3f212519c47843cbc36f7a5151669a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            for v in p._meta_get(\"validators_v2\"):"},{"line_number":93,"context_line":"                results.append("},{"line_number":94,"context_line":"                v.validate(cache, deployment, cfg, plugin_cfg))"},{"line_number":95,"context_line":"                    return results"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Such design allows us to validator in the same way against contexts(which"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bae84128_a32a8ee5","line":95,"updated":"2016-02-25 13:40:24.000000000","message":"`return\u0027 is probably on wrong indentation level","commit_id":"2e28192a0f0c838631eeec4aaad61918f0420a93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"00e3d3dc8b3f212519c47843cbc36f7a5151669a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    class JsonSchemaValidator(Validator):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        def __init__(self, schema\u003dNone):"},{"line_number":108,"context_line":"            self.schema \u003d schema or {}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bae84128_e36c960a","line":108,"updated":"2016-02-25 13:40:24.000000000","message":"super(JsonSchemaValidator, self).__init__()","commit_id":"2e28192a0f0c838631eeec4aaad61918f0420a93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1761189c4a46775b13a9e0a0e0d1baa581228e07","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is not pluggable."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7af24918_649fb7b4","line":28,"updated":"2016-03-02 16:22:05.000000000","message":"Please give more details in proposed changes regarding how this will be solved (what code will be moved to which modules)","commit_id":"b524695c56bd6d7895168cc40615fe62a5180d0a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2a60d0bd3b879354cbb079cbe78046e7fff50d18","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is not pluggable."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_28820001","line":28,"in_reply_to":"7af24918_649fb7b4","updated":"2016-03-11 15:19:51.000000000","message":"See lower in the section `proposed change`","commit_id":"b524695c56bd6d7895168cc40615fe62a5180d0a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c73dbfa0da285502171055bc833ea82d24b98743","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Rally Task Validation Refactoring"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"It\u0027s hard to reuse validators also validators pin us to OpenStack."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_10701f71","line":21,"updated":"2016-04-08 05:57:56.000000000","message":"pin?","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Rally Task Validation Refactoring"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"It\u0027s hard to reuse validators also validators pin us to OpenStack."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_4b71a043","line":21,"in_reply_to":"9a061dce_10701f71","updated":"2016-04-14 15:57:50.000000000","message":"Done","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c73dbfa0da285502171055bc833ea82d24b98743","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is not pluggable."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_504f3733","line":26,"updated":"2016-04-08 05:57:56.000000000","message":"it is plugable.. however it doesn\u0027t use our plugin approach which creates problems. (e.g. we need to hardcode the path for it which makes it hard to move plugin and create them out of tree)","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is not pluggable."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_ab903444","line":26,"in_reply_to":"9a061dce_504f3733","updated":"2016-04-14 15:57:50.000000000","message":"Done","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c73dbfa0da285502171055bc833ea82d24b98743","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is not pluggable."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_d05987fe","line":28,"updated":"2016-04-08 05:57:56.000000000","message":"This will be unclear for everybody. \n\nFirst of all why it is bad. Why that code is in engine, and how proposed spec is related to removing it?","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is not pluggable."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_880f5187","line":28,"in_reply_to":"9a061dce_d05987fe","updated":"2016-04-14 15:57:50.000000000","message":"This is brief description of what will be described below. Read below!","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c73dbfa0da285502171055bc833ea82d24b98743","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_30756363","line":30,"updated":"2016-04-08 05:57:56.000000000","message":"Unclear. What do you mean by this phrase? What scopes? what is hard to reuse? Why it\u0027s hard?","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_e879a5c9","line":30,"in_reply_to":"9a061dce_30756363","updated":"2016-04-14 15:57:50.000000000","message":"Too many question to such a simple sentence. Of cause you need to do some brainwork if you want to understand the problem from its brief description. Read below","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c73dbfa0da285502171055bc833ea82d24b98743","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Need to create Validator, plugin base class, for all validators that would be"},{"line_number":36,"context_line":"inherited from plugin.Plugin. All other validators should be inherited from it."},{"line_number":37,"context_line":"Move all currently created validators under plugin base. Split them into"},{"line_number":38,"context_line":"OpenStack related and not."},{"line_number":39,"context_line":"Also `validator\u0027s stuff in the engine \u003chttps://github"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_d0dea73c","line":36,"updated":"2016-04-08 05:57:56.000000000","message":"All that you described is just a bonus of refoctoring, however it is not the major goal. \n\nMajor goal is to create unified validation mechanism that can be used for all types of future deployments and type of plugins in the same way. \nSo we will be able to remove OpenStack related code from task engine, and create a bunch of common validators (e.g. jsonschema) that can be used by any plugin. \n\nAs a bonus of refactoring we will switch to common mechanims of plugins which has a lot of nice features.","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Need to create Validator, plugin base class, for all validators that would be"},{"line_number":36,"context_line":"inherited from plugin.Plugin. All other validators should be inherited from it."},{"line_number":37,"context_line":"Move all currently created validators under plugin base. Split them into"},{"line_number":38,"context_line":"OpenStack related and not."},{"line_number":39,"context_line":"Also `validator\u0027s stuff in the engine \u003chttps://github"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_eba86c8e","line":36,"in_reply_to":"9a061dce_d0dea73c","updated":"2016-04-14 15:57:50.000000000","message":"Done","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2df9666f3c76c899492ae51ef1666bcdf40a18b1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    class Validator(plugin.Plugin):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        def __init__(self, **kwargs):"},{"line_number":76,"context_line":"            super(plugin.Plugin, self).__init__()"},{"line_number":77,"context_line":"            self.cache \u003d {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        @classmethod"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da0c15f0_8182f9fe","line":76,"updated":"2016-03-25 13:54:31.000000000","message":"We can drop this super()\n\nclass plugin.Plugin has no instance-related implementation, as well as __init__()","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c73dbfa0da285502171055bc833ea82d24b98743","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    class Validator(plugin.Plugin):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        def __init__(self, **kwargs):"},{"line_number":76,"context_line":"            super(plugin.Plugin, self).__init__()"},{"line_number":77,"context_line":"            self.cache \u003d {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        @classmethod"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_90bf0fcf","line":76,"in_reply_to":"da0c15f0_8182f9fe","updated":"2016-04-08 05:57:56.000000000","message":"this can be changed overtime, so it\u0027s okay to call __init__()","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c73dbfa0da285502171055bc833ea82d24b98743","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        def __init__(self, **kwargs):"},{"line_number":76,"context_line":"            super(plugin.Plugin, self).__init__()"},{"line_number":77,"context_line":"            self.cache \u003d {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        @classmethod"},{"line_number":80,"context_line":"        def add(cls, name, **kwargs):"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_70c7db63","line":77,"updated":"2016-04-08 05:57:56.000000000","message":"Seems like you don\u0027t understand how this cache is going to be used.. \n\n\nit\u0027s wrong place to put cache, cache should be common for all validators, and it should be passed outside of validators","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        def __init__(self, **kwargs):"},{"line_number":76,"context_line":"            super(plugin.Plugin, self).__init__()"},{"line_number":77,"context_line":"            self.cache \u003d {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        @classmethod"},{"line_number":80,"context_line":"        def add(cls, name, **kwargs):"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_6b9d7c65","line":77,"in_reply_to":"9a061dce_70c7db63","updated":"2016-04-14 15:57:50.000000000","message":"Done","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2df9666f3c76c899492ae51ef1666bcdf40a18b1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            self.cache \u003d {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        @classmethod"},{"line_number":80,"context_line":"        def add(cls, name, **kwargs):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            validator \u003d cls.get(name)(**kwargs)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da0c15f0_946519e3","line":80,"updated":"2016-03-25 13:54:31.000000000","message":"This is not clear - this methods allows to add validators to Validator?","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c73dbfa0da285502171055bc833ea82d24b98743","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            self.cache \u003d {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        @classmethod"},{"line_number":80,"context_line":"        def add(cls, name, **kwargs):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            validator \u003d cls.get(name)(**kwargs)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_10e5bf07","line":80,"in_reply_to":"da0c15f0_946519e3","updated":"2016-04-08 05:57:56.000000000","message":"This looks just wrong. This is not Validator plugin interface, this is validation mechanism interface.","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2df9666f3c76c899492ae51ef1666bcdf40a18b1","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            validator \u003d cls.get(name)(**kwargs)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            def decorator(p):"},{"line_number":85,"context_line":"                p._meta_setdefault(\"validators_v2\", [])"},{"line_number":86,"context_line":"                p._meta_get(\"validators_v2\").append(validator)"},{"line_number":87,"context_line":"                return p"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da0c15f0_a13c5d30","line":85,"updated":"2016-03-25 13:54:31.000000000","message":"Why \"v2\"? Do we have plugin-based validators v1?","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            validator \u003d cls.get(name)(**kwargs)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            def decorator(p):"},{"line_number":85,"context_line":"                p._meta_setdefault(\"validators_v2\", [])"},{"line_number":86,"context_line":"                p._meta_get(\"validators_v2\").append(validator)"},{"line_number":87,"context_line":"                return p"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_464d173d","line":85,"in_reply_to":"da0c15f0_a13c5d30","updated":"2016-04-14 15:57:50.000000000","message":"We have got \"v1\" https://github.com/openstack/rally/blob/master/rally/task/validation.py#L73 already in the code. https://github.com/openstack/rally/blob/master/rally/task/scenario.py#L129","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c73dbfa0da285502171055bc833ea82d24b98743","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return decorator"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        @classmethod"},{"line_number":92,"context_line":"        def validate(cls, deployment, cfg):"},{"line_number":93,"context_line":"            results \u003d []"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            for v in cls._meta_get(\"validators_v2\"):"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_f0b48b82","line":92,"updated":"2016-04-08 05:57:56.000000000","message":"This is wrong, you are messing up validation mechanism and validators. \n\nValidation mechanism should \n- allow you to add validators to plugins\n- allow you to run validation (get all validators required to validate all passed plugins with configuration and deployment as well as pass to validators cache)\n\nValidator \n\n  - is plugin base for all validators that should accept cache from outside and implement validate method.","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return decorator"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        @classmethod"},{"line_number":92,"context_line":"        def validate(cls, deployment, cfg):"},{"line_number":93,"context_line":"            results \u003d []"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            for v in cls._meta_get(\"validators_v2\"):"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_4b9a406f","line":92,"in_reply_to":"9a061dce_f0b48b82","updated":"2016-04-14 15:57:50.000000000","message":"Done","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2df9666f3c76c899492ae51ef1666bcdf40a18b1","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            for v in cls._meta_get(\"validators_v2\"):"},{"line_number":96,"context_line":"                results.append("},{"line_number":97,"context_line":"                v.validate(cache, deployment, cfg))"},{"line_number":98,"context_line":"            return results"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da0c15f0_f45575c6","line":97,"updated":"2016-03-25 13:54:31.000000000","message":"Where is this \"validate()\" method defined? I see signature \"cache, deployment, cfg\" but I do not see method validate() with such signature within this specification","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            for v in cls._meta_get(\"validators_v2\"):"},{"line_number":96,"context_line":"                results.append("},{"line_number":97,"context_line":"                v.validate(cache, deployment, cfg))"},{"line_number":98,"context_line":"            return results"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_0b7b2829","line":97,"in_reply_to":"da0c15f0_f45575c6","updated":"2016-04-14 15:57:50.000000000","message":"Done","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2df9666f3c76c899492ae51ef1666bcdf40a18b1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            return results"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Such design allows us to validator in the same way against contexts(which"},{"line_number":102,"context_line":"was not possible before), scenarios, etc. For example, we could implement json"},{"line_number":103,"context_line":"schema validation as a plugin. And here is an advantages:"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da0c15f0_01e6e9b3","line":101,"updated":"2016-03-25 13:54:31.000000000","message":"s/to validator/to validate/","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            return results"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Such design allows us to validator in the same way against contexts(which"},{"line_number":102,"context_line":"was not possible before), scenarios, etc. For example, we could implement json"},{"line_number":103,"context_line":"schema validation as a plugin. And here is an advantages:"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_8b8e182c","line":101,"in_reply_to":"da0c15f0_01e6e9b3","updated":"2016-04-14 15:57:50.000000000","message":"Done","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2df9666f3c76c899492ae51ef1666bcdf40a18b1","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            self.schema \u003d schema or {}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @validator.add(\"jsonschema\", schema\u003d\"\u003chere_json_schema\u003e\")"},{"line_number":116,"context_line":"    class SomeContext(base.Context):"},{"line_number":117,"context_line":"        pass"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da0c15f0_d4b6713c","line":115,"updated":"2016-03-25 13:54:31.000000000","message":"What is \"validator.add\"? I see only \"Validator.add\" above at L80","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bcc75a897f25ab17e9b426148bc9e3ac090ee633","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            self.schema \u003d schema or {}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @validator.add(\"jsonschema\", schema\u003d\"\u003chere_json_schema\u003e\")"},{"line_number":116,"context_line":"    class SomeContext(base.Context):"},{"line_number":117,"context_line":"        pass"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_c6de4710","line":115,"in_reply_to":"da0c15f0_d4b6713c","updated":"2016-04-14 15:57:50.000000000","message":"Don\u0027t be too straightforward. Of cause you need to import the method from the module above.","commit_id":"81aebb8814646698761afa4479278e12bc8831f8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9e3a0dff00f610f67e2d5a98ff47ffe7facffbf5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Rally Task Validation Refactoring"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"It\u0027s hard to reuse validators also validators make us depend on OpenStack."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_99bf40cf","line":21,"updated":"2016-04-21 12:16:07.000000000","message":"dependent on","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7a546b8700f059dc4d446c5e9261471375273a27","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Rally Task Validation Refactoring"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"It\u0027s hard to reuse validators also validators make us depend on OpenStack."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_f30b47d3","line":21,"in_reply_to":"1a122d0e_99bf40cf","updated":"2016-04-27 11:49:45.000000000","message":"https://translate.google.com.ua/?hl\u003den\u0026tab\u003dwT#en/ru/depend%20on\n\nhttps://translate.google.com.ua/?hl\u003den\u0026tab\u003dwT#en/ru/dependent%20on\n\nSo in our case there is no difference","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b1f00aff3d05d7bd16c39601cc48a1267a174bf3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Rally Task Validation Refactoring"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"It\u0027s hard to reuse validators also validators make us depend on OpenStack."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_f12bd031","line":21,"in_reply_to":"1a122d0e_f30b47d3","updated":"2016-05-18 10:39:28.000000000","message":"https://translate.google.com/#en/ru/make%20us%20depend%20on\n\nhttps://translate.google.com/#en/ru/make%20us%20dependent%20on","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9e3a0dff00f610f67e2d5a98ff47ffe7facffbf5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system pluggable - but it doesn\u0027t use our plugin approach"},{"line_number":27,"context_line":"  which creates problems (e.g. we need to hardcode the path for it which"},{"line_number":28,"context_line":"  makes it hard to move plugin and create them out of tree)."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_d9d258d0","line":26,"updated":"2016-04-21 12:16:07.000000000","message":"is pluggable","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7a546b8700f059dc4d446c5e9261471375273a27","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system pluggable - but it doesn\u0027t use our plugin approach"},{"line_number":27,"context_line":"  which creates problems (e.g. we need to hardcode the path for it which"},{"line_number":28,"context_line":"  makes it hard to move plugin and create them out of tree)."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_d310cb02","line":26,"in_reply_to":"1a122d0e_d9d258d0","updated":"2016-04-27 11:49:45.000000000","message":"Done","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9e3a0dff00f610f67e2d5a98ff47ffe7facffbf5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @configure(name\u003d\"base_validator\")"},{"line_number":82,"context_line":"    class Validator(plugin.Plugin):"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        def init(self, **kwargs):"},{"line_number":85,"context_line":"            pass"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_364a7628","line":84,"updated":"2016-04-21 12:16:07.000000000","message":"There is no explanation below when this method is called.\n\nMaybe this should be __init__() ?","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7a546b8700f059dc4d446c5e9261471375273a27","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @configure(name\u003d\"base_validator\")"},{"line_number":82,"context_line":"    class Validator(plugin.Plugin):"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        def init(self, **kwargs):"},{"line_number":85,"context_line":"            pass"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_b32c2f4b","line":84,"in_reply_to":"1a122d0e_364a7628","updated":"2016-04-27 11:49:45.000000000","message":"Of cause","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9e3a0dff00f610f67e2d5a98ff47ffe7facffbf5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def add(name, **kwargs):"},{"line_number":92,"context_line":"        validator \u003d Validator.get(name)(**kwargs)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        def decorator(p):"},{"line_number":95,"context_line":"            p._meta_setdefault(\"validators_v2\", [])"},{"line_number":96,"context_line":"            p._meta_get(\"validators_v2\").append(validator)"},{"line_number":97,"context_line":"            return p"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_f37ad076","line":94,"updated":"2016-04-21 12:16:07.000000000","message":"def wrapper(p):","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7a546b8700f059dc4d446c5e9261471375273a27","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def add(name, **kwargs):"},{"line_number":92,"context_line":"        validator \u003d Validator.get(name)(**kwargs)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        def decorator(p):"},{"line_number":95,"context_line":"            p._meta_setdefault(\"validators_v2\", [])"},{"line_number":96,"context_line":"            p._meta_get(\"validators_v2\").append(validator)"},{"line_number":97,"context_line":"            return p"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_53be7bae","line":94,"in_reply_to":"1a122d0e_f37ad076","updated":"2016-04-27 11:49:45.000000000","message":"Done","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9e3a0dff00f610f67e2d5a98ff47ffe7facffbf5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        validator \u003d Validator.get(name)(**kwargs)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        def decorator(p):"},{"line_number":95,"context_line":"            p._meta_setdefault(\"validators_v2\", [])"},{"line_number":96,"context_line":"            p._meta_get(\"validators_v2\").append(validator)"},{"line_number":97,"context_line":"            return p"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_d35d147b","line":95,"updated":"2016-04-21 12:16:07.000000000","message":"\"_v2\" is confusing. Please read my comments in patch set 6 about this","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7a546b8700f059dc4d446c5e9261471375273a27","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        validator \u003d Validator.get(name)(**kwargs)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        def decorator(p):"},{"line_number":95,"context_line":"            p._meta_setdefault(\"validators_v2\", [])"},{"line_number":96,"context_line":"            p._meta_get(\"validators_v2\").append(validator)"},{"line_number":97,"context_line":"            return p"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_33965f4c","line":95,"in_reply_to":"1a122d0e_d35d147b","updated":"2016-04-27 11:49:45.000000000","message":"Please read my answer there under you question https://review.openstack.org/#/c/283180/6/doc/specs/in-progress/pluggable_validators.rst@85","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9e3a0dff00f610f67e2d5a98ff47ffe7facffbf5","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return wrapper"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def validate(plugin, deployment, cfg, plugin_cfg):"},{"line_number":103,"context_line":"        results \u003d []"},{"line_number":104,"context_line":"        cache \u003d {}"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_b69966d3","line":102,"updated":"2016-04-21 12:16:07.000000000","message":"It seems reasonable to consider to have validate() as Plugin classmethod","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7a546b8700f059dc4d446c5e9261471375273a27","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return wrapper"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def validate(plugin, deployment, cfg, plugin_cfg):"},{"line_number":103,"context_line":"        results \u003d []"},{"line_number":104,"context_line":"        cache \u003d {}"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_13cfe356","line":102,"in_reply_to":"1a122d0e_b69966d3","updated":"2016-04-27 11:49:45.000000000","message":"This is just the function inside module. So what is you suggestion?","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9e3a0dff00f610f67e2d5a98ff47ffe7facffbf5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        results \u003d []"},{"line_number":104,"context_line":"        cache \u003d {}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        for v in p._meta_get(\"validators_v2\"):"},{"line_number":107,"context_line":"            results.append(v.validate(cache, deployment, cfg, plugin_cfg))"},{"line_number":108,"context_line":"            return results"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_f342d067","line":106,"updated":"2016-04-21 12:16:07.000000000","message":"s/p/plugin/","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7a546b8700f059dc4d446c5e9261471375273a27","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        results \u003d []"},{"line_number":104,"context_line":"        cache \u003d {}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        for v in p._meta_get(\"validators_v2\"):"},{"line_number":107,"context_line":"            results.append(v.validate(cache, deployment, cfg, plugin_cfg))"},{"line_number":108,"context_line":"            return results"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_b3d38f37","line":106,"in_reply_to":"1a122d0e_f342d067","updated":"2016-04-27 11:49:45.000000000","message":"Done","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9e3a0dff00f610f67e2d5a98ff47ffe7facffbf5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        cache \u003d {}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        for v in p._meta_get(\"validators_v2\"):"},{"line_number":107,"context_line":"            results.append(v.validate(cache, deployment, cfg, plugin_cfg))"},{"line_number":108,"context_line":"            return results"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_16c01a7c","line":107,"updated":"2016-04-21 12:16:07.000000000","message":"Here v.validate(...) is a static call, but tehre is an is instancemethod at L87","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7a546b8700f059dc4d446c5e9261471375273a27","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        cache \u003d {}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        for v in p._meta_get(\"validators_v2\"):"},{"line_number":107,"context_line":"            results.append(v.validate(cache, deployment, cfg, plugin_cfg))"},{"line_number":108,"context_line":"            return results"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_53f67b5d","line":107,"in_reply_to":"1a122d0e_16c01a7c","updated":"2016-04-27 11:49:45.000000000","message":"V - is an instance of validator, so what is wrong?","commit_id":"b5d15c86536dbe6e8ae1ee37c2e42c56857c53e9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b6c3cac296ec627296fb364680203025d02eae9d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Rally Task Validation Refactoring"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"It\u0027s hard to reuse validators also validators make us depend on OpenStack."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_f1d2b033","line":21,"updated":"2016-05-18 10:42:29.000000000","message":"See my comment on patch set 7","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is pluggable - but it doesn\u0027t use our plugin"},{"line_number":27,"context_line":"  approach"},{"line_number":28,"context_line":"  which creates problems (e.g. we need to hardcode the path for it which"},{"line_number":29,"context_line":"  makes it hard to move plugin and create them out of tree)."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_23903943","line":27,"updated":"2016-05-19 08:19:10.000000000","message":"mechanism (new line is redundant)","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is pluggable - but it doesn\u0027t use our plugin"},{"line_number":27,"context_line":"  approach"},{"line_number":28,"context_line":"  which creates problems (e.g. we need to hardcode the path for it which"},{"line_number":29,"context_line":"  makes it hard to move plugin and create them out of tree)."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* A lot of OpenStack related code in the engine."}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_839f654f","line":28,"updated":"2016-05-19 08:19:10.000000000","message":"In current approach all paths are hardcoded which makes it hard to move plugin and create them out of tree.","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"727420b0cd8dcf2c866c6e785be16cb32bac60a9","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is pluggable - but it doesn\u0027t use our plugin"},{"line_number":27,"context_line":"  approach"},{"line_number":28,"context_line":"  which creates problems (e.g. we need to hardcode the path for it which"},{"line_number":29,"context_line":"  makes it hard to move plugin and create them out of tree)."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* A lot of OpenStack related code in the engine."}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_8a8f6322","line":28,"in_reply_to":"bab6814e_839f654f","updated":"2016-05-25 11:37:27.000000000","message":"I just used you words: \"\nBoris Pavlovic\nApr 8 8:57 AM\n\nit is plugable.. however it doesn\u0027t use our plugin approach which creates problems. (e.g. we need to hardcode the path for it which makes it hard to move plugin and create them out of tree)\"","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  which creates problems (e.g. we need to hardcode the path for it which"},{"line_number":29,"context_line":"  makes it hard to move plugin and create them out of tree)."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_a3d269fe","line":31,"updated":"2016-05-19 08:19:10.000000000","message":"This is not complete sentence. \n\n* Rally task engine, has to know about OpenStack to validate input task.","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"727420b0cd8dcf2c866c6e785be16cb32bac60a9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  which creates problems (e.g. we need to hardcode the path for it which"},{"line_number":29,"context_line":"  makes it hard to move plugin and create them out of tree)."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_aaa22749","line":31,"in_reply_to":"bab6814e_a3d269fe","updated":"2016-05-25 11:37:27.000000000","message":"Roman Vasilets\nApr 14 6:57 PM\n\nThis is brief description of what will be described below. Read below!\n\nBut you are not add some comments to my answer later","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_03089590","line":33,"updated":"2016-05-19 08:19:10.000000000","message":"This is not complete sentence, where it is hard and why it is hard?","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"727420b0cd8dcf2c866c6e785be16cb32bac60a9","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_aad4e7bc","line":33,"in_reply_to":"bab6814e_03089590","updated":"2016-05-25 11:37:27.000000000","message":"Ah, this is a short context of what will be describe futher","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Major goal is to create unified validation mechanism that can be used for"},{"line_number":39,"context_line":"all types of future deployments and type of plugins in the same way. So we"},{"line_number":40,"context_line":"will be able to remove OpenStack related code from task engine, and create"},{"line_number":41,"context_line":"a bunch of common validators (e.g. jsonschema) that can be used by any"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_83ac8536","line":38,"updated":"2016-05-19 08:19:10.000000000","message":"Remove \"Major goal is to\". \n\n  Create unified validation mechanism for all types of plugins. \n\n This mechanism will contain few parts: validator plugin base for all validators, mechanism to add validators to plugins and code that will go over the validators for specific plugin and perform actually validation.","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"727420b0cd8dcf2c866c6e785be16cb32bac60a9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Major goal is to create unified validation mechanism that can be used for"},{"line_number":39,"context_line":"all types of future deployments and type of plugins in the same way. So we"},{"line_number":40,"context_line":"will be able to remove OpenStack related code from task engine, and create"},{"line_number":41,"context_line":"a bunch of common validators (e.g. jsonschema) that can be used by any"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_ca120b62","line":38,"in_reply_to":"bab6814e_83ac8536","updated":"2016-05-25 11:37:27.000000000","message":"Boris Pavlovic\nApr 8 8:57 AM\n\nMajor goal is to create unified validation mechanism that can be used for all types of future deployments and type of plugins in the same way. \nSo we will be able to remove OpenStack related code from task engine, and create a bunch of common validators (e.g. jsonschema) that can be used by any plugin. \n\n^ this is you words\n\nRemove \"Major goal is to\". -\u003e okey","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"will be able to remove OpenStack related code from task engine, and create"},{"line_number":41,"context_line":"a bunch of common validators (e.g. jsonschema) that can be used by any"},{"line_number":42,"context_line":"plugin."},{"line_number":43,"context_line":"As a bonus of refactoring we will switch to common mechanism of plugins which"},{"line_number":44,"context_line":"has a lot of nice features."},{"line_number":45,"context_line":"Need to create Validator, plugin base class, for all validators that would be"},{"line_number":46,"context_line":"inherited from plugin.Plugin. All other validators should be inherited from it."}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_e307511a","line":43,"updated":"2016-05-19 08:19:10.000000000","message":"These are actually action items. and should go in proper section.","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"727420b0cd8dcf2c866c6e785be16cb32bac60a9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"will be able to remove OpenStack related code from task engine, and create"},{"line_number":41,"context_line":"a bunch of common validators (e.g. jsonschema) that can be used by any"},{"line_number":42,"context_line":"plugin."},{"line_number":43,"context_line":"As a bonus of refactoring we will switch to common mechanism of plugins which"},{"line_number":44,"context_line":"has a lot of nice features."},{"line_number":45,"context_line":"Need to create Validator, plugin base class, for all validators that would be"},{"line_number":46,"context_line":"inherited from plugin.Plugin. All other validators should be inherited from it."}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_ea070f1b","line":43,"in_reply_to":"bab6814e_e307511a","updated":"2016-05-25 11:37:27.000000000","message":"Okey","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    @configure(name\u003d\"base_validator\")"},{"line_number":83,"context_line":"    class Validator(plugin.Plugin):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        def __init__(self, **kwargs):"},{"line_number":86,"context_line":"            pass"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_be19de7b","line":85,"updated":"2016-05-19 08:19:10.000000000","message":"this can be removed, you are not using __init__ here.","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"727420b0cd8dcf2c866c6e785be16cb32bac60a9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    @configure(name\u003d\"base_validator\")"},{"line_number":83,"context_line":"    class Validator(plugin.Plugin):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        def __init__(self, **kwargs):"},{"line_number":86,"context_line":"            pass"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_ad2361a6","line":85,"in_reply_to":"bab6814e_be19de7b","updated":"2016-05-25 11:37:27.000000000","message":"Boris Pavlovic\nApr 8 8:57 AM\n\nthis can be changed overtime, so it\u0027s okay to call __init__()\n\nCan... But I think \"Can \" means \"must\" here","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"f5ff503168c83d824a0a37a693e5b4b6d182abca","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        def __init__(self, **kwargs):"},{"line_number":86,"context_line":"            pass"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"},{"line_number":89,"context_line":"            pass"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_cc1712ec","line":88,"range":{"start_line":88,"start_character":27,"end_line":88,"end_character":61},"updated":"2016-05-18 11:38:06.000000000","message":"Could you pls elaborate on parameter list. E.g. what is \u0027cache\u0027 and why is it here?","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        def __init__(self, **kwargs):"},{"line_number":86,"context_line":"            pass"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"},{"line_number":89,"context_line":"            pass"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_5e271264","line":88,"range":{"start_line":88,"start_character":27,"end_line":88,"end_character":61},"in_reply_to":"bab6814e_cc1712ec","updated":"2016-05-19 08:19:10.000000000","message":"Ilya, \n\ncache is cross validator cache, this allows us to fetch only once information about enviroment and initialize openstack client and share it for all validators. \n\nE.g. if we need to perform 200 openstack check and each time we need to init client we will add extra 2 minutes for validation step. \n\nAs well, we don\u0027t need to fetch each time all images if we are using many times images validator, and for required services check as well.","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            pass"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def add(name, **kwargs):"},{"line_number":93,"context_line":"        validator \u003d Validator.get(name)(**kwargs)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        def wrapper(p):"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_5edef23f","line":92,"updated":"2016-05-19 08:19:10.000000000","message":"Where are docstirngs? They should describe complete what this method does and why.","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b6c3cac296ec627296fb364680203025d02eae9d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        validator \u003d Validator.get(name)(**kwargs)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        def wrapper(p):"},{"line_number":96,"context_line":"            p._meta_setdefault(\"validators_v2\", [])"},{"line_number":97,"context_line":"            p._meta_get(\"validators_v2\").append(validator)"},{"line_number":98,"context_line":"            return p"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_717c0021","line":96,"updated":"2016-05-18 10:42:29.000000000","message":"I\u0027m confusing about \"_v2\", do we really have versioning of validators? I would suggest to use some name different to \"validators\" but also not having \"v2\". Examples: \"validation\", \"validators_list\", \"validators_plugins\", ...","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        validator \u003d Validator.get(name)(**kwargs)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        def wrapper(p):"},{"line_number":96,"context_line":"            p._meta_setdefault(\"validators_v2\", [])"},{"line_number":97,"context_line":"            p._meta_get(\"validators_v2\").append(validator)"},{"line_number":98,"context_line":"            return p"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_dea022a2","line":96,"in_reply_to":"bab6814e_2c185e84","updated":"2016-05-19 08:19:10.000000000","message":"Alex, Ilya,\n\nit is internal name that is used only by engine, when we remove support of \"validators\" we can rename validators_v2 to validators. \n\nWhich will be actually way simpler to understand, then to have \"validators\" and \"validator_plugin\" in code. Reasonable question is Which one is right?","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"f5ff503168c83d824a0a37a693e5b4b6d182abca","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        validator \u003d Validator.get(name)(**kwargs)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        def wrapper(p):"},{"line_number":96,"context_line":"            p._meta_setdefault(\"validators_v2\", [])"},{"line_number":97,"context_line":"            p._meta_get(\"validators_v2\").append(validator)"},{"line_number":98,"context_line":"            return p"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_ac3a8ecb","line":96,"in_reply_to":"bab6814e_717c0021","updated":"2016-05-18 11:38:06.000000000","message":"+1 for \"validator_plugins\", but please not \"validators_plugins\" http://grammar.about.com/od/ab/g/Attributive-Noun.htm","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"58a0ac3f93d20c7b027689b19f48c18107a499df","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        validator \u003d Validator.get(name)(**kwargs)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        def wrapper(p):"},{"line_number":96,"context_line":"            p._meta_setdefault(\"validators_v2\", [])"},{"line_number":97,"context_line":"            p._meta_get(\"validators_v2\").append(validator)"},{"line_number":98,"context_line":"            return p"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_2c185e84","line":96,"in_reply_to":"bab6814e_ac3a8ecb","updated":"2016-05-18 11:46:55.000000000","message":"Agree :)","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"f5ff503168c83d824a0a37a693e5b4b6d182abca","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return wrapper"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def validate(plugin, deployment, cfg, plugin_cfg):"},{"line_number":104,"context_line":"        results \u003d []"},{"line_number":105,"context_line":"        cache \u003d {}"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_2cba1ee2","line":103,"range":{"start_line":103,"start_character":17,"end_line":103,"end_character":23},"updated":"2016-05-18 11:38:06.000000000","message":"What is \u0027plugin\u0027 here? Do we validate plugins only?","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return wrapper"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def validate(plugin, deployment, cfg, plugin_cfg):"},{"line_number":104,"context_line":"        results \u003d []"},{"line_number":105,"context_line":"        cache \u003d {}"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_5e9a7264","line":103,"range":{"start_line":103,"start_character":17,"end_line":103,"end_character":23},"in_reply_to":"bab6814e_2cba1ee2","updated":"2016-05-19 08:19:10.000000000","message":"docstrings are required here. \n\n\nplugin is plugin that has validators and should be validated.","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        cache \u003d {}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        for v in plugin._meta_get(\"validators_v2\"):"},{"line_number":108,"context_line":"            results.append(v.validate(cache, deployment, cfg, plugin_cfg))"},{"line_number":109,"context_line":"            return results"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_7ec6564a","line":108,"updated":"2016-05-19 08:19:10.000000000","message":"try/finally will be required here, because v.validate may through exceptions that we would like to catch.","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Such design allows us to validate in the same way against contexts(which"},{"line_number":113,"context_line":"was not possible before), scenarios, etc. For example, we could implement json"},{"line_number":114,"context_line":"schema validation as a plugin. And here is an advantages:"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_1e7aaaf1","line":113,"updated":"2016-05-19 08:19:10.000000000","message":"New approach unifies validation of all types of plugins which allows to use same validators for different types of plugins.","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    class JsonSchemaValidator(Validator):"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        def __init__(self, schema\u003dNone):"},{"line_number":122,"context_line":"            super(JsonSchemaValidator, self).__init__()"},{"line_number":123,"context_line":"            self.schema \u003d schema or {}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_fe63663f","line":122,"updated":"2016-05-19 08:19:10.000000000","message":"and where is validate() method?","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"271eefac2d81c52a49aedb1ef4d8d358adbfdad8","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            pass"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Also, as a result, code becomes more comfortable to reuse."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Assignee(s)"},{"line_number":141,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_1ec8ea21","line":138,"updated":"2016-05-19 08:19:10.000000000","message":"This can be removed","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"727420b0cd8dcf2c866c6e785be16cb32bac60a9","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            pass"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Also, as a result, code becomes more comfortable to reuse."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Assignee(s)"},{"line_number":141,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_8d82dd50","line":138,"in_reply_to":"bab6814e_1ec8ea21","updated":"2016-05-25 11:37:27.000000000","message":"Can... But I think \"Can \" means \"must\" here","commit_id":"b4c9dbc0debc935729896caefdd66f4106add2be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Rally Task Validation Refactoring"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"It\u0027s hard to reuse validators also validators make us depend on OpenStack."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_ddcf4c7d","line":21,"updated":"2016-05-26 01:08:16.000000000","message":"this is useless description, because it\u0027s incomplete, I would suggest just to remove this sentence.","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Rally Task Validation Refactoring"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"It\u0027s hard to reuse validators also validators make us depend on OpenStack."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_e2366bb3","line":21,"in_reply_to":"bab6814e_ddcf4c7d","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is pluggable - but it doesn\u0027t use our plugin"},{"line_number":27,"context_line":"  mechanism which creates problems (e.g. we need to hardcode the path for it"},{"line_number":28,"context_line":"  which makes it hard to move plugin and create them out of tree)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* A lot of OpenStack related code in the engine."}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_7d84600a","line":27,"updated":"2016-05-26 01:08:16.000000000","message":"Try not to use \"we\" \"he\" or \"I\" in specs. \n\n(e.g. validators are imported directly and used in code, instead of using their names, which doesn\u0027t allow one to rename or move without breaking backward compatibility)","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Current validator system is pluggable - but it doesn\u0027t use our plugin"},{"line_number":27,"context_line":"  mechanism which creates problems (e.g. we need to hardcode the path for it"},{"line_number":28,"context_line":"  which makes it hard to move plugin and create them out of tree)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* A lot of OpenStack related code in the engine."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_2b303d56","line":27,"in_reply_to":"bab6814e_7d84600a","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  mechanism which creates problems (e.g. we need to hardcode the path for it"},{"line_number":28,"context_line":"  which makes it hard to move plugin and create them out of tree)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_fd705042","line":30,"updated":"2016-05-26 01:08:16.000000000","message":"Current mechanism of validaton leads to a lot of OpenStack related code in the Rally task engine.","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  mechanism which creates problems (e.g. we need to hardcode the path for it"},{"line_number":28,"context_line":"  which makes it hard to move plugin and create them out of tree)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_c16c049f","line":30,"in_reply_to":"bab6814e_fd705042","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_9d96643c","line":32,"updated":"2016-05-26 01:08:16.000000000","message":"What means scope at all? \n\nIt\u0027s hard to use the same validators for different types of plugins, current approach is used only for scenarios.","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* A lot of OpenStack related code in the engine."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* Its hard to reuse in different scopes of the project."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_cbe7f110","line":32,"in_reply_to":"bab6814e_9d96643c","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"To create unified validation mechanism that can be used for all types of"},{"line_number":38,"context_line":"future deployments and type of plugins in the same way. So we will be able"},{"line_number":39,"context_line":"to remove OpenStack related code from task engine, and create a bunch of"},{"line_number":40,"context_line":"common validators (e.g. jsonschema) that can be used by any"},{"line_number":41,"context_line":"plugin."}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_ddcbcc51","line":38,"updated":"2016-05-26 01:08:16.000000000","message":"Do not use \"we\" and try to avoid \"will\" .","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"to remove OpenStack related code from task engine, and create a bunch of"},{"line_number":40,"context_line":"common validators (e.g. jsonschema) that can be used by any"},{"line_number":41,"context_line":"plugin."},{"line_number":42,"context_line":"As a bonus of refactoring we will switch to common mechanism of plugins which"},{"line_number":43,"context_line":"has a lot of nice features."},{"line_number":44,"context_line":"Need to create Validator, plugin base class, for all validators that would be"},{"line_number":45,"context_line":"inherited from plugin.Plugin. All other validators should be inherited from it."}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_9de4a4e0","line":42,"updated":"2016-05-26 01:08:16.000000000","message":"same here","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"common validators (e.g. jsonschema) that can be used by any"},{"line_number":41,"context_line":"plugin."},{"line_number":42,"context_line":"As a bonus of refactoring we will switch to common mechanism of plugins which"},{"line_number":43,"context_line":"has a lot of nice features."},{"line_number":44,"context_line":"Need to create Validator, plugin base class, for all validators that would be"},{"line_number":45,"context_line":"inherited from plugin.Plugin. All other validators should be inherited from it."},{"line_number":46,"context_line":"Move all currently created validators under plugin base. Split them into"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_bdcfe854","line":43,"updated":"2016-05-26 01:08:16.000000000","message":"what features?","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"has a lot of nice features."},{"line_number":44,"context_line":"Need to create Validator, plugin base class, for all validators that would be"},{"line_number":45,"context_line":"inherited from plugin.Plugin. All other validators should be inherited from it."},{"line_number":46,"context_line":"Move all currently created validators under plugin base. Split them into"},{"line_number":47,"context_line":"OpenStack related and not."},{"line_number":48,"context_line":"Also `validator\u0027s stuff in the engine \u003chttps://github"},{"line_number":49,"context_line":".com/openstack/rally/blob/be8cd7bff6de9b3e83dd31005ae5d07ca1c86b9e/rally"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_bd0a4824","line":46,"updated":"2016-05-26 01:08:16.000000000","message":"I already told once that this should go to the work items.","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"inherited from plugin.Plugin. All other validators should be inherited from it."},{"line_number":46,"context_line":"Move all currently created validators under plugin base. Split them into"},{"line_number":47,"context_line":"OpenStack related and not."},{"line_number":48,"context_line":"Also `validator\u0027s stuff in the engine \u003chttps://github"},{"line_number":49,"context_line":".com/openstack/rally/blob/be8cd7bff6de9b3e83dd31005ae5d07ca1c86b9e/rally"},{"line_number":50,"context_line":"/task/engine.py#L188-L278\u003e`_ should be removed from the engine (it used only"},{"line_number":51,"context_line":"in the api, so this is not the proper place) and would be moved under"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_dd40eca7","line":48,"updated":"2016-05-26 01:08:16.000000000","message":"Do not use word \"stuff\" in specs","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":50,"context_line":"/task/engine.py#L188-L278\u003e`_ should be removed from the engine (it used only"},{"line_number":51,"context_line":"in the api, so this is not the proper place) and would be moved under"},{"line_number":52,"context_line":"plugin base for the next suitable usage."},{"line_number":53,"context_line":"_validate_config_scenarios_name and _validate_config_syntax should be moved"},{"line_number":54,"context_line":"under common validators as they are not using any specific information"},{"line_number":55,"context_line":"except config. _validate_config_semantic should be moved under OpenStack"},{"line_number":56,"context_line":"related plugin base as it uses OpenStack deployment information."}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_9d094487","line":53,"updated":"2016-05-26 01:08:16.000000000","message":"not sure that I understand this explanation. and how it\u0027s different from what you telling above line 48.","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            \"\"\""},{"line_number":86,"context_line":"            Method used to validate something."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            :param cache: this is cross validator cache where we could"},{"line_number":89,"context_line":"                          store information about environment like"},{"line_number":90,"context_line":"                          initialized OpenStack clients, images etc and share"},{"line_number":91,"context_line":"                          it through validators"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_3d665851","line":88,"updated":"2016-05-26 01:08:16.000000000","message":"do not use \"we\"\n\nexplain the reason as well why someone would like to use cache (e.g. save time)","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            \"\"\""},{"line_number":86,"context_line":"            Method used to validate something."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            :param cache: this is cross validator cache where we could"},{"line_number":89,"context_line":"                          store information about environment like"},{"line_number":90,"context_line":"                          initialized OpenStack clients, images etc and share"},{"line_number":91,"context_line":"                          it through validators"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_0babb91e","line":88,"in_reply_to":"bab6814e_3d665851","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                          store information about environment like"},{"line_number":90,"context_line":"                          initialized OpenStack clients, images etc and share"},{"line_number":91,"context_line":"                          it through validators"},{"line_number":92,"context_line":"            :param deployment: Deployment object, used to manage with it"},{"line_number":93,"context_line":"            :param cfg: dict, with configuration of specified benchmark"},{"line_number":94,"context_line":"                        scenarios"},{"line_number":95,"context_line":"            :param plugin_cfg: dict, with configuration of specified plugin"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_1d7554f9","line":92,"updated":"2016-05-26 01:08:16.000000000","message":"\"used to manage with it\" ?  it\u0027s not complete sentence, please try better.","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                          store information about environment like"},{"line_number":90,"context_line":"                          initialized OpenStack clients, images etc and share"},{"line_number":91,"context_line":"                          it through validators"},{"line_number":92,"context_line":"            :param deployment: Deployment object, used to manage with it"},{"line_number":93,"context_line":"            :param cfg: dict, with configuration of specified benchmark"},{"line_number":94,"context_line":"                        scenarios"},{"line_number":95,"context_line":"            :param plugin_cfg: dict, with configuration of specified plugin"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_215d10ea","line":92,"in_reply_to":"bab6814e_1d7554f9","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def add(name, **kwargs):"},{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        Use this decorator to add the validator"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        :param name: str, name of the validator plugin"},{"line_number":105,"context_line":"        \"\"\""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_5d96bcf0","line":102,"updated":"2016-05-26 01:08:16.000000000","message":"to add validator where? what? how? why?","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def add(name, **kwargs):"},{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        Use this decorator to add the validator"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        :param name: str, name of the validator plugin"},{"line_number":105,"context_line":"        \"\"\""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_ab3c2d30","line":102,"in_reply_to":"bab6814e_5d96bcf0","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def validate(plugin, deployment, cfg, plugin_cfg):"},{"line_number":117,"context_line":"        \"\"\""},{"line_number":118,"context_line":"        Method used to collect all validators results."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        :param plugin: is plugin class instance that has validators and should"},{"line_number":121,"context_line":"                       be validated"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_fdf6905b","line":118,"updated":"2016-05-26 01:08:16.000000000","message":"Nope this is not method that collects all validators results \u003d( \n\nplease put normal description that describes the purpouse of this method","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def validate(plugin, deployment, cfg, plugin_cfg):"},{"line_number":117,"context_line":"        \"\"\""},{"line_number":118,"context_line":"        Method used to collect all validators results."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        :param plugin: is plugin class instance that has validators and should"},{"line_number":121,"context_line":"                       be validated"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_0b4a99c5","line":118,"in_reply_to":"bab6814e_fdf6905b","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        :param plugin: is plugin class instance that has validators and should"},{"line_number":121,"context_line":"                       be validated"},{"line_number":122,"context_line":"        :param deployment: Deployment object used to manage with it"},{"line_number":123,"context_line":"        :param cfg: dict, with configuration of specified benchmark"},{"line_number":124,"context_line":"                    scenarios"},{"line_number":125,"context_line":"        :param plugin_cfg: dict, with configuration of specified plugin"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_fddfb0d3","line":122,"updated":"2016-05-26 01:08:16.000000000","message":"unclear description try better","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        :param plugin: is plugin class instance that has validators and should"},{"line_number":121,"context_line":"                       be validated"},{"line_number":122,"context_line":"        :param deployment: Deployment object used to manage with it"},{"line_number":123,"context_line":"        :param cfg: dict, with configuration of specified benchmark"},{"line_number":124,"context_line":"                    scenarios"},{"line_number":125,"context_line":"        :param plugin_cfg: dict, with configuration of specified plugin"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_814b1c2b","line":122,"in_reply_to":"bab6814e_fddfb0d3","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        :param plugin: is plugin class instance that has validators and should"},{"line_number":121,"context_line":"                       be validated"},{"line_number":122,"context_line":"        :param deployment: Deployment object used to manage with it"},{"line_number":123,"context_line":"        :param cfg: dict, with configuration of specified benchmark"},{"line_number":124,"context_line":"                    scenarios"},{"line_number":125,"context_line":"        :param plugin_cfg: dict, with configuration of specified plugin"},{"line_number":126,"context_line":"        \"\"\""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_dddc6ce6","line":123,"updated":"2016-05-26 01:08:16.000000000","message":"no this is wrong, this is dict that contains subtask","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        :param plugin: is plugin class instance that has validators and should"},{"line_number":121,"context_line":"                       be validated"},{"line_number":122,"context_line":"        :param deployment: Deployment object used to manage with it"},{"line_number":123,"context_line":"        :param cfg: dict, with configuration of specified benchmark"},{"line_number":124,"context_line":"                    scenarios"},{"line_number":125,"context_line":"        :param plugin_cfg: dict, with configuration of specified plugin"},{"line_number":126,"context_line":"        \"\"\""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_6148b82e","line":123,"in_reply_to":"bab6814e_dddc6ce6","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            return results"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Such design allows us to validate in the same way against contexts(which"},{"line_number":140,"context_line":"was not possible before), scenarios, etc. For example, we could implement json"},{"line_number":141,"context_line":"schema validation as a plugin. And here is an advantages:"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_9db3049a","line":139,"updated":"2016-05-26 01:08:16.000000000","message":"This is not english. \n\nNew design allows us to use the same validator and same validation mechanism for different types of plugins (context, sla, runner, scenarios) which was not possible before.","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            return results"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Such design allows us to validate in the same way against contexts(which"},{"line_number":140,"context_line":"was not possible before), scenarios, etc. For example, we could implement json"},{"line_number":141,"context_line":"schema validation as a plugin. And here is an advantages:"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_816ddc34","line":139,"in_reply_to":"bab6814e_9db3049a","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            self.schema \u003d schema or {}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"},{"line_number":155,"context_line":"            jsonschema.validate(cfg, self.schema)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_5d64fc20","line":155,"updated":"2016-05-26 01:08:16.000000000","message":"this thing raises exceptions and wont\u0027 work in your code properly.","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            self.schema \u003d schema or {}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"},{"line_number":155,"context_line":"            jsonschema.validate(cfg, self.schema)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_2b179da4","line":155,"in_reply_to":"bab6814e_5d64fc20","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"- Create plugin base for all validator plugins."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"- Move validation stuff from the engine."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"- Move all validators under plugin base."},{"line_number":187,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_bd2368bc","line":184,"updated":"2016-05-26 01:08:16.000000000","message":"This is last step, not second. \n\nFirst you need: \n\n1) Create validation module with base plugin and method of adding validators \n\n2) Add support to task engine of new validation mechanism \n\n3) Port all old validators to new mechanism\n\n4) Deprecate old validation mechanism \n\n5) Remove it and old plugins in new release","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"- Create plugin base for all validator plugins."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"- Move validation stuff from the engine."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"- Move all validators under plugin base."},{"line_number":187,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_a1bbc00d","line":184,"in_reply_to":"bab6814e_bd2368bc","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"- Move validation stuff from the engine."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"- Move all validators under plugin base."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- Split them into OpenStack related and not."},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_7d14604c","line":186,"updated":"2016-05-26 01:08:16.000000000","message":"you are going to create new plugin validators and deprecate old","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"- Move validation stuff from the engine."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"- Move all validators under plugin base."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- Split them into OpenStack related and not."},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_01372cb1","line":186,"in_reply_to":"bab6814e_7d14604c","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"- Move all validators under plugin base."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- Split them into OpenStack related and not."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"- Create validators for contexts."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_5d199c87","line":188,"updated":"2016-05-26 01:08:16.000000000","message":"you won\u0027t split anything, you will just implement new validators in proper places","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"- Move all validators under plugin base."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- Split them into OpenStack related and not."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"- Create validators for contexts."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_e13b089b","line":188,"in_reply_to":"bab6814e_5d199c87","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"58c225e06dcdd1ff39ab7b8b031caafd9a5128cd","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- Split them into OpenStack related and not."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"- Create validators for contexts."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_1d2d54a8","line":190,"updated":"2016-05-26 01:08:16.000000000","message":"what?","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"17ccf3a374637cdc4fdcb4faa6e9c325c65c65c1","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- Split them into OpenStack related and not."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"- Create validators for contexts."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_4141340b","line":190,"in_reply_to":"bab6814e_1d2d54a8","updated":"2016-05-27 17:09:42.000000000","message":"Done","commit_id":"6098827d640df69aea95c638a4695cd4de54e9e6"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d28b4aa16b866b08cb7928e5bb5686c7e4793c92","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @configure(name\u003d\"base_validator\")"},{"line_number":73,"context_line":"    class Validator(plugin.Plugin):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"},{"line_number":76,"context_line":"            \"\"\""},{"line_number":77,"context_line":"            Method used to validate something."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"9abb7d3a_a777039e","line":75,"updated":"2016-05-30 14:45:01.000000000","message":"@abc.abstractmethod","commit_id":"90f52cff2cf1337d2ad5fa2dd6c56490737f171e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"717e193512c3c31bcb83c0a8b90f0a7bdd3a394e","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"},{"line_number":76,"context_line":"            \"\"\""},{"line_number":77,"context_line":"            Method used to validate something."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            :param cache: this is cross validator cache where different"},{"line_number":80,"context_line":"                          validators could store information about"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9abb7d3a_27c0337c","line":77,"updated":"2016-05-30 14:48:06.000000000","message":"\"used to \u003cdo_smth\u003e\" means something that happened in past","commit_id":"90f52cff2cf1337d2ad5fa2dd6c56490737f171e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"ad48b983e3f0fc261cc90408abd5c2096da71c2c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            \"\"\""},{"line_number":94,"context_line":"            pass"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def add(name, **kwargs):"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        Add validator instance to the validator plugin class meta."}],"source_content_type":"text/x-rst","patch_set":16,"id":"9abb7d3a_87f2bfd0","line":96,"updated":"2016-05-30 14:50:04.000000000","message":"one empty line between methods","commit_id":"90f52cff2cf1337d2ad5fa2dd6c56490737f171e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5905e551f557c7755000b76a8b05d421098fb71b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        return wrapper"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def validate(plugin, deployment, cfg, plugin_cfg):"},{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        Execute all validate() method of all validators stored in meta of"},{"line_number":123,"context_line":"        Validator."}],"source_content_type":"text/x-rst","patch_set":16,"id":"9abb7d3a_0736cf51","line":120,"updated":"2016-05-30 14:58:29.000000000","message":"This is just a recommendation:\n\n in OOP world it is common to use:\n\n  class Foo(object):\n    # @classmethod - optional\n    def do_smth_with_foo_instance(self):\n      \u003cdo smth with \u0027self\u0027\u003e\n\n instead of:\n\n  def do_smth_with_foo_instance(foo_inst):\n    \u003cdo smth with \u0027foo_inst\u0027\u003e\n\nI would not insist on changes, just point to this approach","commit_id":"90f52cff2cf1337d2ad5fa2dd6c56490737f171e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"888234a1238dbc6cd2b68b76e7a03762d256f0fc","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        for v in plugin._meta_get(\"validators_v2\"):"},{"line_number":140,"context_line":"            try:"},{"line_number":141,"context_line":"                results.append("},{"line_number":142,"context_line":"                    v.validate(cache, deployment, cfg, plugin_cfg) or"},{"line_number":143,"context_line":"                    validation.ValidationResult(True))"},{"line_number":144,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9abb7d3a_03740266","line":141,"updated":"2016-05-30 15:06:58.000000000","message":"It is not clear what Validator.validate() should return - there is no :returns: in Validator.validate docstring.\n\nIf Validator.validate is abstract method, it can return buggy value, so we probably should check type of return value","commit_id":"90f52cff2cf1337d2ad5fa2dd6c56490737f171e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"929fc407637ffb649d4e76137167a17f451e506f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            self.schema \u003d schema or {}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        def validate(self, cache, deployment, cfg, plugin_cfg):"},{"line_number":167,"context_line":"            jsonschema.validate(plugin_cfg, self.schema)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"9abb7d3a_c3b15ae3","line":167,"updated":"2016-05-30 15:10:54.000000000","message":"So, we simply make check and ensure that nothing wrong happens.\n\nReturn value is None, right? As for me, I would consider exception-based validation (not based on return values) is great, but why do we collect validation results on L141?","commit_id":"90f52cff2cf1337d2ad5fa2dd6c56490737f171e"}]}
