)]}'
{"doc/ext/plugin_reference.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"716783ac20dcf5df68e12d7551a5875c8ba3c2ec","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def make_plugin_section(plugin, base_name):"},{"line_number":82,"context_line":"    subcategory_obj \u003d subcategory(\"%s [%s]\" % (plugin.get_name(), base_name))"},{"line_number":83,"context_line":"    info \u003d plugin.get_info()"},{"line_number":84,"context_line":"    if info[\"title\"]:"},{"line_number":85,"context_line":"        subcategory_obj.append(paragraph(info[\"title\"]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_16430514","line":82,"updated":"2016-03-04 12:53:17.000000000","message":"This is much simpler to read:\n\n \"%s %s\" % (base_name.capitalize(), plugin.get_name())","commit_id":"2cf43a31ecb866337db4787d8b3c5334a700d7ad"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"664efff512ec915f235a019180a5ca8bbd9951c5","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def make_plugin_section(plugin, base_name):"},{"line_number":82,"context_line":"    subcategory_obj \u003d subcategory(\"%s [%s]\" % (plugin.get_name(), base_name))"},{"line_number":83,"context_line":"    info \u003d plugin.get_info()"},{"line_number":84,"context_line":"    if info[\"title\"]:"},{"line_number":85,"context_line":"        subcategory_obj.append(paragraph(info[\"title\"]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_9880e38c","line":82,"in_reply_to":"7af24918_16430514","updated":"2016-03-04 13:47:21.000000000","message":"I suppose this comment relates to L113 and comment from L113 relates to current line. :)\n\nNames of base sections(titles of Plugin group) will be fixed and names of plugins will not. Imo, they should contain name of plugin bases. It can be helpful, when you got a link to plugin which located in the center of the page in you don\u0027t know what plugin base it refers to.","commit_id":"2cf43a31ecb866337db4787d8b3c5334a700d7ad"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9934b7af1fd4399d4326cd411f6ef27a6401c109","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def make_plugin_section(plugin, base_name):"},{"line_number":82,"context_line":"    subcategory_obj \u003d subcategory(\"%s [%s]\" % (plugin.get_name(), base_name))"},{"line_number":83,"context_line":"    info \u003d plugin.get_info()"},{"line_number":84,"context_line":"    if info[\"title\"]:"},{"line_number":85,"context_line":"        subcategory_obj.append(paragraph(info[\"title\"]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_dea373b0","line":82,"in_reply_to":"7af24918_9880e38c","updated":"2016-03-04 13:48:35.000000000","message":"Ok","commit_id":"2cf43a31ecb866337db4787d8b3c5334a700d7ad"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"716783ac20dcf5df68e12d7551a5875c8ba3c2ec","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    if info[\"description\"]:"},{"line_number":88,"context_line":"        subcategory_obj.extend(parse_text("},{"line_number":89,"context_line":"                \"**Description**:\\n\\n%s\" % info[\"description\"]))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    if info[\"namespace\"]:"},{"line_number":92,"context_line":"        subcategory_obj.append(paragraph("}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_b6e69141","line":89,"updated":"2016-03-04 12:53:17.000000000","message":"Header \"Description\" looks redundant, I recommend to add description text as-is without this header","commit_id":"2cf43a31ecb866337db4787d8b3c5334a700d7ad"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"664efff512ec915f235a019180a5ca8bbd9951c5","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    if info[\"description\"]:"},{"line_number":88,"context_line":"        subcategory_obj.extend(parse_text("},{"line_number":89,"context_line":"                \"**Description**:\\n\\n%s\" % info[\"description\"]))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    if info[\"namespace\"]:"},{"line_number":92,"context_line":"        subcategory_obj.append(paragraph("}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_1b432d6d","line":89,"in_reply_to":"7af24918_b6e69141","updated":"2016-03-04 13:47:21.000000000","message":"Done","commit_id":"2cf43a31ecb866337db4787d8b3c5334a700d7ad"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"716783ac20dcf5df68e12d7551a5875c8ba3c2ec","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    for item in plugin_group[\"items\"]:"},{"line_number":112,"context_line":"        name \u003d item[\"name\"].title() if \"SLA\" !\u003d item[\"name\"] else item[\"name\"]"},{"line_number":113,"context_line":"        category_obj \u003d category(\"%ss [%s]\" % (name, plugin_group[\"group\"]))"},{"line_number":114,"context_line":"        elements.append(category_obj)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        module, cls \u003d item[\"base\"].split(\":\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_f6a3f9af","line":113,"updated":"2016-03-04 12:53:17.000000000","message":"plugin group is already displayed above as section header, so it is better to not repeat it, especially within the square brackets that looks confusing. I propose to get rid of plugin group here:\n\n category(\"%ss\" % name)\n\nAlso, there is an image with examples: http://postimg.org/image/isvdn9svz/","commit_id":"2cf43a31ecb866337db4787d8b3c5334a700d7ad"}]}
