)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4cdcbc6563afedb10b06e090a80194dcf03d027c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hkumarmk \u003chkumar@d4devops.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-08 12:12:09 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"networks context to support creating ports and fips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0c50b05ff01f04031520f03e06051e1067db06e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_dfa65f0f","line":7,"updated":"2016-03-08 19:29:42.000000000","message":"\"Modify network context to support ports and fips\". Also please add exact msg not only the title","commit_id":"4e170dcbbb5af72b5a74552cbb7567fd6adc9f41"}],"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e30dbcbe575b54b571f3cf74b3a3246360f8854e","unresolved":false,"context_lines":[{"line_number":414,"context_line":"      context:"},{"line_number":415,"context_line":"        network:"},{"line_number":416,"context_line":"          ports_per_network: 10"},{"line_number":417,"context_line":"          floating_ips_per_tenant: 1"},{"line_number":418,"context_line":"        users:"},{"line_number":419,"context_line":"          tenants: {{smoke or 3}}"},{"line_number":420,"context_line":"          users_per_tenant: {{smoke or 2}}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3afc51ec_72fdf239","line":417,"updated":"2016-03-12 23:25:30.000000000","message":"Please increase it to 2 to test whether multiple ips per tenant works or not.","commit_id":"d9318d83439774560f8d8ec02de01b7f0732ce18"}],"rally-jobs/rally.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e30dbcbe575b54b571f3cf74b3a3246360f8854e","unresolved":false,"context_lines":[{"line_number":954,"context_line":"          tenants: 3"},{"line_number":955,"context_line":"          users_per_tenant: 2"},{"line_number":956,"context_line":"        network:"},{"line_number":957,"context_line":"          floating_ips_per_tenant: 1"},{"line_number":958,"context_line":"      sla:"},{"line_number":959,"context_line":"        failure_rate:"},{"line_number":960,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3afc51ec_52fa7643","line":957,"updated":"2016-03-12 23:25:30.000000000","message":"Please increase it to 2 to test whether multiple ips per tenant works or not.","commit_id":"d9318d83439774560f8d8ec02de01b7f0732ce18"}],"rally/plugins/openstack/context/network/networks.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4cdcbc6563afedb10b06e090a80194dcf03d027c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    network_create_args\u003dself.config[\"network_create_args\"])"},{"line_number":93,"context_line":"                self.context[\"tenants\"][tenant_id][\"networks\"].append(network)"},{"line_number":94,"context_line":"                for port in range(self.config[\"ports_per_network\"]):"},{"line_number":95,"context_line":"                    net_wrapper.create_port(network[\"id\"])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            for i in range(self.config[\"floating_ips_per_tenant\"]):"},{"line_number":98,"context_line":"                fip \u003d net_wrapper.create_floating_ip(tenant_id\u003dtenant_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_bf2433af","line":95,"updated":"2016-03-08 19:29:42.000000000","message":"this is neutron specific method(it absent in neutron wrapper). So this will not work under nova-network https://github.com/openstack/rally/blob/master/rally/plugins/openstack/wrappers/network.py#L389","commit_id":"4e170dcbbb5af72b5a74552cbb7567fd6adc9f41"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e30dbcbe575b54b571f3cf74b3a3246360f8854e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    network_create_args\u003dself.config[\"network_create_args\"])"},{"line_number":93,"context_line":"                self.context[\"tenants\"][tenant_id][\"networks\"].append(network)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"                # Nova network doesnt have create_port"},{"line_number":96,"context_line":"                if hasattr(net_wrapper, \"create_port\"):"},{"line_number":97,"context_line":"                    for port in range(self.config[\"ports_per_network\"]):"},{"line_number":98,"context_line":"                        net_wrapper.create_port(network[\"id\"])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_fbb43df3","line":95,"updated":"2016-03-12 23:25:30.000000000","message":"Here should the format # NOTE(nick_name): bla-bla","commit_id":"d9318d83439774560f8d8ec02de01b7f0732ce18"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e30dbcbe575b54b571f3cf74b3a3246360f8854e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                # Nova network doesnt have create_port"},{"line_number":96,"context_line":"                if hasattr(net_wrapper, \"create_port\"):"},{"line_number":97,"context_line":"                    for port in range(self.config[\"ports_per_network\"]):"},{"line_number":98,"context_line":"                        net_wrapper.create_port(network[\"id\"])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            for i in range(self.config[\"floating_ips_per_tenant\"]):"},{"line_number":101,"context_line":"                fip \u003d net_wrapper.create_floating_ip(tenant_id\u003dtenant_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_9bbff9cf","line":98,"updated":"2016-03-12 23:25:30.000000000","message":"I think that we need to log warning if user can\u0027t create ports per tenant.","commit_id":"d9318d83439774560f8d8ec02de01b7f0732ce18"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e30dbcbe575b54b571f3cf74b3a3246360f8854e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                        _(\"Failed to delete network for tenant %s\")"},{"line_number":114,"context_line":"                        % tenant_id):"},{"line_number":115,"context_line":"                    net_wrapper.delete_network(network)"},{"line_number":116,"context_line":"            for fip in tenant_ctx.get(\"fips\", []):"},{"line_number":117,"context_line":"                with logging.ExceptionLogger("},{"line_number":118,"context_line":"                        LOG,"},{"line_number":119,"context_line":"                        _(\"Failed to delete floating ip for tenant %s\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_bbd3d537","line":116,"updated":"2016-03-12 23:25:30.000000000","message":"You need to delete fips through https://github.com/openstack/rally/blob/master/rally/plugins/openstack/cleanup/resources.py#L207 resources cleanup","commit_id":"d9318d83439774560f8d8ec02de01b7f0732ce18"}],"tests/unit/plugins/openstack/context/network/test_network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e30dbcbe575b54b571f3cf74b3a3246360f8854e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def test__init__default(self, mock_wrap, mock_clients):"},{"line_number":43,"context_line":"        context \u003d network_context.Network(self.get_context())"},{"line_number":44,"context_line":"        self.assertEqual(context.config[\"networks_per_tenant\"], 1)"},{"line_number":45,"context_line":"        self.assertEqual(context.config[\"ports_per_network\"], 0)"},{"line_number":46,"context_line":"        self.assertEqual(context.config[\"floating_ips_per_tenant\"], 0)"},{"line_number":47,"context_line":"        self.assertEqual(context.config[\"start_cidr\"],"},{"line_number":48,"context_line":"                         network_context.Network.DEFAULT_CONFIG[\"start_cidr\"])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_354cf441","line":45,"updated":"2016-03-12 23:25:30.000000000","message":"Please change the order of parameters in assertEqual functions that you\u0027ve added. The right order is (expected value, actual value)","commit_id":"d9318d83439774560f8d8ec02de01b7f0732ce18"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e30dbcbe575b54b571f3cf74b3a3246360f8854e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                     mock.call(tenant_id\u003d\"bar_tenant\")] * 2"},{"line_number":102,"context_line":"        actual_create_fip_calls \u003d ("},{"line_number":103,"context_line":"            mock_wrap.return_value.create_floating_ip.call_args_list)"},{"line_number":104,"context_line":"        self.assertSequenceEqual(sorted(expected_create_fip_calls),"},{"line_number":105,"context_line":"                                 sorted(actual_create_fip_calls))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        mock_utils.iterate_per_tenants.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_b2181a86","line":104,"updated":"2016-03-12 23:25:30.000000000","message":"This line fail at gate.","commit_id":"d9318d83439774560f8d8ec02de01b7f0732ce18"}]}
