)]}'
{"rally/plugins/common/scenarios/dummy/dummy.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"5ae56150eac4372de36da9dc833716438301db44","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @scenario.configure()"},{"line_number":188,"context_line":"    def dummy_random_atomic(self, atomics_num\u003d5, sleep_min\u003d0, sleep_max\u003d2):"},{"line_number":189,"context_line":"        \"\"\"Sleep random time in dummy atomic actions."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param atomics_num: int number of atomic actions to generate"},{"line_number":192,"context_line":"        :param sleep_min: minimal time to sleep, numeric seconds"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_b8d17b25","line":189,"updated":"2016-03-18 16:26:19.000000000","message":"\"Sleep random time between `sleep_min` and `sleep_max` seconds in dummy atomic action.\"\n\nWe need to say to users that here is not actually random time at all, but random from the interval.","commit_id":"cdfa7f9ffb474a07e0e6a4fbc1015b0dcfe8a7ce"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"445f99edf0fbfe96cfb9a9b02527722ab0c2baf2","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @scenario.configure()"},{"line_number":188,"context_line":"    def dummy_random_atomic(self, atomics_num\u003d5, sleep_min\u003d0, sleep_max\u003d2):"},{"line_number":189,"context_line":"        \"\"\"Sleep random time in dummy atomic actions."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param atomics_num: int number of atomic actions to generate"},{"line_number":192,"context_line":"        :param sleep_min: minimal time to sleep, numeric seconds"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_1b3d098f","line":189,"in_reply_to":"1af94dfe_b8d17b25","updated":"2016-03-18 16:40:53.000000000","message":"This can not be set because we have restrictions for docstrings - title should be on single line and have length less then 79 characters.\n\nI can add detailed explanation below in docstring, not in title line.","commit_id":"cdfa7f9ffb474a07e0e6a4fbc1015b0dcfe8a7ce"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"5ae56150eac4372de36da9dc833716438301db44","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        :param sleep_min: minimal time to sleep, numeric seconds"},{"line_number":193,"context_line":"        :param sleep_max: maximum time to sleep, numeric seconds"},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":"        min_ \u003d int(sleep_min * 1000)"},{"line_number":196,"context_line":"        max_ \u003d int(sleep_max * 1000)"},{"line_number":197,"context_line":"        for idx in range(atomics_num):"},{"line_number":198,"context_line":"            duration \u003d random.randint(min_, max_) * 0.001"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_58115703","line":195,"updated":"2016-03-18 16:26:19.000000000","message":"Why we use such a hack multiply by 1000 then divide by 1000? We could just to use here https://docs.python.org/2/library/random.html#random.uniform Why we so praying here on int type?","commit_id":"cdfa7f9ffb474a07e0e6a4fbc1015b0dcfe8a7ce"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"445f99edf0fbfe96cfb9a9b02527722ab0c2baf2","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        :param sleep_min: minimal time to sleep, numeric seconds"},{"line_number":193,"context_line":"        :param sleep_max: maximum time to sleep, numeric seconds"},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":"        min_ \u003d int(sleep_min * 1000)"},{"line_number":196,"context_line":"        max_ \u003d int(sleep_max * 1000)"},{"line_number":197,"context_line":"        for idx in range(atomics_num):"},{"line_number":198,"context_line":"            duration \u003d random.randint(min_, max_) * 0.001"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_bb233555","line":195,"in_reply_to":"1af94dfe_58115703","updated":"2016-03-18 16:40:53.000000000","message":"Good suggestion, thanks","commit_id":"cdfa7f9ffb474a07e0e6a4fbc1015b0dcfe8a7ce"}]}
