)]}'
{"rally/plugins/openstack/cleanup/resources.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b438f3bbc33a62d792d5374093177a446ea68eac","unresolved":false,"context_lines":[{"line_number":313,"context_line":"               tenant_resource\u003dTrue)"},{"line_number":314,"context_line":"class NeutronSecurityGroup(NeutronMixin):"},{"line_number":315,"context_line":"    def list(self):"},{"line_number":316,"context_line":"        resources \u003d self._resource + \"s\""},{"line_number":317,"context_line":"        list_method \u003d getattr(self._manager(), \"list_%s\" % resources)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        tenant_sgs \u003d filter(lambda r: r[\"tenant_id\"] \u003d\u003d self.tenant_uuid,"},{"line_number":320,"context_line":"                            list_method(tenant_id\u003dself.tenant_uuid)[resources])"},{"line_number":321,"context_line":"        # NOTE(pirsriva): Filter out \"default\" security group deletion"},{"line_number":322,"context_line":"        # by non-admin role user"},{"line_number":323,"context_line":"        if not (self.admin and self.admin_required):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_f76a13ec","line":320,"range":{"start_line":316,"start_character":8,"end_line":320,"end_character":79},"updated":"2016-03-23 18:25:36.000000000","message":"you can replace this code by `tenant_sgs \u003d super(NeutronSecurityGroup, self).list()`","commit_id":"cd5e8aa3b39e8c765be70948aeeac60702a0b2a3"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1c9c8e0ee8589c50246e27d2831bce14d585f9df","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        tenant_sgs \u003d super(NeutronSecurityGroup, self).list()"},{"line_number":317,"context_line":"        # NOTE(pirsriva): Filter out \"default\" security group deletion"},{"line_number":318,"context_line":"        # by non-admin role user"},{"line_number":319,"context_line":"        if not (self.admin and self.admin_required):"},{"line_number":320,"context_line":"            return filter(lambda r: r[\"name\"] !\u003d \"default\","},{"line_number":321,"context_line":"                          tenant_sgs)"},{"line_number":322,"context_line":"        return tenant_sgs"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_f0879db2","line":319,"updated":"2016-03-31 19:47:22.000000000","message":"So this is always false, I think what we need to do here is actually just\n\n   return filter(lambda r: r[\"name\"] !\u003d \"default\", \n                   super(NeutronSecurityGroup, self).list())","commit_id":"d5972648cbd6c82e435affd477c3ed66434f96c1"},{"author":{"_account_id":20196,"name":"Piyush","email":"piyush2011257@gmail.com","username":"pirsriva"},"change_message_id":"ce92816010069b636bcb340de8a1daa8f8aa4f9d","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        tenant_sgs \u003d super(NeutronSecurityGroup, self).list()"},{"line_number":317,"context_line":"        # NOTE(pirsriva): Filter out \"default\" security group deletion"},{"line_number":318,"context_line":"        # by non-admin role user"},{"line_number":319,"context_line":"        if not (self.admin and self.admin_required):"},{"line_number":320,"context_line":"            return filter(lambda r: r[\"name\"] !\u003d \"default\","},{"line_number":321,"context_line":"                          tenant_sgs)"},{"line_number":322,"context_line":"        return tenant_sgs"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_18b9882e","line":319,"in_reply_to":"ba0121b8_f0879db2","updated":"2016-04-01 05:44:18.000000000","message":"Yes you are right. I get the point. I did not glance through user context cleanup ( _remove_default_security_group() function ). Will make the required changes.","commit_id":"d5972648cbd6c82e435affd477c3ed66434f96c1"}]}