)]}'
{"doc/specs/in-progress/db_refactoring.rst":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e01a32214c1edb66766f2d15e8bfbb80b81a4208","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Task table"},{"line_number":120,"context_line":"~~~~~~~~~~"},{"line_number":121,"context_line":".. code-block::"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    id                      : INT, PK"},{"line_number":124,"context_line":"    uuid                    : UUID"}],"source_content_type":"text/x-rst","patch_set":47,"id":"bacf61ea_58e9b719","line":121,"updated":"2016-08-04 09:40:39.000000000","message":"empty line is required after ~~~~~~~~~~~~~~~","commit_id":"5e0dde3cea7db0e14ae5253a8a4a3357655dbf8e"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"3a926f6e4c33c7f8dc4b9f7eccee7f91b6a3ae22","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Task table"},{"line_number":120,"context_line":"~~~~~~~~~~"},{"line_number":121,"context_line":".. code-block::"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    id                      : INT, PK"},{"line_number":124,"context_line":"    uuid                    : UUID"}],"source_content_type":"text/x-rst","patch_set":47,"id":"bacf61ea_13fd603a","line":121,"in_reply_to":"bacf61ea_58e9b719","updated":"2016-08-04 10:07:40.000000000","message":"Done","commit_id":"5e0dde3cea7db0e14ae5253a8a4a3357655dbf8e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e01a32214c1edb66766f2d15e8bfbb80b81a4208","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Task.status diagram of states"},{"line_number":165,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":166,"context_line":".. code-block::"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    INIT -\u003e VALIDATING -\u003e VALIDATION_FAILED"},{"line_number":169,"context_line":"                       -\u003e ABORTING -\u003e ABORTED"}],"source_content_type":"text/x-rst","patch_set":47,"id":"bacf61ea_98f32f0a","line":166,"updated":"2016-08-04 09:40:39.000000000","message":"same here","commit_id":"5e0dde3cea7db0e14ae5253a8a4a3357655dbf8e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e01a32214c1edb66766f2d15e8bfbb80b81a4208","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Subtask table"},{"line_number":179,"context_line":"~~~~~~~~~~~~~"},{"line_number":180,"context_line":".. code-block::"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    id                      : INT, PK"},{"line_number":183,"context_line":"    uuid                    : UUID"}],"source_content_type":"text/x-rst","patch_set":47,"id":"bacf61ea_d8af67e1","line":180,"updated":"2016-08-04 09:40:39.000000000","message":"same here","commit_id":"5e0dde3cea7db0e14ae5253a8a4a3357655dbf8e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e01a32214c1edb66766f2d15e8bfbb80b81a4208","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Workload table"},{"line_number":206,"context_line":"~~~~~~~~~~~~~~"},{"line_number":207,"context_line":".. code-block::"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    id                      : INT, PK"},{"line_number":210,"context_line":"    uuid                    : UUID"}],"source_content_type":"text/x-rst","patch_set":47,"id":"bacf61ea_18ba9f23","line":207,"updated":"2016-08-04 09:40:39.000000000","message":"same here","commit_id":"5e0dde3cea7db0e14ae5253a8a4a3357655dbf8e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e01a32214c1edb66766f2d15e8bfbb80b81a4208","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"WorkloadData"},{"line_number":296,"context_line":"~~~~~~~~~~~~"},{"line_number":297,"context_line":".. code-block::"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    id                      : INT, PK"},{"line_number":300,"context_line":"    uuid                    : UUID"}],"source_content_type":"text/x-rst","patch_set":47,"id":"bacf61ea_f8b4eb35","line":297,"updated":"2016-08-04 09:40:39.000000000","message":"same here","commit_id":"5e0dde3cea7db0e14ae5253a8a4a3357655dbf8e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e01a32214c1edb66766f2d15e8bfbb80b81a4208","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"Tag table"},{"line_number":341,"context_line":"~~~~~~~~~"},{"line_number":342,"context_line":".. code-block::"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    id                      : INT, PK"},{"line_number":345,"context_line":"    uuid                    : UUID of task or subtask"}],"source_content_type":"text/x-rst","patch_set":47,"id":"bacf61ea_987ccf73","line":342,"updated":"2016-08-04 09:40:39.000000000","message":"same here","commit_id":"5e0dde3cea7db0e14ae5253a8a4a3357655dbf8e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1dd08db952243fce3277c7926e6111e52b1d2e6e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    |        |  |"},{"line_number":91,"context_line":"    |  id    |  |"},{"line_number":92,"context_line":"    |  uuid -+--+"},{"line_number":93,"context_line":"    |  kind  |"},{"line_number":94,"context_line":"    |  tag   |"},{"line_number":95,"context_line":"    +--------+"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":73,"id":"9a629dbe_6b99adc3","line":93,"updated":"2016-11-11 15:05:35.000000000","message":"This is actually not a problem to have DB field name `type\u0027, this does not affect built-in type \u0027type\u0027 name in any scope.\n\nI would prefer to use \u0027type\u0027 instead of \u0027kind\u0027 in this case","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"cbfd734471bb7fbc45b5b040c264978767f5ba19","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    |        |  |"},{"line_number":91,"context_line":"    |  id    |  |"},{"line_number":92,"context_line":"    |  uuid -+--+"},{"line_number":93,"context_line":"    |  kind  |"},{"line_number":94,"context_line":"    |  tag   |"},{"line_number":95,"context_line":"    +--------+"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":73,"id":"7a77a97e_8ce14d9d","line":93,"in_reply_to":"9a629dbe_6b99adc3","updated":"2016-11-16 09:45:16.000000000","message":"Done","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1dd08db952243fce3277c7926e6111e52b1d2e6e","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    id                      : INT, PK"},{"line_number":351,"context_line":"    uuid                    : UUID of task or subtask"},{"line_number":352,"context_line":"    kind                    : ENUM(task, subtask)"},{"line_number":353,"context_line":"    tag                     : TEXT"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"- (uuid, type, tag) is unique and indexed"}],"source_content_type":"text/x-rst","patch_set":73,"id":"9a629dbe_ebebfd10","line":352,"updated":"2016-11-11 15:05:35.000000000","message":"same here","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"cbfd734471bb7fbc45b5b040c264978767f5ba19","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    id                      : INT, PK"},{"line_number":351,"context_line":"    uuid                    : UUID of task or subtask"},{"line_number":352,"context_line":"    kind                    : ENUM(task, subtask)"},{"line_number":353,"context_line":"    tag                     : TEXT"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"- (uuid, type, tag) is unique and indexed"}],"source_content_type":"text/x-rst","patch_set":73,"id":"7a77a97e_acee0989","line":352,"in_reply_to":"9a629dbe_ebebfd10","updated":"2016-11-16 09:45:16.000000000","message":"Done","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1dd08db952243fce3277c7926e6111e52b1d2e6e","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"Open questions"},{"line_number":359,"context_line":"~~~~~~~~~~~~~~"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"Alternatives"},{"line_number":362,"context_line":"------------"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-rst","patch_set":73,"id":"9a629dbe_cb1479ea","line":360,"updated":"2016-11-11 15:05:35.000000000","message":"I would recommend to put \u0027None\u0027 here as dummy content","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"cbfd734471bb7fbc45b5b040c264978767f5ba19","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"Open questions"},{"line_number":359,"context_line":"~~~~~~~~~~~~~~"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"Alternatives"},{"line_number":362,"context_line":"------------"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-rst","patch_set":73,"id":"7a77a97e_8cf86d4b","line":360,"in_reply_to":"9a629dbe_cb1479ea","updated":"2016-11-16 09:45:16.000000000","message":"Done","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"change_message_id":"adb75341afda925079f1d566b660bdf097c56641","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    |  id        |    |  id         |"},{"line_number":58,"context_line":"    |  uuid   \u003c--+----+- task_uuid  |"},{"line_number":59,"context_line":"    |   ^        |    |             |"},{"line_number":60,"context_line":"    +---+--------+    +-------------+"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Task - stores task status, tags, validation log"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":77,"id":"5a74a57a_585e4b46","line":60,"updated":"2016-11-23 11:22:24.000000000","message":"Maybe you want to remove the bits remaining for the arrow that points below UUID","commit_id":"24a7a0bae8056696817fcee33fe80a8b1579a895"}],"rally/common/db/sqlalchemy/api.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9c4a6290b41044d3d6f1850d92421067f0bfda33","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def _task_get_result_data(self, uuid, id):"},{"line_number":225,"context_line":"        task_result_data \u003d (self.model_query(models.TaskResultData)."},{"line_number":226,"context_line":"                            filter_by(task_uuid\u003duuid, id\u003did).all())"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        data \u003d []"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_f1cd5ab8","line":226,"updated":"2016-04-13 10:13:38.000000000","message":"id is PK so there will be single result (or no result), so \"all()\" is not required\n\nAlso, do we need UUID? PK `id\u0027 already identifies the resource","commit_id":"755cc6e6f83fb0af3717d36ccd445e25be46e412"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e81c29ed46b4e5235a3fa624372619a3cf2f8b42","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def _task_get_result_data(self, uuid, id):"},{"line_number":225,"context_line":"        task_result_data \u003d (self.model_query(models.TaskResultData)."},{"line_number":226,"context_line":"                            filter_by(task_uuid\u003duuid, id\u003did).all())"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        data \u003d []"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_d4e92c1c","line":226,"in_reply_to":"5a18252c_1113b667","updated":"2016-04-13 10:27:36.000000000","message":"This seems to be correct:\n\n  filter_by(task_result_id\u003did)\n\n\nAlso, all() is redundant (we already have filter() which returns a collection)","commit_id":"755cc6e6f83fb0af3717d36ccd445e25be46e412"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"887c4a7215da9e1ab268b89babf406f9a63c85c3","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def _task_get_result_data(self, uuid, id):"},{"line_number":225,"context_line":"        task_result_data \u003d (self.model_query(models.TaskResultData)."},{"line_number":226,"context_line":"                            filter_by(task_uuid\u003duuid, id\u003did).all())"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        data \u003d []"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_1113b667","line":226,"in_reply_to":"5a18252c_f1cd5ab8","updated":"2016-04-13 10:24:37.000000000","message":"Maybe filter by task_uuid\u003duui only?","commit_id":"755cc6e6f83fb0af3717d36ccd445e25be46e412"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9c4a6290b41044d3d6f1850d92421067f0bfda33","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        data \u003d []"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        for d in task_result_data:"},{"line_number":231,"context_line":"            if d.data:"},{"line_number":232,"context_line":"                data.extend(d.data.get(\"raw\", []))"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_514c0e42","line":230,"updated":"2016-04-13 10:13:38.000000000","message":"As mentioned above, \"task_result_data\" is single result","commit_id":"755cc6e6f83fb0af3717d36ccd445e25be46e412"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e81c29ed46b4e5235a3fa624372619a3cf2f8b42","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        data \u003d []"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        for d in task_result_data:"},{"line_number":231,"context_line":"            if d.data:"},{"line_number":232,"context_line":"                data.extend(d.data.get(\"raw\", []))"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_945694d0","line":230,"in_reply_to":"5a18252c_514c0e42","updated":"2016-04-13 10:27:36.000000000","message":"My comments above are corrected","commit_id":"755cc6e6f83fb0af3717d36ccd445e25be46e412"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9ebfd4c69f7f3d3eab675f5252e73f402e1750f6","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        })"},{"line_number":342,"context_line":"        result.save()"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        result_data \u003d models.TaskResultData()"},{"line_number":345,"context_line":"        result_data.update({"},{"line_number":346,"context_line":"            \"task_uuid\": task_uuid,"},{"line_number":347,"context_line":"            \"task_result_id\": result.id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_3fb03943","line":344,"updated":"2016-04-13 10:40:41.000000000","message":"Why not add data in initialization:\n\n result_data \u003d models.TaskResultData(\n    task_uuid\u003dtask_uuid,\n    task_result_id\u003dresult.id,\n    data\u003d{\"raw\": data.get(\"raw\", [])})","commit_id":"755cc6e6f83fb0af3717d36ccd445e25be46e412"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"73ef6ff7e680eb00465baa78b3b6e8bbbb78ebd0","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        return (self.model_query(models.Subtask)."},{"line_number":260,"context_line":"                filter_by(task_uuid\u003dtask_uuid).first()).uuid"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    # @db_api.serialize"},{"line_number":263,"context_line":"    def task_get(self, uuid):"},{"line_number":264,"context_line":"        task \u003d self._task_get(uuid)"},{"line_number":265,"context_line":"        return self._make_old_task(task)"}],"source_content_type":"text/x-python","patch_set":46,"id":"bacf61ea_ea824a93","line":262,"range":{"start_line":262,"start_character":4,"end_line":262,"end_character":6},"updated":"2016-07-29 15:15:26.000000000","message":"why @db_api.serialize is commented in many places across this file?)","commit_id":"7f983063604641e5117709a70a4e2d0b7b8173e2"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"832a81f4ddfdf711b99dba5c6cb1087f379083b9","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        return (self.model_query(models.Subtask)."},{"line_number":260,"context_line":"                filter_by(task_uuid\u003dtask_uuid).first()).uuid"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    # @db_api.serialize"},{"line_number":263,"context_line":"    def task_get(self, uuid):"},{"line_number":264,"context_line":"        task \u003d self._task_get(uuid)"},{"line_number":265,"context_line":"        return self._make_old_task(task)"}],"source_content_type":"text/x-python","patch_set":46,"id":"bacf61ea_6cfeba06","line":262,"range":{"start_line":262,"start_character":4,"end_line":262,"end_character":6},"in_reply_to":"bacf61ea_717851f9","updated":"2016-08-03 11:16:15.000000000","message":"Well, it\u0027s still used in other places, and there will be more once we fully embrace new DB model","commit_id":"7f983063604641e5117709a70a4e2d0b7b8173e2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9e64897eee9ecda396229e91a20c395fc582171c","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        return (self.model_query(models.Subtask)."},{"line_number":260,"context_line":"                filter_by(task_uuid\u003dtask_uuid).first()).uuid"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    # @db_api.serialize"},{"line_number":263,"context_line":"    def task_get(self, uuid):"},{"line_number":264,"context_line":"        task \u003d self._task_get(uuid)"},{"line_number":265,"context_line":"        return self._make_old_task(task)"}],"source_content_type":"text/x-python","patch_set":46,"id":"bacf61ea_717851f9","line":262,"range":{"start_line":262,"start_character":4,"end_line":262,"end_character":6},"in_reply_to":"bacf61ea_d19f7d4e","updated":"2016-08-03 11:11:26.000000000","message":"so let\u0027s remove this decorator at all:)","commit_id":"7f983063604641e5117709a70a4e2d0b7b8173e2"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"4da9e666787feee52a1dcde0307251c82d917d4e","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        return (self.model_query(models.Subtask)."},{"line_number":260,"context_line":"                filter_by(task_uuid\u003dtask_uuid).first()).uuid"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    # @db_api.serialize"},{"line_number":263,"context_line":"    def task_get(self, uuid):"},{"line_number":264,"context_line":"        task \u003d self._task_get(uuid)"},{"line_number":265,"context_line":"        return self._make_old_task(task)"}],"source_content_type":"text/x-python","patch_set":46,"id":"bacf61ea_d19f7d4e","line":262,"range":{"start_line":262,"start_character":4,"end_line":262,"end_character":6},"in_reply_to":"bacf61ea_ea824a93","updated":"2016-08-03 11:06:58.000000000","message":"Because current implementation already returns dicts -- no need for dict-arizing it once again","commit_id":"7f983063604641e5117709a70a4e2d0b7b8173e2"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"09e1b1174642347b2c1408517856424ff727d5a1","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            }"},{"line_number":254,"context_line":"        }"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    # (ikhudoshyn): we assume there is only one subtask"},{"line_number":257,"context_line":"    # until we fully embrace new task format"},{"line_number":258,"context_line":"    def _get_subtask_uuid(self, task_uuid):"},{"line_number":259,"context_line":"        return (self.model_query(models.Subtask)."}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_4fb09a43","line":256,"updated":"2016-08-05 07:37:04.000000000","message":"This looks for me very strange. \n\nEven in old format single task contained a lot of subtasks (they were called different, however it was there) \n\nSo this phrase seems wrong.","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"f2bb2afc48d2eeff8d8b89ec9c174b202e7786ff","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            }"},{"line_number":254,"context_line":"        }"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    # (ikhudoshyn): we assume there is only one subtask"},{"line_number":257,"context_line":"    # until we fully embrace new task format"},{"line_number":258,"context_line":"    def _get_subtask_uuid(self, task_uuid):"},{"line_number":259,"context_line":"        return (self.model_query(models.Subtask)."}],"source_content_type":"text/x-python","patch_set":48,"id":"9ad45d7e_7a852e58","line":256,"in_reply_to":"bacf61ea_4fb09a43","updated":"2016-08-11 16:14:36.000000000","message":"Done","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"09e1b1174642347b2c1408517856424ff727d5a1","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    # @db_api.serialize"},{"line_number":403,"context_line":"    def task_result_create(self, task_uuid, key, data):"},{"line_number":404,"context_line":"        subtask_uuid \u003d self._get_subtask_uuid(task_uuid)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        raw_data \u003d data.get(\"raw\", [])"},{"line_number":407,"context_line":"        iter_count \u003d len(raw_data)"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_6ffd9eb0","line":404,"updated":"2016-08-05 07:37:04.000000000","message":"I do not understand this at all. \n\nwhen you are creating results you are creating: \n\nsubtask inside this subtask you are creating workload and workloaddata. In current format and current engine (we can\u0027t use abbility to have many workloads and workloads data per subtask)","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"f2bb2afc48d2eeff8d8b89ec9c174b202e7786ff","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    # @db_api.serialize"},{"line_number":403,"context_line":"    def task_result_create(self, task_uuid, key, data):"},{"line_number":404,"context_line":"        subtask_uuid \u003d self._get_subtask_uuid(task_uuid)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        raw_data \u003d data.get(\"raw\", [])"},{"line_number":407,"context_line":"        iter_count \u003d len(raw_data)"}],"source_content_type":"text/x-python","patch_set":48,"id":"9ad45d7e_baa4c607","line":404,"in_reply_to":"bacf61ea_6ffd9eb0","updated":"2016-08-11 16:14:36.000000000","message":"Done","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e8d314d9c31256f2e25577204126a93595d767a2","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _tags_get(self, uuid, type):"},{"line_number":202,"context_line":"        tags \u003d (self.model_query(models.Tag)."},{"line_number":203,"context_line":"                filter_by(uuid\u003duuid, type\u003dtype).all())"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        return list(set(t.tag for t in tags))"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":51,"id":"fa7ab95a_fa47b448","line":203,"updated":"2016-08-29 09:20:37.000000000","message":"type is keyword it\u0027s bad to use it.","commit_id":"d024b33c3efc30e829ad32694ab424e160a24673"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"226315fa5f1c5d85b62275444150fa0e9c2e1add","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            \"created_at\": task.created_at,"},{"line_number":227,"context_line":"            \"updated_at\": task.updated_at,"},{"line_number":228,"context_line":"            \"tag\": tag,"},{"line_number":229,"context_line":"            \"verification_log\": \"\""},{"line_number":230,"context_line":"        }"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _make_old_task_result(self, workload, workload_data):"}],"source_content_type":"text/x-python","patch_set":51,"id":"fa7ab95a_3a64bc47","line":229,"updated":"2016-08-29 09:25:45.000000000","message":"Actually this is a bug. It should not be empty. I know it is ugly but it was used in case of errors to store logs.","commit_id":"d024b33c3efc30e829ad32694ab424e160a24673"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"83ef59b3c59baf6130582302e3f5eddb1839b43c","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _tags_get(self, uuid, type):"},{"line_number":202,"context_line":"        tags \u003d (self.model_query(models.Tag)."},{"line_number":203,"context_line":"                filter_by(uuid\u003duuid, type\u003dtype).all())"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        return list(set(t.tag for t in tags))"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"9a89bdaa_aee7fe10","line":203,"updated":"2016-09-05 10:34:44.000000000","message":"There is a @boris-42 comment regarding `type\u0027 argument at patch set 51 - this is still not fixed","commit_id":"42492c6c26123380cbba8cb58651e3a7edff850e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"66c5bdeee3c940f73c5314920e161f2dd92193a2","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _tags_get(self, uuid, type):"},{"line_number":202,"context_line":"        tags \u003d (self.model_query(models.Tag)."},{"line_number":203,"context_line":"                filter_by(uuid\u003duuid, type\u003dtype).all())"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        return list(set(t.tag for t in tags))"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"9a89bdaa_654d0772","line":203,"in_reply_to":"9a89bdaa_aee7fe10","updated":"2016-09-05 15:14:16.000000000","message":"This is the name taken from initial model. As the other name wasn\u0027t suggested I have left this one. I don\u0027t have any better variant","commit_id":"42492c6c26123380cbba8cb58651e3a7edff850e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1dd08db952243fce3277c7926e6111e52b1d2e6e","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        if filters:"},{"line_number":354,"context_line":"            query \u003d query.filter_by(**filters)"},{"line_number":355,"context_line":"        all \u003d query.all()"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        return [self._make_old_task(task) for task in all]"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":73,"id":"9a629dbe_311f245c","line":355,"updated":"2016-11-11 15:05:35.000000000","message":"this clashes with built-in function \u0027all\u0027","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"cbfd734471bb7fbc45b5b040c264978767f5ba19","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        if filters:"},{"line_number":354,"context_line":"            query \u003d query.filter_by(**filters)"},{"line_number":355,"context_line":"        all \u003d query.all()"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        return [self._make_old_task(task) for task in all]"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":73,"id":"7a77a97e_ecb64189","line":355,"in_reply_to":"9a629dbe_311f245c","updated":"2016-11-16 09:45:16.000000000","message":"Done","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1dd08db952243fce3277c7926e6111e52b1d2e6e","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        return results"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    # @db_api.serialize"},{"line_number":501,"context_line":"    def task_result_get_all_by_uuid(self, uuid):"},{"line_number":502,"context_line":"        return self._task_result_get_all_by_uuid(uuid)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def _deployment_get(self, deployment, session\u003dNone):"}],"source_content_type":"text/x-python","patch_set":73,"id":"9a629dbe_4b5ce97c","line":501,"updated":"2016-11-11 15:05:35.000000000","message":"Why there are 2 methods if last one simply calls first one?\n\n _task_result_get_all_by_uuid()\n task_result_get_all_by_uuid()","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"16caf8788dc14dec6f855b2d53f8b3f86d53fee3","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        return results"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    # @db_api.serialize"},{"line_number":501,"context_line":"    def task_result_get_all_by_uuid(self, uuid):"},{"line_number":502,"context_line":"        return self._task_result_get_all_by_uuid(uuid)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def _deployment_get(self, deployment, session\u003dNone):"}],"source_content_type":"text/x-python","patch_set":73,"id":"7a77a97e_bae4a20d","line":501,"in_reply_to":"9a629dbe_4b5ce97c","updated":"2016-11-15 14:27:09.000000000","message":"It is used more than 1 time.\nin task_get_detailed and task_get_detailed_last","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"}],"rally/common/db/sqlalchemy/migrations/versions/6ad4f426f005_add_hooks_to_task_result.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5023691a0c66052a613c28fa3dae6e3f58693dfc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"task_results\","},{"line_number":40,"context_line":"    sa.MetaData(),"},{"line_number":41,"context_line":"    sa.Column(\"id\", sa.Integer(), nullable\u003dFalse),"},{"line_number":42,"context_line":"    sa.Column(\"data\", sa_types.MutableJSONEncodedDict(), nullable\u003dFalse),"},{"line_number":43,"context_line":")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":77,"id":"5a74a57a_986c639e","line":42,"updated":"2016-11-23 11:07:00.000000000","message":"Why it was changed?","commit_id":"24a7a0bae8056696817fcee33fe80a8b1579a895"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"971385e7f14d6c7752063535af315abbf2e9feb7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"task_results\","},{"line_number":40,"context_line":"    sa.MetaData(),"},{"line_number":41,"context_line":"    sa.Column(\"id\", sa.Integer(), nullable\u003dFalse),"},{"line_number":42,"context_line":"    sa.Column(\"data\", sa_types.MutableJSONEncodedDict(), nullable\u003dFalse),"},{"line_number":43,"context_line":")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":77,"id":"5a74a57a_385fcf73","line":42,"in_reply_to":"5a74a57a_986c639e","updated":"2016-11-23 11:14:45.000000000","message":"because BigMutableJSONEncodedDict was renamed, but logically it represents the same type.","commit_id":"24a7a0bae8056696817fcee33fe80a8b1579a895"}],"rally/common/db/sqlalchemy/migrations/versions/ca3626f62937_init_migration.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5023691a0c66052a613c28fa3dae6e3f58693dfc","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            nullable\u003dFalse),"},{"line_number":180,"context_line":"        sa.Column("},{"line_number":181,"context_line":"            \"data\","},{"line_number":182,"context_line":"            rally.common.db.sqlalchemy.types.MutableJSONEncodedDict(),"},{"line_number":183,"context_line":"            nullable\u003dFalse),"},{"line_number":184,"context_line":"        sa.Column(\"task_uuid\", sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":185,"context_line":"        sa.ForeignKeyConstraint([\"task_uuid\"], [\"tasks.uuid\"], ),"}],"source_content_type":"text/x-python","patch_set":77,"id":"5a74a57a_781dc70e","line":182,"updated":"2016-11-23 11:07:00.000000000","message":"same question here","commit_id":"24a7a0bae8056696817fcee33fe80a8b1579a895"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5023691a0c66052a613c28fa3dae6e3f58693dfc","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        sa.Column(\"verification_uuid\", sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":195,"context_line":"        sa.Column("},{"line_number":196,"context_line":"            \"data\","},{"line_number":197,"context_line":"            rally.common.db.sqlalchemy.types.MutableJSONEncodedDict(),"},{"line_number":198,"context_line":"            nullable\u003dFalse),"},{"line_number":199,"context_line":"        sa.ForeignKeyConstraint([\"verification_uuid\"], [\"verifications.uuid\"]),"},{"line_number":200,"context_line":"        sa.PrimaryKeyConstraint(\"id\")"}],"source_content_type":"text/x-python","patch_set":77,"id":"5a74a57a_d8d25b34","line":197,"updated":"2016-11-23 11:07:00.000000000","message":"and here","commit_id":"24a7a0bae8056696817fcee33fe80a8b1579a895"}],"rally/common/db/sqlalchemy/migrations/versions/e654a0648db0_refactor_task_results.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6450188975101f050ef6115382374b0abfa97125","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"init\", \"paused\", \"running\", \"setting up\", \"soft_aborting\","},{"line_number":49,"context_line":"        \"verifying\", name\u003d\"enum_tasks_status\"), nullable\u003dFalse),"},{"line_number":50,"context_line":"    sa.Column(\"verification_log\", sa.Text(), nullable\u003dTrue),"},{"line_number":51,"context_line":"    sa.Column(\"tag\", sa.String(length\u003d64), nullable\u003dTrue),"},{"line_number":52,"context_line":"    sa.Column(\"deployment_uuid\", sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":53,"context_line":"    sa.Column(\"title\", sa.String(length\u003d64), default\u003d\"\"),"},{"line_number":54,"context_line":"    sa.Column(\"description\", sa.Text(), default\u003d\"\"),"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_dbe0fe98","line":51,"updated":"2016-08-04 11:04:25.000000000","message":"Does this mean that task can have only one tag associated?","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"9bf2a5f9289a327b6e405ad707f2be64f0f04d91","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"init\", \"paused\", \"running\", \"setting up\", \"soft_aborting\","},{"line_number":49,"context_line":"        \"verifying\", name\u003d\"enum_tasks_status\"), nullable\u003dFalse),"},{"line_number":50,"context_line":"    sa.Column(\"verification_log\", sa.Text(), nullable\u003dTrue),"},{"line_number":51,"context_line":"    sa.Column(\"tag\", sa.String(length\u003d64), nullable\u003dTrue),"},{"line_number":52,"context_line":"    sa.Column(\"deployment_uuid\", sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":53,"context_line":"    sa.Column(\"title\", sa.String(length\u003d64), default\u003d\"\"),"},{"line_number":54,"context_line":"    sa.Column(\"description\", sa.Text(), default\u003d\"\"),"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_27377400","line":51,"in_reply_to":"bacf61ea_dbe0fe98","updated":"2016-08-04 14:21:06.000000000","message":"This helper contains fields for both old and new schema.\n\u0027tag\u0027 attribute goes from old one.\nThere is no explicit relation to tags table because this relation is more complex then sql allows and it is supported programatically by python code.","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6450188975101f050ef6115382374b0abfa97125","unresolved":false,"context_lines":[{"line_number":102,"context_line":"def upgrade():"},{"line_number":103,"context_line":"    conn \u003d op.get_bind()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    subtask_table \u003d op.create_table("},{"line_number":106,"context_line":"        \"subtasks\","},{"line_number":107,"context_line":"        sa.Column(\"created_at\", sa.DateTime()),"},{"line_number":108,"context_line":"        sa.Column(\"updated_at\", sa.DateTime()),"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_5b47ee76","line":105,"updated":"2016-08-04 11:04:25.000000000","message":"Where is relation to tags?","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"9bf2a5f9289a327b6e405ad707f2be64f0f04d91","unresolved":false,"context_lines":[{"line_number":102,"context_line":"def upgrade():"},{"line_number":103,"context_line":"    conn \u003d op.get_bind()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    subtask_table \u003d op.create_table("},{"line_number":106,"context_line":"        \"subtasks\","},{"line_number":107,"context_line":"        sa.Column(\"created_at\", sa.DateTime()),"},{"line_number":108,"context_line":"        sa.Column(\"updated_at\", sa.DateTime()),"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_a72364bc","line":105,"in_reply_to":"bacf61ea_5b47ee76","updated":"2016-08-04 14:21:06.000000000","message":"See above","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"9b1d292623be1e2ad197f732348a6cdf76b41c01","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        conn.execute("},{"line_number":456,"context_line":"            taskhelper.update(),"},{"line_number":457,"context_line":"            {"},{"line_number":458,"context_line":"                \"validation_result\": task.verification_log"},{"line_number":459,"context_line":"            }"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"7a8ec9b2_dd0632cd","line":458,"range":{"start_line":458,"start_character":42,"end_line":458,"end_character":58},"updated":"2016-09-16 15:10:25.000000000","message":"here would be a bug. verification_log is of type \u0027string\u0027, but validation_result expects a dict","commit_id":"643a31c177f99ddffc8e7e62cebdc6a06b3d913d"}],"rally/common/db/sqlalchemy/models.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"77d990966d489043477172a6ed1ae35d3c80a5a1","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    id \u003d sa.Column(sa.Integer, primary_key\u003dTrue, autoincrement\u003dTrue)"},{"line_number":246,"context_line":"    uuid \u003d sa.Column(sa.String(36), default\u003dUUID, nullable\u003dFalse)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    task_uuid \u003d sa.Column("},{"line_number":249,"context_line":"        sa.String(36),"},{"line_number":250,"context_line":"        sa.ForeignKey(Task.uuid),"},{"line_number":251,"context_line":"        nullable\u003dFalse,"},{"line_number":252,"context_line":"    )"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    task \u003d sa.orm.relationship("},{"line_number":255,"context_line":"        Task,"},{"line_number":256,"context_line":"        backref\u003dsa.orm.backref(\"workloads\"),"},{"line_number":257,"context_line":"        foreign_keys\u003dtask_uuid,"},{"line_number":258,"context_line":"        primaryjoin\u003d(task_uuid \u003d\u003d Task.uuid),"},{"line_number":259,"context_line":"    )"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    subtask_uuid \u003d sa.Column("},{"line_number":262,"context_line":"        sa.String(36),"}],"source_content_type":"text/x-python","patch_set":45,"id":"dada55a8_787d3f6c","line":259,"range":{"start_line":248,"start_character":4,"end_line":259,"end_character":5},"updated":"2016-07-27 11:51:15.000000000","message":"not sure that we need relations with task. subtask should be enough.","commit_id":"faade6b1b9c747a81357aac5224f947f780d073c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"061b8cfff49534ebce21db856afcf9b8541e7f8f","unresolved":false,"context_lines":[{"line_number":197,"context_line":"class Subtask(BASE, RallyBase):"},{"line_number":198,"context_line":"    __tablename__ \u003d \"subtasks\""},{"line_number":199,"context_line":"    __table_args__ \u003d ("},{"line_number":200,"context_line":"        sa.Index(\"subtask_uuid\", \"uuid\", unique\u003dTrue),"},{"line_number":201,"context_line":"        sa.Index(\"subtask_status\", \"status\"),"},{"line_number":202,"context_line":"    )"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_5901b669","line":200,"updated":"2016-08-04 11:38:34.000000000","message":"This is not clear for me. `uuid\u0027 must be already unique, right? (I mean probably missing `unique\u003dTrue, index\u003dTrue\u0027 at L205)","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"9bf2a5f9289a327b6e405ad707f2be64f0f04d91","unresolved":false,"context_lines":[{"line_number":197,"context_line":"class Subtask(BASE, RallyBase):"},{"line_number":198,"context_line":"    __tablename__ \u003d \"subtasks\""},{"line_number":199,"context_line":"    __table_args__ \u003d ("},{"line_number":200,"context_line":"        sa.Index(\"subtask_uuid\", \"uuid\", unique\u003dTrue),"},{"line_number":201,"context_line":"        sa.Index(\"subtask_status\", \"status\"),"},{"line_number":202,"context_line":"    )"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_4761c838","line":200,"in_reply_to":"bacf61ea_5901b669","updated":"2016-08-04 14:21:06.000000000","message":"As you could see, there is no unique\u003dTrue @L205 ))\nThere could be a subtle difference during table creation,\ne.g. in this case index gets explicit name.","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"09e1b1174642347b2c1408517856424ff727d5a1","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        nullable\u003dFalse,"},{"line_number":252,"context_line":"    )"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    task \u003d sa.orm.relationship("},{"line_number":255,"context_line":"        Task,"},{"line_number":256,"context_line":"        backref\u003dsa.orm.backref(\"workloads\"),"},{"line_number":257,"context_line":"        foreign_keys\u003dtask_uuid,"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_d40d3d90","line":254,"updated":"2016-08-05 07:37:04.000000000","message":"do we actually need to have this here? \n\nI really don\u0027t think that we are going to access task via Workload instance. \n\nSo maybe we can just remove this ?","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"f2bb2afc48d2eeff8d8b89ec9c174b202e7786ff","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        nullable\u003dFalse,"},{"line_number":252,"context_line":"    )"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    task \u003d sa.orm.relationship("},{"line_number":255,"context_line":"        Task,"},{"line_number":256,"context_line":"        backref\u003dsa.orm.backref(\"workloads\"),"},{"line_number":257,"context_line":"        foreign_keys\u003dtask_uuid,"}],"source_content_type":"text/x-python","patch_set":48,"id":"9ad45d7e_263d668f","line":254,"in_reply_to":"bacf61ea_d40d3d90","updated":"2016-08-11 16:14:36.000000000","message":"Done","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"09e1b1174642347b2c1408517856424ff727d5a1","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    load_duration \u003d sa.Column(sa.Float)"},{"line_number":301,"context_line":"    full_duration \u003d sa.Column(sa.Float)"},{"line_number":302,"context_line":"    min_duration \u003d sa.Column(sa.Float)"},{"line_number":303,"context_line":"    max_duration \u003d sa.Column(sa.Float)"},{"line_number":304,"context_line":"    total_iteration_count \u003d sa.Column(sa.Integer)"},{"line_number":305,"context_line":"    failed_iteration_count \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_347819c4","line":302,"updated":"2016-08-05 07:37:04.000000000","message":"min_duration and max_duration seems like should go to statistics? no?","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"f2bb2afc48d2eeff8d8b89ec9c174b202e7786ff","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    load_duration \u003d sa.Column(sa.Float)"},{"line_number":301,"context_line":"    full_duration \u003d sa.Column(sa.Float)"},{"line_number":302,"context_line":"    min_duration \u003d sa.Column(sa.Float)"},{"line_number":303,"context_line":"    max_duration \u003d sa.Column(sa.Float)"},{"line_number":304,"context_line":"    total_iteration_count \u003d sa.Column(sa.Integer)"},{"line_number":305,"context_line":"    failed_iteration_count \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":48,"id":"9ad45d7e_da11ba53","line":302,"in_reply_to":"bacf61ea_347819c4","updated":"2016-08-11 16:14:36.000000000","message":"for what i could see in the spec, statistics contain per-atomic_action data. but these are per workload","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"09e1b1174642347b2c1408517856424ff727d5a1","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        nullable\u003dFalse,"},{"line_number":327,"context_line":"    )"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    task \u003d sa.orm.relationship("},{"line_number":330,"context_line":"        Task,"},{"line_number":331,"context_line":"        backref\u003dsa.orm.backref(\"workload_data\"),"},{"line_number":332,"context_line":"        foreign_keys\u003dtask_uuid,"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_5452ed35","line":329,"updated":"2016-08-05 07:37:04.000000000","message":"same here I don\u0027t think that we need these kind of fields in this model","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"f2bb2afc48d2eeff8d8b89ec9c174b202e7786ff","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        nullable\u003dFalse,"},{"line_number":327,"context_line":"    )"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    task \u003d sa.orm.relationship("},{"line_number":330,"context_line":"        Task,"},{"line_number":331,"context_line":"        backref\u003dsa.orm.backref(\"workload_data\"),"},{"line_number":332,"context_line":"        foreign_keys\u003dtask_uuid,"}],"source_content_type":"text/x-python","patch_set":48,"id":"9ad45d7e_ba1fa659","line":329,"in_reply_to":"bacf61ea_5452ed35","updated":"2016-08-11 16:14:36.000000000","message":"Done","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a61dfe4eb1737f3277a997dbddfca64fc0933eaf","unresolved":false,"context_lines":[{"line_number":363,"context_line":"class Tag(BASE, RallyBase):"},{"line_number":364,"context_line":"    __tablename__ \u003d \"tags\""},{"line_number":365,"context_line":"    __table_args__ \u003d ("},{"line_number":366,"context_line":"        sa.Index(\"d_type_tag\", \"uuid\", \"type\", \"tag\", unique\u003dTrue),"},{"line_number":367,"context_line":"    )"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    id \u003d sa.Column(sa.Integer, primary_key\u003dTrue, autoincrement\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_5fb7ccd7","line":366,"updated":"2016-08-04 14:59:01.000000000","message":"So, this is normal to have the following two tags?\n\n uuid                                   type   tag\n\n 3cfbf7c7-0783-4a0c-b9ff-af00959b31e0   task   Foo_tag\n 9ff7ac9d-b971-4826-bcaf-e22d1bbfa809   task   Foo_tag","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"96b8ff38ed0f195043b3ca8a88d8c57b1972426c","unresolved":false,"context_lines":[{"line_number":363,"context_line":"class Tag(BASE, RallyBase):"},{"line_number":364,"context_line":"    __tablename__ \u003d \"tags\""},{"line_number":365,"context_line":"    __table_args__ \u003d ("},{"line_number":366,"context_line":"        sa.Index(\"d_type_tag\", \"uuid\", \"type\", \"tag\", unique\u003dTrue),"},{"line_number":367,"context_line":"    )"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    id \u003d sa.Column(sa.Integer, primary_key\u003dTrue, autoincrement\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_4f7d3a1b","line":366,"in_reply_to":"bacf61ea_54002d02","updated":"2016-08-05 07:41:11.000000000","message":"@Boris, I was confused about uuid because I thought this uuid of Tag itself, not Task/Subtask","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"09e1b1174642347b2c1408517856424ff727d5a1","unresolved":false,"context_lines":[{"line_number":363,"context_line":"class Tag(BASE, RallyBase):"},{"line_number":364,"context_line":"    __tablename__ \u003d \"tags\""},{"line_number":365,"context_line":"    __table_args__ \u003d ("},{"line_number":366,"context_line":"        sa.Index(\"d_type_tag\", \"uuid\", \"type\", \"tag\", unique\u003dTrue),"},{"line_number":367,"context_line":"    )"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    id \u003d sa.Column(sa.Integer, primary_key\u003dTrue, autoincrement\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":48,"id":"bacf61ea_54002d02","line":366,"in_reply_to":"bacf61ea_5fb7ccd7","updated":"2016-08-05 07:37:04.000000000","message":"why not? \n\nit means that we have 2 tasks that has Foo_tag","commit_id":"56b120fdb06d91db88046223e124b11155ba64c0"}],"rally/common/db/sqlalchemy/types.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1dd08db952243fce3277c7926e6111e52b1d2e6e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"class JSONEncodedList(JSONEncodedDict):"},{"line_number":58,"context_line":"    \"\"\"Represents an immutable structure as a json-encoded string.\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def process_result_value(self, value, dialect):"},{"line_number":61,"context_line":"        if value is not None:"},{"line_number":62,"context_line":"            value \u003d json.loads(value)"},{"line_number":63,"context_line":"        return value"}],"source_content_type":"text/x-python","patch_set":73,"id":"9a629dbe_d445f642","line":60,"updated":"2016-11-11 15:05:35.000000000","message":"argument \"dialect\" is not used","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"16caf8788dc14dec6f855b2d53f8b3f86d53fee3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"class JSONEncodedList(JSONEncodedDict):"},{"line_number":58,"context_line":"    \"\"\"Represents an immutable structure as a json-encoded string.\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def process_result_value(self, value, dialect):"},{"line_number":61,"context_line":"        if value is not None:"},{"line_number":62,"context_line":"            value \u003d json.loads(value)"},{"line_number":63,"context_line":"        return value"}],"source_content_type":"text/x-python","patch_set":73,"id":"7a77a97e_9aa3669e","line":60,"in_reply_to":"9a629dbe_d445f642","updated":"2016-11-15 14:27:09.000000000","message":"It is required by sqlalchemy api\nhttp://docs.sqlalchemy.org/en/latest/core/custom_types.html#sqlalchemy.types.TypeDecorator.process_result_value","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"}],"rally/consts.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"77d990966d489043477172a6ed1ae35d3c80a5a1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"class _SubtaskStatus(utils.ImmutableMixin, utils.EnumMixin):"},{"line_number":79,"context_line":"    RUNNING \u003d \"running\""},{"line_number":80,"context_line":"    FINISHED \u003d \"finished\""},{"line_number":81,"context_line":"    CRASHED \u003d \"crashed\""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class _DeployStatus(utils.ImmutableMixin, utils.EnumMixin):"}],"source_content_type":"text/x-python","patch_set":45,"id":"dada55a8_b5098233","line":81,"updated":"2016-07-27 11:51:15.000000000","message":"it looks like we need aborting states here.","commit_id":"faade6b1b9c747a81357aac5224f947f780d073c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1dd08db952243fce3277c7926e6111e52b1d2e6e","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    VALIDATION_FAILED \u003d \"validation_failed\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"class _TagKind(utils.ImmutableMixin, utils.EnumMixin):"},{"line_number":211,"context_line":"    TASK \u003d \"task\""},{"line_number":212,"context_line":"    SUBTASK \u003d \"subtask\""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":73,"id":"9a629dbe_94945e8b","line":210,"updated":"2016-11-11 15:05:35.000000000","message":"I would recommend to name it _TagType","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"cbfd734471bb7fbc45b5b040c264978767f5ba19","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    VALIDATION_FAILED \u003d \"validation_failed\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"class _TagKind(utils.ImmutableMixin, utils.EnumMixin):"},{"line_number":211,"context_line":"    TASK \u003d \"task\""},{"line_number":212,"context_line":"    SUBTASK \u003d \"subtask\""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":73,"id":"7a77a97e_0c71bde0","line":210,"in_reply_to":"9a629dbe_94945e8b","updated":"2016-11-16 09:45:16.000000000","message":"Done","commit_id":"c7521499ee827c0070db2cab9b98d79f1b40470d"}]}
