)]}'
{"rally/plugins/common/scenarios/dummy/dummy.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"87533ea547a67113cf4b1b08a1a5122bbb4e38df","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    @scenario.configure()"},{"line_number":201,"context_line":"    def dummy_timed_atomic_actions(self):"},{"line_number":202,"context_line":"        \"\"\"Run some sleepy atomic actions for SLA atomic action tests.\"\"\""},{"line_number":203,"context_line":"        for sleeptime in range(5):"},{"line_number":204,"context_line":"            with atomic.ActionTimer(self, \"action_%d\" % sleeptime):"},{"line_number":205,"context_line":"                utils.interruptable_sleep(sleeptime)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_4130cf01","line":203,"updated":"2016-03-29 16:04:21.000000000","message":"Actions number is hardcoded, let\u0027s make it a scenario argument. Also we can split number of actions and sleep time increment, something like thiat:\n\n def dummy_timed_atomic_actions(self, actions_num\u003d5, sleep_factor\u003d1):\n     for i in range(1, actions_num + 1):\n         with atomic.ActionTimer(self, \"action_%d\" % i):\n                utils.interruptable_sleep(i * sleep_factor)","commit_id":"7f4444430cbc8efc40b61bf995ea88d3d18a1563"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"34611d1c24b92b1f5924a9690c3a084593656f61","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    @scenario.configure()"},{"line_number":201,"context_line":"    def dummy_timed_atomic_actions(self):"},{"line_number":202,"context_line":"        \"\"\"Run some sleepy atomic actions for SLA atomic action tests.\"\"\""},{"line_number":203,"context_line":"        for sleeptime in range(5):"},{"line_number":204,"context_line":"            with atomic.ActionTimer(self, \"action_%d\" % sleeptime):"},{"line_number":205,"context_line":"                utils.interruptable_sleep(sleeptime)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_6aa68011","line":203,"in_reply_to":"ba0121b8_4130cf01","updated":"2016-03-29 19:56:13.000000000","message":"Done","commit_id":"7f4444430cbc8efc40b61bf995ea88d3d18a1563"}],"rally/plugins/common/sla/max_average_duration.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"880330df491f1108c7878813a01f9086dd7937f9","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"@sla.configure(name\u003d\"max_avg_duration_per_atomic\")"},{"line_number":60,"context_line":"class MaxAverageDurationPerAtomic(sla.SLA):"},{"line_number":61,"context_line":"    \"\"\"Maximum average duration of one iterations atomic actions in seconds.\"\"\""},{"line_number":62,"context_line":"    CONFIG_SCHEMA \u003d {\"type\": \"object\", \"$schema\": consts.JSON_SCHEMA,"},{"line_number":63,"context_line":"                     \"patternProperties\": {\".*\": {\"type\": \"number\"}},"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_d4903fef","line":60,"updated":"2016-03-29 03:58:28.000000000","message":"we are trying to keep code as 1 plugin per 1 file, so could you just move this code outside?","commit_id":"605ee4da4cf7c2fa35afb2dcffa1d6853e59757a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7c10a7b17ca1ac818f767b273e408878b76377c2","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"@sla.configure(name\u003d\"max_avg_duration_per_atomic\")"},{"line_number":60,"context_line":"class MaxAverageDurationPerAtomic(sla.SLA):"},{"line_number":61,"context_line":"    \"\"\"Maximum average duration of one iterations atomic actions in seconds.\"\"\""},{"line_number":62,"context_line":"    CONFIG_SCHEMA \u003d {\"type\": \"object\", \"$schema\": consts.JSON_SCHEMA,"},{"line_number":63,"context_line":"                     \"patternProperties\": {\".*\": {\"type\": \"number\"}},"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_a74bdf2a","line":60,"in_reply_to":"ba0121b8_d4903fef","updated":"2016-03-29 04:35:59.000000000","message":"Done","commit_id":"605ee4da4cf7c2fa35afb2dcffa1d6853e59757a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"880330df491f1108c7878813a01f9086dd7937f9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                self.avg_comp_by_action[action].add(value)"},{"line_number":76,"context_line":"                result \u003d self.avg_comp_by_action[action].result()"},{"line_number":77,"context_line":"                self.avg_by_action[action] \u003d result"},{"line_number":78,"context_line":"        self.success \u003d all([self.avg_by_action[atom] \u003c\u003d val"},{"line_number":79,"context_line":"                            for atom, val in self.criterion_value.items()])"},{"line_number":80,"context_line":"        return self.success"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_94236705","line":78,"updated":"2016-03-29 03:58:28.000000000","message":"you don\u0027t need [] here, it will work without it as well.","commit_id":"605ee4da4cf7c2fa35afb2dcffa1d6853e59757a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7c10a7b17ca1ac818f767b273e408878b76377c2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                self.avg_comp_by_action[action].add(value)"},{"line_number":76,"context_line":"                result \u003d self.avg_comp_by_action[action].result()"},{"line_number":77,"context_line":"                self.avg_by_action[action] \u003d result"},{"line_number":78,"context_line":"        self.success \u003d all([self.avg_by_action[atom] \u003c\u003d val"},{"line_number":79,"context_line":"                            for atom, val in self.criterion_value.items()])"},{"line_number":80,"context_line":"        return self.success"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_07bf2bd1","line":78,"in_reply_to":"ba0121b8_94236705","updated":"2016-03-29 04:35:59.000000000","message":"Done","commit_id":"605ee4da4cf7c2fa35afb2dcffa1d6853e59757a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"880330df491f1108c7878813a01f9086dd7937f9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                result \u003d self.avg_comp_by_action[action].result()"},{"line_number":77,"context_line":"                self.avg_by_action[action] \u003d result"},{"line_number":78,"context_line":"        self.success \u003d all([self.avg_by_action[atom] \u003c\u003d val"},{"line_number":79,"context_line":"                            for atom, val in self.criterion_value.items()])"},{"line_number":80,"context_line":"        return self.success"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def merge(self, other):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_74d173cd","line":79,"updated":"2016-03-29 03:58:28.000000000","message":"items() creates a copy of criterion_value, I know it works \"fast\" however we should avoid here any extra operations here, this method is called to process each iteration online (it means we are reducing the ability to generate load) So it will be better to just perform this operation one during __init__() method.","commit_id":"605ee4da4cf7c2fa35afb2dcffa1d6853e59757a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7c10a7b17ca1ac818f767b273e408878b76377c2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                result \u003d self.avg_comp_by_action[action].result()"},{"line_number":77,"context_line":"                self.avg_by_action[action] \u003d result"},{"line_number":78,"context_line":"        self.success \u003d all([self.avg_by_action[atom] \u003c\u003d val"},{"line_number":79,"context_line":"                            for atom, val in self.criterion_value.items()])"},{"line_number":80,"context_line":"        return self.success"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def merge(self, other):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_c7c1b330","line":79,"in_reply_to":"ba0121b8_74d173cd","updated":"2016-03-29 04:35:59.000000000","message":"Done","commit_id":"605ee4da4cf7c2fa35afb2dcffa1d6853e59757a"}],"rally/plugins/common/sla/max_average_duration_per_atomic.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"feefcfd1f2ed6697cfa759a75f64a59a87c3f8ef","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return self.success"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def details(self):"},{"line_number":65,"context_line":"        strs \u003d [_(\"Action: \u0027%s\u0027. %.2fs \u003c\u003d %.2fs\") % (atom, val,"},{"line_number":66,"context_line":"                                                     self.avg_by_action[atom])"},{"line_number":67,"context_line":"                for atom, val in self.criterion_items]"},{"line_number":68,"context_line":"        head \u003d _(\"Average duration of one iteration for atomic actions:\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_aede8c0e","line":65,"updated":"2016-03-31 10:06:47.000000000","message":"Seems like this is wrong.\nIf you take a look at resutls: http://logs.openstack.org/62/298462/6/check/gate-rally-dsvm-rally/fef56c0/rally-plot/results.html.gz#/Dummy.dummy_timed_atomic_actions/overview\n\nYou will see that \n \u0027action_4\u0027. 5.00s \u003c\u003d 4.01s  \n\nwhich is not true, basically it should be \n\n \u0027action_4\u0027: 4.01s  \u003c\u003d 5.00s\n\nso you need to put % (atom, self.avg_by_action[atom], val) and please change . -\u003e : otherwise this thing has unclear message","commit_id":"22f4efd7bf783d4887aa6af97cfcd45bc3e7ae16"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"09d40a60f1c558413ea708d87b3ab18e92d20a50","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return self.success"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def details(self):"},{"line_number":65,"context_line":"        strs \u003d [_(\"Action: \u0027%s\u0027. %.2fs \u003c\u003d %.2fs\") % (atom, val,"},{"line_number":66,"context_line":"                                                     self.avg_by_action[atom])"},{"line_number":67,"context_line":"                for atom, val in self.criterion_items]"},{"line_number":68,"context_line":"        head \u003d _(\"Average duration of one iteration for atomic actions:\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_8d63ae41","line":65,"in_reply_to":"ba0121b8_aede8c0e","updated":"2016-03-31 19:23:10.000000000","message":"Ah, good catch!","commit_id":"22f4efd7bf783d4887aa6af97cfcd45bc3e7ae16"}]}
