)]}'
{"rally-jobs/rally-senlin.yaml":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0e44dac305c94e738481244a99e0bc3a69746465","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9abb7d3a_565a9051","line":26,"updated":"2016-06-02 14:18:21.000000000","message":"1) Missed \u0027sla\u0027 section:\n\n      sla:\n        failure_rate:\n          max: 0\n\n\n2) This scenario actually fails:\n\nhttp://logs.openstack.org/22/301522/11/experimental/gate-rally-dsvm-senlin-rally/ba66f6c/rally-plot/results.html.gz#/SenlinClusters.create_and_delete_cluster/overview","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1c560440b4d4ba1f3b8f0da2bb73749956995a53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9abb7d3a_df695027","line":26,"in_reply_to":"9abb7d3a_565a9051","updated":"2016-06-03 04:27:36.000000000","message":"Thanks, Alexander. Will add the \u0027sla\u0027 section. The scenario test failed since neutron support was missing in gate job. Will propose a patch to fix it. About support in osresources module, will add it later. Thanks.","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac75056695a5714dd62ba3586d2ef92ea6a81f0a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      runner:"},{"line_number":18,"context_line":"        type: \"constant\""},{"line_number":19,"context_line":"        times: 3"},{"line_number":20,"context_line":"        concurrency: 1"},{"line_number":21,"context_line":"      context:"},{"line_number":22,"context_line":"        users:"},{"line_number":23,"context_line":"          tenants: 1"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7aa08908_25fbc47c","line":20,"updated":"2016-06-14 10:24:41.000000000","message":"Please increase concurrency to 2. To check how senlin works with multiple threads","commit_id":"f3647cafe4a291b1114592dbbcb675f258f210d5"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"df872087d969814a76f676538ac626edbd7aeb56","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      runner:"},{"line_number":18,"context_line":"        type: \"constant\""},{"line_number":19,"context_line":"        times: 3"},{"line_number":20,"context_line":"        concurrency: 1"},{"line_number":21,"context_line":"      context:"},{"line_number":22,"context_line":"        users:"},{"line_number":23,"context_line":"          tenants: 1"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7aa08908_25a08b8f","line":20,"in_reply_to":"7aa08908_25fbc47c","updated":"2016-06-15 03:28:12.000000000","message":"Done","commit_id":"f3647cafe4a291b1114592dbbcb675f258f210d5"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3fca3c445db3a4366dc009a7e5a8ac777570df07","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        concurrency: 2"},{"line_number":21,"context_line":"      context:"},{"line_number":22,"context_line":"        users:"},{"line_number":23,"context_line":"          tenants: 1"},{"line_number":24,"context_line":"          users_per_tenant: 1"},{"line_number":25,"context_line":"      sla:"},{"line_number":26,"context_line":"        failure_rate:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"dada55a8_250fae89","line":23,"updated":"2016-07-24 15:52:35.000000000","message":"Please increase it to 2","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"f6f015bb7e94af98319e21e04aedc52b04611f2d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        concurrency: 2"},{"line_number":21,"context_line":"      context:"},{"line_number":22,"context_line":"        users:"},{"line_number":23,"context_line":"          tenants: 1"},{"line_number":24,"context_line":"          users_per_tenant: 1"},{"line_number":25,"context_line":"      sla:"},{"line_number":26,"context_line":"        failure_rate:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"dada55a8_7d4f7abe","line":23,"in_reply_to":"dada55a8_250fae89","updated":"2016-07-25 03:46:48.000000000","message":"Done","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3fca3c445db3a4366dc009a7e5a8ac777570df07","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      context:"},{"line_number":22,"context_line":"        users:"},{"line_number":23,"context_line":"          tenants: 1"},{"line_number":24,"context_line":"          users_per_tenant: 1"},{"line_number":25,"context_line":"      sla:"},{"line_number":26,"context_line":"        failure_rate:"},{"line_number":27,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"dada55a8_85265a14","line":24,"updated":"2016-07-24 15:52:35.000000000","message":"Please increase it to 2","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"f6f015bb7e94af98319e21e04aedc52b04611f2d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      context:"},{"line_number":22,"context_line":"        users:"},{"line_number":23,"context_line":"          tenants: 1"},{"line_number":24,"context_line":"          users_per_tenant: 1"},{"line_number":25,"context_line":"      sla:"},{"line_number":26,"context_line":"        failure_rate:"},{"line_number":27,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"dada55a8_fdc9aa26","line":24,"in_reply_to":"dada55a8_85265a14","updated":"2016-07-25 03:46:48.000000000","message":"Done","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"}],"rally/plugins/openstack/cleanup/resources.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"fd307d984d3b5f29d2b1b9d594ac108428a91a7e","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# SENLIN"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"@base.resource(\"senlin\", \"clusters\", order\u003d160)"},{"line_number":79,"context_line":"class SenlinCluster(base.ResourceManager):"},{"line_number":80,"context_line":"    def _manager(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_49493b5f","line":77,"updated":"2016-06-06 13:50:58.000000000","message":"Do this run cleanup for profiles as well?\n\nIn clusters.py:L44 I see profile created, but how this resource can be removed by cleanup manager ?","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1b7be951ccdd6a325c7fe4a1ff7257c635b815c6","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# SENLIN"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"@base.resource(\"senlin\", \"clusters\", order\u003d160)"},{"line_number":79,"context_line":"class SenlinCluster(base.ResourceManager):"},{"line_number":80,"context_line":"    def _manager(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_c11b021b","line":77,"in_reply_to":"7aa08908_49493b5f","updated":"2016-06-11 10:38:49.000000000","message":"hi, Alexander, the profile created will be deleted in cluster.py L48.","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"fd307d984d3b5f29d2b1b9d594ac108428a91a7e","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def list(self):"},{"line_number":85,"context_line":"        return self._manager().clusters()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# NOVA"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_14146a42","line":86,"updated":"2016-06-06 13:50:58.000000000","message":"Method `delete()\u0027 should be also overridden because we have to call delete_cluster() instead of delete()","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1b7be951ccdd6a325c7fe4a1ff7257c635b815c6","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def list(self):"},{"line_number":85,"context_line":"        return self._manager().clusters()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# NOVA"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_e1cefe81","line":86,"in_reply_to":"7aa08908_14146a42","updated":"2016-06-11 10:38:49.000000000","message":"Yes, will override delete() method as well. Thanks.","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac75056695a5714dd62ba3586d2ef92ea6a81f0a","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# SENLIN"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"@base.resource(\"senlin\", \"clusters\", order\u003d160)"},{"line_number":79,"context_line":"class SenlinCluster(base.ResourceManager):"},{"line_number":80,"context_line":"    def _manager(self):"},{"line_number":81,"context_line":"        client \u003d self._admin_required and self.admin or self.user"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_80099f97","line":78,"updated":"2016-06-14 10:24:41.000000000","message":"You use in the patch `profile` but not add it to resource manager. We should do it)","commit_id":"f3647cafe4a291b1114592dbbcb675f258f210d5"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"df872087d969814a76f676538ac626edbd7aeb56","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# SENLIN"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"@base.resource(\"senlin\", \"clusters\", order\u003d160)"},{"line_number":79,"context_line":"class SenlinCluster(base.ResourceManager):"},{"line_number":80,"context_line":"    def _manager(self):"},{"line_number":81,"context_line":"        client \u003d self._admin_required and self.admin or self.user"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_25c7eb45","line":78,"in_reply_to":"7aa08908_80099f97","updated":"2016-06-15 03:28:12.000000000","message":"Done","commit_id":"f3647cafe4a291b1114592dbbcb675f258f210d5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e4d440673883b65685825cb888f3367065223243","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"@base.resource(\"senlin\", \"clusters\", order\u003d160)"},{"line_number":88,"context_line":"class SenlinCluster(SenlinMixin):"},{"line_number":89,"context_line":"    def list(self):"},{"line_number":90,"context_line":"        return self._manager().clusters()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def delete(self):"},{"line_number":93,"context_line":"        return self._manager().delete_cluster(self.id)"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_ff1b5a7e","line":90,"range":{"start_line":89,"start_character":4,"end_line":90,"end_character":41},"updated":"2016-07-19 09:59:56.000000000","message":"NIT: it sounds like we can unify this code and move to SenlinMexin. something like:\n\n    def list(self):\n        return getattr(self._manager(), self._resource)()","commit_id":"16efbedb6dc001a7ed4dcae735f41bcfe5851317"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"a77f1bc93a2aba4f5fc3e070ffe51899bc171443","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"@base.resource(\"senlin\", \"clusters\", order\u003d160)"},{"line_number":88,"context_line":"class SenlinCluster(SenlinMixin):"},{"line_number":89,"context_line":"    def list(self):"},{"line_number":90,"context_line":"        return self._manager().clusters()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def delete(self):"},{"line_number":93,"context_line":"        return self._manager().delete_cluster(self.id)"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_930f8d2d","line":90,"range":{"start_line":89,"start_character":4,"end_line":90,"end_character":41},"in_reply_to":"dada55a8_ff1b5a7e","updated":"2016-07-20 02:40:16.000000000","message":"Yes, that is better. Will make a change. Thanks.","commit_id":"16efbedb6dc001a7ed4dcae735f41bcfe5851317"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e4d440673883b65685825cb888f3367065223243","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    def list(self):"},{"line_number":90,"context_line":"        return self._manager().clusters()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def delete(self):"},{"line_number":93,"context_line":"        return self._manager().delete_cluster(self.id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"@base.resource(\"senlin\", \"profiles\", order\u003d180)"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_df7f7564","line":93,"range":{"start_line":92,"start_character":4,"end_line":93,"end_character":54},"updated":"2016-07-19 09:59:56.000000000","message":"same nit here:)\n\n    def delete(self):\n        # make singular form of resource name from plural form\n        res_name \u003d self._resource[:-1]\n        return getattr(self._manager, \"delete_%s\" % res_name)(self.id)","commit_id":"16efbedb6dc001a7ed4dcae735f41bcfe5851317"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"a77f1bc93a2aba4f5fc3e070ffe51899bc171443","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    def list(self):"},{"line_number":90,"context_line":"        return self._manager().clusters()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def delete(self):"},{"line_number":93,"context_line":"        return self._manager().delete_cluster(self.id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"@base.resource(\"senlin\", \"profiles\", order\u003d180)"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_334ea16f","line":93,"range":{"start_line":92,"start_character":4,"end_line":93,"end_character":54},"in_reply_to":"dada55a8_df7f7564","updated":"2016-07-20 02:40:16.000000000","message":"Cool! Didn\u0027t realize it can be invoked using this way :)","commit_id":"16efbedb6dc001a7ed4dcae735f41bcfe5851317"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3fca3c445db3a4366dc009a7e5a8ac777570df07","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def list(self):"},{"line_number":87,"context_line":"        return getattr(self._manager(), self._resource)()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def delete(self):"},{"line_number":90,"context_line":"        # make singular form of resource name from plural form"},{"line_number":91,"context_line":"        res_name \u003d self._resource[:-1]"},{"line_number":92,"context_line":"        return getattr(self._manager(), \"delete_%s\" % res_name)(self.id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_c506921f","line":89,"updated":"2016-07-24 15:52:35.000000000","message":"I think that delete can\u0027t be the base for Senlin resources because of methods like https://github.com/openstack/python-senlinclient/blob/master/senlinclient/v1/client.py#L192 and plural forms like https://github.com/openstack/python-senlinclient/blob/master/senlinclient/v1/client.py#L136","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"f6f015bb7e94af98319e21e04aedc52b04611f2d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def list(self):"},{"line_number":87,"context_line":"        return getattr(self._manager(), self._resource)()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def delete(self):"},{"line_number":90,"context_line":"        # make singular form of resource name from plural form"},{"line_number":91,"context_line":"        res_name \u003d self._resource[:-1]"},{"line_number":92,"context_line":"        return getattr(self._manager(), \"delete_%s\" % res_name)(self.id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_5d9f1603","line":89,"in_reply_to":"dada55a8_c506921f","updated":"2016-07-25 03:46:48.000000000","message":"Hi, \"cluster_del_nodes\" is actually a type of \"cluster action\" which removes node(s) member from parent cluster. \nhttp://developer.openstack.org/api-ref/clustering/?expanded\u003dremove-nodes-from-a-cluster-detail\n\nSo it is not for node resource deleting which is actually done by \"delete_node\" method. Sorry the senlinclient docstring doesn\u0027t explain it clearly... And I just made a check and didn\u0027t found plural forms of deleting method naming...","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3fca3c445db3a4366dc009a7e5a8ac777570df07","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return getattr(self._manager(), \"delete_%s\" % res_name)(self.id)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"@base.resource(\"senlin\", \"clusters\", order\u003d160)"},{"line_number":96,"context_line":"class SenlinCluster(SenlinMixin):"},{"line_number":97,"context_line":"    \"\"\"Resource class for Senlin Cluster.\"\"\""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_c5585259","line":95,"updated":"2016-07-24 15:52:35.000000000","message":"Better to use here get_order() and next() approach, see nova examples","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"f6f015bb7e94af98319e21e04aedc52b04611f2d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return getattr(self._manager(), \"delete_%s\" % res_name)(self.id)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"@base.resource(\"senlin\", \"clusters\", order\u003d160)"},{"line_number":96,"context_line":"class SenlinCluster(SenlinMixin):"},{"line_number":97,"context_line":"    \"\"\"Resource class for Senlin Cluster.\"\"\""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_1dbc7e6b","line":95,"in_reply_to":"dada55a8_c5585259","updated":"2016-07-25 03:46:48.000000000","message":"I see. Will make a change. Thanks.","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d41fa12e8b33070bf39808a4bfc81b7749358b19","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        return getattr(client, self._service)()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def list(self):"},{"line_number":89,"context_line":"        return getattr(self._manager(), self._resource)()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def delete(self):"},{"line_number":92,"context_line":"        # make singular form of resource name from plural form"}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_44994dc3","line":89,"updated":"2016-08-02 11:40:42.000000000","message":"Could you elaborate: will this list all resources in senlin or possibly there is default page size for list?","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e8b2f83ae9b0ce45c9437d041b4aee672720444c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        return getattr(client, self._service)()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def list(self):"},{"line_number":89,"context_line":"        return getattr(self._manager(), self._resource)()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def delete(self):"},{"line_number":92,"context_line":"        # make singular form of resource name from plural form"}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_991f035b","line":89,"in_reply_to":"bacf61ea_44994dc3","updated":"2016-08-03 02:19:29.000000000","message":"All resources will be listed without \"limit\" being specified.","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d41fa12e8b33070bf39808a4bfc81b7749358b19","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return getattr(self._manager(), \"delete_%s\" % res_name)(self.id)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"@base.resource(\"senlin\", \"clusters\", order\u003dnext(_senlin_order))"},{"line_number":98,"context_line":"class SenlinCluster(SenlinMixin):"},{"line_number":99,"context_line":"    \"\"\"Resource class for Senlin Cluster.\"\"\""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_0440f505","line":97,"updated":"2016-08-02 11:40:42.000000000","message":"As I saw in utils file cluster require admin, so we need to add admin_required\u003dTrue https://github.com/openstack/rally/blob/master/rally/plugins/openstack/cleanup/resources.py#L138","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e8b2f83ae9b0ce45c9437d041b4aee672720444c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return getattr(self._manager(), \"delete_%s\" % res_name)(self.id)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"@base.resource(\"senlin\", \"clusters\", order\u003dnext(_senlin_order))"},{"line_number":98,"context_line":"class SenlinCluster(SenlinMixin):"},{"line_number":99,"context_line":"    \"\"\"Resource class for Senlin Cluster.\"\"\""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_5973cbb4","line":97,"in_reply_to":"bacf61ea_0440f505","updated":"2016-08-03 02:19:29.000000000","message":"I see. Will change.","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d41fa12e8b33070bf39808a4bfc81b7749358b19","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \"\"\"Resource class for Senlin Cluster.\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"@base.resource(\"senlin\", \"profiles\", order\u003dnext(_senlin_order))"},{"line_number":103,"context_line":"class SenlinProfile(SenlinMixin):"},{"line_number":104,"context_line":"    \"\"\"Resource class for Senlin Profile.\"\"\""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_9f0a6ed0","line":102,"updated":"2016-08-02 11:40:42.000000000","message":"as well as in 97 line","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e8b2f83ae9b0ce45c9437d041b4aee672720444c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \"\"\"Resource class for Senlin Cluster.\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"@base.resource(\"senlin\", \"profiles\", order\u003dnext(_senlin_order))"},{"line_number":103,"context_line":"class SenlinProfile(SenlinMixin):"},{"line_number":104,"context_line":"    \"\"\"Resource class for Senlin Profile.\"\"\""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_3978978f","line":102,"in_reply_to":"bacf61ea_9f0a6ed0","updated":"2016-08-03 02:19:29.000000000","message":"Done","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"}],"rally/plugins/openstack/scenarios/senlin/clusters.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"743e611ee935d92e3519c0385034b611f6802ad1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014: Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_ff8ff720","line":2,"updated":"2016-04-05 09:30:41.000000000","message":"remove the copyright lines?","commit_id":"8a8803814eba3bb90038b350675f9939370320d3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"64b3d10ea5a2b24b9b0307b44a53ae7812b01bb3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014: Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_c24cdc72","line":2,"in_reply_to":"9a061dce_ff8ff720","updated":"2016-04-05 09:47:04.000000000","message":"Done","commit_id":"8a8803814eba3bb90038b350675f9939370320d3"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"70e40ebb26ed1739eb4f79312c2e45d4653ea568","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Benchmark scenarios for Senlin clusters.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @validation.required_services(consts.Service.SENLIN)"},{"line_number":23,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"senlin\"]})"},{"line_number":24,"context_line":"    def create_and_delete_cluster(self, profile_spec, name\u003dNone,"},{"line_number":25,"context_line":"                                  desired_capacity\u003d0, min_size\u003d0, max_size\u003d-1,"},{"line_number":26,"context_line":"                                  timeout\u003d3600, metadata\u003d{}):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_797340e8","line":23,"updated":"2016-06-02 15:59:00.000000000","message":"Please add validator for required openstack. Also profile_spec file should be validated by https://github.com/openstack/rally/blob/master/rally/task/validation.py#L148","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1565a95a2267f70bffb5708c548066980f282b47","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Benchmark scenarios for Senlin clusters.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @validation.required_services(consts.Service.SENLIN)"},{"line_number":23,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"senlin\"]})"},{"line_number":24,"context_line":"    def create_and_delete_cluster(self, profile_spec, name\u003dNone,"},{"line_number":25,"context_line":"                                  desired_capacity\u003d0, min_size\u003d0, max_size\u003d-1,"},{"line_number":26,"context_line":"                                  timeout\u003d3600, metadata\u003d{}):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_0bc55a5a","line":23,"in_reply_to":"9abb7d3a_504eef96","updated":"2016-06-03 05:09:55.000000000","message":"And will update the docstring of this parameter. Thanks.","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e08dcec8262cb0fdd495ccb01fcb1d32d5dfd3f3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Benchmark scenarios for Senlin clusters.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @validation.required_services(consts.Service.SENLIN)"},{"line_number":23,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"senlin\"]})"},{"line_number":24,"context_line":"    def create_and_delete_cluster(self, profile_spec, name\u003dNone,"},{"line_number":25,"context_line":"                                  desired_capacity\u003d0, min_size\u003d0, max_size\u003d-1,"},{"line_number":26,"context_line":"                                  timeout\u003d3600, metadata\u003d{}):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_504eef96","line":23,"in_reply_to":"9abb7d3a_5f4e0097","updated":"2016-06-03 04:51:22.000000000","message":"oh, sorry I forgot to mention that the profile_spec is a dictionary not a file path. So we don\u0027t need to validate file existence here.","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1c560440b4d4ba1f3b8f0da2bb73749956995a53","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Benchmark scenarios for Senlin clusters.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @validation.required_services(consts.Service.SENLIN)"},{"line_number":23,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"senlin\"]})"},{"line_number":24,"context_line":"    def create_and_delete_cluster(self, profile_spec, name\u003dNone,"},{"line_number":25,"context_line":"                                  desired_capacity\u003d0, min_size\u003d0, max_size\u003d-1,"},{"line_number":26,"context_line":"                                  timeout\u003d3600, metadata\u003d{}):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_5f4e0097","line":23,"in_reply_to":"9abb7d3a_797340e8","updated":"2016-06-03 04:27:36.000000000","message":"Done","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"70e40ebb26ed1739eb4f79312c2e45d4653ea568","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"senlin\"]})"},{"line_number":24,"context_line":"    def create_and_delete_cluster(self, profile_spec, name\u003dNone,"},{"line_number":25,"context_line":"                                  desired_capacity\u003d0, min_size\u003d0, max_size\u003d-1,"},{"line_number":26,"context_line":"                                  timeout\u003d3600, metadata\u003d{}):"},{"line_number":27,"context_line":"        \"\"\"Create a cluster and then delete it."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        Measure the \"senlin cluster-create\" and \"senlin cluster-delete\""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_f9bf305e","line":26,"updated":"2016-06-02 15:59:00.000000000","message":"Don\u0027t use dict by default https://pythonconquerstheuniverse.wordpress.com/2012/02/15/mutable-default-arguments/","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1c560440b4d4ba1f3b8f0da2bb73749956995a53","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"senlin\"]})"},{"line_number":24,"context_line":"    def create_and_delete_cluster(self, profile_spec, name\u003dNone,"},{"line_number":25,"context_line":"                                  desired_capacity\u003d0, min_size\u003d0, max_size\u003d-1,"},{"line_number":26,"context_line":"                                  timeout\u003d3600, metadata\u003d{}):"},{"line_number":27,"context_line":"        \"\"\"Create a cluster and then delete it."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        Measure the \"senlin cluster-create\" and \"senlin cluster-delete\""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_7f94a4e7","line":26,"in_reply_to":"9abb7d3a_f9bf305e","updated":"2016-06-03 04:27:36.000000000","message":"My fault. Will change it.","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"70e40ebb26ed1739eb4f79312c2e45d4653ea568","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def create_and_delete_cluster(self, profile_spec, name\u003dNone,"},{"line_number":25,"context_line":"                                  desired_capacity\u003d0, min_size\u003d0, max_size\u003d-1,"},{"line_number":26,"context_line":"                                  timeout\u003d3600, metadata\u003d{}):"},{"line_number":27,"context_line":"        \"\"\"Create a cluster and then delete it."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        Measure the \"senlin cluster-create\" and \"senlin cluster-delete\""},{"line_number":30,"context_line":"        commands performance."}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_4f566e07","line":27,"updated":"2016-06-02 15:59:00.000000000","message":"You not only create and delete cluster. Also you do the same for profile which will be included into measurements. Thus you need to update doc and change scenario name. Or write you profile context and not to include it into measurements","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1c560440b4d4ba1f3b8f0da2bb73749956995a53","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def create_and_delete_cluster(self, profile_spec, name\u003dNone,"},{"line_number":25,"context_line":"                                  desired_capacity\u003d0, min_size\u003d0, max_size\u003d-1,"},{"line_number":26,"context_line":"                                  timeout\u003d3600, metadata\u003d{}):"},{"line_number":27,"context_line":"        \"\"\"Create a cluster and then delete it."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        Measure the \"senlin cluster-create\" and \"senlin cluster-delete\""},{"line_number":30,"context_line":"        commands performance."}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_b0a47b08","line":27,"in_reply_to":"9abb7d3a_4f566e07","updated":"2016-06-03 04:27:36.000000000","message":"I see. Will update doc and change scenario name. Thanks.","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"70e40ebb26ed1739eb4f79312c2e45d4653ea568","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        commands performance."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        :param profile_spec: spec file used to create profile"},{"line_number":33,"context_line":"        :param name: name of cluster to be created"},{"line_number":34,"context_line":"        :param desired_capacity: The capacity or initial size of cluster"},{"line_number":35,"context_line":"        :param min_size: The minimum size of the cluster"},{"line_number":36,"context_line":"        :param max_size: The maximum size of the cluster. -1 means no limit"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_b47dafb3","line":33,"updated":"2016-06-02 15:59:00.000000000","message":"This is critical to Rally not to specify custom name by hand see https://github.com/openstack/rally/blob/master/doc/specs/in-progress/cleanup_refactoring.rst","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1c560440b4d4ba1f3b8f0da2bb73749956995a53","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        commands performance."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        :param profile_spec: spec file used to create profile"},{"line_number":33,"context_line":"        :param name: name of cluster to be created"},{"line_number":34,"context_line":"        :param desired_capacity: The capacity or initial size of cluster"},{"line_number":35,"context_line":"        :param min_size: The minimum size of the cluster"},{"line_number":36,"context_line":"        :param max_size: The maximum size of the cluster. -1 means no limit"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_ba7bba7a","line":33,"in_reply_to":"9abb7d3a_b47dafb3","updated":"2016-06-03 04:27:36.000000000","message":"I see. Will remove this input parameter.","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"70e40ebb26ed1739eb4f79312c2e45d4653ea568","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        :param profile_spec: spec file used to create profile"},{"line_number":33,"context_line":"        :param name: name of cluster to be created"},{"line_number":34,"context_line":"        :param desired_capacity: The capacity or initial size of cluster"},{"line_number":35,"context_line":"        :param min_size: The minimum size of the cluster"},{"line_number":36,"context_line":"        :param max_size: The maximum size of the cluster. -1 means no limit"},{"line_number":37,"context_line":"        :param timeout: The timeout value in minutes for cluster creation"},{"line_number":38,"context_line":"        :param metadata: A set of key value pairs to associate with the cluster"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        profile \u003d self._create_profile(profile_spec)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_34ec1f8f","line":37,"range":{"start_line":34,"start_character":2,"end_line":37,"end_character":73},"updated":"2016-06-02 15:59:00.000000000","message":"Please describe in what units of measure here","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1c560440b4d4ba1f3b8f0da2bb73749956995a53","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        :param profile_spec: spec file used to create profile"},{"line_number":33,"context_line":"        :param name: name of cluster to be created"},{"line_number":34,"context_line":"        :param desired_capacity: The capacity or initial size of cluster"},{"line_number":35,"context_line":"        :param min_size: The minimum size of the cluster"},{"line_number":36,"context_line":"        :param max_size: The maximum size of the cluster. -1 means no limit"},{"line_number":37,"context_line":"        :param timeout: The timeout value in minutes for cluster creation"},{"line_number":38,"context_line":"        :param metadata: A set of key value pairs to associate with the cluster"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        profile \u003d self._create_profile(profile_spec)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_707333b5","line":37,"range":{"start_line":34,"start_character":2,"end_line":37,"end_character":73},"in_reply_to":"9abb7d3a_34ec1f8f","updated":"2016-06-03 04:27:36.000000000","message":"Done","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e4d440673883b65685825cb888f3367065223243","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"senlin\"]})"},{"line_number":25,"context_line":"    def create_and_delete_profile_cluster(self, profile_spec,"},{"line_number":26,"context_line":"                                          desired_capacity\u003d0, min_size\u003d0,"},{"line_number":27,"context_line":"                                          max_size\u003d-1, timeout\u003d3600,"},{"line_number":28,"context_line":"                                          metadata\u003dNone):"},{"line_number":29,"context_line":"        \"\"\"Create a profile and a cluster and then delete them."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_9fa4ddb9","line":27,"range":{"start_line":27,"start_character":55,"end_line":27,"end_character":67},"updated":"2016-07-19 09:59:56.000000000","message":"do we need ability to set different values of this timeout for different tasks?\n\nI prefer to do it similar to other scenarios - throw config file, like https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/sahara/utils.py#L36-L44","commit_id":"16efbedb6dc001a7ed4dcae735f41bcfe5851317"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"a77f1bc93a2aba4f5fc3e070ffe51899bc171443","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"senlin\"]})"},{"line_number":25,"context_line":"    def create_and_delete_profile_cluster(self, profile_spec,"},{"line_number":26,"context_line":"                                          desired_capacity\u003d0, min_size\u003d0,"},{"line_number":27,"context_line":"                                          max_size\u003d-1, timeout\u003d3600,"},{"line_number":28,"context_line":"                                          metadata\u003dNone):"},{"line_number":29,"context_line":"        \"\"\"Create a profile and a cluster and then delete them."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_539d1558","line":27,"range":{"start_line":27,"start_character":55,"end_line":27,"end_character":67},"in_reply_to":"dada55a8_9fa4ddb9","updated":"2016-07-20 02:40:16.000000000","message":"Hi, Andrey, this is because time consumption of cluster operation could vary across different cluster scale. E.g. creating a cluster of 1,000 nova servers usually costs more time than creating a cluster consists of 500 nova servers. For this reason, Senlin allows user to customize the operation timeout for each cluster when creating it. And this value can be updated as well when cluster scale changes later. So this timeout is defined as an attribute of cluster resource rather than a configure option of Senlin service. So I feel making this value customizable could be helpful for benchmarking cluster operation with different cluster scale. Thanks.","commit_id":"16efbedb6dc001a7ed4dcae735f41bcfe5851317"}],"rally/plugins/openstack/scenarios/senlin/utils.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"743e611ee935d92e3519c0385034b611f6802ad1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014: Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_5f78a32b","line":2,"updated":"2016-04-05 09:30:41.000000000","message":"Don\u0027t see a need to keep the copyright line.","commit_id":"8a8803814eba3bb90038b350675f9939370320d3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"64b3d10ea5a2b24b9b0307b44a53ae7812b01bb3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014: Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_6264f0e4","line":2,"in_reply_to":"9a061dce_5f78a32b","updated":"2016-04-05 09:47:04.000000000","message":"Done","commit_id":"8a8803814eba3bb90038b350675f9939370320d3"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"743e611ee935d92e3519c0385034b611f6802ad1","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        :returns: object of profile created"},{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        attrs \u003d {}"},{"line_number":145,"context_line":"        attrs[\"spec\"] \u003d get_spec_content(spec_path)"},{"line_number":146,"context_line":"        if not attrs.get(\"name\", None):"},{"line_number":147,"context_line":"            profile_name \u003d self.generate_random_name()"},{"line_number":148,"context_line":"            attrs[\"name\"] \u003d profile_name"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_df8b131d","line":145,"range":{"start_line":145,"start_character":24,"end_line":145,"end_character":40},"updated":"2016-04-05 09:30:41.000000000","message":"since this test is at API service layer, we don\u0027t need to load spec file from file system as we do for CLI. Maybe spec defined in dict format is enough?","commit_id":"8a8803814eba3bb90038b350675f9939370320d3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"64b3d10ea5a2b24b9b0307b44a53ae7812b01bb3","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        :returns: object of profile created"},{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        attrs \u003d {}"},{"line_number":145,"context_line":"        attrs[\"spec\"] \u003d get_spec_content(spec_path)"},{"line_number":146,"context_line":"        if not attrs.get(\"name\", None):"},{"line_number":147,"context_line":"            profile_name \u003d self.generate_random_name()"},{"line_number":148,"context_line":"            attrs[\"name\"] \u003d profile_name"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_626eb097","line":145,"in_reply_to":"9a061dce_df8b131d","updated":"2016-04-05 09:47:04.000000000","message":"Yes, directly embedding spec dict into job description file is better. Will make a change. Thanks.","commit_id":"8a8803814eba3bb90038b350675f9939370320d3"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"70e40ebb26ed1739eb4f79312c2e45d4653ea568","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Base class for Senlin scenarios with basic atomic actions.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @atomic.action_timer(\"senlin.get_action\")"},{"line_number":38,"context_line":"    def _get_action(self, action):"},{"line_number":39,"context_line":"        \"\"\"Get action details."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param action: ID of action to get"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_cf61bed5","line":38,"updated":"2016-06-02 15:59:00.000000000","message":"please rename it to `action_id`","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1c560440b4d4ba1f3b8f0da2bb73749956995a53","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Base class for Senlin scenarios with basic atomic actions.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @atomic.action_timer(\"senlin.get_action\")"},{"line_number":38,"context_line":"    def _get_action(self, action):"},{"line_number":39,"context_line":"        \"\"\"Get action details."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param action: ID of action to get"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_5ad44e46","line":38,"in_reply_to":"9abb7d3a_cf61bed5","updated":"2016-06-03 04:27:36.000000000","message":"Done","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"70e40ebb26ed1739eb4f79312c2e45d4653ea568","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            cluster,"},{"line_number":116,"context_line":"            # FIXME(Yanyan Hu): ready_statuses is actually useless"},{"line_number":117,"context_line":"            # for deleting Senlin cluster since cluster db item will"},{"line_number":118,"context_line":"            # be removed once cluster is deleted successfully."},{"line_number":119,"context_line":"            ready_statuses\u003d[\"DELETED\"],"},{"line_number":120,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":121,"context_line":"            check_deletion\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_0f0466c4","line":118,"updated":"2016-06-02 15:59:00.000000000","message":"I can\u0027t get why its useless here","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1c560440b4d4ba1f3b8f0da2bb73749956995a53","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            cluster,"},{"line_number":116,"context_line":"            # FIXME(Yanyan Hu): ready_statuses is actually useless"},{"line_number":117,"context_line":"            # for deleting Senlin cluster since cluster db item will"},{"line_number":118,"context_line":"            # be removed once cluster is deleted successfully."},{"line_number":119,"context_line":"            ready_statuses\u003d[\"DELETED\"],"},{"line_number":120,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":121,"context_line":"            check_deletion\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_1a0006aa","line":118,"in_reply_to":"9abb7d3a_0f0466c4","updated":"2016-06-03 04:27:36.000000000","message":"This is because in senlin, the db entry of a cluster will be removed once the cluster is deleted. Therefore, a cluster will never be in \"DELETED\" status if we observe it through get_cluster client interface. Therefore the only way to track cluster deletion progress through get_cluster interface is catching 404 NotFound exception. That\u0027s why we set check_deletion\u003dTrue when invoking wait_for_status.","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"70e40ebb26ed1739eb4f79312c2e45d4653ea568","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \"\"\"Create a new profile from attributes."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param spec: spec dictionary used to create profile"},{"line_number":130,"context_line":"        :param name: name of cluster to be created"},{"line_number":131,"context_line":"        :param metadata: A set of key value pairs to associate with the"},{"line_number":132,"context_line":"                         profile"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_efa482ba","line":130,"updated":"2016-06-02 15:59:00.000000000","message":"We should not allow user to specify custom names","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1c560440b4d4ba1f3b8f0da2bb73749956995a53","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \"\"\"Create a new profile from attributes."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param spec: spec dictionary used to create profile"},{"line_number":130,"context_line":"        :param name: name of cluster to be created"},{"line_number":131,"context_line":"        :param metadata: A set of key value pairs to associate with the"},{"line_number":132,"context_line":"                         profile"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_3a9fca60","line":130,"in_reply_to":"9abb7d3a_efa482ba","updated":"2016-06-03 04:27:36.000000000","message":"Done","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"70e40ebb26ed1739eb4f79312c2e45d4653ea568","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def _get_profile(self, profile):"},{"line_number":148,"context_line":"        \"\"\"Get profile details."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        :param profile: profile to get"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        :returns: object of profile"},{"line_number":153,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_8f4a1626","line":150,"updated":"2016-06-02 15:59:00.000000000","message":"Better to pass only profile id","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1c560440b4d4ba1f3b8f0da2bb73749956995a53","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def _get_profile(self, profile):"},{"line_number":148,"context_line":"        \"\"\"Get profile details."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        :param profile: profile to get"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        :returns: object of profile"},{"line_number":153,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_7a879212","line":150,"in_reply_to":"9abb7d3a_8f4a1626","updated":"2016-06-03 04:27:36.000000000","message":"Yes, will change it.","commit_id":"008202d8c23a14a78dfc1e2d28ed757767541527"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"fd307d984d3b5f29d2b1b9d594ac108428a91a7e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Base class for Senlin scenarios with basic atomic actions.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @atomic.action_timer(\"senlin.get_action\")"},{"line_number":38,"context_line":"    def _get_action(self, action_id):"},{"line_number":39,"context_line":"        \"\"\"Get action details."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param action_id: ID of action to get"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_29730f82","line":38,"updated":"2016-06-06 13:50:58.000000000","message":"Where is this method used?","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1b7be951ccdd6a325c7fe4a1ff7257c635b815c6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Base class for Senlin scenarios with basic atomic actions.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @atomic.action_timer(\"senlin.get_action\")"},{"line_number":38,"context_line":"    def _get_action(self, action_id):"},{"line_number":39,"context_line":"        \"\"\"Get action details."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param action_id: ID of action to get"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_61a16ea9","line":38,"in_reply_to":"7aa08908_29730f82","updated":"2016-06-11 10:38:49.000000000","message":"My fault. This function has not been used yet in current patch. I will remove it.","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac75056695a5714dd62ba3586d2ef92ea6a81f0a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        \"\"\""},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            return self.admin_clients(\"senlin\").get_cluster(cluster.id)"},{"line_number":89,"context_line":"        except Exception as e:"},{"line_number":90,"context_line":"            if getattr(e, \"code\", getattr(e, \"http_status\", 400)) \u003d\u003d 404:"},{"line_number":91,"context_line":"                raise exceptions.GetResourceNotFound(resource\u003dcluster.id)"},{"line_number":92,"context_line":"            raise exceptions.GetResourceFailure(resource\u003dcluster.id, err\u003de)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_133d0bc4","line":89,"updated":"2016-06-14 10:24:41.000000000","message":"Why you catch all exceptions here?","commit_id":"f3647cafe4a291b1114592dbbcb675f258f210d5"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"df872087d969814a76f676538ac626edbd7aeb56","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        \"\"\""},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            return self.admin_clients(\"senlin\").get_cluster(cluster.id)"},{"line_number":89,"context_line":"        except Exception as e:"},{"line_number":90,"context_line":"            if getattr(e, \"code\", getattr(e, \"http_status\", 400)) \u003d\u003d 404:"},{"line_number":91,"context_line":"                raise exceptions.GetResourceNotFound(resource\u003dcluster.id)"},{"line_number":92,"context_line":"            raise exceptions.GetResourceFailure(resource\u003dcluster.id, err\u003de)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_456f972a","line":89,"in_reply_to":"7aa08908_133d0bc4","updated":"2016-06-15 03:28:12.000000000","message":"I think no matter what kind of exception happened here, the get_cluster operation should be marked as failed.","commit_id":"f3647cafe4a291b1114592dbbcb675f258f210d5"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac75056695a5714dd62ba3586d2ef92ea6a81f0a","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return cluster"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @atomic.action_timer(\"senlin.get_cluster\")"},{"line_number":80,"context_line":"    def _get_cluster(self, cluster):"},{"line_number":81,"context_line":"        \"\"\"Get cluster details."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param cluster: cluster to get"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :returns: object of cluster"},{"line_number":86,"context_line":"        \"\"\""},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            return self.admin_clients(\"senlin\").get_cluster(cluster.id)"},{"line_number":89,"context_line":"        except Exception as e:"},{"line_number":90,"context_line":"            if getattr(e, \"code\", getattr(e, \"http_status\", 400)) \u003d\u003d 404:"},{"line_number":91,"context_line":"                raise exceptions.GetResourceNotFound(resource\u003dcluster.id)"},{"line_number":92,"context_line":"            raise exceptions.GetResourceFailure(resource\u003dcluster.id, err\u003de)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @atomic.action_timer(\"senlin.delete_cluster\")"},{"line_number":95,"context_line":"    def _delete_cluster(self, cluster):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_200f0b38","line":92,"range":{"start_line":79,"start_character":3,"end_line":92,"end_character":75},"updated":"2016-06-14 10:24:41.000000000","message":"Strange behaviour of this function. You pass the cluster to the function get_cluster. Something goes wrong here)","commit_id":"f3647cafe4a291b1114592dbbcb675f258f210d5"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"df872087d969814a76f676538ac626edbd7aeb56","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return cluster"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @atomic.action_timer(\"senlin.get_cluster\")"},{"line_number":80,"context_line":"    def _get_cluster(self, cluster):"},{"line_number":81,"context_line":"        \"\"\"Get cluster details."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param cluster: cluster to get"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :returns: object of cluster"},{"line_number":86,"context_line":"        \"\"\""},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            return self.admin_clients(\"senlin\").get_cluster(cluster.id)"},{"line_number":89,"context_line":"        except Exception as e:"},{"line_number":90,"context_line":"            if getattr(e, \"code\", getattr(e, \"http_status\", 400)) \u003d\u003d 404:"},{"line_number":91,"context_line":"                raise exceptions.GetResourceNotFound(resource\u003dcluster.id)"},{"line_number":92,"context_line":"            raise exceptions.GetResourceFailure(resource\u003dcluster.id, err\u003de)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @atomic.action_timer(\"senlin.delete_cluster\")"},{"line_number":95,"context_line":"    def _delete_cluster(self, cluster):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_e5e8437d","line":92,"range":{"start_line":79,"start_character":3,"end_line":92,"end_character":75},"in_reply_to":"7aa08908_200f0b38","updated":"2016-06-15 03:28:12.000000000","message":"Do you mean cluster ID rather than cluster object should be passed to _get_cluster method? For get_cluster method, cluster.id is passed to it currently. Actually both cluster object and cluster ID are available input for get_cluster method of senlinclient.","commit_id":"f3647cafe4a291b1114592dbbcb675f258f210d5"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac75056695a5714dd62ba3586d2ef92ea6a81f0a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            cluster,"},{"line_number":105,"context_line":"            # FIXME(Yanyan Hu): ready_statuses is actually useless"},{"line_number":106,"context_line":"            # for deleting Senlin cluster since cluster db item will"},{"line_number":107,"context_line":"            # be removed once cluster is deleted successfully."},{"line_number":108,"context_line":"            ready_statuses\u003d[\"DELETED\"],"},{"line_number":109,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":110,"context_line":"            check_deletion\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_137fcb15","line":107,"updated":"2016-06-14 10:24:41.000000000","message":"\"cluster db item will be removed once cluster is deleted successfully\" - maybe you want to tell that cluster would be removed immediately right after you give the command to delete the cluster. If so you don\u0027t need 103-112 line. Just 102","commit_id":"f3647cafe4a291b1114592dbbcb675f258f210d5"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"df872087d969814a76f676538ac626edbd7aeb56","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            cluster,"},{"line_number":105,"context_line":"            # FIXME(Yanyan Hu): ready_statuses is actually useless"},{"line_number":106,"context_line":"            # for deleting Senlin cluster since cluster db item will"},{"line_number":107,"context_line":"            # be removed once cluster is deleted successfully."},{"line_number":108,"context_line":"            ready_statuses\u003d[\"DELETED\"],"},{"line_number":109,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":110,"context_line":"            check_deletion\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_0824865d","line":107,"in_reply_to":"7aa08908_137fcb15","updated":"2016-06-15 03:28:12.000000000","message":"Sorry, I didn\u0027t explain it clearly. I mean in Senlin, the DB record of a cluster will be removed from \u0027cluster\u0027 table after the cluster is deleted. In that case, get_cluster method will return 404 NotFound exception rather than a cluster object whose status is \u0027DELETED\u0027. So the approach to tell whether a cluster deletion has been done is catching NotFound exception rather than checking cluster\u0027s status.","commit_id":"f3647cafe4a291b1114592dbbcb675f258f210d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"81c731c4d9771ba3fd23f1c45b0e3061b23e0519","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            cluster,"},{"line_number":72,"context_line":"            ready_statuses\u003d[\"ACTIVE\"],"},{"line_number":73,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":74,"context_line":"            update_resource\u003dself._get_cluster,"},{"line_number":75,"context_line":"            timeout\u003dCONF.benchmark.senlin_action_timeout)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return cluster"}],"source_content_type":"text/x-python","patch_set":18,"id":"3aaa91ec_f71d5c10","line":74,"updated":"2016-06-22 12:22:13.000000000","message":"This is a problem, because each time self._get_cluster() is called (L79), we have atomic action saved. As result, there is a nasty number of senlin.get_cluser atomic actions:\n\nhttp://logs.openstack.org/22/301522/18/experimental/gate-rally-dsvm-senlin-rally/12c2173/rally-plot/results.html.gz#/SenlinClusters.create_and_delete_profile_cluster/details","commit_id":"63d846d777172cb4456e4e64d23766ba7578ae2a"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"dcedfacb34a40fe4e14d1a152fe72071846f849b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            cluster,"},{"line_number":72,"context_line":"            ready_statuses\u003d[\"ACTIVE\"],"},{"line_number":73,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":74,"context_line":"            update_resource\u003dself._get_cluster,"},{"line_number":75,"context_line":"            timeout\u003dCONF.benchmark.senlin_action_timeout)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return cluster"}],"source_content_type":"text/x-python","patch_set":18,"id":"3aaa91ec_ecd44ebe","line":74,"in_reply_to":"3aaa91ec_f71d5c10","updated":"2016-06-23 02:24:56.000000000","message":"Thanks, Alexander, you\u0027re right. And the same problem happened when deleting cluster. I will remove the action_timer decorator of _get_cluster method to avoid this pollution to test result.","commit_id":"63d846d777172cb4456e4e64d23766ba7578ae2a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e4d440673883b65685825cb888f3367065223243","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        :returns: object of cluster created."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        attrs \u003d {}"},{"line_number":60,"context_line":"        attrs[\"profile_id\"] \u003d profile_id"},{"line_number":61,"context_line":"        attrs[\"name\"] \u003d self.generate_random_name()"},{"line_number":62,"context_line":"        attrs[\"desired_capacity\"] \u003d desired_capacity"},{"line_number":63,"context_line":"        attrs[\"min_size\"] \u003d min_size"},{"line_number":64,"context_line":"        attrs[\"max_size\"] \u003d max_size"},{"line_number":65,"context_line":"        attrs[\"metadata\"] \u003d metadata"},{"line_number":66,"context_line":"        if timeout:"},{"line_number":67,"context_line":"            attrs[\"timeout\"] \u003d timeout"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_dfead5ab","line":65,"range":{"start_line":59,"start_character":8,"end_line":65,"end_character":36},"updated":"2016-07-19 09:59:56.000000000","message":"NIT: this dictionary creation could be rewritten as a dictionary literal:\n\n    attrs \u003d {\"profile_id\": profile_id, \"name\": self.generate_random_name(), ...}","commit_id":"16efbedb6dc001a7ed4dcae735f41bcfe5851317"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"a77f1bc93a2aba4f5fc3e070ffe51899bc171443","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        :returns: object of cluster created."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        attrs \u003d {}"},{"line_number":60,"context_line":"        attrs[\"profile_id\"] \u003d profile_id"},{"line_number":61,"context_line":"        attrs[\"name\"] \u003d self.generate_random_name()"},{"line_number":62,"context_line":"        attrs[\"desired_capacity\"] \u003d desired_capacity"},{"line_number":63,"context_line":"        attrs[\"min_size\"] \u003d min_size"},{"line_number":64,"context_line":"        attrs[\"max_size\"] \u003d max_size"},{"line_number":65,"context_line":"        attrs[\"metadata\"] \u003d metadata"},{"line_number":66,"context_line":"        if timeout:"},{"line_number":67,"context_line":"            attrs[\"timeout\"] \u003d timeout"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_3361813a","line":65,"range":{"start_line":59,"start_character":8,"end_line":65,"end_character":36},"in_reply_to":"dada55a8_dfead5ab","updated":"2016-07-20 02:40:16.000000000","message":"Yes, will make a change.","commit_id":"16efbedb6dc001a7ed4dcae735f41bcfe5851317"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3fca3c445db3a4366dc009a7e5a8ac777570df07","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param cluster: cluster object to delete"},{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        cluster \u003d self.admin_clients(\"senlin\").delete_cluster(cluster)"},{"line_number":103,"context_line":"        utils.wait_for_status("},{"line_number":104,"context_line":"            cluster,"},{"line_number":105,"context_line":"            # FIXME(Yanyan Hu): ready_statuses is actually useless"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_4599026e","line":102,"updated":"2016-07-24 15:52:35.000000000","message":"What does it mean cluster returned by delete cluster?  I don\u0027t see it here http://developer.openstack.org/api-ref-clustering-v1.html#deleteCluster Looks like we don\u0027t need this assign","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"f6f015bb7e94af98319e21e04aedc52b04611f2d","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param cluster: cluster object to delete"},{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        cluster \u003d self.admin_clients(\"senlin\").delete_cluster(cluster)"},{"line_number":103,"context_line":"        utils.wait_for_status("},{"line_number":104,"context_line":"            cluster,"},{"line_number":105,"context_line":"            # FIXME(Yanyan Hu): ready_statuses is actually useless"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_903a15cc","line":102,"in_reply_to":"dada55a8_4599026e","updated":"2016-07-25 03:46:48.000000000","message":"Sorry, my mistake. We don\u0027t need this assignment here. Will remove it. BTW, the latest API reference is now accessible here: http://developer.openstack.org/api-ref/clustering/?expanded\u003ddelete-cluster-detail","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3fca3c445db3a4366dc009a7e5a8ac777570df07","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            cluster,"},{"line_number":105,"context_line":"            # FIXME(Yanyan Hu): ready_statuses is actually useless"},{"line_number":106,"context_line":"            # for deleting Senlin cluster since cluster db item will"},{"line_number":107,"context_line":"            # be removed once cluster is deleted successfully."},{"line_number":108,"context_line":"            ready_statuses\u003d[\"DELETED\"],"},{"line_number":109,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":110,"context_line":"            check_deletion\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_97a5f448","line":107,"updated":"2016-07-24 15:52:35.000000000","message":"Looks like you can pass here empty list as ready_statuses. If so I have solved you FIXME \u003d)","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"f6f015bb7e94af98319e21e04aedc52b04611f2d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            cluster,"},{"line_number":105,"context_line":"            # FIXME(Yanyan Hu): ready_statuses is actually useless"},{"line_number":106,"context_line":"            # for deleting Senlin cluster since cluster db item will"},{"line_number":107,"context_line":"            # be removed once cluster is deleted successfully."},{"line_number":108,"context_line":"            ready_statuses\u003d[\"DELETED\"],"},{"line_number":109,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":110,"context_line":"            check_deletion\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_1074659a","line":107,"in_reply_to":"dada55a8_97a5f448","updated":"2016-07-25 03:46:48.000000000","message":"Yep, empty list is adequate. Thanks for the fix :)","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3fca3c445db3a4366dc009a7e5a8ac777570df07","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return self.admin_clients(\"senlin\").create_profile(**attrs)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @atomic.action_timer(\"senlin.get_profile\")"},{"line_number":133,"context_line":"    def _get_profile(self, profile_id):"},{"line_number":134,"context_line":"        \"\"\"Get profile details."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        :param profile_id: ID of profile to get"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        :returns: object of profile"},{"line_number":139,"context_line":"        \"\"\""},{"line_number":140,"context_line":"        return self.admin_clients(\"senlin\").get_profile(profile_id)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @atomic.action_timer(\"senlin.delete_profile\")"},{"line_number":143,"context_line":"    def _delete_profile(self, profile):"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_05b6eadb","line":140,"range":{"start_line":132,"start_character":0,"end_line":140,"end_character":66},"updated":"2016-07-24 15:52:35.000000000","message":"Its not used elsewhere","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"f6f015bb7e94af98319e21e04aedc52b04611f2d","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return self.admin_clients(\"senlin\").create_profile(**attrs)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @atomic.action_timer(\"senlin.get_profile\")"},{"line_number":133,"context_line":"    def _get_profile(self, profile_id):"},{"line_number":134,"context_line":"        \"\"\"Get profile details."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        :param profile_id: ID of profile to get"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        :returns: object of profile"},{"line_number":139,"context_line":"        \"\"\""},{"line_number":140,"context_line":"        return self.admin_clients(\"senlin\").get_profile(profile_id)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @atomic.action_timer(\"senlin.delete_profile\")"},{"line_number":143,"context_line":"    def _delete_profile(self, profile):"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_706321de","line":140,"range":{"start_line":132,"start_character":0,"end_line":140,"end_character":66},"in_reply_to":"dada55a8_05b6eadb","updated":"2016-07-25 03:46:48.000000000","message":"Yes, will remove it.","commit_id":"6c0a57100ce41a5d6396b94d93ce371ab31db6bd"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"de7feba949f12121a33f11a82849804bffb6e352","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.admin_clients(\"senlin\").delete_cluster(cluster)"},{"line_number":103,"context_line":"        utils.wait_for_status("},{"line_number":104,"context_line":"            cluster,"},{"line_number":105,"context_line":"            ready_statuses\u003d[],"},{"line_number":106,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":107,"context_line":"            check_deletion\u003dTrue,"},{"line_number":108,"context_line":"            update_resource\u003dself._get_cluster,"}],"source_content_type":"text/x-python","patch_set":25,"id":"bacf61ea_468207c9","line":105,"updated":"2016-08-02 01:54:15.000000000","message":"ready_statuses cannot be empty although it is not needed here. Otherwise, exception will happen. Will make a change to fix it.\n\nhttp://git.openstack.org/cgit/openstack/rally/tree/rally/task/utils.py#n197","commit_id":"f8a4276d303d1c6bbd8bb84811ec5a7ee54c19ef"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d41fa12e8b33070bf39808a4bfc81b7749358b19","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Base class for Senlin scenarios with basic atomic actions.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @atomic.action_timer(\"senlin.list_clusters\")"},{"line_number":38,"context_line":"    def _list_clusters(self):"},{"line_number":39,"context_line":"        \"\"\"Return user cluster list.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        return list(self.admin_clients(\"senlin\").clusters())"}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_4e75ee61","line":38,"updated":"2016-08-02 11:40:42.000000000","message":"Here is more parameters http://developer.openstack.org/api-ref-clustering-v1.html#listClusters We should pass them","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e8b2f83ae9b0ce45c9437d041b4aee672720444c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Base class for Senlin scenarios with basic atomic actions.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @atomic.action_timer(\"senlin.list_clusters\")"},{"line_number":38,"context_line":"    def _list_clusters(self):"},{"line_number":39,"context_line":"        \"\"\"Return user cluster list.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        return list(self.admin_clients(\"senlin\").clusters())"}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_f95eff10","line":38,"in_reply_to":"bacf61ea_4e75ee61","updated":"2016-08-03 02:19:29.000000000","message":"Yes, will add query parameter.","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d41fa12e8b33070bf39808a4bfc81b7749358b19","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @atomic.action_timer(\"senlin.create_cluster\")"},{"line_number":44,"context_line":"    def _create_cluster(self, profile_id, desired_capacity\u003d0, min_size\u003d0,"},{"line_number":45,"context_line":"                        max_size\u003d-1, timeout\u003dNone, metadata\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Create a new cluster from attributes."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        :param profile_id: ID of profile used to create cluster"}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_2e94fa88","line":45,"updated":"2016-08-02 11:40:42.000000000","message":"We forgot to allow \u0027parent\u0027 attribute. It should be added to allow creation of nested clusters","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e8b2f83ae9b0ce45c9437d041b4aee672720444c","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @atomic.action_timer(\"senlin.create_cluster\")"},{"line_number":44,"context_line":"    def _create_cluster(self, profile_id, desired_capacity\u003d0, min_size\u003d0,"},{"line_number":45,"context_line":"                        max_size\u003d-1, timeout\u003dNone, metadata\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Create a new cluster from attributes."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        :param profile_id: ID of profile used to create cluster"}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_1955d3c5","line":45,"in_reply_to":"bacf61ea_2e94fa88","updated":"2016-08-03 02:19:29.000000000","message":"Hi, Roman, actually \u0027parent\u0027 attribute has been removed from cluster resource a while ago. We added this property for nested cluster support when we designed cluster resource at the beginning. But we found there is no such use case later and thus decided to remove it. Currently, \u0027parent\u0027 property is still kept in cluster DB model. But it has been removed from both engine and API layer and is thus invisible to enduser. Maybe in future, we will remove it from DB as well. Actually, in latest Senlin API reference, this property has been removed from description of cluster resource. The following is the link. Thanks.\n\nhttp://developer.openstack.org/api-ref/clustering/","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d41fa12e8b33070bf39808a4bfc81b7749358b19","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param min_size: The minimum number of nodes owned by the cluster"},{"line_number":52,"context_line":"        :param max_size: The maximum number of nodes owned by the cluster."},{"line_number":53,"context_line":"                         -1 means no limit"},{"line_number":54,"context_line":"        :param timeout: The timeout value in minutes for cluster creation"},{"line_number":55,"context_line":"        :param metadata: A set of key value pairs to associate with the cluster"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        :returns: object of cluster created."}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_4bde80dd","line":54,"updated":"2016-08-02 11:40:42.000000000","message":"The timeout value, in minutes, for cluster creation. Default is 60. \nSo we could write timeout\u003d60 and initialize attrs by timeout in 59 line","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e8b2f83ae9b0ce45c9437d041b4aee672720444c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param min_size: The minimum number of nodes owned by the cluster"},{"line_number":52,"context_line":"        :param max_size: The maximum number of nodes owned by the cluster."},{"line_number":53,"context_line":"                         -1 means no limit"},{"line_number":54,"context_line":"        :param timeout: The timeout value in minutes for cluster creation"},{"line_number":55,"context_line":"        :param metadata: A set of key value pairs to associate with the cluster"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        :returns: object of cluster created."}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_196cb39b","line":54,"in_reply_to":"bacf61ea_4bde80dd","updated":"2016-08-03 02:19:29.000000000","message":"I see. Will change.","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d41fa12e8b33070bf39808a4bfc81b7749358b19","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            raise exceptions.GetResourceFailure(resource\u003dcluster.id, err\u003de)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @atomic.action_timer(\"senlin.delete_cluster\")"},{"line_number":95,"context_line":"    def _delete_cluster(self, cluster):"},{"line_number":96,"context_line":"        \"\"\"Delete given cluster."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        Returns after the cluster is successfully deleted."}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_8eac068d","line":95,"updated":"2016-08-02 11:40:42.000000000","message":"In the docs is written that it should except id not the whole cluster http://developer.openstack.org/api-ref-clustering-v1.html#deleteCluster","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e8b2f83ae9b0ce45c9437d041b4aee672720444c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            raise exceptions.GetResourceFailure(resource\u003dcluster.id, err\u003de)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @atomic.action_timer(\"senlin.delete_cluster\")"},{"line_number":95,"context_line":"    def _delete_cluster(self, cluster):"},{"line_number":96,"context_line":"        \"\"\"Delete given cluster."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        Returns after the cluster is successfully deleted."}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_592bcb33","line":95,"in_reply_to":"bacf61ea_8eac068d","updated":"2016-08-03 02:19:29.000000000","message":"Yes, for cluster delete API, cluster_id is expected. But for delete_cluster method in senlinclient, both cluster_id and cluster object are acceptable. Senlinclient will extract cluster_id from cluster object before requesting Senlin API. So sorry for the inaccuracy of senlinclient doc. Will improve it later. Thanks.","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d41fa12e8b33070bf39808a4bfc81b7749358b19","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param cluster: cluster object to delete"},{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        self.admin_clients(\"senlin\").delete_cluster(cluster)"},{"line_number":103,"context_line":"        utils.wait_for_status("},{"line_number":104,"context_line":"            cluster,"},{"line_number":105,"context_line":"            ready_statuses\u003d[\"DELETED\"],"}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_aebbcac2","line":102,"updated":"2016-08-02 11:40:42.000000000","message":"In the docs is written that it should except id not the whole cluster http://developer.openstack.org/api-ref-clustering-v1.html#deleteCluster","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e8b2f83ae9b0ce45c9437d041b4aee672720444c","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param cluster: cluster object to delete"},{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        self.admin_clients(\"senlin\").delete_cluster(cluster)"},{"line_number":103,"context_line":"        utils.wait_for_status("},{"line_number":104,"context_line":"            cluster,"},{"line_number":105,"context_line":"            ready_statuses\u003d[\"DELETED\"],"}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_792a0f2e","line":102,"in_reply_to":"bacf61ea_aebbcac2","updated":"2016-08-03 02:19:29.000000000","message":"The same as above.","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d41fa12e8b33070bf39808a4bfc81b7749358b19","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        return self.admin_clients(\"senlin\").create_profile(**attrs)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @atomic.action_timer(\"senlin.delete_profile\")"},{"line_number":130,"context_line":"    def _delete_profile(self, profile):"},{"line_number":131,"context_line":"        \"\"\"Delete given profile."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        Returns after the profile is successfully deleted."}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_eeff8263","line":130,"updated":"2016-08-02 11:40:42.000000000","message":"The same as in 102 is for profile http://developer.openstack.org/api-ref-clustering-v1.html#deleteProfile How its working?)","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e8b2f83ae9b0ce45c9437d041b4aee672720444c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        return self.admin_clients(\"senlin\").create_profile(**attrs)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @atomic.action_timer(\"senlin.delete_profile\")"},{"line_number":130,"context_line":"    def _delete_profile(self, profile):"},{"line_number":131,"context_line":"        \"\"\"Delete given profile."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        Returns after the profile is successfully deleted."}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_191af317","line":130,"in_reply_to":"bacf61ea_eeff8263","updated":"2016-08-03 02:19:29.000000000","message":"The same as delete_cluster. senlinclient will extract profile_id from profile object provided. Thanks.","commit_id":"48f7c3266dd4bb178bd4fa2b2012ebe38d42aee2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3216670ecc6e7d0773e006a6ee878b6f2bee2241","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from rally.task import atomic"},{"line_number":19,"context_line":"from rally.task import utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"SENLIN_BENCHMARK_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.FloatOpt(\"senlin_action_timeout\","}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_808e5525","line":21,"updated":"2016-08-03 10:20:22.000000000","message":"Its redundant here","commit_id":"9bba7c9a7e7f8ca2d343190edd37876ecfefc5fa"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"cf5e367c7e615828d8957822e530e2261c43018e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from rally.task import atomic"},{"line_number":19,"context_line":"from rally.task import utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"SENLIN_BENCHMARK_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.FloatOpt(\"senlin_action_timeout\","}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_331d4167","line":21,"in_reply_to":"bacf61ea_808e5525","updated":"2016-08-03 10:23:58.000000000","message":"will remove it.","commit_id":"9bba7c9a7e7f8ca2d343190edd37876ecfefc5fa"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3216670ecc6e7d0773e006a6ee878b6f2bee2241","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                the last-seen item from the response as the marker parameter"},{"line_number":55,"context_line":"                value in a subsequent limited request."},{"line_number":56,"context_line":"            * global_project: A boolean value indicating whether clusters"},{"line_number":57,"context_line":"                from all projects will be returned."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        return list(self.admin_clients(\"senlin\").clusters(**queries))"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_a08719d6","line":57,"updated":"2016-08-03 10:20:22.000000000","message":":returns: list of clusters according to query.","commit_id":"9bba7c9a7e7f8ca2d343190edd37876ecfefc5fa"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"cf5e367c7e615828d8957822e530e2261c43018e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                the last-seen item from the response as the marker parameter"},{"line_number":55,"context_line":"                value in a subsequent limited request."},{"line_number":56,"context_line":"            * global_project: A boolean value indicating whether clusters"},{"line_number":57,"context_line":"                from all projects will be returned."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        return list(self.admin_clients(\"senlin\").clusters(**queries))"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_7325f9ac","line":57,"in_reply_to":"bacf61ea_a08719d6","updated":"2016-08-03 10:23:58.000000000","message":"Done","commit_id":"9bba7c9a7e7f8ca2d343190edd37876ecfefc5fa"}],"samples/tasks/scenarios/senlin/create-and-delete-cluster.json":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"743e611ee935d92e3519c0385034b611f6802ad1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"SenlinClusters.create_and_delete_cluster\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {"},{"line_number":5,"context_line":"               \"spec_path\": \"specs/nova_server.yaml\","},{"line_number":6,"context_line":"               \"desired_capacity\": 3,"},{"line_number":7,"context_line":"               \"min_size\": 0,"},{"line_number":8,"context_line":"               \"max_size\": 5"}],"source_content_type":"application/json","patch_set":2,"id":"9a061dce_bf1bbf1a","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":25},"updated":"2016-04-05 09:30:41.000000000","message":"this is a bit confusing ... should we directly embed the nova_server.yaml contents here?","commit_id":"8a8803814eba3bb90038b350675f9939370320d3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"64b3d10ea5a2b24b9b0307b44a53ae7812b01bb3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"SenlinClusters.create_and_delete_cluster\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {"},{"line_number":5,"context_line":"               \"spec_path\": \"specs/nova_server.yaml\","},{"line_number":6,"context_line":"               \"desired_capacity\": 3,"},{"line_number":7,"context_line":"               \"min_size\": 0,"},{"line_number":8,"context_line":"               \"max_size\": 5"}],"source_content_type":"application/json","patch_set":2,"id":"9a061dce_82fae4bb","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":25},"in_reply_to":"9a061dce_bf1bbf1a","updated":"2016-04-05 09:47:04.000000000","message":"Done","commit_id":"8a8803814eba3bb90038b350675f9939370320d3"}],"tests/ci/osresources.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"fd307d984d3b5f29d2b1b9d594ac108428a91a7e","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def list_clusters(self):"},{"line_number":216,"context_line":"        return self.client.clusters()"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"class CloudResources(object):"},{"line_number":220,"context_line":"    \"\"\"List and compare cloud resources."}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_14b0ea42","line":217,"updated":"2016-06-06 13:50:58.000000000","message":"Method list_profiles() is also needed","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1b7be951ccdd6a325c7fe4a1ff7257c635b815c6","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def list_clusters(self):"},{"line_number":216,"context_line":"        return self.client.clusters()"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"class CloudResources(object):"},{"line_number":220,"context_line":"    \"\"\"List and compare cloud resources."}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_c1902251","line":217,"in_reply_to":"7aa08908_14b0ea42","updated":"2016-06-11 10:38:49.000000000","message":"Will add it.","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"}],"tests/unit/plugins/openstack/cleanup/test_resources.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"fd307d984d3b5f29d2b1b9d594ac108428a91a7e","unresolved":false,"context_lines":[{"line_number":745,"context_line":"        cluster \u003d resources.SenlinCluster()"},{"line_number":746,"context_line":"        cluster._manager \u003d mock.MagicMock()"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        cluster.list()"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        self.assertEqual(\"clusters\", cluster._resource)"},{"line_number":751,"context_line":"        cluster._manager.return_value.clusters.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_ef3747e1","line":748,"updated":"2016-06-06 13:50:58.000000000","message":"return value must be checked.\n\nAt L751 we checked that proper method is called behind the scene, however was the result actually returned by list() ?","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1b7be951ccdd6a325c7fe4a1ff7257c635b815c6","unresolved":false,"context_lines":[{"line_number":745,"context_line":"        cluster \u003d resources.SenlinCluster()"},{"line_number":746,"context_line":"        cluster._manager \u003d mock.MagicMock()"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        cluster.list()"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        self.assertEqual(\"clusters\", cluster._resource)"},{"line_number":751,"context_line":"        cluster._manager.return_value.clusters.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_418b921e","line":748,"in_reply_to":"7aa08908_ef3747e1","updated":"2016-06-11 10:38:49.000000000","message":"I see, will complete this test case.","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"}],"tests/unit/plugins/openstack/scenarios/senlin/test_clusters.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"fd307d984d3b5f29d2b1b9d594ac108428a91a7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_4fbf7bfb","line":1,"updated":"2016-06-06 13:50:58.000000000","message":"1) 2016\n\n2) Red Hat? Maybe IBM (according to your email address)?","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1b7be951ccdd6a325c7fe4a1ff7257c635b815c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_e17c3e22","line":1,"in_reply_to":"7aa08908_4fbf7bfb","updated":"2016-06-11 10:38:49.000000000","message":"Sorry, I should remove this copyright line. Will change.","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6929e646c83ffcb25bd2da72ae0f9b2e8014d323","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from rally.plugins.openstack.scenarios.senlin import clusters"},{"line_number":16,"context_line":"from tests.unit import test"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BASE \u003d \"rally.plugins.openstack.scenarios.senlin.\""},{"line_number":19,"context_line":"CLUSTER \u003d BASE + \"clusters.SenlinClusters.\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SenlinClustersTestCase(test.ScenarioTestCase):"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_3febff14","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":43},"updated":"2016-07-20 06:17:56.000000000","message":"these variables are not used.","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e1f858044727cac23d16e9d699531e0d62ec53ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from rally.plugins.openstack.scenarios.senlin import clusters"},{"line_number":16,"context_line":"from tests.unit import test"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BASE \u003d \"rally.plugins.openstack.scenarios.senlin.\""},{"line_number":19,"context_line":"CLUSTER \u003d BASE + \"clusters.SenlinClusters.\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SenlinClustersTestCase(test.ScenarioTestCase):"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_4597cb39","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":43},"in_reply_to":"dada55a8_3febff14","updated":"2016-07-21 02:45:01.000000000","message":"Yes, will remove them.","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6929e646c83ffcb25bd2da72ae0f9b2e8014d323","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_create_and_delete_cluster(self):"},{"line_number":25,"context_line":"        profile_spec \u003d {\"k1\": \"v1\"}"},{"line_number":26,"context_line":"        mock_profile \u003d mock.Mock()"},{"line_number":27,"context_line":"        mock_cluster \u003d mock.Mock()"},{"line_number":28,"context_line":"        mock_profile.id \u003d \"fake_profile_id\""},{"line_number":29,"context_line":"        mock_cluster.id \u003d \"fake_cluster_id\""},{"line_number":30,"context_line":"        scenario \u003d clusters.SenlinClusters(self.context)"},{"line_number":31,"context_line":"        scenario._create_profile \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        scenario._create_cluster \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_dc011108","line":29,"range":{"start_line":26,"start_character":8,"end_line":29,"end_character":43},"updated":"2016-07-20 06:17:56.000000000","message":"NIT: you can merge these 4 lines in 2:\n\n        mock_profile \u003d mock.Mock(id\u003d\"fake_profile_id\")\n        mock_cluster \u003d mock.Mock(id\u003d\"fake_cluster_id\")","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e1f858044727cac23d16e9d699531e0d62ec53ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_create_and_delete_cluster(self):"},{"line_number":25,"context_line":"        profile_spec \u003d {\"k1\": \"v1\"}"},{"line_number":26,"context_line":"        mock_profile \u003d mock.Mock()"},{"line_number":27,"context_line":"        mock_cluster \u003d mock.Mock()"},{"line_number":28,"context_line":"        mock_profile.id \u003d \"fake_profile_id\""},{"line_number":29,"context_line":"        mock_cluster.id \u003d \"fake_cluster_id\""},{"line_number":30,"context_line":"        scenario \u003d clusters.SenlinClusters(self.context)"},{"line_number":31,"context_line":"        scenario._create_profile \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        scenario._create_cluster \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_a5e2072d","line":29,"range":{"start_line":26,"start_character":8,"end_line":29,"end_character":43},"in_reply_to":"dada55a8_dc011108","updated":"2016-07-21 02:45:01.000000000","message":"Done","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6929e646c83ffcb25bd2da72ae0f9b2e8014d323","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        mock_profile.id \u003d \"fake_profile_id\""},{"line_number":29,"context_line":"        mock_cluster.id \u003d \"fake_cluster_id\""},{"line_number":30,"context_line":"        scenario \u003d clusters.SenlinClusters(self.context)"},{"line_number":31,"context_line":"        scenario._create_profile \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        scenario._create_cluster \u003d mock.MagicMock()"},{"line_number":33,"context_line":"        scenario._delete_cluster \u003d mock.MagicMock()"},{"line_number":34,"context_line":"        scenario._delete_profile \u003d mock.MagicMock()"},{"line_number":35,"context_line":"        scenario._create_profile.return_value \u003d mock_profile"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_ff1b2771","line":32,"range":{"start_line":31,"start_character":8,"end_line":32,"end_character":51},"updated":"2016-07-20 06:17:56.000000000","message":"same here:\n\n        scenario._create_profile \u003d mock.MagicMock(return_value\u003dmock_profile)\n        scenario._create_cluster \u003d mock.MagicMock(return_value\u003dmock_cluster)","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e1f858044727cac23d16e9d699531e0d62ec53ac","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        mock_profile.id \u003d \"fake_profile_id\""},{"line_number":29,"context_line":"        mock_cluster.id \u003d \"fake_cluster_id\""},{"line_number":30,"context_line":"        scenario \u003d clusters.SenlinClusters(self.context)"},{"line_number":31,"context_line":"        scenario._create_profile \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        scenario._create_cluster \u003d mock.MagicMock()"},{"line_number":33,"context_line":"        scenario._delete_cluster \u003d mock.MagicMock()"},{"line_number":34,"context_line":"        scenario._delete_profile \u003d mock.MagicMock()"},{"line_number":35,"context_line":"        scenario._create_profile.return_value \u003d mock_profile"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_05d2f35b","line":32,"range":{"start_line":31,"start_character":8,"end_line":32,"end_character":51},"in_reply_to":"dada55a8_ff1b2771","updated":"2016-07-21 02:45:01.000000000","message":"Done","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6929e646c83ffcb25bd2da72ae0f9b2e8014d323","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        mock_profile.id \u003d \"fake_profile_id\""},{"line_number":29,"context_line":"        mock_cluster.id \u003d \"fake_cluster_id\""},{"line_number":30,"context_line":"        scenario \u003d clusters.SenlinClusters(self.context)"},{"line_number":31,"context_line":"        scenario._create_profile \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        scenario._create_cluster \u003d mock.MagicMock()"},{"line_number":33,"context_line":"        scenario._delete_cluster \u003d mock.MagicMock()"},{"line_number":34,"context_line":"        scenario._delete_profile \u003d mock.MagicMock()"},{"line_number":35,"context_line":"        scenario._create_profile.return_value \u003d mock_profile"},{"line_number":36,"context_line":"        scenario._create_cluster.return_value \u003d mock_cluster"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_df8bc366","line":34,"range":{"start_line":31,"start_character":8,"end_line":34,"end_character":51},"updated":"2016-07-20 06:17:56.000000000","message":"In general, I prefer to make such mocks in another way via decorators:\n\n   @mock.patch(\"%sutils.SenlinScenario._delete_cluster\")\n   @mock.patch(\"%sutils.SenlinScenario._delete_profile\")\n   @mock.patch(\"%sutils.SenlinScenario._create_cluster\")\n   @mock.patch(\"%sutils.SenlinScenario._create_profile\")\n   def test_create_and_delete_cluster(self, mock__create_profile, mock__create_cluster, mock__delete_profile, mock__delete_cluster):\n        pass\n\n\nBut I\u0027m ok with the way you choose.","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e1f858044727cac23d16e9d699531e0d62ec53ac","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        mock_profile.id \u003d \"fake_profile_id\""},{"line_number":29,"context_line":"        mock_cluster.id \u003d \"fake_cluster_id\""},{"line_number":30,"context_line":"        scenario \u003d clusters.SenlinClusters(self.context)"},{"line_number":31,"context_line":"        scenario._create_profile \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        scenario._create_cluster \u003d mock.MagicMock()"},{"line_number":33,"context_line":"        scenario._delete_cluster \u003d mock.MagicMock()"},{"line_number":34,"context_line":"        scenario._delete_profile \u003d mock.MagicMock()"},{"line_number":35,"context_line":"        scenario._create_profile.return_value \u003d mock_profile"},{"line_number":36,"context_line":"        scenario._create_cluster.return_value \u003d mock_cluster"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_25445719","line":34,"range":{"start_line":31,"start_character":8,"end_line":34,"end_character":51},"in_reply_to":"dada55a8_df8bc366","updated":"2016-07-21 02:45:01.000000000","message":"Yes, actually myself also don\u0027t like MagicMock so much since it is too \"magic\" sometimes to test some tricky defects :) So will use mock.Mock to replace MagicMock here. Thanks.","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"}],"tests/unit/plugins/openstack/scenarios/senlin/test_utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"fd307d984d3b5f29d2b1b9d594ac108428a91a7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_2fc66f67","line":1,"updated":"2016-06-06 13:50:58.000000000","message":"ditto","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1b7be951ccdd6a325c7fe4a1ff7257c635b815c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_c1778239","line":1,"in_reply_to":"7aa08908_2fc66f67","updated":"2016-06-11 10:38:49.000000000","message":"Done","commit_id":"49be509b48f76f1d49d12e6f4a71802ca4eaa39e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6929e646c83ffcb25bd2da72ae0f9b2e8014d323","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @mock.patch(SENLIN_UTILS + \"SenlinScenario.generate_random_name\","},{"line_number":36,"context_line":"                return_value\u003d\"test_cluster\")"},{"line_number":37,"context_line":"    def test_create_cluster(self, mock_generate_random_name):"},{"line_number":38,"context_line":"        fake_cluster \u003d mock.Mock()"},{"line_number":39,"context_line":"        fake_cluster.id \u003d \"fake_cluster_id\""},{"line_number":40,"context_line":"        res_cluster \u003d mock.Mock()"},{"line_number":41,"context_line":"        self.admin_clients(\"senlin\").create_cluster.return_value \u003d fake_cluster"},{"line_number":42,"context_line":"        self.mock_wait_for_status.mock.return_value \u003d res_cluster"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_7fc8d7a8","line":39,"range":{"start_line":38,"start_character":8,"end_line":39,"end_character":43},"updated":"2016-07-20 06:17:56.000000000","message":"same nit here, you can merge these lines","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e1f858044727cac23d16e9d699531e0d62ec53ac","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @mock.patch(SENLIN_UTILS + \"SenlinScenario.generate_random_name\","},{"line_number":36,"context_line":"                return_value\u003d\"test_cluster\")"},{"line_number":37,"context_line":"    def test_create_cluster(self, mock_generate_random_name):"},{"line_number":38,"context_line":"        fake_cluster \u003d mock.Mock()"},{"line_number":39,"context_line":"        fake_cluster.id \u003d \"fake_cluster_id\""},{"line_number":40,"context_line":"        res_cluster \u003d mock.Mock()"},{"line_number":41,"context_line":"        self.admin_clients(\"senlin\").create_cluster.return_value \u003d fake_cluster"},{"line_number":42,"context_line":"        self.mock_wait_for_status.mock.return_value \u003d res_cluster"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_052e7342","line":39,"range":{"start_line":38,"start_character":8,"end_line":39,"end_character":43},"in_reply_to":"dada55a8_7fc8d7a8","updated":"2016-07-21 02:45:01.000000000","message":"Done","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6929e646c83ffcb25bd2da72ae0f9b2e8014d323","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                       \"senlin.create_cluster\")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_get_cluster(self):"},{"line_number":66,"context_line":"        fake_cluster \u003d mock.Mock()"},{"line_number":67,"context_line":"        fake_cluster.id \u003d \"fake_cluster_id\""},{"line_number":68,"context_line":"        scenario \u003d utils.SenlinScenario(context\u003dself.context)"},{"line_number":69,"context_line":"        scenario._get_cluster(fake_cluster)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_bfc6cf97","line":67,"range":{"start_line":66,"start_character":8,"end_line":67,"end_character":43},"updated":"2016-07-20 06:17:56.000000000","message":"same here","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e1f858044727cac23d16e9d699531e0d62ec53ac","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                       \"senlin.create_cluster\")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_get_cluster(self):"},{"line_number":66,"context_line":"        fake_cluster \u003d mock.Mock()"},{"line_number":67,"context_line":"        fake_cluster.id \u003d \"fake_cluster_id\""},{"line_number":68,"context_line":"        scenario \u003d utils.SenlinScenario(context\u003dself.context)"},{"line_number":69,"context_line":"        scenario._get_cluster(fake_cluster)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_a5fe87ab","line":67,"range":{"start_line":66,"start_character":8,"end_line":67,"end_character":43},"in_reply_to":"dada55a8_bfc6cf97","updated":"2016-07-21 02:45:01.000000000","message":"Done","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6929e646c83ffcb25bd2da72ae0f9b2e8014d323","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"fake_cluster_id\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_get_cluster_notfound(self):"},{"line_number":75,"context_line":"        fake_cluster \u003d mock.Mock()"},{"line_number":76,"context_line":"        fake_cluster.id \u003d \"fake_cluster_id\""},{"line_number":77,"context_line":"        ex \u003d Exception()"},{"line_number":78,"context_line":"        ex.code \u003d 404"},{"line_number":79,"context_line":"        self.admin_clients(\"senlin\").get_cluster.side_effect \u003d ex"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_3f393fa5","line":76,"range":{"start_line":75,"start_character":8,"end_line":76,"end_character":43},"updated":"2016-07-20 06:17:56.000000000","message":"and here:)","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e1f858044727cac23d16e9d699531e0d62ec53ac","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"fake_cluster_id\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_get_cluster_notfound(self):"},{"line_number":75,"context_line":"        fake_cluster \u003d mock.Mock()"},{"line_number":76,"context_line":"        fake_cluster.id \u003d \"fake_cluster_id\""},{"line_number":77,"context_line":"        ex \u003d Exception()"},{"line_number":78,"context_line":"        ex.code \u003d 404"},{"line_number":79,"context_line":"        self.admin_clients(\"senlin\").get_cluster.side_effect \u003d ex"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_c518db20","line":76,"range":{"start_line":75,"start_character":8,"end_line":76,"end_character":43},"in_reply_to":"dada55a8_3f393fa5","updated":"2016-07-21 02:45:01.000000000","message":"Done","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6929e646c83ffcb25bd2da72ae0f9b2e8014d323","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            \"fake_cluster_id\")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_get_cluster_failed(self):"},{"line_number":89,"context_line":"        fake_cluster \u003d mock.Mock()"},{"line_number":90,"context_line":"        fake_cluster.id \u003d \"fake_cluster_id\""},{"line_number":91,"context_line":"        ex \u003d Exception()"},{"line_number":92,"context_line":"        ex.code \u003d 500"},{"line_number":93,"context_line":"        self.admin_clients(\"senlin\").get_cluster.side_effect \u003d ex"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_7f3f3787","line":90,"range":{"start_line":89,"start_character":8,"end_line":90,"end_character":43},"updated":"2016-07-20 06:17:56.000000000","message":"you know what I mean","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"e1f858044727cac23d16e9d699531e0d62ec53ac","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            \"fake_cluster_id\")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_get_cluster_failed(self):"},{"line_number":89,"context_line":"        fake_cluster \u003d mock.Mock()"},{"line_number":90,"context_line":"        fake_cluster.id \u003d \"fake_cluster_id\""},{"line_number":91,"context_line":"        ex \u003d Exception()"},{"line_number":92,"context_line":"        ex.code \u003d 500"},{"line_number":93,"context_line":"        self.admin_clients(\"senlin\").get_cluster.side_effect \u003d ex"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_05d5d31a","line":90,"range":{"start_line":89,"start_character":8,"end_line":90,"end_character":43},"in_reply_to":"dada55a8_7f3f3787","updated":"2016-07-21 02:45:01.000000000","message":"yep:)","commit_id":"173cc35e74fa5115fe23b01c2ab7661b297029e3"}]}
