)]}'
{"rally/verification/tempest/config.py":[{"author":{"_account_id":20196,"name":"Piyush","email":"piyush2011257@gmail.com","username":"pirsriva"},"change_message_id":"053512884728db0033e09a7322132f8fc03af2b2","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        glance_wrap \u003d glance_wrapper.wrap(self.clients.glance, self)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        if CONF.image.name_regex:"},{"line_number":425,"context_line":"            LOG.debug(\"Trying to discover an image with name matching \""},{"line_number":426,"context_line":"                      \"regular expression \u0027%s\u0027. Note that case insensitive \""},{"line_number":427,"context_line":"                      \"matching is performed\" % CONF.image.name_regex)"},{"line_number":428,"context_line":"            images \u003d self.clients.glance().images.list()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_3e3151ed","line":425,"updated":"2016-04-05 17:36:22.000000000","message":"Small nit. It would be better to mention \"public image\" instead of just \"image\" in logs.","commit_id":"ef60847acdbfbdd6e37dda426d4c923b2e8f57fe"},{"author":{"_account_id":20196,"name":"Piyush","email":"piyush2011257@gmail.com","username":"pirsriva"},"change_message_id":"05c569861e27e3dc165bacf1affb8659803aedf1","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                        and img.status.lower() \u003d\u003d \"active\" and img.name]"},{"line_number":431,"context_line":"            for img in img_list:"},{"line_number":432,"context_line":"                if re.match(CONF.image.name_regex, img.name, re.IGNORECASE):"},{"line_number":433,"context_line":"                    LOG.debug(\"The following image discovered: \u0027{0}\u0027. Using \""},{"line_number":434,"context_line":"                              \"image \u0027{0}\u0027 for the tests\".format(img.name))"},{"line_number":435,"context_line":"                    return img"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_fe9fd94d","line":433,"updated":"2016-04-05 17:37:03.000000000","message":"Same as above","commit_id":"ef60847acdbfbdd6e37dda426d4c923b2e8f57fe"},{"author":{"_account_id":20196,"name":"Piyush","email":"piyush2011257@gmail.com","username":"pirsriva"},"change_message_id":"053512884728db0033e09a7322132f8fc03af2b2","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                              \"image \u0027{0}\u0027 for the tests\".format(img.name))"},{"line_number":435,"context_line":"                    return img"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"            LOG.debug(\"There is no image with name matching \""},{"line_number":438,"context_line":"                      \"regular expression \u0027%s\u0027\" % CONF.image.name_regex)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_de581535","line":437,"updated":"2016-04-05 17:36:22.000000000","message":"Same as above","commit_id":"ef60847acdbfbdd6e37dda426d4c923b2e8f57fe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d1d1c39eae7b35efb9e4253dd719481743976446","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            LOG.debug(\"Trying to discover a public image with name matching \""},{"line_number":426,"context_line":"                      \"regular expression \u0027%s\u0027. Note that case insensitive \""},{"line_number":427,"context_line":"                      \"matching is performed\" % CONF.image.name_regex)"},{"line_number":428,"context_line":"            images \u003d self.clients.glance().images.list()"},{"line_number":429,"context_line":"            filtered_images \u003d [img for img in images if img.is_public is True"},{"line_number":430,"context_line":"                               and img.status.lower() \u003d\u003d \"active\" and img.name]"},{"line_number":431,"context_line":"            for img in filtered_images:"},{"line_number":432,"context_line":"                if re.match(CONF.image.name_regex, img.name, re.IGNORECASE):"},{"line_number":433,"context_line":"                    LOG.debug("},{"line_number":434,"context_line":"                        \"The following public image discovered: \u0027{0}\u0027. \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_01bb9bc5","line":431,"range":{"start_line":428,"start_character":12,"end_line":431,"end_character":39},"updated":"2016-04-11 12:17:36.000000000","message":"I suppose you can replace this code by:\n\n    images \u003d self.clients.glance().images.list(filters\u003d{\"is_public\": True})","commit_id":"cfd62ef679f3d4fff5d9951261f021fe037b3db4"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"6293734bcacc047a38c6d3079b58dc66a40955e1","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            LOG.debug(\"Trying to discover a public image with name matching \""},{"line_number":426,"context_line":"                      \"regular expression \u0027%s\u0027. Note that case insensitive \""},{"line_number":427,"context_line":"                      \"matching is performed\" % CONF.image.name_regex)"},{"line_number":428,"context_line":"            images \u003d self.clients.glance().images.list()"},{"line_number":429,"context_line":"            filtered_images \u003d [img for img in images if img.is_public is True"},{"line_number":430,"context_line":"                               and img.status.lower() \u003d\u003d \"active\" and img.name]"},{"line_number":431,"context_line":"            for img in filtered_images:"},{"line_number":432,"context_line":"                if re.match(CONF.image.name_regex, img.name, re.IGNORECASE):"},{"line_number":433,"context_line":"                    LOG.debug("},{"line_number":434,"context_line":"                        \"The following public image discovered: \u0027{0}\u0027. \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_ba1db0bf","line":431,"range":{"start_line":428,"start_character":12,"end_line":431,"end_character":39},"in_reply_to":"7a1b2928_01bb9bc5","updated":"2016-04-11 13:09:17.000000000","message":"Sorry, but it doesn\u0027t work. I tried already to do in such way, but I failed.","commit_id":"cfd62ef679f3d4fff5d9951261f021fe037b3db4"},{"author":{"_account_id":20196,"name":"Piyush","email":"piyush2011257@gmail.com","username":"pirsriva"},"change_message_id":"c7f78fe5ccbab28147efa88312502c44fbfb2895","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            LOG.debug(\"Trying to discover a public image with name matching \""},{"line_number":426,"context_line":"                      \"regular expression \u0027%s\u0027. Note that case insensitive \""},{"line_number":427,"context_line":"                      \"matching is performed\" % CONF.image.name_regex)"},{"line_number":428,"context_line":"            images \u003d self.clients.glance().images.list()"},{"line_number":429,"context_line":"            filtered_images \u003d [img for img in images if img.is_public is True"},{"line_number":430,"context_line":"                               and img.status.lower() \u003d\u003d \"active\" and img.name]"},{"line_number":431,"context_line":"            for img in filtered_images:"},{"line_number":432,"context_line":"                if re.match(CONF.image.name_regex, img.name, re.IGNORECASE):"},{"line_number":433,"context_line":"                    LOG.debug("},{"line_number":434,"context_line":"                        \"The following public image discovered: \u0027{0}\u0027. \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_40143243","line":431,"range":{"start_line":428,"start_character":12,"end_line":431,"end_character":39},"in_reply_to":"7a1b2928_ba1db0bf","updated":"2016-04-13 11:37:10.000000000","message":"I browsed through the glanceclient code.\nThis method that you used in the patch is specific to glance API v1 only ( is_public ).\nIn V2 , there is no \"is_public\" field !!\nMy concern is that the patch is becoming specific to Glance V1 API and not compatible with V2 Glance API\n\n\n[root@rally-sep11-148 tutorial]# glance --os-image-api-version 1 image-show 314f6964-8b0c-4c93-9775-87c164ae21c1\n+------------------+--------------------------------------+\n| Property         | Value                                |\n+------------------+--------------------------------------+\n| checksum         | 133eae9fb1c98f45894a4e60d8736619     |\n| container_format | bare                                 |\n| created_at       | 2015-07-29T09:28:02.000000           |\n| deleted          | False                                |\n| disk_format      | qcow2                                |\n| id               | 314f6964-8b0c-4c93-9775-87c164ae21c1 |\n| is_public        | True                                 |\n| min_disk         | 0                                    |\n| min_ram          | 0                                    |\n| name             | cirros                               |\n| owner            | d99ab9c5d14f4dd1aa9830f0f70f3fe5     |\n| protected        | False                                |\n| size             | 13200896                             |\n| status           | active                               |\n| updated_at       | 2015-07-29T09:28:03.000000           |\n+------------------+--------------------------------------+\n\n\n\n[root@rally-sep11-148 tutorial]# glance --os-image-api-version 2 image-show 314f6964-8b0c-4c93-9775-87c164ae21c1\n+------------------+--------------------------------------+\n| Property         | Value                                |\n+------------------+--------------------------------------+\n| checksum         | 133eae9fb1c98f45894a4e60d8736619     |\n| container_format | bare                                 |\n| created_at       | 2015-07-29T09:28:02Z                 |\n| disk_format      | qcow2                                |\n| id               | 314f6964-8b0c-4c93-9775-87c164ae21c1 |\n| min_disk         | 0                                    |\n| min_ram          | 0                                    |\n| name             | cirros                               |\n| owner            | d99ab9c5d14f4dd1aa9830f0f70f3fe5     |\n| protected        | False                                |\n| size             | 13200896                             |\n| status           | active                               |\n| tags             | []                                   |\n| updated_at       | 2015-07-29T09:28:03Z                 |\n| virtual_size     | None                                 |\n| visibility       | public                               |\n+------------------+--------------------------------------+","commit_id":"cfd62ef679f3d4fff5d9951261f021fe037b3db4"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2e629d914cf5ed9536857f90a91d4bef211ea16e","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            LOG.debug(\"Trying to discover a public image with name matching \""},{"line_number":426,"context_line":"                      \"regular expression \u0027%s\u0027. Note that case insensitive \""},{"line_number":427,"context_line":"                      \"matching is performed\" % CONF.image.name_regex)"},{"line_number":428,"context_line":"            images \u003d self.clients.glance().images.list("},{"line_number":429,"context_line":"                filters\u003d{\"status\": \"active\"})"},{"line_number":430,"context_line":"            filtered_images \u003d ["},{"line_number":431,"context_line":"                img for img in images if getattr(img, \"is_public\", False)"},{"line_number":432,"context_line":"                or getattr(img, \"visibility\", None) \u003d\u003d \"public\" and img.name]"},{"line_number":433,"context_line":"            for img in filtered_images:"},{"line_number":434,"context_line":"                if re.match(CONF.image.name_regex, img.name, re.IGNORECASE):"},{"line_number":435,"context_line":"                    LOG.debug("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a18252c_925e8874","line":432,"range":{"start_line":428,"start_character":13,"end_line":432,"end_character":77},"updated":"2016-04-13 18:05:44.000000000","message":"sorry for a number of different comments about this part of code, but I have another one:)\n\nplease, make your patch depend on https://review.openstack.org/#/c/305345 and use glance wrapper.","commit_id":"edfe5cdeb304018403d1f0df67eed90cb0db3004"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"fb5e8f13c77d06348ca5b1b0e8d587cf06da1ef8","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            LOG.debug(\"Trying to discover a public image with name matching \""},{"line_number":426,"context_line":"                      \"regular expression \u0027%s\u0027. Note that case insensitive \""},{"line_number":427,"context_line":"                      \"matching is performed\" % CONF.image.name_regex)"},{"line_number":428,"context_line":"            images \u003d self.clients.glance().images.list("},{"line_number":429,"context_line":"                filters\u003d{\"status\": \"active\"})"},{"line_number":430,"context_line":"            filtered_images \u003d ["},{"line_number":431,"context_line":"                img for img in images if getattr(img, \"is_public\", False)"},{"line_number":432,"context_line":"                or getattr(img, \"visibility\", None) \u003d\u003d \"public\" and img.name]"},{"line_number":433,"context_line":"            for img in filtered_images:"},{"line_number":434,"context_line":"                if re.match(CONF.image.name_regex, img.name, re.IGNORECASE):"},{"line_number":435,"context_line":"                    LOG.debug("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a18252c_e72718c8","line":432,"range":{"start_line":428,"start_character":13,"end_line":432,"end_character":77},"in_reply_to":"5a18252c_925e8874","updated":"2016-04-14 10:36:11.000000000","message":"ok, will do.","commit_id":"edfe5cdeb304018403d1f0df67eed90cb0db3004"},{"author":{"_account_id":20196,"name":"Piyush","email":"piyush2011257@gmail.com","username":"pirsriva"},"change_message_id":"221ab5034105f572120b95d318a8685eb8ec3688","unresolved":false,"context_lines":[{"line_number":444,"context_line":"            \"container_format\": CONF.image.container_format,"},{"line_number":445,"context_line":"            \"image_location\": os.path.join(_create_or_get_data_dir(),"},{"line_number":446,"context_line":"                                           self.image_name),"},{"line_number":447,"context_line":"            \"visibility\": \"public\""},{"line_number":448,"context_line":"        }"},{"line_number":449,"context_line":"        LOG.debug(\"Creating image \u0027%s\u0027\" % params[\"name\"])"},{"line_number":450,"context_line":"        image \u003d glance_wrap.create_image(**params)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_792fbfa1","line":447,"range":{"start_line":447,"start_character":12,"end_line":447,"end_character":34},"updated":"2016-04-15 10:26:35.000000000","message":"We\u0027ll need is_public here in case we use V1, right?\nThe change in patch- https://review.openstack.org/#/c/305345/6/rally/plugins/openstack/wrappers/glance.py is wrt list_image NOT create_image. \nV1 will still use is_public for create_image()\nV2 would use visibility.\nhttps://review.openstack.org/#/c/305345/6/rally/plugins/openstack/wrappers/glance.py\nPlease correct me if i am wrong.","commit_id":"78ab9d22f9f0f380b8a1a5f43566d5beee423bd7"}]}