)]}'
{"rally/plugins/openstack/cleanup/manager.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"71743b93224da5a126fc025b10f17b8f05007f62","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                admin_client \u003d self._get_cached_client(self.admin)"},{"line_number":158,"context_line":"                for user in self.users:"},{"line_number":159,"context_line":"                    if self.manager_cls._tenant_resource:"},{"line_number":160,"context_line":"                        if user[\"tenant_id\"] in visited_tenants:"},{"line_number":161,"context_line":"                            continue"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"                    visited_tenants.add(user[\"tenant_id\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_2a69028c","line":160,"updated":"2016-04-13 15:25:46.000000000","message":"All the other changes look fine, but I don\u0027t understand this one.","commit_id":"415eb56c8828c944ec03870fac19b2fe2a3819bd"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"7b00795baa3cd7ef6ce3573c132f3cb9f8a88efa","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                admin_client \u003d self._get_cached_client(self.admin)"},{"line_number":158,"context_line":"                for user in self.users:"},{"line_number":159,"context_line":"                    if self.manager_cls._tenant_resource:"},{"line_number":160,"context_line":"                        if user[\"tenant_id\"] in visited_tenants:"},{"line_number":161,"context_line":"                            continue"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"                    visited_tenants.add(user[\"tenant_id\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_4a31de04","line":160,"in_reply_to":"5a18252c_2a69028c","updated":"2016-04-13 15:47:45.000000000","message":"This just looks nicer (more readable), that\u0027s all, I didn\u0027t continue refactoring of this module because I found your changes with the bug and decided to split it in separated patch. \n\nBtw do you think that this refactoring (that increase readability) it\u0027s enough reason to block this patch?","commit_id":"415eb56c8828c944ec03870fac19b2fe2a3819bd"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"86068432bf632784884dd3fdb64e08c8cea9cd0c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                admin_client \u003d self._get_cached_client(self.admin)"},{"line_number":158,"context_line":"                for user in self.users:"},{"line_number":159,"context_line":"                    if self.manager_cls._tenant_resource:"},{"line_number":160,"context_line":"                        if user[\"tenant_id\"] in visited_tenants:"},{"line_number":161,"context_line":"                            continue"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"                    visited_tenants.add(user[\"tenant_id\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_60be7bd5","line":160,"in_reply_to":"5a18252c_40925f9f","updated":"2016-04-13 15:58:21.000000000","message":"to avoid spending time on really dummy stuff I removed this, however readability of such construction is quite bad.","commit_id":"415eb56c8828c944ec03870fac19b2fe2a3819bd"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a2fbe479ce6d0266b4c72421d263e3fbe8b9d695","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                admin_client \u003d self._get_cached_client(self.admin)"},{"line_number":158,"context_line":"                for user in self.users:"},{"line_number":159,"context_line":"                    if self.manager_cls._tenant_resource:"},{"line_number":160,"context_line":"                        if user[\"tenant_id\"] in visited_tenants:"},{"line_number":161,"context_line":"                            continue"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"                    visited_tenants.add(user[\"tenant_id\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_40925f9f","line":160,"in_reply_to":"5a18252c_4a31de04","updated":"2016-04-13 15:53:05.000000000","message":"I don\u0027t think it does increase readability, though. If we\u0027re concerned about readability, I think moving the \u0027and\u0027 to the end of the first line (rather than the start of the second line) is sufficient. If we can\u0027t find a readable way to write compound if statements, we\u0027re in deep trouble....","commit_id":"415eb56c8828c944ec03870fac19b2fe2a3819bd"}],"rally/plugins/openstack/scenarios/cinder/volumes.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7853195567d6388b7f5263e410c32a775111031f","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    @validation.required_services(consts.Service.NOVA, consts.Service.CINDER)"},{"line_number":365,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":366,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"cinder\", \"nova\"]})"},{"line_number":367,"context_line":"    @logging.log_deprecated_args(\"Use \u0027nested_level\u0027 as an int\", \"0.1.2\","},{"line_number":368,"context_line":"                                 [\"nested_level\"], once\u003dTrue)"},{"line_number":369,"context_line":"    def create_nested_snapshots_and_attach_volume(self,"},{"line_number":370,"context_line":"                                                  size\u003dNone,"},{"line_number":371,"context_line":"                                                  nested_level\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_d0ee5db3","side":"PARENT","line":368,"range":{"start_line":367,"start_character":4,"end_line":368,"end_character":61},"updated":"2016-04-13 09:14:32.000000000","message":"Please, mention such removements in commit message. It will help to write proper release notes.","commit_id":"37ffd64fb14ef01539966104901c3d669e5a2bd1"}]}