)]}'
{"rally/plugins/openstack/wrappers/glance.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1bcd2058b1adf0795ec689d674fc32ffa9162318","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        return image"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def delete_image(self, image):"},{"line_number":117,"context_line":"        self.client.images.delete(image.id)"},{"line_number":118,"context_line":"        utils.wait_for_status("},{"line_number":119,"context_line":"            image, [\"deleted\"],"},{"line_number":120,"context_line":"            check_deletion\u003dTrue,"},{"line_number":121,"context_line":"            update_resource\u003dself._update_image,"},{"line_number":122,"context_line":"            timeout\u003dCONF.benchmark.glance_image_delete_timeout,"},{"line_number":123,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_delete_poll_interval)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def list_images(self, **filters):"},{"line_number":126,"context_line":"        return self.client.images.list(**filters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_6d2682cf","line":123,"range":{"start_line":116,"start_character":4,"end_line":123,"end_character":76},"updated":"2016-04-13 12:54:03.000000000","message":"I suppose we can move this method to base class now and remove duplication code.","commit_id":"3feda1dc61602f4fa228941ada84d7c7aad145d7"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5cd445cc1115c7a7c9ad45d3e1e935500cf2e69","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        return image"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def delete_image(self, image):"},{"line_number":117,"context_line":"        self.client.images.delete(image.id)"},{"line_number":118,"context_line":"        utils.wait_for_status("},{"line_number":119,"context_line":"            image, [\"deleted\"],"},{"line_number":120,"context_line":"            check_deletion\u003dTrue,"},{"line_number":121,"context_line":"            update_resource\u003dself._update_image,"},{"line_number":122,"context_line":"            timeout\u003dCONF.benchmark.glance_image_delete_timeout,"},{"line_number":123,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_delete_poll_interval)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def list_images(self, **filters):"},{"line_number":126,"context_line":"        return self.client.images.list(**filters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_c8634440","line":123,"range":{"start_line":116,"start_character":4,"end_line":123,"end_character":76},"in_reply_to":"5a18252c_6d2682cf","updated":"2016-04-13 13:02:20.000000000","message":"There\u0027s another approach to this here: https://review.openstack.org/#/c/298787/10/rally/plugins/openstack/wrappers/glance.py","commit_id":"3feda1dc61602f4fa228941ada84d7c7aad145d7"},{"author":{"_account_id":12637,"name":"Srinivas Sakhamuri","email":"srini.openstack@gmail.com","username":"srsakhamuri"},"change_message_id":"a9207c75832a9e46264d316f8228519094e86d3c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            timeout\u003dCONF.benchmark.glance_image_delete_timeout,"},{"line_number":79,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_delete_poll_interval)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _update_image(self, image):"},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            return self.client.images.get(image.id)"},{"line_number":84,"context_line":"        except glance_exc.HTTPNotFound:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_dd5124da","line":81,"updated":"2016-04-14 00:06:34.000000000","message":"We probably can do away with leading underscore here, since it potentially will be used in other wait_for functions outside of this class","commit_id":"4d253399e11b6a42ce4b3b5952516f7130917f52"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"137476b470e4ab8a7b06bcae79ec8c688f47a088","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            return self.client.images.get(image.id)"},{"line_number":84,"context_line":"        except glance_exc.HTTPNotFound:"},{"line_number":85,"context_line":"            raise exceptions.GetResourceNotFound(resource\u003dimage)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class GlanceV1Wrapper(GlanceWrapper):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_90868e63","line":85,"updated":"2016-04-13 14:45:45.000000000","message":"If we can do this in one consistent way across all API versions, we probably don\u0027t even need it in the wrapper. Just make rally.plugins.openstack.scenarios.glance.utils.GlanceScenario.delete_image() do the right thing, and then we can use that wherever possible.","commit_id":"4d253399e11b6a42ce4b3b5952516f7130917f52"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"27954b8767dfd1f85ae3ce1576b3009074e8110d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            return self.client.images.get(image.id)"},{"line_number":84,"context_line":"        except glance_exc.HTTPNotFound:"},{"line_number":85,"context_line":"            raise exceptions.GetResourceNotFound(resource\u003dimage)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class GlanceV1Wrapper(GlanceWrapper):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_949679ee","line":85,"in_reply_to":"5a18252c_3473254f","updated":"2016-04-13 17:13:41.000000000","message":"Can\u0027t we use the scenario code in \"verify\" as well?\n\nIt\u0027d be really nice if we could make the wrapper as small as possible, since we\u0027ll need to replace the wrapper with a service class any time now.","commit_id":"4d253399e11b6a42ce4b3b5952516f7130917f52"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"9d87d0ccd6bfa151fb3b2388499f9a66aefbeda2","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            return self.client.images.get(image.id)"},{"line_number":84,"context_line":"        except glance_exc.HTTPNotFound:"},{"line_number":85,"context_line":"            raise exceptions.GetResourceNotFound(resource\u003dimage)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class GlanceV1Wrapper(GlanceWrapper):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_bed554ba","line":85,"in_reply_to":"5a18252c_90868e63","updated":"2016-04-13 16:36:50.000000000","message":"Sorry, but I didn\u0027t get your point. rally.plugins.openstack.scenarios.glance.utils.GlanceScenario._delete_image() calls\n\n\n    glance_wrapper.wrap(self._clients.glance, self)\n    client.delete_image(image)\n\n\nSo we need the delete_image() method in the wrapper :)","commit_id":"4d253399e11b6a42ce4b3b5952516f7130917f52"},{"author":{"_account_id":12637,"name":"Srinivas Sakhamuri","email":"srini.openstack@gmail.com","username":"srsakhamuri"},"change_message_id":"a9207c75832a9e46264d316f8228519094e86d3c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            return self.client.images.get(image.id)"},{"line_number":84,"context_line":"        except glance_exc.HTTPNotFound:"},{"line_number":85,"context_line":"            raise exceptions.GetResourceNotFound(resource\u003dimage)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class GlanceV1Wrapper(GlanceWrapper):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_5dafd493","line":85,"in_reply_to":"5a18252c_949679ee","updated":"2016-04-14 00:06:34.000000000","message":"I agree with Chris here, if there is no difference between V1 and V2 functions then there is no need for convenience functions in the wrapper class that is designed to take care of version differences.","commit_id":"4d253399e11b6a42ce4b3b5952516f7130917f52"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"98479eb7c59090a469c562070aa078164024e03f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            return self.client.images.get(image.id)"},{"line_number":84,"context_line":"        except glance_exc.HTTPNotFound:"},{"line_number":85,"context_line":"            raise exceptions.GetResourceNotFound(resource\u003dimage)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class GlanceV1Wrapper(GlanceWrapper):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_fe734ce5","line":85,"in_reply_to":"5a18252c_bed554ba","updated":"2016-04-13 16:38:37.000000000","message":"But we can change rally.plugins.openstack.scenarios.glance.utils.GlanceScenario._delete_image(). We don\u0027t need a wrapper if the code is exactly the same for glance v1 and glance v2.","commit_id":"4d253399e11b6a42ce4b3b5952516f7130917f52"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"88c4165e34956671a4ee0adbbb884c109c4dff95","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            return self.client.images.get(image.id)"},{"line_number":84,"context_line":"        except glance_exc.HTTPNotFound:"},{"line_number":85,"context_line":"            raise exceptions.GetResourceNotFound(resource\u003dimage)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class GlanceV1Wrapper(GlanceWrapper):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_3473254f","line":85,"in_reply_to":"5a18252c_d4a6310f","updated":"2016-04-13 17:08:32.000000000","message":"The delete_image method in the wrapper contains both self.client.images.delete() and utils.wait_for_status(). So I think it is convenient enough to have the delete_image method in the wrapper.","commit_id":"4d253399e11b6a42ce4b3b5952516f7130917f52"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7144049775d81837311ed180abf3d48584b13148","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            return self.client.images.get(image.id)"},{"line_number":84,"context_line":"        except glance_exc.HTTPNotFound:"},{"line_number":85,"context_line":"            raise exceptions.GetResourceNotFound(resource\u003dimage)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class GlanceV1Wrapper(GlanceWrapper):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_d4a6310f","line":85,"in_reply_to":"5a18252c_fe734ce5","updated":"2016-04-13 16:59:59.000000000","message":"We use this code in \"verify\" part as well :)","commit_id":"4d253399e11b6a42ce4b3b5952516f7130917f52"}]}
