)]}'
{"rally/task/scenario.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6b8af23ea271d5193f52fff3b1e695b132bc2451","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # validate scenario arguments"},{"line_number":133,"context_line":"        args, _varargs, _keywords, defaults \u003d inspect.getargspec(scenario)"},{"line_number":134,"context_line":"        if args:"},{"line_number":135,"context_line":"            if \"self\" \u003d\u003d args[0]:"},{"line_number":136,"context_line":"                args \u003d args[1:]"},{"line_number":137,"context_line":"            if defaults:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_1c62ba16","line":134,"updated":"2016-06-16 12:55:37.000000000","message":"This \u0027if\u0027 is redundant since \u0027args\u0027 must have at least one element.\n\nIt would be ok to have unexpected IndexError raised if args are empty for some reason","commit_id":"54921349622c2189ac629d23a9b0d3734b6c1c6b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"21cfbd8240f651be22769a891f193c77740f2b5a","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # validate scenario arguments"},{"line_number":133,"context_line":"        args, _varargs, _keywords, defaults \u003d inspect.getargspec(scenario)"},{"line_number":134,"context_line":"        if args:"},{"line_number":135,"context_line":"            if \"self\" \u003d\u003d args[0]:"},{"line_number":136,"context_line":"                args \u003d args[1:]"},{"line_number":137,"context_line":"            if defaults:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_d069c78d","line":134,"in_reply_to":"7aa08908_1c62ba16","updated":"2016-07-12 15:45:38.000000000","message":"Done","commit_id":"54921349622c2189ac629d23a9b0d3734b6c1c6b"}],"tests/unit/task/test_scenario.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6b8af23ea271d5193f52fff3b1e695b132bc2451","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                                                        arg3\u003dNone, **kwargs):"},{"line_number":176,"context_line":"                pass"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # use try...except to check exception message"},{"line_number":179,"context_line":"        try:"},{"line_number":180,"context_line":"            scenario.Scenario.validate(\"Testing.fake_scenario_to_validate_\""},{"line_number":181,"context_line":"                                       \"scenario_args\", {\"args\": {\"arg1\": 3}})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_7c201ef9","line":178,"updated":"2016-06-16 12:55:37.000000000","message":"This can be done without try/except:\n\n e \u003d self.assertRaises(...)\n self.assertIn(\"\u0027args2\u0027\", str(e))","commit_id":"54921349622c2189ac629d23a9b0d3734b6c1c6b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"485e77f04070cc01dfd17352a2648b2762beea61","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                                                        arg3\u003dNone, **kwargs):"},{"line_number":176,"context_line":"                pass"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # use try...except to check exception message"},{"line_number":179,"context_line":"        try:"},{"line_number":180,"context_line":"            scenario.Scenario.validate(\"Testing.fake_scenario_to_validate_\""},{"line_number":181,"context_line":"                                       \"scenario_args\", {\"args\": {\"arg1\": 3}})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_464b84b1","line":178,"in_reply_to":"7aa08908_7c201ef9","updated":"2016-07-12 14:48:53.000000000","message":"thanks, I did not know this feature of self.assertRaises.","commit_id":"54921349622c2189ac629d23a9b0d3734b6c1c6b"}]}
