)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"a4f9af2d16ef94246d91743bb9ad68d7f6b99cd9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run `tox -e py27` you\u0027ll see redundant output to user:"},{"line_number":10,"context_line":"  * Failed to consume a task from the queue:"},{"line_number":11,"context_line":"Fix the test by proper side effect."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6fa99e93c0fe680fc7decf62c701032ad92bf32a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_3a169055","line":11,"updated":"2016-04-18 11:44:40.000000000","message":"How exactly and what exactly is fixed? It should work fine if first call of create_user raises exception, right?","commit_id":"e97a94701f1f1e4b955816ea98167e8031c87702"}],"tests/unit/plugins/openstack/context/keystone/test_users.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ac1ba0d7b1187d4eb8899a820920d42b9be9ffa9","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    def test_setup_failure_and_cleanup(self, mock_keystone):"},{"line_number":302,"context_line":"        wrapped_keystone \u003d mock_keystone.wrap.return_value"},{"line_number":303,"context_line":"        wrapped_keystone.create_user.side_effect \u003d ("},{"line_number":304,"context_line":"            [mock.MagicMock()] * (self.users_num - 1))"},{"line_number":305,"context_line":"        with users.UserGenerator(self.context) as ctx:"},{"line_number":306,"context_line":"            self.assertRaises(exceptions.ContextSetupFailure, ctx.setup)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_650684cf","line":304,"updated":"2016-04-19 06:57:35.000000000","message":"And what does this method test now? \nThis method should rise the exception","commit_id":"e97a94701f1f1e4b955816ea98167e8031c87702"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"783877b303bf2346aafae4b8e8177b8999c854de","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    def test_setup_failure_and_cleanup(self, mock_keystone):"},{"line_number":302,"context_line":"        wrapped_keystone \u003d mock_keystone.wrap.return_value"},{"line_number":303,"context_line":"        wrapped_keystone.create_user.side_effect \u003d ("},{"line_number":304,"context_line":"            [mock.MagicMock()] * (self.users_num - 1))"},{"line_number":305,"context_line":"        with users.UserGenerator(self.context) as ctx:"},{"line_number":306,"context_line":"            self.assertRaises(exceptions.ContextSetupFailure, ctx.setup)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_44ef0187","line":304,"in_reply_to":"1a122d0e_0e0528bb","updated":"2016-04-19 10:39:59.000000000","message":"https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/keystone/users.py#L291 Now proper error raise in UserGenerator","commit_id":"e97a94701f1f1e4b955816ea98167e8031c87702"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"71b2480c1187a90ae0eff028bee79cd605d2706c","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    def test_setup_failure_and_cleanup(self, mock_keystone):"},{"line_number":302,"context_line":"        wrapped_keystone \u003d mock_keystone.wrap.return_value"},{"line_number":303,"context_line":"        wrapped_keystone.create_user.side_effect \u003d ("},{"line_number":304,"context_line":"            [mock.MagicMock()] * (self.users_num - 1))"},{"line_number":305,"context_line":"        with users.UserGenerator(self.context) as ctx:"},{"line_number":306,"context_line":"            self.assertRaises(exceptions.ContextSetupFailure, ctx.setup)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_8ef498f2","line":304,"in_reply_to":"1a122d0e_650684cf","updated":"2016-04-19 09:42:45.000000000","message":"No it shouldn\u0027t. Setup should raise an exception. It test that error during setup not cause wrong cleanup","commit_id":"e97a94701f1f1e4b955816ea98167e8031c87702"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"324fd18d038d265c6da034f9673d2760b168fd68","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    def test_setup_failure_and_cleanup(self, mock_keystone):"},{"line_number":302,"context_line":"        wrapped_keystone \u003d mock_keystone.wrap.return_value"},{"line_number":303,"context_line":"        wrapped_keystone.create_user.side_effect \u003d ("},{"line_number":304,"context_line":"            [mock.MagicMock()] * (self.users_num - 1))"},{"line_number":305,"context_line":"        with users.UserGenerator(self.context) as ctx:"},{"line_number":306,"context_line":"            self.assertRaises(exceptions.ContextSetupFailure, ctx.setup)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_0e0528bb","line":304,"in_reply_to":"1a122d0e_8ef498f2","updated":"2016-04-19 09:45:36.000000000","message":"And what exactly raises error in UserGenerator now? \n\nThis seems invalid.","commit_id":"e97a94701f1f1e4b955816ea98167e8031c87702"}]}
