)]}'
{"rally-jobs/nova.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bce6c6594041ae9a01135e991c06fa577300899c","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"    -"},{"line_number":1018,"context_line":"      args:"},{"line_number":1019,"context_line":"        flavor:"},{"line_number":1020,"context_line":"          name: \"m1.tiny\""},{"line_number":1021,"context_line":"        image:"},{"line_number":1022,"context_line":"          name: {{image_name}}"},{"line_number":1023,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_e2106f5b","line":1020,"updated":"2016-05-17 07:34:19.000000000","message":"Looks like you patch is not rebased on master. Here should be {{flavor_name}}","commit_id":"7b1913b619b803e9eb4583ee8cd36af6ca03e65e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"063fcd52edfd85a33c1bcd912d87e69db7d36b60","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"        type: \"constant\""},{"line_number":1026,"context_line":"        times: 5"},{"line_number":1027,"context_line":"        concurrency: 2"},{"line_number":1028,"context_line":"      sla:"},{"line_number":1029,"context_line":"        failure_rate:"},{"line_number":1030,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_a9f88c4a","line":1028,"updated":"2016-05-30 08:19:06.000000000","message":"Please add \u0027context\u0027 section with \u0027users\u0027 context\n\n\n      context:\n        users:\n          tenants: 2\n          users_per_tenant: 2","commit_id":"1aeb38cbeb7e1787ad19e7c8688c99cb0e1b3a06"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"8ced320f89da9453b1174ae1c5f82af4d3cf803c","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"        type: \"constant\""},{"line_number":1026,"context_line":"        times: 5"},{"line_number":1027,"context_line":"        concurrency: 2"},{"line_number":1028,"context_line":"      sla:"},{"line_number":1029,"context_line":"        failure_rate:"},{"line_number":1030,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9abb7d3a_5ae9dc7f","line":1028,"in_reply_to":"9abb7d3a_a9f88c4a","updated":"2016-05-30 09:30:59.000000000","message":"Done. Carelessly copy-paste.","commit_id":"1aeb38cbeb7e1787ad19e7c8688c99cb0e1b3a06"}],"rally/plugins/openstack/scenarios/nova/servers.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"96a6b253d9177c96d67e033b792f6d46e9b63322","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        :param kwargs: Optional additional arguments for server creation"},{"line_number":880,"context_line":"        \"\"\""},{"line_number":881,"context_line":"        server \u003d self._boot_server(image, flavor, **kwargs)"},{"line_number":882,"context_line":"        new_name \u003d self.generate_random_name()"},{"line_number":883,"context_line":"        self._rename_server(server, new_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_03637a1b","line":882,"updated":"2016-05-13 10:13:55.000000000","message":"This better to have inside _rename_server to disallow to get hidden bug when users will start to get servers with not rally specific name therefore they will be not cleanup by rally","commit_id":"514925c1079df472ccdc02f405a022f0861f7047"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"3a25be7c5c40619b8c296b417302d673686d8aa4","unresolved":false,"context_lines":[{"line_number":868,"context_line":"    @validation.required_services(consts.Service.NOVA)"},{"line_number":869,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":870,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"nova\"]})"},{"line_number":871,"context_line":"    def boot_and_rename_server(self, image, flavor, **kwargs):"},{"line_number":872,"context_line":"        \"\"\"Boot a server, then rename it."},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        The scenario first creates a server, then rename it."}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_d23e148a","line":871,"updated":"2016-05-16 09:34:21.000000000","message":"i\u0027d prefer to rename this scenario to boot_and_update_server, so we can pass other arguments like description as well.","commit_id":"8ca2ff364b6d7169b9c7b7f076cd0a09e5e5d8f8"}],"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"96a6b253d9177c96d67e033b792f6d46e9b63322","unresolved":false,"context_lines":[{"line_number":957,"context_line":"        :param name: The server\u0027s new name"},{"line_number":958,"context_line":"        :returns: The renamed server"},{"line_number":959,"context_line":"        \"\"\""},{"line_number":960,"context_line":"        return server.update(name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_0331ba0b","line":960,"updated":"2016-05-13 10:13:55.000000000","message":"There is more parameters starting from 2.19 version https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L1263","commit_id":"514925c1079df472ccdc02f405a022f0861f7047"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"3a25be7c5c40619b8c296b417302d673686d8aa4","unresolved":false,"context_lines":[{"line_number":978,"context_line":"        :returns: The renamed server"},{"line_number":979,"context_line":"        \"\"\""},{"line_number":980,"context_line":"        new_name \u003d self.generate_random_name()"},{"line_number":981,"context_line":"        return server.update(name\u003dnew_name, description\u003dNone)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_b270b0a5","line":981,"updated":"2016-05-16 09:34:21.000000000","message":"no point to add description\u003dNone, i\u0027d prefer renaming the method to _update_server(self, server, description\u003dNone), and set \n`description \u003d description or self.generate_random_name()`","commit_id":"8ca2ff364b6d7169b9c7b7f076cd0a09e5e5d8f8"}],"tests/unit/plugins/openstack/scenarios/nova/test_servers.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d1dd0770081436ea3a9df3037b138e6f8208e696","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        scenario._rename_server \u003d mock.Mock()"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        image \u003d \"img\""},{"line_number":773,"context_line":"        flavor \u003d \"flavor\""},{"line_number":774,"context_line":"        scenario.boot_and_rename_server(image, flavor, fakearg\u003d\"fakearg\")"},{"line_number":775,"context_line":"        scenario._boot_server.assert_called_once_with(image, flavor,"},{"line_number":776,"context_line":"                                                      fakearg\u003d\"fakearg\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_1e70f1db","line":773,"updated":"2016-05-13 10:26:17.000000000","message":"Please don\u0027t use unneeded local variables","commit_id":"514925c1079df472ccdc02f405a022f0861f7047"}],"tests/unit/plugins/openstack/scenarios/nova/test_utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d1dd0770081436ea3a9df3037b138e6f8208e696","unresolved":false,"context_lines":[{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    def test__rename_server(self):"},{"line_number":948,"context_line":"        server \u003d mock.Mock()"},{"line_number":949,"context_line":"        renamed_server \u003d mock.Mock()"},{"line_number":950,"context_line":"        nova_scenario \u003d utils.NovaScenario()"},{"line_number":951,"context_line":"        server.update \u003d mock.Mock(return_value\u003drenamed_server)"},{"line_number":952,"context_line":"        result \u003d nova_scenario._rename_server(server, \"new_name\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_5ec9d978","line":949,"updated":"2016-05-13 10:26:17.000000000","message":"Please don\u0027t use unneeded local variable","commit_id":"514925c1079df472ccdc02f405a022f0861f7047"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d1dd0770081436ea3a9df3037b138e6f8208e696","unresolved":false,"context_lines":[{"line_number":950,"context_line":"        nova_scenario \u003d utils.NovaScenario()"},{"line_number":951,"context_line":"        server.update \u003d mock.Mock(return_value\u003drenamed_server)"},{"line_number":952,"context_line":"        result \u003d nova_scenario._rename_server(server, \"new_name\")"},{"line_number":953,"context_line":"        self.assertEqual(server.update.return_value, result)"},{"line_number":954,"context_line":"        server.update.assert_called_once_with(\"new_name\")"},{"line_number":955,"context_line":"        self._test_atomic_action_timer(nova_scenario.atomic_actions(),"},{"line_number":956,"context_line":"                                       \"nova.rename_server\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_ded5c91b","line":953,"updated":"2016-05-13 10:26:17.000000000","message":"First should be expected value, then actual.","commit_id":"514925c1079df472ccdc02f405a022f0861f7047"}]}