)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"33e341f9944a710ccb97f987b00d3c932cdd97a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     chenhb-zte \u003cchen.haibing1@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-24 15:55:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix list_samples unknown argument \"limit\" error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"list_samples should invoke \"new_samples.list\"."},{"line_number":10,"context_line":"the object samples points to OldSample."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_2c933751","line":7,"updated":"2016-05-24 10:49:29.000000000","message":"Please share the paste with traceback. Why we don\u0027t see such an error at the gate? In the client I see https://github.com/openstack/python-ceilometerclient/blob/master/ceilometerclient/v2/samples.py#L46 Thus there is limit argument","commit_id":"bffc429761e80616c04c5a441bc9fc7f7d77dd55"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"99b81597faff8eb8b70375229e1f527eef3591db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     chenhb-zte \u003cchen.haibing1@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-24 15:55:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix list_samples unknown argument \"limit\" error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"list_samples should invoke \"new_samples.list\"."},{"line_number":10,"context_line":"the object samples points to OldSample."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_b2f75558","line":7,"in_reply_to":"bab6814e_013eeab7","updated":"2016-05-25 01:12:37.000000000","message":"Hi, Sergey. I have explained it in roman comments. I am not sure if you can see the comment.","commit_id":"bffc429761e80616c04c5a441bc9fc7f7d77dd55"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"99b81597faff8eb8b70375229e1f527eef3591db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     chenhb-zte \u003cchen.haibing1@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-24 15:55:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix list_samples unknown argument \"limit\" error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"list_samples should invoke \"new_samples.list\"."},{"line_number":10,"context_line":"the object samples points to OldSample."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_b24915ba","line":7,"in_reply_to":"bab6814e_2c933751","updated":"2016-05-25 01:12:37.000000000","message":"Hi roman. I am sorry for the error. I have found the unknown argument reason.My ceilometer version is out-dated, /v2/meters does not support the limit argument. Now i have a new question. list_sample invokes OldSample.list，and sets the argument meter_name\u003dNone，so the request is \"/v2/meters?limit\u003d50\". list_meters is the same /v2/meters as list_sample. I am not sure what is difference between them. Therefore i think new_sample is still a good choice for us.","commit_id":"bffc429761e80616c04c5a441bc9fc7f7d77dd55"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"c32306fe5a69452f7ba1a3e420a733eca86d6aab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     chenhb-zte \u003cchen.haibing1@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-24 15:55:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix list_samples unknown argument \"limit\" error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"list_samples should invoke \"new_samples.list\"."},{"line_number":10,"context_line":"the object samples points to OldSample."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_013eeab7","line":7,"in_reply_to":"bab6814e_2c933751","updated":"2016-05-24 14:49:13.000000000","message":"It seems OldSample does support limit argument: https://github.com/openstack/python-ceilometerclient/blob/2.2.1/ceilometerclient/v2/samples.py#L46-L49","commit_id":"bffc429761e80616c04c5a441bc9fc7f7d77dd55"}]}
