)]}'
{"rally/cli/commands/verify.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0e9e44b4473421799c96c17646d6046de0aac471","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _print_verification_uuid(self, uuid):"},{"line_number":47,"context_line":"        print(_(\"Verification UUID: %s\") % uuid)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @cliutils.args(\"--deployment\", dest\u003d\"deployment\", type\u003dstr,"},{"line_number":50,"context_line":"                   metavar\u003d\"\u003cuuid\u003e\", required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_c7092e86","line":47,"updated":"2016-05-26 08:48:34.000000000","message":"Please don\u0027t use one line function that just print","commit_id":"e6c2c1c65b90121c000505e7b74c8914a7cb6fca"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"57f69db3c1d399c19121d56cde4c9e3991311f1d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _print_verification_uuid(self, uuid):"},{"line_number":47,"context_line":"        print(_(\"Verification UUID: %s\") % uuid)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @cliutils.args(\"--deployment\", dest\u003d\"deployment\", type\u003dstr,"},{"line_number":50,"context_line":"                   metavar\u003d\"\u003cuuid\u003e\", required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_c3df42d4","line":47,"in_reply_to":"bab6814e_c7092e86","updated":"2016-05-26 18:38:34.000000000","message":"Do you mean that I should call print directly in each of the functions?\n\n(I just tried to make sure that we use the same format when print a verification UUID by introducing this function)","commit_id":"e6c2c1c65b90121c000505e7b74c8914a7cb6fca"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0e9e44b4473421799c96c17646d6046de0aac471","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self._print_verification_uuid(verification[\"uuid\"])"},{"line_number":155,"context_line":"        if do_use:"},{"line_number":156,"context_line":"            self._use(verification[\"uuid\"])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @cliutils.args(\"--deployment\", dest\u003d\"deployment\", type\u003dstr,"},{"line_number":159,"context_line":"                   metavar\u003d\"\u003cuuid\u003e\", required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_a746aa78","line":156,"updated":"2016-05-26 08:48:34.000000000","message":"Why _use?","commit_id":"e6c2c1c65b90121c000505e7b74c8914a7cb6fca"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0e9e44b4473421799c96c17646d6046de0aac471","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        deployment, verification \u003d api.Verification.import_results(deployment,"},{"line_number":184,"context_line":"                                                                   set_name,"},{"line_number":185,"context_line":"                                                                   log_file)"},{"line_number":186,"context_line":"        self._print_verification_uuid(verification[\"uuid\"])"},{"line_number":187,"context_line":"        if do_use:"},{"line_number":188,"context_line":"            self._use(verification[\"uuid\"])"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_277c7ab4","line":186,"updated":"2016-05-26 08:48:34.000000000","message":"You use print before every https://github.com/openstack/rally/blob/master/rally/cli/commands/verify.py#L376 But it already exist inside. Thus those prints are redundant","commit_id":"e6c2c1c65b90121c000505e7b74c8914a7cb6fca"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0e9e44b4473421799c96c17646d6046de0aac471","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                                                                   log_file)"},{"line_number":186,"context_line":"        self._print_verification_uuid(verification[\"uuid\"])"},{"line_number":187,"context_line":"        if do_use:"},{"line_number":188,"context_line":"            self._use(verification[\"uuid\"])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def list(self):"},{"line_number":191,"context_line":"        \"\"\"List verification runs.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_67504233","line":188,"updated":"2016-05-26 08:48:34.000000000","message":"Why _use?","commit_id":"e6c2c1c65b90121c000505e7b74c8914a7cb6fca"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4627d881369c4db89a8ec7f8ffbc5cb8c2c3a115","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                                                                   log_file)"},{"line_number":186,"context_line":"        self._print_verification_uuid(verification[\"uuid\"])"},{"line_number":187,"context_line":"        if do_use:"},{"line_number":188,"context_line":"            self._use(verification[\"uuid\"])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def list(self):"},{"line_number":191,"context_line":"        \"\"\"List verification runs.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_d970f2a6","line":188,"in_reply_to":"bab6814e_67504233","updated":"2016-05-26 08:52:38.000000000","message":"Uh, now I get you point","commit_id":"e6c2c1c65b90121c000505e7b74c8914a7cb6fca"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0e9e44b4473421799c96c17646d6046de0aac471","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        else:"},{"line_number":372,"context_line":"            print(result)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def _use(self, verification):"},{"line_number":375,"context_line":"        api.Verification.get(verification)"},{"line_number":376,"context_line":"        fileutils.update_globals_file(\"RALLY_VERIFICATION\", verification)"},{"line_number":377,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_e77552cb","line":374,"updated":"2016-05-26 08:48:34.000000000","message":"You wrap in the function two lines that would be called only once in 386 line. Thus there is no benefits in this function.","commit_id":"e6c2c1c65b90121c000505e7b74c8914a7cb6fca"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"57f69db3c1d399c19121d56cde4c9e3991311f1d","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        else:"},{"line_number":372,"context_line":"            print(result)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def _use(self, verification):"},{"line_number":375,"context_line":"        api.Verification.get(verification)"},{"line_number":376,"context_line":"        fileutils.update_globals_file(\"RALLY_VERIFICATION\", verification)"},{"line_number":377,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_fd366501","line":374,"in_reply_to":"bab6814e_e77552cb","updated":"2016-05-26 18:38:34.000000000","message":"BTW, I wonder \"Verification UUID: \u003cuuid\u003e\" printed by \"rally verify use --uuid \u003cuuid\u003e\" is useless, since it just repeats what is already known. If so, can I remove this print? Then, _use() will be no longer needed.","commit_id":"e6c2c1c65b90121c000505e7b74c8914a7cb6fca"}]}