)]}'
{"rally/task/runner.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0ae5f30b89f5359133c7a227046575f9166a5f17","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def run(self, name, context, args):"},{"line_number":155,"context_line":"        method_name \u003d name.split(\".\", 1).pop()"},{"line_number":156,"context_line":"        scenario_plugin \u003d scenario.Scenario.get(name)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # NOTE(boris-42): processing @types decorators"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d14fd48f","line":155,"updated":"2016-06-09 05:00:51.000000000","message":"Looks like its better to move it to 164th line.","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d3643b180d8d5cba81ceda831bcbefd89975f176","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def run(self, name, context, args):"},{"line_number":155,"context_line":"        method_name \u003d name.split(\".\", 1).pop()"},{"line_number":156,"context_line":"        scenario_plugin \u003d scenario.Scenario.get(name)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # NOTE(boris-42): processing @types decorators"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_28006233","line":155,"in_reply_to":"7aa08908_d14fd48f","updated":"2016-06-09 08:31:57.000000000","message":"Agree","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"64af272fbfcc8ea36a65b97fa311df1d5dbf5a5c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def run(self, name, context, args):"},{"line_number":155,"context_line":"        method_name \u003d name.split(\".\", 1).pop()"},{"line_number":156,"context_line":"        scenario_plugin \u003d scenario.Scenario.get(name)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # NOTE(boris-42): processing @types decorators"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_fb4ccd43","line":155,"in_reply_to":"7aa08908_d14fd48f","updated":"2016-06-13 11:39:53.000000000","message":"Done","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"}],"rally/task/scenario.py":[{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"0ec052b55dfe33ee2aa6f399bb5ad68deba0cfeb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        scen._meta_init()"},{"line_number":50,"context_line":"        if name:"},{"line_number":51,"context_line":"            if \".\" not in name:"},{"line_number":52,"context_line":"                msg \u003d (_(\"Scenario name must include point: \u0027%s\u0027\") % name)"},{"line_number":53,"context_line":"                raise exceptions.RallyException(msg)"},{"line_number":54,"context_line":"            scen._set_name_and_namespace(name, namespace)"},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_1ab634dc","line":52,"range":{"start_line":52,"start_character":44,"end_line":52,"end_character":58},"updated":"2016-06-03 10:12:57.000000000","message":"...must include a dot (.)","commit_id":"697481a151b523b3aaefce85e9b67a77488e225d"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"eac2689156f2aa51713a110465f83a3b58f28ff1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        scen._meta_init()"},{"line_number":50,"context_line":"        if name:"},{"line_number":51,"context_line":"            if \".\" not in name:"},{"line_number":52,"context_line":"                msg \u003d (_(\"Scenario name must include point: \u0027%s\u0027\") % name)"},{"line_number":53,"context_line":"                raise exceptions.RallyException(msg)"},{"line_number":54,"context_line":"            scen._set_name_and_namespace(name, namespace)"},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_b9e8d517","line":52,"range":{"start_line":52,"start_character":44,"end_line":52,"end_character":58},"in_reply_to":"9abb7d3a_1ab634dc","updated":"2016-06-03 10:44:48.000000000","message":"Done","commit_id":"697481a151b523b3aaefce85e9b67a77488e225d"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0ae5f30b89f5359133c7a227046575f9166a5f17","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from rally.common.i18n import _"},{"line_number":22,"context_line":"from rally.common import logging"},{"line_number":23,"context_line":"from rally.common.objects import task  # noqa"},{"line_number":24,"context_line":"from rally.common.plugin import plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a7930a5a","line":21,"updated":"2016-06-09 05:00:51.000000000","message":"RallyException itself wrap into _ so we don\u0027t need this import","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d3643b180d8d5cba81ceda831bcbefd89975f176","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from rally.common.i18n import _"},{"line_number":22,"context_line":"from rally.common import logging"},{"line_number":23,"context_line":"from rally.common.objects import task  # noqa"},{"line_number":24,"context_line":"from rally.common.plugin import plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a8f3b271","line":21,"in_reply_to":"7aa08908_a7930a5a","updated":"2016-06-09 08:31:57.000000000","message":"Agree","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4dfedb1975789f26db4144adf6830094dae41f3c","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from rally.common.i18n import _"},{"line_number":22,"context_line":"from rally.common import logging"},{"line_number":23,"context_line":"from rally.common.objects import task  # noqa"},{"line_number":24,"context_line":"from rally.common.plugin import plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c01d9c63","line":21,"in_reply_to":"7aa08908_a8f3b271","updated":"2016-06-13 11:24:10.000000000","message":"UPDATE: this is partially correct, we do not need to wrap message with _() if we use subclass of RallyException with property msg_fmt set, but in this case (L53) we can not prepare i18n message without adding a new exception class to rally.exceptions, so we have to pass internationalized message to RallyException\n\nhttps://github.com/openstack/rally/blob/master/rally/exceptions.py#L29","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0ae5f30b89f5359133c7a227046575f9166a5f17","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def configure(name\u003dNone, namespace\u003d\"default\", context\u003dNone):"},{"line_number":37,"context_line":"    \"\"\"Make from plain python method task scenario plugin."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"       :param name: Plugin name"},{"line_number":40,"context_line":"       :param namespace: Plugin namespace"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_511e440c","line":37,"updated":"2016-06-09 05:00:51.000000000","message":"Now this is not the full description","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d3643b180d8d5cba81ceda831bcbefd89975f176","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def configure(name\u003dNone, namespace\u003d\"default\", context\u003dNone):"},{"line_number":37,"context_line":"    \"\"\"Make from plain python method task scenario plugin."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"       :param name: Plugin name"},{"line_number":40,"context_line":"       :param namespace: Plugin namespace"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_88e4f6ab","line":37,"in_reply_to":"7aa08908_511e440c","updated":"2016-06-09 08:31:57.000000000","message":"Agree","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"64af272fbfcc8ea36a65b97fa311df1d5dbf5a5c","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def configure(name\u003dNone, namespace\u003d\"default\", context\u003dNone):"},{"line_number":37,"context_line":"    \"\"\"Make from plain python method task scenario plugin."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"       :param name: Plugin name"},{"line_number":40,"context_line":"       :param namespace: Plugin namespace"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_9b430913","line":37,"in_reply_to":"7aa08908_511e440c","updated":"2016-06-13 11:39:53.000000000","message":"Done","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0ae5f30b89f5359133c7a227046575f9166a5f17","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            plugin.from_func(Scenario)(scen)"},{"line_number":49,"context_line":"        scen._meta_init()"},{"line_number":50,"context_line":"        if name:"},{"line_number":51,"context_line":"            if \".\" not in name.strip(\".\"):"},{"line_number":52,"context_line":"                msg \u003d (_(\"Scenario name must include a dot: \u0027%s\u0027\") % name)"},{"line_number":53,"context_line":"                raise exceptions.RallyException(msg)"},{"line_number":54,"context_line":"            scen._set_name_and_namespace(name, namespace)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_96e9f4b9","line":51,"updated":"2016-06-09 05:00:51.000000000","message":"Why we need this strip? - Is \"..A.B.\" valid name?","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"149d75e9ba2b7f999b8efe52532d1d6090d08207","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            plugin.from_func(Scenario)(scen)"},{"line_number":49,"context_line":"        scen._meta_init()"},{"line_number":50,"context_line":"        if name:"},{"line_number":51,"context_line":"            if \".\" not in name.strip(\".\"):"},{"line_number":52,"context_line":"                msg \u003d (_(\"Scenario name must include a dot: \u0027%s\u0027\") % name)"},{"line_number":53,"context_line":"                raise exceptions.RallyException(msg)"},{"line_number":54,"context_line":"            scen._set_name_and_namespace(name, namespace)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a2d3c65e","line":51,"in_reply_to":"7aa08908_681a6ac7","updated":"2016-06-09 11:01:32.000000000","message":"Ok, lets not to touch this line. Agree\u003d)","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d3643b180d8d5cba81ceda831bcbefd89975f176","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            plugin.from_func(Scenario)(scen)"},{"line_number":49,"context_line":"        scen._meta_init()"},{"line_number":50,"context_line":"        if name:"},{"line_number":51,"context_line":"            if \".\" not in name.strip(\".\"):"},{"line_number":52,"context_line":"                msg \u003d (_(\"Scenario name must include a dot: \u0027%s\u0027\") % name)"},{"line_number":53,"context_line":"                raise exceptions.RallyException(msg)"},{"line_number":54,"context_line":"            scen._set_name_and_namespace(name, namespace)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_681a6ac7","line":51,"in_reply_to":"7aa08908_96e9f4b9","updated":"2016-06-09 08:31:57.000000000","message":"Yes, \"..A.B.\" is a valid name for now, as well as \"^^.;\" or \"foo!. %%\" because we do not discuss any limitations regarding scenario names - we will probably discuss this later and create (or do not create anything) some convention for that. But now the only thing we really need is to have ability to split name into 2 non-empty parts.\n\nBasically, if someone decided to name scenario as \"..A.B.\", everything will work but everyone will ask him/her what does this naming mean :)","commit_id":"63fbb8b92be4ab9999991352467a47c823cc8419"}]}
