)]}'
{"rally/plugins/openstack/scenarios/ceilometer/meters.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9b6555588a2f10e80183559c50d96f0148b7473e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"Benchmark scenarios for Ceilometer Meters API.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_contexts(\"users\", \"ceilometer\")"},{"line_number":26,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":27,"context_line":"    @scenario.configure()"},{"line_number":28,"context_line":"    def list_meters(self, metadata_query\u003dNone, limit\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_b8e018ce","line":25,"updated":"2016-06-02 10:08:54.000000000","message":"What if I want to use existing users?","commit_id":"702d9c230f84abc2f615428ea242805d2f86d4cc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"57c55dfd3730c387224f8be776b83890937120a3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"Benchmark scenarios for Ceilometer Meters API.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_contexts(\"users\", \"ceilometer\")"},{"line_number":26,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":27,"context_line":"    @scenario.configure()"},{"line_number":28,"context_line":"    def list_meters(self, metadata_query\u003dNone, limit\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_8ec7ce63","line":25,"in_reply_to":"9abb7d3a_b8e018ce","updated":"2016-06-02 10:50:03.000000000","message":"Then we have a bug. Because I can\u0027t specify users as required contexts if I have in the code self.context[\"user\"]\nWe need to write something like (\"users\" or \"existing users\", \"ceilometers\") but we are unable. What am I supposed to do before we will create such validator, any suggestion","commit_id":"702d9c230f84abc2f615428ea242805d2f86d4cc"}],"rally/plugins/openstack/scenarios/ceilometer/samples.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9b6555588a2f10e80183559c50d96f0148b7473e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        :param metadata_query: dict with metadata fields and values for query"},{"line_number":38,"context_line":"        :param limit: count of samples in response"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        if filter_by_user_id is True:"},{"line_number":41,"context_line":"            filter_by_user_id \u003d self.context[\"user\"][\"id\"]"},{"line_number":42,"context_line":"        if filter_by_project_id is True:"},{"line_number":43,"context_line":"            filter_by_project_id \u003d self.context[\"tenant\"][\"id\"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_f8d460be","line":40,"updated":"2016-06-02 10:08:54.000000000","message":"L40-45 are repeated several times across this patch, so these lines are required to be refactored and used once somewhere (inside self._make_general_query or in another place)","commit_id":"702d9c230f84abc2f615428ea242805d2f86d4cc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"fc6c9bcfac5ed1ff64f719f14dcfbdbea870cd05","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        :param metadata_query: dict with metadata fields and values for query"},{"line_number":38,"context_line":"        :param limit: count of samples in response"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        if filter_by_user_id is True:"},{"line_number":41,"context_line":"            filter_by_user_id \u003d self.context[\"user\"][\"id\"]"},{"line_number":42,"context_line":"        if filter_by_project_id is True:"},{"line_number":43,"context_line":"            filter_by_project_id \u003d self.context[\"tenant\"][\"id\"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_91da4f16","line":40,"in_reply_to":"9abb7d3a_5140e735","updated":"2016-06-02 10:57:58.000000000","message":"Discussed - _prepare_query_args","commit_id":"702d9c230f84abc2f615428ea242805d2f86d4cc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"57c55dfd3730c387224f8be776b83890937120a3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        :param metadata_query: dict with metadata fields and values for query"},{"line_number":38,"context_line":"        :param limit: count of samples in response"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        if filter_by_user_id is True:"},{"line_number":41,"context_line":"            filter_by_user_id \u003d self.context[\"user\"][\"id\"]"},{"line_number":42,"context_line":"        if filter_by_project_id is True:"},{"line_number":43,"context_line":"            filter_by_project_id \u003d self.context[\"tenant\"][\"id\"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_5140e735","line":40,"in_reply_to":"9abb7d3a_f8d460be","updated":"2016-06-02 10:50:03.000000000","message":"I can\u0027t do this inside _make_general_query. Because the idea was to pass to this function already specified ids. Okey I will add this stuff to the utils. Please suggest the name to the function.\n\ndef filter_converter(filter_by_resource_id\u003dFalse,\n        filter_by_project_id\u003dFalse,\n        filter_by_user_id\u003dFalse):\n    if filter_by_user_id is True:\n        filter_by_user_id \u003d self.context[\"user\"][\"id\"]\n    if filter_by_project_id is True:\n        filter_by_project_id \u003d self.context[\"tenant\"][\"id\"]\n    if filter_by_resource_id is True:\n        filter_by_resource_id \u003d self.context[\"tenant\"][\"resources\"][0]\n    return filter_by_resource_id, filter_by_project_id, filter_by_user_id\n\nOк, maybe you want more and will ask me to create separate types.convert for that?","commit_id":"702d9c230f84abc2f615428ea242805d2f86d4cc"}],"rally/plugins/openstack/scenarios/ceilometer/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"04a2227eaf1b177daedc70757747708cd3820a47","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        metadata_query \u003d metadata_query or {}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if filter_by_user_id:"},{"line_number":115,"context_line":"            query.append(self._make_query_item(\"user_id\", \"eq\","},{"line_number":116,"context_line":"                                               self.context[\"user\"][\"id\"]))"},{"line_number":117,"context_line":"        if filter_by_project_id:"},{"line_number":118,"context_line":"            query.append(self._make_query_item("}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_a430eee9","line":115,"updated":"2016-06-02 12:35:13.000000000","message":"Everything looks good to me but proper unit test should be updated as well","commit_id":"20b6571029a48928c9b25f027e3e21fd5adf8b23"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c0af3eb1ae10de9a81ebfd09724ca7d78d935696","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        metadata_query \u003d metadata_query or {}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if filter_by_user_id:"},{"line_number":115,"context_line":"            query.append(self._make_query_item(\"user_id\", \"eq\","},{"line_number":116,"context_line":"                                               self.context[\"user\"][\"id\"]))"},{"line_number":117,"context_line":"        if filter_by_project_id:"},{"line_number":118,"context_line":"            query.append(self._make_query_item("}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_f05c6cf2","line":115,"in_reply_to":"9abb7d3a_a430eee9","updated":"2016-06-02 13:43:34.000000000","message":"My mistake, everything looks fine","commit_id":"20b6571029a48928c9b25f027e3e21fd5adf8b23"}]}
