)]}'
{"rally/plugins/openstack/scenarios/cinder/volumes.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"8b5fd3659b4522b60841ba37cf61e6ce01dc4c97","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        create_volume_kwargs \u003d create_volume_kwargs or {}"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        source_vol \u003d self._create_volume(size, **create_volume_kwargs)"},{"line_number":402,"context_line":"        nes_objs \u003d [(self.get_random_server(), source_vol,"},{"line_number":403,"context_line":"                     self._create_snapshot(source_vol.id, False, **kwargs))]"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_1318e783","line":401,"updated":"2016-06-03 09:02:04.000000000","message":"We need at least one more unit test to check this","commit_id":"187eec4db6a1c2f8116d707d0020e3f70f0c32b8"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b69bd2019662020d3c9bed5f8ba247da7b0c1b87","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                                                  size\u003dNone,"},{"line_number":370,"context_line":"                                                  nested_level\u003d1,"},{"line_number":371,"context_line":"                                                  create_volume_kwargs\u003dNone,"},{"line_number":372,"context_line":"                                                  **kwargs):"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        \"\"\"Create a volume from snapshot and attach/detach the volume"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_f5ba6ae0","line":372,"updated":"2016-06-06 17:49:32.000000000","message":"I feel like this would be better if we added create_snapshot_kwargs as well and deprecated **kwargs, just for clarity.","commit_id":"82f47ee2e1a4225de79ae5fda2c5f175228df339"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"60eb8b96a475010e157543282e9e7f7db97488fe","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":367,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"cinder\", \"nova\"]})"},{"line_number":368,"context_line":"    @logging.log_deprecated_args("},{"line_number":369,"context_line":"        \"Use \u0027create_snapshot_params\u0027 for additional snapshot parameters.\","},{"line_number":370,"context_line":"        \"0.4.1\", [\"kwargs\"], once\u003dTrue)"},{"line_number":371,"context_line":"    def create_nested_snapshots_and_attach_volume(self,"},{"line_number":372,"context_line":"                                                  size\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_7e9d8f58","line":369,"updated":"2016-06-07 12:09:10.000000000","message":"create_snapshot_params? maybe create_snapshot_kwargs?","commit_id":"66a34ea3aa1e0eda9dade62c34d556366f2c56bb"},{"author":{"_account_id":12637,"name":"Srinivas Sakhamuri","email":"srini.openstack@gmail.com","username":"srsakhamuri"},"change_message_id":"2d3a892871f2b56fe05270790496cda87658da89","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":367,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"cinder\", \"nova\"]})"},{"line_number":368,"context_line":"    @logging.log_deprecated_args("},{"line_number":369,"context_line":"        \"Use \u0027create_snapshot_params\u0027 for additional snapshot parameters.\","},{"line_number":370,"context_line":"        \"0.4.1\", [\"kwargs\"], once\u003dTrue)"},{"line_number":371,"context_line":"    def create_nested_snapshots_and_attach_volume(self,"},{"line_number":372,"context_line":"                                                  size\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_8ccbf1a4","line":369,"in_reply_to":"7aa08908_7e9d8f58","updated":"2016-06-07 12:31:02.000000000","message":"oops, fixed it!","commit_id":"66a34ea3aa1e0eda9dade62c34d556366f2c56bb"}],"tests/unit/plugins/openstack/scenarios/cinder/test_volumes.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"479639af0d98bd1f25824906bfc1a63a7e2fbec8","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            create_volume_kwargs\u003dvolume_kwargs)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        scenario._create_volume.assert_called_once_with(1, **volume_kwargs)"},{"line_number":365,"context_line":"        self.assertEqual(scenario._create_volume.return_value, fake_volume)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def test_create_nested_snapshots_calls_order(self):"},{"line_number":368,"context_line":"        fake_volume1 \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_824e8abf","line":365,"updated":"2016-06-04 05:10:54.000000000","message":"LGTM, except wrong order here. First should be expected value, then actual","commit_id":"4a663861cc68e582438335fb629104e5f60d0d61"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"4d20fdfbf9c3da9cfb77df54b4a3d7cf4a1dbc5b","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        self.assertEqual(scenario._delete_snapshot.call_count, snapshots_count)"},{"line_number":343,"context_line":"        self.assertEqual(scenario._detach_volume.call_count, attached_count)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def test_create_nested_snapshots_and_attach_volume_kwargs(self):"},{"line_number":346,"context_line":"        fake_volume \u003d mock.MagicMock()"},{"line_number":347,"context_line":"        fake_snapshot \u003d mock.MagicMock()"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_a4035941","line":345,"updated":"2016-06-07 14:54:18.000000000","message":"These cases may be covered by single test with @ddt. But this not a blocker","commit_id":"77c54c6f6e3e2a8abce54bb25995fbbac26bfabb"}]}