)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"6edcb2d57ff5d6c2e50246911fe41b3fec6ad779","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint rally-hypervisor-boot"},{"line_number":13,"context_line":"Implements: blueprint rally-lbaas-scenarios"},{"line_number":14,"context_line":"Implements: blueprint scenario-for-network-traffic-performance"},{"line_number":15,"context_line":"Implements: blueprint network-vm-scale"},{"line_number":16,"context_line":"Change-Id: I3d67aad67ac16a3443b8793fef509583f25023e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7aa08908_bebc30dc","line":14,"updated":"2016-06-10 16:39:51.000000000","message":"This is the only blueprint that actually looks related here.","commit_id":"9843c495d4e16d9342ec8d9de9d43e869f4dbcc8"}],"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"6edcb2d57ff5d6c2e50246911fe41b3fec6ad779","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @atomic.action_timer(\"nova.boot_server\")"},{"line_number":114,"context_line":"    def _boot_server(self, image_id, flavor_id,"},{"line_number":115,"context_line":"                     auto_assign_nic\u003dFalse, name\u003dNone, **kwargs):"},{"line_number":116,"context_line":"        \"\"\"Boot a server."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        Returns when the server is actually booted and in \"ACTIVE\" state."}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_1b9f5604","line":115,"updated":"2016-06-10 16:39:51.000000000","message":"This doesn\u0027t seem like it belongs here?","commit_id":"9843c495d4e16d9342ec8d9de9d43e869f4dbcc8"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"6edcb2d57ff5d6c2e50246911fe41b3fec6ad779","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                CONF.benchmark.nova_server_resize_revert_poll_interval)"},{"line_number":675,"context_line":"        )"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def _list_hypervisor_list(self, zone_info):"},{"line_number":678,"context_line":"        \"\"\"List hypervisor in availability zone"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        Given a availability zone info"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_3b2052b0","line":677,"updated":"2016-06-10 16:39:51.000000000","message":"I\u0027d rather either a) add this to the existing _list_hypervisors() command, with zone_info as an optional kwarg; or b) call _list_hypervisors() in this function, and rename it to something a bit more intuitive, like _list_hypervisors_in_az().","commit_id":"9843c495d4e16d9342ec8d9de9d43e869f4dbcc8"},{"author":{"_account_id":10061,"name":"Joe Talerico","email":"jtaleric@redhat.com","username":"rook"},"change_message_id":"5d42b4fe5b1220e4f5330b0b9f0bc2347578da04","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @atomic.action_timer(\"nova.boot_server\")"},{"line_number":114,"context_line":"    def _boot_server(self, image_id, flavor_id,"},{"line_number":115,"context_line":"                     auto_assign_nic\u003dFalse, name\u003dNone, **kwargs):"},{"line_number":116,"context_line":"        \"\"\"Boot a server."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        Returns when the server is actually booted and in \"ACTIVE\" state."}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_494bbb87","line":115,"updated":"2016-06-23 12:29:57.000000000","message":"You never use name?","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                CONF.benchmark.nova_server_resize_revert_poll_interval)"},{"line_number":675,"context_line":"        )"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def _list_hypervisor_list(self, zone_info):"},{"line_number":678,"context_line":"        \"\"\"List hypervisor in availability zone"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        Given a availability zone info"}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_041fd55f","line":677,"updated":"2016-06-23 13:48:42.000000000","message":"Too many \u0027list\u0027 in method name, it is better to name it simply \"_list_hosts\" or \"_hypervisor_list\" or something like that","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        Given a availability zone info"},{"line_number":681,"context_line":"        list the hosts in that availability zone"},{"line_number":682,"context_line":"        Needs admin access to execute this"},{"line_number":683,"context_line":"        Returns empty list if no admin access"},{"line_number":684,"context_line":"        \"\"\""},{"line_number":685,"context_line":"        try:"},{"line_number":686,"context_line":"            avail_list \u003d []"}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_64afb994","line":683,"updated":"2016-06-23 13:48:42.000000000","message":":param zone_info: ...\n:returns: list of str host names","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        Needs admin access to execute this"},{"line_number":683,"context_line":"        Returns empty list if no admin access"},{"line_number":684,"context_line":"        \"\"\""},{"line_number":685,"context_line":"        try:"},{"line_number":686,"context_line":"            avail_list \u003d []"},{"line_number":687,"context_line":"            host_list \u003d self.clients(\"nova\").hosts.list()"},{"line_number":688,"context_line":"            for host in host_list:"}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_c4faedbc","line":685,"updated":"2016-06-23 13:48:42.000000000","message":"This \u0027try\u0027 is probably on wrong place, because:\n\n1) if exception is caught at L691, then we will have NameError at L693\n\n2) all the code between try/except is not problematic but L687\n\nAlso, should self.clients(\"nova\").hosts.list() raise exception is access is forbidden?","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[{"line_number":688,"context_line":"            for host in host_list:"},{"line_number":689,"context_line":"                if host.zone \u003d\u003d zone_info:"},{"line_number":690,"context_line":"                    avail_list.append(host.host_name)"},{"line_number":691,"context_line":"        except Exception:"},{"line_number":692,"context_line":"            LOG.warn(\"Host list access forbidden\")"},{"line_number":693,"context_line":"        return avail_list"},{"line_number":694,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_816e17ff","line":691,"updated":"2016-06-23 13:48:42.000000000","message":"Can we catch explicit exceptions?","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"}],"rally/plugins/openstack/scenarios/vm/IperfInstance.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"6edcb2d57ff5d6c2e50246911fe41b3fec6ad779","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        Start the server if the role is a server"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        instance.Instance.create(self, self.role, image, flavor, net,"},{"line_number":41,"context_line":"                                 use_floatingip, floating_network, username,"},{"line_number":42,"context_line":"                                 port, key_name, **kwargs)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_1e09042d","line":40,"updated":"2016-06-10 16:39:51.000000000","message":"This should use super()","commit_id":"9843c495d4e16d9342ec8d9de9d43e869f4dbcc8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"3aaa91ec_64d5f9b7","updated":"2016-06-23 13:48:42.000000000","message":"Please use underscores+lowercase convention for module names. This module should be named \"iperf_instance.py\"","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10061,"name":"Joe Talerico","email":"jtaleric@redhat.com","username":"rook"},"change_message_id":"5d42b4fe5b1220e4f5330b0b9f0bc2347578da04","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.ssh_instance.put_file(src_file, self.dst_file, mode\u003d755)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if self.role \u003d\u003d \"server\":"},{"line_number":48,"context_line":"            cmd \u003d \"sudo %s -s -D \u003e /dev/null\" % self.dst_file"},{"line_number":49,"context_line":"            code, out, err \u003d self.ssh_instance.execute(cmd)"},{"line_number":50,"context_line":"            if code:"},{"line_number":51,"context_line":"                raise RuntimeError(\"Failed to start iperf server\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_146426e2","line":48,"updated":"2016-06-23 12:29:57.000000000","message":"What if the guest has iptables/firewalld? You don\u0027t seem to be opening any ports to allow the server to listen. Also, SELinux might block you too...","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"}],"rally/plugins/openstack/scenarios/vm/instance.py":[{"author":{"_account_id":10061,"name":"Joe Talerico","email":"jtaleric@redhat.com","username":"rook"},"change_message_id":"5d42b4fe5b1220e4f5330b0b9f0bc2347578da04","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from rally.common import sshutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Instance(object):"},{"line_number":20,"context_line":"    \"\"\"Defines a VM instance has a ssh instance with floating ip if needed"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Functions to create and delete a VM and associated floating ips"}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_94f496f2","line":19,"updated":"2016-06-23 12:29:57.000000000","message":"Curious why you didn\u0027t use the nova_utils to build your guest? https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/nova/utils.py","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from rally.common import sshutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Instance(object):"},{"line_number":20,"context_line":"    \"\"\"Defines a VM instance has a ssh instance with floating ip if needed"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Functions to create and delete a VM and associated floating ips"}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_9a083c2f","line":19,"in_reply_to":"3aaa91ec_94f496f2","updated":"2016-06-23 13:48:42.000000000","message":"This class is not needed and should be removed as well as its subclass IperfInstance.\n\nIssues:\n\n* this module is located in .../openstack/scenarios/... so any class must be a subclass of rally.task.Scenario\n* this class does something that is already implemented (completely or partially) in Rally, so take a look at: \n\nhttps://github.com/openstack/rally/blob/4d22d8944b30000115fc1e28b5f30f4ae4e8941a/rally/plugins/openstack/context/vm/custom_image.py#L37-L52\n\nhttps://github.com/openstack/rally/blob/4d22d8944b30000115fc1e28b5f30f4ae4e8941a/rally/plugins/openstack/scenarios/vm/utils.py#L101\n\nPlease do not invent a wheel and use Rally approaches","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"}],"rally/plugins/openstack/scenarios/vm/iperf.txt":[{"author":{"_account_id":10061,"name":"Joe Talerico","email":"jtaleric@redhat.com","username":"rook"},"change_message_id":"5d42b4fe5b1220e4f5330b0b9f0bc2347578da04","unresolved":false,"context_lines":[{"line_number":7,"context_line":" production Openstack deployment."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":" * The Use of iperf in VMPerf Task Scenarios"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" The VMPerf task scenarios use iperf to benchmark the network performance between"},{"line_number":13,"context_line":" instances using glance based images.  The installation of iperf on your Rally host"}],"source_content_type":"text/plain","patch_set":20,"id":"3aaa91ec_74864a14","line":10,"updated":"2016-06-23 12:29:57.000000000","message":"I do not understand how this is any different then Shaker?","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10061,"name":"Joe Talerico","email":"jtaleric@redhat.com","username":"rook"},"change_message_id":"5d42b4fe5b1220e4f5330b0b9f0bc2347578da04","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":" * Scenario Changes Required by VMPerf"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":" The default scenario file will need to be updated to point to your instance of iperf."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":" Current:"},{"line_number":26,"context_line":""}],"source_content_type":"text/plain","patch_set":20,"id":"3aaa91ec_144b86ca","line":23,"updated":"2016-06-23 12:29:57.000000000","message":"Can we guarantee the output of iperf is the same for every version? It seems your parsing for the result is quite dependent on the output of iperf.","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"}],"rally/plugins/openstack/scenarios/vm/monitor.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"6edcb2d57ff5d6c2e50246911fe41b3fec6ad779","unresolved":false,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"def parse_options(inst):"},{"line_number":467,"context_line":"    parser \u003d optparse.OptionParser(usage\u003d\"Usage: %prog [options]\""},{"line_number":468,"context_line":"                                   \"{-s \u003cserver ip\u003e} {-p \u003cserver port\u003e}\""},{"line_number":469,"context_line":"                                   \"{-c \u003ccount\u003e} {-f \u003cfrequency\u003e}\","},{"line_number":470,"context_line":"                                   description\u003d\"Ganglia Monitoring frontend\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_de4c9c78","line":467,"updated":"2016-06-10 16:39:51.000000000","message":"At a very minimum this needs to use argparse, not optparse. Although I don\u0027t understand why it parses options at all, since AFAICT it\u0027s only imported as a module. There seems to be a lot of historical cruft here.","commit_id":"9843c495d4e16d9342ec8d9de9d43e869f4dbcc8"}],"rally/plugins/openstack/scenarios/vm/tools/iperf":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"6edcb2d57ff5d6c2e50246911fe41b3fec6ad779","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7aa08908_5e41cc38","updated":"2016-06-10 16:39:51.000000000","message":"Why are we checking binaries into git?","commit_id":"9843c495d4e16d9342ec8d9de9d43e869f4dbcc8"}],"rally/plugins/openstack/scenarios/vm/vm_perf.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"6edcb2d57ff5d6c2e50246911fe41b3fec6ad779","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            # or Rally created network"},{"line_number":105,"context_line":"            #######################################################"},{"line_number":106,"context_line":"            router_id \u003d []"},{"line_number":107,"context_line":"            nets \u003d self.clients(\"nova\").networks.list()"},{"line_number":108,"context_line":"            # check if fixed network was passed, if so pass its nic"},{"line_number":109,"context_line":"            if fixed_network:"},{"line_number":110,"context_line":"                for net in nets:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_9ebe94fd","line":107,"updated":"2016-06-10 16:39:51.000000000","message":"This is only used on line 118, so should be moved inside that if block. Also, use self._list_networks().","commit_id":"9843c495d4e16d9342ec8d9de9d43e869f4dbcc8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"3aaa91ec_fa1b4019","updated":"2016-06-23 13:48:42.000000000","message":"vm/vm_perf.py - we have double \"vm\" here, name this module simply \"vm/perf.py\"","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from rally.task import validation"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"\"\"\""},{"line_number":28,"context_line":"Scenario to measure the iperf throughput"},{"line_number":29,"context_line":"between client and server VMs"},{"line_number":30,"context_line":"Needs ssh access to VM to be able to"},{"line_number":31,"context_line":"install iperf"}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_1586dd64","line":28,"updated":"2016-06-23 13:48:42.000000000","message":"This docstring should be placed to scenario - at L69","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                    self.client_az \u003d self.server_az"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            # Boot the server and client VM"},{"line_number":152,"context_line":"            self.server \u003d IperfInstance.IperfInstance(self, \"server\")"},{"line_number":153,"context_line":"            if schedule_node:"},{"line_number":154,"context_line":"                kwargs[\"availability_zone\"] \u003d self.server_az"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_ba4c1843","line":152,"updated":"2016-06-23 13:48:42.000000000","message":"So iperf is installed into server each time in each iteration? The only reason to do this is when we want to measure this installation. If you want to save a scenario time, create and use context based on https://github.com/openstack/rally/blob/4d22d8944b30000115fc1e28b5f30f4ae4e8941a/rally/plugins/openstack/context/vm/custom_image.py#L37-L52\n\nIn thi scase iperf will be installed only once and then customuized image will be used in each iteration","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"}],"rally/task/scenario.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"6edcb2d57ff5d6c2e50246911fe41b3fec6ad779","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self._output \u003d {\"additive\": [], \"complete\": []}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def _generate_random_name(self):"},{"line_number":115,"context_line":"        return self.generate_random_name()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @staticmethod"},{"line_number":118,"context_line":"    def _validate_helper(validators, clients, config, deployment):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_5e4b8c2b","line":115,"updated":"2016-06-10 16:39:51.000000000","message":"Why?","commit_id":"9843c495d4e16d9342ec8d9de9d43e869f4dbcc8"}],"rally/task/types.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"6edcb2d57ff5d6c2e50246911fe41b3fec6ad779","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                                        resources\u003dlist("},{"line_number":289,"context_line":"                                            glanceclient.images.list()),"},{"line_number":290,"context_line":"                                        typename\u003d\"image\")"},{"line_number":291,"context_line":"        return resource_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_5e726c7d","line":291,"updated":"2016-06-10 16:39:51.000000000","message":"This looks like you\u0027re reverting portions of previous commits? Why?","commit_id":"9843c495d4e16d9342ec8d9de9d43e869f4dbcc8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    return obj_from_id(resource_config, resources, typename).name"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"def set(**kwargs):"},{"line_number":240,"context_line":"    \"\"\"Decorator to define resource transformation(s) on scenario parameters."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    The `kwargs` passed as arguments to the decorator are used to"}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_355f99e6","line":239,"updated":"2016-06-23 13:48:42.000000000","message":"This function already exists and is renamed to \"convert\" - see L52","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    return wrapper"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"class FlavorResourceType(ResourceType):"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @classmethod"},{"line_number":256,"context_line":"    def transform(cls, clients, resource_config):"}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_f5c99179","line":253,"updated":"2016-06-23 13:48:42.000000000","message":"This already exists at https://github.com/openstack/rally/blob/4d22d8944b30000115fc1e28b5f30f4ae4e8941a/rally/plugins/openstack/types.py#L21","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cec7c69c757d27bf2e2f3cd49587b7dab5881d49","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        return resource_id"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"class ImageResourceType(ResourceType):"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @classmethod"},{"line_number":276,"context_line":"    def transform(cls, clients, resource_config):"}],"source_content_type":"text/x-python","patch_set":20,"id":"3aaa91ec_7583e104","line":273,"updated":"2016-06-23 13:48:42.000000000","message":"This already exists at https://github.com/openstack/rally/blob/4d22d8944b30000115fc1e28b5f30f4ae4e8941a/rally/plugins/openstack/types.py#L69","commit_id":"1f857d09fb91f8d37eb463a8fa0501a2ce7506c3"}]}
