)]}'
{"doc/ext/plugin_reference.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f0ea8097887b538ea79423d0f4728f20b00e0529","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    if info[\"description\"]:"},{"line_number":47,"context_line":"        subcategory_obj.extend(parse_text(info[\"description\"]))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if hasattr(plugin, \"CONFIG_SCHEMA\") and plugin.CONFIG_SCHEMA:"},{"line_number":50,"context_line":"        subcategory_obj.extend(paragraph(\"**Config JSON Schema**\"))"},{"line_number":51,"context_line":"        subcategory_obj.extend(make_json_block(plugin.CONFIG_SCHEMA))"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_fb494d61","line":49,"updated":"2016-06-24 10:57:07.000000000","message":"1) Let\u0027s simplify this:\n\n if getattr(plugin, plugin.CONFIG_SCHEMA, None):\n\n2) I\u0027ve noticed that variable \u0027plugin\u0027 overrides module imported at L20 - this patch seems to be a good place to fix that","commit_id":"e9784ed57b91a7b87f79a96a21c0d95578abacc2"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"aa14ff40102ce0773da6f0d7e038b418c0378585","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    if info[\"description\"]:"},{"line_number":47,"context_line":"        subcategory_obj.extend(parse_text(info[\"description\"]))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if hasattr(plugin, \"CONFIG_SCHEMA\") and plugin.CONFIG_SCHEMA:"},{"line_number":50,"context_line":"        subcategory_obj.extend(paragraph(\"**Config JSON Schema**\"))"},{"line_number":51,"context_line":"        subcategory_obj.extend(make_json_block(plugin.CONFIG_SCHEMA))"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_663f8487","line":49,"in_reply_to":"3aaa91ec_fb494d61","updated":"2016-06-24 11:20:33.000000000","message":"1) not sure it is simpler, and moreover, we later access the value as plugin.CONFIG_SCHEMA, so getattr is a bit redundant. Are we talking about personal preferences anyway? ))\n\n2) agree with that","commit_id":"e9784ed57b91a7b87f79a96a21c0d95578abacc2"}],"doc/ext/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f0ea8097887b538ea79423d0f4728f20b00e0529","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def make_json_block(d):"},{"line_number":57,"context_line":"    if not isinstance(d, (list, dict)):"},{"line_number":58,"context_line":"        raise ValueError(\"\u0027d\u0027 object should be instance of dictionary or list.\")"},{"line_number":59,"context_line":"    text \u003d \".. code-block:: json\\n\\n\""},{"line_number":60,"context_line":"    for line in json.dumps(d, indent\u003d4).split(\"\\n\"):"},{"line_number":61,"context_line":"        text +\u003d \"    %s\\n\" % line"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_bbfb45c0","line":58,"updated":"2016-06-24 10:57:07.000000000","message":"\u0027d\u0027 object? Maybe something like \"Specified JSON data...\"","commit_id":"e9784ed57b91a7b87f79a96a21c0d95578abacc2"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f0ea8097887b538ea79423d0f4728f20b00e0529","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    text \u003d \".. code-block:: json\\n\\n\""},{"line_number":60,"context_line":"    for line in json.dumps(d, indent\u003d4).split(\"\\n\"):"},{"line_number":61,"context_line":"        text +\u003d \"    %s\\n\" % line"},{"line_number":62,"context_line":"    return parse_text(text)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_fbef8de6","line":62,"updated":"2016-06-24 10:57:07.000000000","message":"Can we make this block expandable by JavaScript? It takes a lot of place on a page","commit_id":"e9784ed57b91a7b87f79a96a21c0d95578abacc2"}]}