)]}'
{"rally/plugins/openstack/context/manila/manila_share_networks.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5e1c8004abd5a94b19a359d0d11fb0adbf19946a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                self.context.get(\"users\", []))):"},{"line_number":135,"context_line":"            networks \u003d self.context[\"tenants\"][tenant_id].get(\"networks\")"},{"line_number":136,"context_line":"            manila_scenario \u003d manila_utils.ManilaScenario("},{"line_number":137,"context_line":"                {\"task\": self.task, \"user\": user})"},{"line_number":138,"context_line":"            self.context[\"tenants\"][tenant_id][CONTEXT_NAME] \u003d {}"},{"line_number":139,"context_line":"            self.context[\"tenants\"][tenant_id][CONTEXT_NAME]["},{"line_number":140,"context_line":"                \"share_networks\"] \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_9797ab8f","line":137,"updated":"2016-07-28 16:17:52.000000000","message":"please, transmit api_versions context here and to all usages of ManilaScenario in this file","commit_id":"5030c6252280f733fbd9b8d02ed9f58e209349b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"279d4555981bde357e282c30589bad294aed755b","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                self.context.get(\"users\", []))):"},{"line_number":135,"context_line":"            networks \u003d self.context[\"tenants\"][tenant_id].get(\"networks\")"},{"line_number":136,"context_line":"            manila_scenario \u003d manila_utils.ManilaScenario("},{"line_number":137,"context_line":"                {\"task\": self.task, \"user\": user})"},{"line_number":138,"context_line":"            self.context[\"tenants\"][tenant_id][CONTEXT_NAME] \u003d {}"},{"line_number":139,"context_line":"            self.context[\"tenants\"][tenant_id][CONTEXT_NAME]["},{"line_number":140,"context_line":"                \"share_networks\"] \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_abe88ae3","line":137,"in_reply_to":"bacf61ea_9797ab8f","updated":"2016-07-28 17:24:30.000000000","message":"Done","commit_id":"5030c6252280f733fbd9b8d02ed9f58e209349b2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5e1c8004abd5a94b19a359d0d11fb0adbf19946a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            networks \u003d self.context[\"tenants\"][tenant_id].get(\"networks\")"},{"line_number":136,"context_line":"            manila_scenario \u003d manila_utils.ManilaScenario("},{"line_number":137,"context_line":"                {\"task\": self.task, \"user\": user})"},{"line_number":138,"context_line":"            self.context[\"tenants\"][tenant_id][CONTEXT_NAME] \u003d {}"},{"line_number":139,"context_line":"            self.context[\"tenants\"][tenant_id][CONTEXT_NAME]["},{"line_number":140,"context_line":"                \"share_networks\"] \u003d []"},{"line_number":141,"context_line":"            data \u003d {}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"            def _setup_share_network(tenant_id, data):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_77d95783","line":140,"range":{"start_line":138,"start_character":12,"end_line":140,"end_character":38},"updated":"2016-07-28 16:17:52.000000000","message":"NIT: replace by:\n\n    self.context[\"tenants\"][tenant_id][CONTEXT_NAME] \u003d {\"share_networks\": []}","commit_id":"5030c6252280f733fbd9b8d02ed9f58e209349b2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"279d4555981bde357e282c30589bad294aed755b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            networks \u003d self.context[\"tenants\"][tenant_id].get(\"networks\")"},{"line_number":136,"context_line":"            manila_scenario \u003d manila_utils.ManilaScenario("},{"line_number":137,"context_line":"                {\"task\": self.task, \"user\": user})"},{"line_number":138,"context_line":"            self.context[\"tenants\"][tenant_id][CONTEXT_NAME] \u003d {}"},{"line_number":139,"context_line":"            self.context[\"tenants\"][tenant_id][CONTEXT_NAME]["},{"line_number":140,"context_line":"                \"share_networks\"] \u003d []"},{"line_number":141,"context_line":"            data \u003d {}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"            def _setup_share_network(tenant_id, data):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_8be30605","line":140,"range":{"start_line":138,"start_character":12,"end_line":140,"end_character":38},"in_reply_to":"bacf61ea_77d95783","updated":"2016-07-28 17:24:30.000000000","message":"Done","commit_id":"5030c6252280f733fbd9b8d02ed9f58e209349b2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d95acd967c5bb082a5cd76dc525f9999efa9808e","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            manila_scenario \u003d manila_utils.ManilaScenario({"},{"line_number":111,"context_line":"                \"user\": existing_user,"},{"line_number":112,"context_line":"                \"config\": {"},{"line_number":113,"context_line":"                    \"api_versions\": self.context[\"config\"].get("},{"line_number":114,"context_line":"                        \"api_versions\", [])}"},{"line_number":115,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_d220e64b","line":112,"updated":"2016-08-04 09:06:34.000000000","message":"\"config\": self.context[\"config\"],","commit_id":"3f0f5b8f5cce23e469015c2e5299b4acb718f5e0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d4ae379ef28eac59756dbc213a9273eeb37263b4","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            manila_scenario \u003d manila_utils.ManilaScenario({"},{"line_number":111,"context_line":"                \"user\": existing_user,"},{"line_number":112,"context_line":"                \"config\": {"},{"line_number":113,"context_line":"                    \"api_versions\": self.context[\"config\"].get("},{"line_number":114,"context_line":"                        \"api_versions\", [])}"},{"line_number":115,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_b2fd723d","line":112,"in_reply_to":"bacf61ea_d220e64b","updated":"2016-08-04 09:16:37.000000000","message":"It was done in agreement with akurilin. I cannot satisfy two opposite requests at once. Moreover, it is very strange that end context should care about such stuff.","commit_id":"3f0f5b8f5cce23e469015c2e5299b4acb718f5e0"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d95acd967c5bb082a5cd76dc525f9999efa9808e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                        data[\"nova_net_id\"] \u003d network[\"id\"]"},{"line_number":161,"context_line":"                    elif network.get(\"subnets\"):"},{"line_number":162,"context_line":"                        data[\"neutron_net_id\"] \u003d network[\"id\"]"},{"line_number":163,"context_line":"                        data[\"neutron_subnet_id\"] \u003d network[\"subnets\"][0]"},{"line_number":164,"context_line":"                    else:"},{"line_number":165,"context_line":"                        LOG.warning(_("},{"line_number":166,"context_line":"                            \"Can not determine network service provider. \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_873e32d8","line":163,"updated":"2016-08-04 09:06:34.000000000","message":"Why do we use only first element? Subnets have different ids","commit_id":"3f0f5b8f5cce23e469015c2e5299b4acb718f5e0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d4ae379ef28eac59756dbc213a9273eeb37263b4","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                        data[\"nova_net_id\"] \u003d network[\"id\"]"},{"line_number":161,"context_line":"                    elif network.get(\"subnets\"):"},{"line_number":162,"context_line":"                        data[\"neutron_net_id\"] \u003d network[\"id\"]"},{"line_number":163,"context_line":"                        data[\"neutron_subnet_id\"] \u003d network[\"subnets\"][0]"},{"line_number":164,"context_line":"                    else:"},{"line_number":165,"context_line":"                        LOG.warning(_("},{"line_number":166,"context_line":"                            \"Can not determine network service provider. \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_12f39e9f","line":163,"in_reply_to":"bacf61ea_873e32d8","updated":"2016-08-04 09:16:37.000000000","message":"We need to pick one. That\u0027s all. Do you suggest something?","commit_id":"3f0f5b8f5cce23e469015c2e5299b4acb718f5e0"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d95acd967c5bb082a5cd76dc525f9999efa9808e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        if not isinstance(resources, list):"},{"line_number":241,"context_line":"            resources \u003d [resources]"},{"line_number":242,"context_line":"        for resource in resources:"},{"line_number":243,"context_line":"            bench_utils.wait_for_delete("},{"line_number":244,"context_line":"                resource,"},{"line_number":245,"context_line":"                update_resource\u003dbench_utils.get_from_manager(),"},{"line_number":246,"context_line":"                timeout\u003dCONF.benchmark.manila_share_delete_timeout,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_4761daa7","line":243,"updated":"2016-08-04 09:06:34.000000000","message":"This is deprecated usage in favor of wait_for_status https://github.com/openstack/rally/blob/fc5f0a4a9a0c02e378f15553c3f199c9eb5a0409/rally/task/utils.py#L254","commit_id":"3f0f5b8f5cce23e469015c2e5299b4acb718f5e0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d4ae379ef28eac59756dbc213a9273eeb37263b4","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        if not isinstance(resources, list):"},{"line_number":241,"context_line":"            resources \u003d [resources]"},{"line_number":242,"context_line":"        for resource in resources:"},{"line_number":243,"context_line":"            bench_utils.wait_for_delete("},{"line_number":244,"context_line":"                resource,"},{"line_number":245,"context_line":"                update_resource\u003dbench_utils.get_from_manager(),"},{"line_number":246,"context_line":"                timeout\u003dCONF.benchmark.manila_share_delete_timeout,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_b268d222","line":243,"in_reply_to":"bacf61ea_4761daa7","updated":"2016-08-04 09:16:37.000000000","message":"It was up-to-date when was implemented on 5th of October in 2015. Just imagine how old is this code! originally it was located in following commit: https://review.openstack.org/#/c/187643/","commit_id":"3f0f5b8f5cce23e469015c2e5299b4acb718f5e0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4e524b03010acb3b107ea3bef3b965e6947c8f77","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        if not isinstance(resources, list):"},{"line_number":241,"context_line":"            resources \u003d [resources]"},{"line_number":242,"context_line":"        for resource in resources:"},{"line_number":243,"context_line":"            bench_utils.wait_for_delete("},{"line_number":244,"context_line":"                resource,"},{"line_number":245,"context_line":"                update_resource\u003dbench_utils.get_from_manager(),"},{"line_number":246,"context_line":"                timeout\u003dCONF.benchmark.manila_share_delete_timeout,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_d83ac7cc","line":243,"in_reply_to":"bacf61ea_b268d222","updated":"2016-08-04 09:38:06.000000000","message":"Done","commit_id":"3f0f5b8f5cce23e469015c2e5299b4acb718f5e0"}]}
