)]}'
{"rally-jobs/nova.yaml":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6908c214b57c9e3bd8645acbf4fefda553d2f45a","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"      context:"},{"line_number":1115,"context_line":"        users:"},{"line_number":1116,"context_line":"          tenants: 2"},{"line_number":1117,"context_line":"          users_per_tenant: 2"},{"line_number":1118,"context_line":"      sla:"},{"line_number":1119,"context_line":"        failure_rate:"},{"line_number":1120,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_30e9671b","line":1117,"updated":"2016-06-29 11:20:34.000000000","message":"This is not critical however it worth to notice that 2 users per tenant are redundant because 2 tenants x 2 users \u003d 4 but there are only 2 iterations, so 2 users are not in use","commit_id":"d201049cfb86c9ec52eaeb778723a0dce571d82c"}],"rally/plugins/openstack/scenarios/nova/servers.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"904b2a4d81adeab4bfe3c8f6cdf92c1aaabbc20f","unresolved":false,"context_lines":[{"line_number":889,"context_line":"    @validation.required_services(consts.Service.NOVA, consts.Service.CINDER)"},{"line_number":890,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":891,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"nova\", \"cinder\"]})"},{"line_number":892,"context_line":"    def boot_server_from_snapshot(self, image, flavor, volume_size,"},{"line_number":893,"context_line":"                                  auto_assign_nic\u003dFalse, **kwargs):"},{"line_number":894,"context_line":"        \"\"\"Boot a server from a snapshot."},{"line_number":895,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_9bc6749a","line":892,"updated":"2016-06-17 12:36:33.000000000","message":"Please make volume_size parameter with default 1. Also the name doesn\u0027t fit the things that going on in scenario. Name should be changed or use volume context. I prefer usage of context its more suitable here","commit_id":"9600daba46dd0f4ac17f4c37d2f2c2c0595fddc5"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"33f2b0aba246cc9aa2717112b9a9f6e301a01993","unresolved":false,"context_lines":[{"line_number":889,"context_line":"    @validation.required_services(consts.Service.NOVA, consts.Service.CINDER)"},{"line_number":890,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":891,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"nova\", \"cinder\"]})"},{"line_number":892,"context_line":"    def boot_server_from_snapshot(self, image, flavor, volume_size,"},{"line_number":893,"context_line":"                                  auto_assign_nic\u003dFalse, **kwargs):"},{"line_number":894,"context_line":"        \"\"\"Boot a server from a snapshot."},{"line_number":895,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_4a65c9df","line":892,"in_reply_to":"7aa08908_9bc6749a","updated":"2016-06-20 09:15:22.000000000","message":"Done","commit_id":"9600daba46dd0f4ac17f4c37d2f2c2c0595fddc5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a3bfb989c558063bf9e7b557479a89c08e54ae35","unresolved":false,"context_lines":[{"line_number":908,"context_line":"        volume \u003d random.choice(self.context[\"tenant\"][\"volumes\"])"},{"line_number":909,"context_line":"        snapshot \u003d self._create_snapshot(volume[\"id\"], False)"},{"line_number":910,"context_line":"        block_device_mapping \u003d {\"vda\": \"%s:snap::1\" % snapshot.id}"},{"line_number":911,"context_line":"        self._boot_server(None, flavor, auto_assign_nic\u003dauto_assign_nic,"},{"line_number":912,"context_line":"                          block_device_mapping\u003dblock_device_mapping,"},{"line_number":913,"context_line":"                          **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8b179ba2","line":911,"updated":"2016-06-22 11:24:09.000000000","message":"Something has gone wrong http://logs.openstack.org/91/330291/2/check/gate-rally-dsvm-rally-nova/82127eb/rally-plot/results.html.gz#/NovaServers.boot_server_from_snapshot/overview","commit_id":"04583bd707798c23105004ad4180bc0ff8fb9cc6"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"70e0a88754288293835002a8604c478e9922d7b3","unresolved":false,"context_lines":[{"line_number":908,"context_line":"        volume \u003d random.choice(self.context[\"tenant\"][\"volumes\"])"},{"line_number":909,"context_line":"        snapshot \u003d self._create_snapshot(volume[\"id\"], False)"},{"line_number":910,"context_line":"        block_device_mapping \u003d {\"vda\": \"%s:snap::1\" % snapshot.id}"},{"line_number":911,"context_line":"        self._boot_server(None, flavor, auto_assign_nic\u003dauto_assign_nic,"},{"line_number":912,"context_line":"                          block_device_mapping\u003dblock_device_mapping,"},{"line_number":913,"context_line":"                          **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8e4250ac","line":911,"in_reply_to":"3aaa91ec_8b179ba2","updated":"2016-06-27 03:31:27.000000000","message":"I am very careless. The image is not created on the volume.","commit_id":"04583bd707798c23105004ad4180bc0ff8fb9cc6"}],"samples/tasks/scenarios/nova/boot-from-snapshot.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"904b2a4d81adeab4bfe3c8f6cdf92c1aaabbc20f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set flavor_name \u003d flavor_name or \"m1.tiny\" %}"},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    \"NovaServers.boot_server_from_snapshot\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"args\": {"},{"line_number":6,"context_line":"                \"flavor\": {"}],"source_content_type":"application/json","patch_set":1,"id":"7aa08908_5bba4ce2","line":3,"updated":"2016-06-17 12:36:33.000000000","message":"Please replace _ to - in the name due to https://review.openstack.org/#/c/330536/","commit_id":"9600daba46dd0f4ac17f4c37d2f2c2c0595fddc5"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"33f2b0aba246cc9aa2717112b9a9f6e301a01993","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set flavor_name \u003d flavor_name or \"m1.tiny\" %}"},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    \"NovaServers.boot_server_from_snapshot\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"args\": {"},{"line_number":6,"context_line":"                \"flavor\": {"}],"source_content_type":"application/json","patch_set":1,"id":"5a9d85d2_2a579d03","line":3,"in_reply_to":"7aa08908_5bba4ce2","updated":"2016-06-20 09:15:22.000000000","message":"Done","commit_id":"9600daba46dd0f4ac17f4c37d2f2c2c0595fddc5"}],"samples/tasks/scenarios/nova/boot-from-snapshot.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"904b2a4d81adeab4bfe3c8f6cdf92c1aaabbc20f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set flavor_name \u003d flavor_name or \"m1.tiny\" %}"},{"line_number":2,"context_line":"---"},{"line_number":3,"context_line":"  NovaServers.boot_server_from_snapshot:"},{"line_number":4,"context_line":"    -"},{"line_number":5,"context_line":"      args:"},{"line_number":6,"context_line":"        flavor:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_9ba794bb","line":3,"updated":"2016-06-17 12:36:33.000000000","message":"Same as in json file","commit_id":"9600daba46dd0f4ac17f4c37d2f2c2c0595fddc5"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"33f2b0aba246cc9aa2717112b9a9f6e301a01993","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set flavor_name \u003d flavor_name or \"m1.tiny\" %}"},{"line_number":2,"context_line":"---"},{"line_number":3,"context_line":"  NovaServers.boot_server_from_snapshot:"},{"line_number":4,"context_line":"    -"},{"line_number":5,"context_line":"      args:"},{"line_number":6,"context_line":"        flavor:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a9d85d2_6a41a539","line":3,"in_reply_to":"7aa08908_9ba794bb","updated":"2016-06-20 09:15:22.000000000","message":"Done","commit_id":"9600daba46dd0f4ac17f4c37d2f2c2c0595fddc5"}],"tests/unit/plugins/openstack/scenarios/nova/test_servers.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"904b2a4d81adeab4bfe3c8f6cdf92c1aaabbc20f","unresolved":false,"context_lines":[{"line_number":779,"context_line":"        fake_snapshot \u003d mock.MagicMock(id\u003d\"snapshot_id\")"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"        scenario \u003d servers.NovaServers(self.context)"},{"line_number":782,"context_line":"        scenario._boot_server \u003d mock.MagicMock(return_value\u003dfake_server)"},{"line_number":783,"context_line":"        scenario._create_volume \u003d mock.MagicMock(return_value\u003dfake_volume)"},{"line_number":784,"context_line":"        scenario._create_snapshot \u003d mock.MagicMock(return_value\u003dfake_snapshot)"},{"line_number":785,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_fba698a9","line":782,"updated":"2016-06-17 12:36:33.000000000","message":"Looks like return value is redundant here","commit_id":"9600daba46dd0f4ac17f4c37d2f2c2c0595fddc5"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"33f2b0aba246cc9aa2717112b9a9f6e301a01993","unresolved":false,"context_lines":[{"line_number":779,"context_line":"        fake_snapshot \u003d mock.MagicMock(id\u003d\"snapshot_id\")"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"        scenario \u003d servers.NovaServers(self.context)"},{"line_number":782,"context_line":"        scenario._boot_server \u003d mock.MagicMock(return_value\u003dfake_server)"},{"line_number":783,"context_line":"        scenario._create_volume \u003d mock.MagicMock(return_value\u003dfake_volume)"},{"line_number":784,"context_line":"        scenario._create_snapshot \u003d mock.MagicMock(return_value\u003dfake_snapshot)"},{"line_number":785,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_ea73d5b2","line":782,"in_reply_to":"7aa08908_fba698a9","updated":"2016-06-20 09:15:22.000000000","message":"Done","commit_id":"9600daba46dd0f4ac17f4c37d2f2c2c0595fddc5"}]}
