)]}'
{"rally/plugins/openstack/scenarios/keystone/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9f61c24ec64455866dcf50949146795344d0d5b0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        admin_clients \u003d self.admin_clients(\"keystone\")"},{"line_number":129,"context_line":"        if admin_clients.version in [\"v3\"]:"},{"line_number":130,"context_line":"            return admin_clients.roles.list(user\u003duser, project\u003dtenant)"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            return admin_clients.roles.roles_for_user(user, tenant)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_fb2df88f","line":130,"updated":"2016-06-17 12:18:53.000000000","message":"For this purpose we are already had wrappers. And now we are going to replace utils and wrapper by services https://github.com/openstack/rally/blob/master/doc/specs/in-progress/refactor_scenario_utils.rst https://review.openstack.org/#/c/310758/14","commit_id":"24fec561c9d37bb49794bfd57f0ce5210df7c15b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"89ed57d6c801eda23112e16dd149f5582d71fbee","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        admin_clients \u003d self.admin_clients(\"keystone\")"},{"line_number":129,"context_line":"        if admin_clients.version in [\"v3\"]:"},{"line_number":130,"context_line":"            return admin_clients.roles.list(user\u003duser, project\u003dtenant)"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            return admin_clients.roles.roles_for_user(user, tenant)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_9c3955da","line":130,"in_reply_to":"7aa08908_fb2df88f","updated":"2016-06-23 14:30:58.000000000","message":"I do not know when we merged new keystone service, so let\u0027s extend keystone wrapper with one new method (list_roles)","commit_id":"24fec561c9d37bb49794bfd57f0ce5210df7c15b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"89ed57d6c801eda23112e16dd149f5582d71fbee","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        :param role: user role to assign with"},{"line_number":140,"context_line":"        :param tenant: tenant on which assignation will take place"},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        admin_clients \u003d self.admin_clients(\"keystone\")"},{"line_number":143,"context_line":"        if admin_clients.version in [\"v3\"]:"},{"line_number":144,"context_line":"            admin_clients.roles.grant(user\u003duser, role\u003drole, project\u003dtenant)"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            admin_clients.roles.add_user_role(user, role, tenant)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @atomic.action_timer(\"keystone.remove_role\")"},{"line_number":149,"context_line":"    def _role_remove(self, user, role, tenant):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_c62b0d93","line":146,"range":{"start_line":142,"start_character":8,"end_line":146,"end_character":65},"updated":"2016-06-23 14:30:58.000000000","message":"it is better to initialize keystone wrapper here and reuse add_role method.","commit_id":"24fec561c9d37bb49794bfd57f0ce5210df7c15b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"89ed57d6c801eda23112e16dd149f5582d71fbee","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        :param role: role to be dissociated with user"},{"line_number":154,"context_line":"        :param tenant: tenant on which assignation took place"},{"line_number":155,"context_line":"        \"\"\""},{"line_number":156,"context_line":"        admin_clients \u003d self.admin_clients(\"keystone\")"},{"line_number":157,"context_line":"        if admin_clients.version in [\"v3\"]:"},{"line_number":158,"context_line":"            admin_clients.roles.revoke(user\u003duser, role\u003drole, project\u003dtenant)"},{"line_number":159,"context_line":"        else:"},{"line_number":160,"context_line":"            admin_clients.roles.remove_user_role(user, role, tenant)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @atomic.action_timer(\"keystone.get_tenant\")"},{"line_number":163,"context_line":"    def _get_tenant(self, tenant_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_8608e52e","line":160,"range":{"start_line":156,"start_character":8,"end_line":160,"end_character":68},"updated":"2016-06-23 14:30:58.000000000","message":"same here. use remove_role from keystone wrapper","commit_id":"24fec561c9d37bb49794bfd57f0ce5210df7c15b"}]}
