)]}'
{"tests/unit/fakes.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"ad0e9e287b46a4192aaccfc6f132e758489695ed","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def create(self, package_descr, package_arch, package_class\u003dFakeMurano):"},{"line_number":431,"context_line":"        package \u003d self._cache(package_class(self))"},{"line_number":432,"context_line":"        package.name \u003d list(package_arch.keys())[0]"},{"line_number":433,"context_line":"        return package"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_5bf3da0a","line":432,"updated":"2016-06-22 01:12:34.000000000","message":"in general this is the right fix.  Just need to be careful as list(dict.keys()) isn\u0027t atomic like dict.keys() was, so running in multithreaded environments could give issues.  But I think its just fine here.","commit_id":"0b7c9f4f991fbdc1c5cc2f3f50dc24ee9a6ac59d"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"5c899a251c0cfec3b1c6d01133894e2e3211d434","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def create(self, package_descr, package_arch, package_class\u003dFakeMurano):"},{"line_number":431,"context_line":"        package \u003d self._cache(package_class(self))"},{"line_number":432,"context_line":"        package.name \u003d list(package_arch.keys())[0]"},{"line_number":433,"context_line":"        return package"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_1c5f6f42","line":432,"in_reply_to":"3aaa91ec_022390be","updated":"2016-06-22 12:13:45.000000000","message":"Does not look nicer for me:\n1) popitem is destructive\n2) whether it uses the same order as keys() or not, my complaint was about non-predictability of that order","commit_id":"0b7c9f4f991fbdc1c5cc2f3f50dc24ee9a6ac59d"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"36c514affe1bd0659b26c3a84f85e82a5f99471b","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def create(self, package_descr, package_arch, package_class\u003dFakeMurano):"},{"line_number":431,"context_line":"        package \u003d self._cache(package_class(self))"},{"line_number":432,"context_line":"        package.name \u003d list(package_arch.keys())[0]"},{"line_number":433,"context_line":"        return package"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_022390be","line":432,"in_reply_to":"3aaa91ec_3c823253","updated":"2016-06-22 10:33:44.000000000","message":"popitem() looks much nicer:\n\n package_arch.popitem()[0]","commit_id":"0b7c9f4f991fbdc1c5cc2f3f50dc24ee9a6ac59d"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"789cdc9ba2334542f6d0419e3447f7baa805ee62","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def create(self, package_descr, package_arch, package_class\u003dFakeMurano):"},{"line_number":431,"context_line":"        package \u003d self._cache(package_class(self))"},{"line_number":432,"context_line":"        package.name \u003d list(package_arch.keys())[0]"},{"line_number":433,"context_line":"        return package"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_3c823253","line":432,"in_reply_to":"3aaa91ec_5bf3da0a","updated":"2016-06-22 10:08:17.000000000","message":"ugh.. original code is ridiculously ugly. How could anybody rely on the prder of keys in a plain dict. \nAs for the change,  in py2 this will cause two creations of a list, during _keys() and during list(). This seems to be a pretty good place to use six.iterkeys()\nBut since we don\u0027t expect package_arch to be that big, i\u0027m just ok)","commit_id":"0b7c9f4f991fbdc1c5cc2f3f50dc24ee9a6ac59d"}]}