)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4df51e7336b89347260b659fee68e20847409de4","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds default role parameter to rally openstack"},{"line_number":15,"context_line":"deployment creation. And for the existed deployments the"},{"line_number":16,"context_line":"role name is still set to \"memeber\"."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact"},{"line_number":19,"context_line":"Closes-Bug: #1595081"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_9c05f17b","line":16,"range":{"start_line":16,"start_character":26,"end_line":16,"end_character":35},"updated":"2016-06-23 06:39:08.000000000","message":"s/memeber/member","commit_id":"3e805641c848dc24b6a2a5da70146d8c5a78919f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d2d9c5232faeac449dea1623b7238aeeea930e5d","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds default role parameter to rally openstack"},{"line_number":15,"context_line":"deployment creation. And for the existed deployments the"},{"line_number":16,"context_line":"role name is still set to \"memeber\"."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact"},{"line_number":19,"context_line":"Closes-Bug: #1595081"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_62c69e49","line":16,"range":{"start_line":16,"start_character":26,"end_line":16,"end_character":35},"in_reply_to":"3aaa91ec_9c05f17b","updated":"2016-06-23 07:38:56.000000000","message":"Done","commit_id":"3e805641c848dc24b6a2a5da70146d8c5a78919f"}],"rally/plugins/openstack/wrappers/keystone.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ee47d31ea4f030f635d5016869ca0a577ef8e111","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def create_user(self, username, password, email\u003dNone, project_id\u003dNone,"},{"line_number":140,"context_line":"                    domain_name\u003d\"Default\", default_role\u003d\"member\"):"},{"line_number":141,"context_line":"        # NOTE(liuyulong): For v2 wrapper the `default_role` here is not used."},{"line_number":142,"context_line":"        self._check_domain(domain_name)"},{"line_number":143,"context_line":"        user \u003d self.client.users.create(username, password, email, project_id)"},{"line_number":144,"context_line":"        return KeystoneV2Wrapper._wrap_v2_user(user)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_7ce125d0","line":142,"range":{"start_line":141,"start_character":7,"end_line":142,"end_character":39},"updated":"2016-06-23 06:38:40.000000000","message":"Could you write _check_default_role like _check_domain_name?","commit_id":"3e805641c848dc24b6a2a5da70146d8c5a78919f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d2d9c5232faeac449dea1623b7238aeeea930e5d","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def create_user(self, username, password, email\u003dNone, project_id\u003dNone,"},{"line_number":140,"context_line":"                    domain_name\u003d\"Default\", default_role\u003d\"member\"):"},{"line_number":141,"context_line":"        # NOTE(liuyulong): For v2 wrapper the `default_role` here is not used."},{"line_number":142,"context_line":"        self._check_domain(domain_name)"},{"line_number":143,"context_line":"        user \u003d self.client.users.create(username, password, email, project_id)"},{"line_number":144,"context_line":"        return KeystoneV2Wrapper._wrap_v2_user(user)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4200c2aa","line":142,"range":{"start_line":141,"start_character":7,"end_line":142,"end_character":39},"in_reply_to":"3aaa91ec_7ce125d0","updated":"2016-06-23 07:38:56.000000000","message":"Actually the keystone v2 could have some default roles named \u0027_member_\u0027, \u0027__member__\u0027 and so on. If here we check the default_role whether is \"member\" or not, it will block all the v2 tests for those env that has a default \u0027_member_\u0027 role. So I don\u0027t think that check will be needed, what do you think? Thank you.","commit_id":"3e805641c848dc24b6a2a5da70146d8c5a78919f"}],"rally/task/engine.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d2d9c5232faeac449dea1623b7238aeeea930e5d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Task validation of semantic.\"))"},{"line_number":259,"context_line":"    def _validate_config_semantic(self, config):"},{"line_number":260,"context_line":"        self._check_cloud()"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        deployment \u003d objects.Deployment.get(self.task[\"deployment_uuid\"])"},{"line_number":263,"context_line":"        ctx_conf \u003d {"},{"line_number":264,"context_line":"            \"task\": self.task, \"admin\": {\"credential\": self.admin},"},{"line_number":265,"context_line":"            \"default_role\": self.default_role}"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        # TODO(boris-42): It\u0027s quite hard at the moment to validate case"},{"line_number":268,"context_line":"        #                 when both user context and existing_users are"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_dcde593e","line":265,"range":{"start_line":261,"start_character":0,"end_line":265,"end_character":46},"updated":"2016-06-23 07:38:56.000000000","message":"mark","commit_id":"3e805641c848dc24b6a2a5da70146d8c5a78919f"}],"tests/unit/task/test_engine.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d2d9c5232faeac449dea1623b7238aeeea930e5d","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    @mock.patch(\"rally.task.engine.TaskEngine\""},{"line_number":270,"context_line":"                \"._validate_config_semantic_helper\")"},{"line_number":271,"context_line":"    @mock.patch(\"rally.task.engine.objects.Deployment.get\","},{"line_number":272,"context_line":"                return_value\u003dfakes.FakeDeployment())"},{"line_number":273,"context_line":"    def test__validate_config_semantic("},{"line_number":274,"context_line":"            self, mock_deployment_get,"},{"line_number":275,"context_line":"            mock__validate_config_semantic_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_bce1cd00","line":272,"range":{"start_line":272,"start_character":16,"end_line":272,"end_character":52},"updated":"2016-06-23 07:38:56.000000000","message":"mark","commit_id":"3e805641c848dc24b6a2a5da70146d8c5a78919f"}]}