)]}'
{"rally/plugins/openstack/scenarios/neutron/network.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"d186df012f4b48921728ffd9388ad05070a36464","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        port_update_args[\"fixed_ips\"] \u003d [{\"subnet_id\":"},{"line_number":317,"context_line":"                                          subnets[0][\"subnet\"][\"id\"]}]"},{"line_number":318,"context_line":"        for i in range(ports_per_network):"},{"line_number":319,"context_line":"            port \u003d self._create_port(network, port_create_args)"},{"line_number":320,"context_line":"            self._update_port(port, port_update_args)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @validation.required_parameters(\"ports_per_network\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_be42e5a8","line":319,"updated":"2016-07-01 01:32:43.000000000","message":"Maybe port_create_args value equals None. \nport \u003d self._create_port(network, port_create_args or {})","commit_id":"18e8a39921913e5a9a40b08699533d27f5df2e06"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"30e392669d6e0e54e510bca97fb052f48d3b32e4","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        port_update_args[\"fixed_ips\"] \u003d [{\"subnet_id\":"},{"line_number":317,"context_line":"                                          subnets[0][\"subnet\"][\"id\"]}]"},{"line_number":318,"context_line":"        for i in range(ports_per_network):"},{"line_number":319,"context_line":"            port \u003d self._create_port(network, port_create_args)"},{"line_number":320,"context_line":"            self._update_port(port, port_update_args)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @validation.required_parameters(\"ports_per_network\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_d5f5eeed","line":319,"in_reply_to":"3aaa91ec_be42e5a8","updated":"2016-07-01 14:16:08.000000000","message":"(1) port_create_args is a required argument of the method \n(2) that pattern is not consistent with how other scenarios are coded here...","commit_id":"18e8a39921913e5a9a40b08699533d27f5df2e06"}],"tests/unit/plugins/openstack/scenarios/neutron/test_network.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"53c3b5be1c3ab1c8231e8d4564c1398a5df114eb","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            [mock.call(p, port_update_args) for p in ports])"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def test_create_and_update_ports_in_subnet(self):"},{"line_number":331,"context_line":"        port_update_args \u003d {\"admin_state_up\": False},"},{"line_number":332,"context_line":"        port_create_args \u003d {\"allocation_pools\": []}"},{"line_number":333,"context_line":"        ports_per_network \u003d 10"},{"line_number":334,"context_line":"        subnet_cidr_start \u003d \"default_cidr\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_d1109b5b","line":331,"range":{"start_line":331,"start_character":52,"end_line":331,"end_character":53},"updated":"2016-06-30 15:43:50.000000000","message":"Comma at the end here makes port_update_args a tuple, which I don\u0027t think you want.","commit_id":"84ab6246b7e5c860ec2a6d34f7f57e2e4c2f13ea"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"6500d52cb922ce0690b82eb61bcc170ff0821194","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            [mock.call(p, port_update_args) for p in ports])"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def test_create_and_update_ports_in_subnet(self):"},{"line_number":331,"context_line":"        port_update_args \u003d {\"admin_state_up\": False},"},{"line_number":332,"context_line":"        port_create_args \u003d {\"allocation_pools\": []}"},{"line_number":333,"context_line":"        ports_per_network \u003d 10"},{"line_number":334,"context_line":"        subnet_cidr_start \u003d \"default_cidr\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_d4f1a902","line":331,"range":{"start_line":331,"start_character":52,"end_line":331,"end_character":53},"in_reply_to":"3aaa91ec_d1109b5b","updated":"2016-06-30 15:46:36.000000000","message":"Done","commit_id":"84ab6246b7e5c860ec2a6d34f7f57e2e4c2f13ea"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"53c3b5be1c3ab1c8231e8d4564c1398a5df114eb","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        scenario._get_or_create_network.assert_called_once_with("},{"line_number":361,"context_line":"            network_create_args)"},{"line_number":362,"context_line":"        scenario._create_subnets.assert_called_once_with("},{"line_number":363,"context_line":"            net, subnet_create_args, subnet_cidr_start, 1)"},{"line_number":364,"context_line":"        scenario._create_port.assert_has_calls("},{"line_number":365,"context_line":"            [mock.call(net, port_create_args)"},{"line_number":366,"context_line":"             for i in range(ports_per_network)])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_342e2d8c","line":363,"range":{"start_line":363,"start_character":56,"end_line":363,"end_character":57},"updated":"2016-06-30 15:43:50.000000000","message":"What\u0027s this \u00271\u0027 extra arg? I don\u0027t think you want it.","commit_id":"84ab6246b7e5c860ec2a6d34f7f57e2e4c2f13ea"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"6500d52cb922ce0690b82eb61bcc170ff0821194","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        scenario._get_or_create_network.assert_called_once_with("},{"line_number":361,"context_line":"            network_create_args)"},{"line_number":362,"context_line":"        scenario._create_subnets.assert_called_once_with("},{"line_number":363,"context_line":"            net, subnet_create_args, subnet_cidr_start, 1)"},{"line_number":364,"context_line":"        scenario._create_port.assert_has_calls("},{"line_number":365,"context_line":"            [mock.call(net, port_create_args)"},{"line_number":366,"context_line":"             for i in range(ports_per_network)])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_14e05128","line":363,"range":{"start_line":363,"start_character":56,"end_line":363,"end_character":57},"in_reply_to":"3aaa91ec_342e2d8c","updated":"2016-06-30 15:46:36.000000000","message":"I originally did, but it can go now","commit_id":"84ab6246b7e5c860ec2a6d34f7f57e2e4c2f13ea"}]}
