)]}'
{"rally/cli/commands/verify.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"f5f06139651ac4169954d22b9bfb78617deac2aa","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    @cliutils.args(\"--xfails-file\", dest\u003d\"xfails_file\", type\u003dstr,"},{"line_number":67,"context_line":"                   required\u003dFalse, metavar\u003d\"\u003cpath\u003e\","},{"line_number":68,"context_line":"                   help\u003d\"Path to a YAML file with a list of Tempest tests \""},{"line_number":69,"context_line":"                        \"to mark them as expected failures\")"},{"line_number":70,"context_line":"    @cliutils.args(\"--no-use\", action\u003d\"store_false\", dest\u003d\"do_use\","},{"line_number":71,"context_line":"                   help\u003d\"Don\u0027t set the task as default for future operations\")"},{"line_number":72,"context_line":"    @cliutils.args(\"--system-wide\", dest\u003d\"system_wide\","}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_8647ad1c","line":69,"updated":"2016-07-08 09:51:11.000000000","message":"IMO previous description was more clear","commit_id":"b9015121b376c6ef759b13a3dc6981d38cb3f79f"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"f5f06139651ac4169954d22b9bfb78617deac2aa","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if tests_file and tests_file_to_skip:"},{"line_number":124,"context_line":"            print(msg % (\"tests-file\", \"tests-file-to-skip\"))"},{"line_number":125,"context_line":"            return 1"},{"line_number":126,"context_line":"        if failing and set_name:"},{"line_number":127,"context_line":"            print(msg % (\"failing\", \"set\"))"},{"line_number":128,"context_line":"            return 1"},{"line_number":129,"context_line":"        if failing and regex:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_66dc4147","line":126,"updated":"2016-07-08 09:51:11.000000000","message":"these changes are not mentioned in commit message","commit_id":"b9015121b376c6ef759b13a3dc6981d38cb3f79f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0d62625c7b73f17ce1e558435d3e0d54a1f051dd","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            print(msg % (\"failing\", \"tests-file\"))"},{"line_number":134,"context_line":"            return 1"},{"line_number":135,"context_line":"        if failing and tests_file_to_skip:"},{"line_number":136,"context_line":"            print(msg % (\"failing\", \"tests-file-to-skip\"))"},{"line_number":137,"context_line":"            return 1"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        if not (regex or set_name or tests_file or failing):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_5fde9f6d","line":136,"updated":"2016-07-12 08:19:09.000000000","message":"How about that http://ideone.com/n97RIh to avoid duplicated lines in 114-137 lines?\n\n    not_iteracted_params \u003d [(\"tests_file\", \"set\"), (\"tests_file\", \"regex\")]\n    def print_msg(**kwargs):\n    \tfor params in not_iteracted_params:\n    \t\tmsg \u003d (\"Arguments \u0027%s\u0027 and \u0027%s\u0027 are not compatible. \"\n    \t\t\"You can use only one of the mentioned arguments.\")\n    \t\tif kwargs[params[0]] and kwargs[params[1]]:\n    \t\t\tprint((msg % params).replace(\"_\", \"-\"))\n    \t\t\treturn True\n     \n    print_msg(tests_file\u003d1, set\u003d2)","commit_id":"6d70d37c6047a5542442784427cc28b7d42ca24c"}],"rally/verification/tempest/tempest.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"f5f06139651ac4169954d22b9bfb78617deac2aa","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        if tests_file_to_skip and not tests_file:"},{"line_number":319,"context_line":"            with open(os.path.abspath(tests_file_to_skip), \"rb\") as f:"},{"line_number":320,"context_line":"                tests_to_skip \u003d filter("},{"line_number":321,"context_line":"                    lambda x: not re.match(r\"^\\s*$\", x), f.read().splitlines())"},{"line_number":322,"context_line":"            tests_to_run \u003d self.discover_tests(testr_args)"},{"line_number":323,"context_line":"            for test in tests_to_skip:"},{"line_number":324,"context_line":"                if test in tests_to_run:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_a6d0e9f8","line":321,"updated":"2016-07-08 09:51:11.000000000","message":"Nothing will be wrong if we just read all lines from this file\n\nActually it will be much better to use set instead of list and call strip() on every line.","commit_id":"b9015121b376c6ef759b13a3dc6981d38cb3f79f"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"f5f06139651ac4169954d22b9bfb78617deac2aa","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                tests_to_skip \u003d filter("},{"line_number":321,"context_line":"                    lambda x: not re.match(r\"^\\s*$\", x), f.read().splitlines())"},{"line_number":322,"context_line":"            tests_to_run \u003d self.discover_tests(testr_args)"},{"line_number":323,"context_line":"            for test in tests_to_skip:"},{"line_number":324,"context_line":"                if test in tests_to_run:"},{"line_number":325,"context_line":"                    tests_to_run.remove(test)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_6643a16d","line":323,"updated":"2016-07-08 09:51:11.000000000","message":"Please consider using sets:\n\n    tests_to_run -\u003d tests_to_skip","commit_id":"b9015121b376c6ef759b13a3dc6981d38cb3f79f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0d62625c7b73f17ce1e558435d3e0d54a1f051dd","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                       \"Check logs for details.\"))"},{"line_number":333,"context_line":"        finally:"},{"line_number":334,"context_line":"            if temp_file:"},{"line_number":335,"context_line":"                temp_file.close()"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def run(self, testr_args\u003d\"\", log_file\u003dNone, tempest_conf\u003dNone, concur\u003d0):"},{"line_number":338,"context_line":"        \"\"\"Run Tempest."}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_6c5300e3","line":335,"updated":"2016-07-12 08:19:09.000000000","message":"Please use context manager for that","commit_id":"6d70d37c6047a5542442784427cc28b7d42ca24c"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"76fd729111c07204a460bd1b95fba0d1618f4180","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                       \"Check logs for details.\"))"},{"line_number":333,"context_line":"        finally:"},{"line_number":334,"context_line":"            if temp_file:"},{"line_number":335,"context_line":"                temp_file.close()"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def run(self, testr_args\u003d\"\", log_file\u003dNone, tempest_conf\u003dNone, concur\u003d0):"},{"line_number":338,"context_line":"        \"\"\"Run Tempest."}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_c5300259","line":335,"in_reply_to":"1aa78d24_6c5300e3","updated":"2016-07-12 08:57:53.000000000","message":"We cannot use the context manager in L324 because if we use it, the temporary file will be closed and removed before the call of self.run(testr_args, concur\u003dconcur).","commit_id":"6d70d37c6047a5542442784427cc28b7d42ca24c"}]}