)]}'
{"rally-jobs/rally-watcher.yaml":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"66a9ae5d950cb1d1a1f51914dfdd5b8ae750b9f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1aa78d24_21d04cf7","line":17,"updated":"2016-07-14 14:04:45.000000000","message":"SLA is missing\n\n    sla:\n      failure_rate:\n        max: 0","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"47fd313738bdd0838c4ac7f5fa35ebc86546bbec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fad55976_547731d4","line":17,"in_reply_to":"1aa78d24_21d04cf7","updated":"2016-07-15 17:43:41.000000000","message":"Done","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    -"},{"line_number":4,"context_line":"      args:"},{"line_number":5,"context_line":"        goal:"},{"line_number":6,"context_line":"            name: \"dummy\""},{"line_number":7,"context_line":"        strategy:"},{"line_number":8,"context_line":"            name: \"dummy\""},{"line_number":9,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_171e806f","line":6,"updated":"2016-07-22 11:37:22.000000000","message":"here wrong indentation. It should be 2 spaces","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    -"},{"line_number":4,"context_line":"      args:"},{"line_number":5,"context_line":"        goal:"},{"line_number":6,"context_line":"            name: \"dummy\""},{"line_number":7,"context_line":"        strategy:"},{"line_number":8,"context_line":"            name: \"dummy\""},{"line_number":9,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_d3fe6537","line":6,"in_reply_to":"dada55a8_171e806f","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        goal:"},{"line_number":6,"context_line":"            name: \"dummy\""},{"line_number":7,"context_line":"        strategy:"},{"line_number":8,"context_line":"            name: \"dummy\""},{"line_number":9,"context_line":"      runner:"},{"line_number":10,"context_line":"        type: \"constant\""},{"line_number":11,"context_line":"        times: 10"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_972390bc","line":8,"updated":"2016-07-22 11:37:22.000000000","message":"here wrong indentation. It should be 2 spaces","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        goal:"},{"line_number":6,"context_line":"            name: \"dummy\""},{"line_number":7,"context_line":"        strategy:"},{"line_number":8,"context_line":"            name: \"dummy\""},{"line_number":9,"context_line":"      runner:"},{"line_number":10,"context_line":"        type: \"constant\""},{"line_number":11,"context_line":"        times: 10"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_33fc213e","line":8,"in_reply_to":"dada55a8_972390bc","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"563e6ef6a723994ba6ed96d1c9342c202dcebc7a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"          name: \"dummy\""},{"line_number":7,"context_line":"        strategy:"},{"line_number":8,"context_line":"          name: \"dummy\""},{"line_number":9,"context_line":"        extra: {}"},{"line_number":10,"context_line":"      runner:"},{"line_number":11,"context_line":"        type: \"constant\""},{"line_number":12,"context_line":"        times: 10"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_cf2f9886","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":17},"updated":"2016-08-04 12:11:10.000000000","message":"this option looks optional. let\u0027s make it real and add None default value to it with check\n\n   if extra is None:\n        extra \u003d {}","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"c4cec355325cbcf062a5b049ad7c924b981e1eb8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"          name: \"dummy\""},{"line_number":7,"context_line":"        strategy:"},{"line_number":8,"context_line":"          name: \"dummy\""},{"line_number":9,"context_line":"        extra: {}"},{"line_number":10,"context_line":"      runner:"},{"line_number":11,"context_line":"        type: \"constant\""},{"line_number":12,"context_line":"        times: 10"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_139e6256","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":17},"in_reply_to":"bacf61ea_cf2f9886","updated":"2016-08-08 15:15:08.000000000","message":"Done","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"}],"rally/plugins/openstack/scenarios/watcher/basic.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4958953054ec5a8215b9d13b7c67bba5d3376b3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @types.convert(strategy\u003d{\"type\": \"watcher_strategy\"},"},{"line_number":27,"context_line":"                   goal\u003d{\"type\": \"watcher_goal\"})"},{"line_number":28,"context_line":"    @validation.required_services(consts.Service.WATCHER)"},{"line_number":29,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"watcher\"]})"},{"line_number":30,"context_line":"    def create_audit_template_and_delete(self, goal, strategy,"},{"line_number":31,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_aceb7adb","line":28,"updated":"2016-07-14 22:06:33.000000000","message":"You\u0027ve forgot to add one more validator. See example of it https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/glance/images.py#L29","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"47fd313738bdd0838c4ac7f5fa35ebc86546bbec","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @types.convert(strategy\u003d{\"type\": \"watcher_strategy\"},"},{"line_number":27,"context_line":"                   goal\u003d{\"type\": \"watcher_goal\"})"},{"line_number":28,"context_line":"    @validation.required_services(consts.Service.WATCHER)"},{"line_number":29,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"watcher\"]})"},{"line_number":30,"context_line":"    def create_audit_template_and_delete(self, goal, strategy,"},{"line_number":31,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_e702f56e","line":28,"in_reply_to":"1aa78d24_aceb7adb","updated":"2016-07-15 17:43:41.000000000","message":"Done","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4958953054ec5a8215b9d13b7c67bba5d3376b3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        algorithm"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        audit_template \u003d self._create_audit_template(goal, strategy)"},{"line_number":42,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":43,"context_line":"        self._delete_audit_template(audit_template.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_2c5aeaf2","line":41,"updated":"2016-07-14 22:06:33.000000000","message":"Here you\u0027ve got an error\nForbidden: Policy doesn\u0027t allow audit_template:create to be performed. (HTTP 403)\nPossibly because you need to have admin rules see comment in line 28","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4958953054ec5a8215b9d13b7c67bba5d3376b3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        audit_template \u003d self._create_audit_template(goal, strategy)"},{"line_number":42,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":43,"context_line":"        self._delete_audit_template(audit_template.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_581f3170","line":42,"updated":"2016-07-14 22:06:33.000000000","message":"Why we need to sleep before delete?","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"47fd313738bdd0838c4ac7f5fa35ebc86546bbec","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        audit_template \u003d self._create_audit_template(goal, strategy)"},{"line_number":42,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":43,"context_line":"        self._delete_audit_template(audit_template.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_a72f5df5","line":42,"in_reply_to":"1aa78d24_581f3170","updated":"2016-07-15 17:43:41.000000000","message":"Removed","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016: Servionica LTD."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_520be623","line":1,"updated":"2016-07-22 11:37:22.000000000","message":"Please remove the first line","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":30,"context_line":"    @scenario.configure(context\u003d{\"admin_cleanup\": [\"watcher\"]})"},{"line_number":31,"context_line":"    def create_audit_template_and_delete(self, goal, strategy,"},{"line_number":32,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0):"},{"line_number":33,"context_line":"        \"\"\"Create audit template and delete it."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param goal: The goal audit template is based on"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_46cdc35c","line":32,"updated":"2016-07-22 11:37:22.000000000","message":"min_sleep and max_sleep are rudiments here, please delete them","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":30,"context_line":"    @scenario.configure(context\u003d{\"admin_cleanup\": [\"watcher\"]})"},{"line_number":31,"context_line":"    def create_audit_template_and_delete(self, goal, strategy,"},{"line_number":32,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0):"},{"line_number":33,"context_line":"        \"\"\"Create audit template and delete it."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param goal: The goal audit template is based on"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_f35d6949","line":32,"in_reply_to":"dada55a8_46cdc35c","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e13fc404d42dc1f42e99c8916771d020c88abb8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016: Servionica LTD."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_f703e30a","line":1,"updated":"2016-08-07 15:56:53.000000000","message":"please remove this line","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"c4cec355325cbcf062a5b049ad7c924b981e1eb8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016: Servionica LTD."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_b0367eb2","line":1,"in_reply_to":"bacf61ea_f703e30a","updated":"2016-08-08 15:15:08.000000000","message":"Done","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e13fc404d42dc1f42e99c8916771d020c88abb8b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @validation.required_services(consts.Service.WATCHER)"},{"line_number":29,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":30,"context_line":"    @scenario.configure(context\u003d{\"admin_cleanup\": [\"watcher\"]})"},{"line_number":31,"context_line":"    def create_audit_template_and_delete(self, goal, strategy, extra):"},{"line_number":32,"context_line":"        \"\"\"Create audit template and delete it."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        :param goal: The goal audit template is based on"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_17015705","line":31,"updated":"2016-08-07 15:56:53.000000000","message":"extra should have default value","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"c4cec355325cbcf062a5b049ad7c924b981e1eb8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @validation.required_services(consts.Service.WATCHER)"},{"line_number":29,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":30,"context_line":"    @scenario.configure(context\u003d{\"admin_cleanup\": [\"watcher\"]})"},{"line_number":31,"context_line":"    def create_audit_template_and_delete(self, goal, strategy, extra):"},{"line_number":32,"context_line":"        \"\"\"Create audit template and delete it."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        :param goal: The goal audit template is based on"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_f05756c8","line":31,"in_reply_to":"bacf61ea_17015705","updated":"2016-08-08 15:15:08.000000000","message":"Done","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"}],"rally/plugins/openstack/scenarios/watcher/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4958953054ec5a8215b9d13b7c67bba5d3376b3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class WatcherScenario(scenario.OpenStackScenario):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @atomic.action_timer(\"watcher.create_audit_template\")"},{"line_number":23,"context_line":"    def _create_audit_template(self, goal, strategy):"},{"line_number":24,"context_line":"        at \u003d self.clients(\"watcher\").audit_template.create("},{"line_number":25,"context_line":"            goal\u003dgoal,"},{"line_number":26,"context_line":"            strategy\u003dstrategy,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_6c6232db","line":23,"updated":"2016-07-14 22:06:33.000000000","message":"Need doc string here","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"47fd313738bdd0838c4ac7f5fa35ebc86546bbec","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class WatcherScenario(scenario.OpenStackScenario):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @atomic.action_timer(\"watcher.create_audit_template\")"},{"line_number":23,"context_line":"    def _create_audit_template(self, goal, strategy):"},{"line_number":24,"context_line":"        at \u003d self.clients(\"watcher\").audit_template.create("},{"line_number":25,"context_line":"            goal\u003dgoal,"},{"line_number":26,"context_line":"            strategy\u003dstrategy,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_aa6284ab","line":23,"in_reply_to":"1aa78d24_6c6232db","updated":"2016-07-15 17:43:41.000000000","message":"Done","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4958953054ec5a8215b9d13b7c67bba5d3376b3","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @atomic.action_timer(\"watcher.create_audit_template\")"},{"line_number":23,"context_line":"    def _create_audit_template(self, goal, strategy):"},{"line_number":24,"context_line":"        at \u003d self.clients(\"watcher\").audit_template.create("},{"line_number":25,"context_line":"            goal\u003dgoal,"},{"line_number":26,"context_line":"            strategy\u003dstrategy,"},{"line_number":27,"context_line":"            name\u003dself.generate_random_name())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_1814894b","line":24,"updated":"2016-07-14 22:06:33.000000000","message":"Please don\u0027t use local variable here","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"47fd313738bdd0838c4ac7f5fa35ebc86546bbec","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @atomic.action_timer(\"watcher.create_audit_template\")"},{"line_number":23,"context_line":"    def _create_audit_template(self, goal, strategy):"},{"line_number":24,"context_line":"        at \u003d self.clients(\"watcher\").audit_template.create("},{"line_number":25,"context_line":"            goal\u003dgoal,"},{"line_number":26,"context_line":"            strategy\u003dstrategy,"},{"line_number":27,"context_line":"            name\u003dself.generate_random_name())"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_ca5d38ee","line":24,"in_reply_to":"1aa78d24_1814894b","updated":"2016-07-15 17:43:41.000000000","message":"Done","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4958953054ec5a8215b9d13b7c67bba5d3376b3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        at \u003d self.clients(\"watcher\").audit_template.create("},{"line_number":25,"context_line":"            goal\u003dgoal,"},{"line_number":26,"context_line":"            strategy\u003dstrategy,"},{"line_number":27,"context_line":"            name\u003dself.generate_random_name())"},{"line_number":28,"context_line":"        return at"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @atomic.action_timer(\"watcher.delete_audit_template\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_8c7b1e29","line":27,"updated":"2016-07-14 22:06:33.000000000","message":"Does Watcher immediately create audit template? If no, then we need something like https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/nova/utils.py#L142-L149","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"47fd313738bdd0838c4ac7f5fa35ebc86546bbec","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        at \u003d self.clients(\"watcher\").audit_template.create("},{"line_number":25,"context_line":"            goal\u003dgoal,"},{"line_number":26,"context_line":"            strategy\u003dstrategy,"},{"line_number":27,"context_line":"            name\u003dself.generate_random_name())"},{"line_number":28,"context_line":"        return at"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @atomic.action_timer(\"watcher.delete_audit_template\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_6703a510","line":27,"in_reply_to":"1aa78d24_8c7b1e29","updated":"2016-07-15 17:43:41.000000000","message":"It has no state, so it is created immediately.","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4958953054ec5a8215b9d13b7c67bba5d3376b3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        return at"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @atomic.action_timer(\"watcher.delete_audit_template\")"},{"line_number":31,"context_line":"    def _delete_audit_template(self, audit_template):"},{"line_number":32,"context_line":"        self.clients(\"watcher\").audit_template.delete(audit_template)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_ac453a44","line":31,"updated":"2016-07-14 22:06:33.000000000","message":"Need doc string here","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"47fd313738bdd0838c4ac7f5fa35ebc86546bbec","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        return at"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @atomic.action_timer(\"watcher.delete_audit_template\")"},{"line_number":31,"context_line":"    def _delete_audit_template(self, audit_template):"},{"line_number":32,"context_line":"        self.clients(\"watcher\").audit_template.delete(audit_template)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_0a58f0f9","line":31,"in_reply_to":"1aa78d24_ac453a44","updated":"2016-07-15 17:43:41.000000000","message":"Done","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a4958953054ec5a8215b9d13b7c67bba5d3376b3","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @atomic.action_timer(\"watcher.delete_audit_template\")"},{"line_number":31,"context_line":"    def _delete_audit_template(self, audit_template):"},{"line_number":32,"context_line":"        self.clients(\"watcher\").audit_template.delete(audit_template)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_6c76b240","line":32,"updated":"2016-07-14 22:06:33.000000000","message":"Does Watcher immediately delete audit template? If no, then we need something like https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/nova/utils.py#L142-L149","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"47fd313738bdd0838c4ac7f5fa35ebc86546bbec","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @atomic.action_timer(\"watcher.delete_audit_template\")"},{"line_number":31,"context_line":"    def _delete_audit_template(self, audit_template):"},{"line_number":32,"context_line":"        self.clients(\"watcher\").audit_template.delete(audit_template)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_6a69ac8b","line":32,"in_reply_to":"1aa78d24_6c76b240","updated":"2016-07-15 17:43:41.000000000","message":"ditto","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016: Servionica LLC."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_41912d52","line":1,"updated":"2016-07-22 11:37:22.000000000","message":"Lets delete the first line","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from rally.task import atomic"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class WatcherScenario(scenario.OpenStackScenario):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @atomic.action_timer(\"watcher.create_audit_template\")"},{"line_number":23,"context_line":"    def _create_audit_template(self, goal, strategy):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_6139d1d8","line":20,"updated":"2016-07-22 11:37:22.000000000","message":"Please add docstring here \n\"\"\"Base class for Watcher scenarios with basic atomic actions.\"\"\"","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from rally.task import atomic"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class WatcherScenario(scenario.OpenStackScenario):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @atomic.action_timer(\"watcher.create_audit_template\")"},{"line_number":23,"context_line":"    def _create_audit_template(self, goal, strategy):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_361d2f67","line":20,"in_reply_to":"dada55a8_6139d1d8","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class WatcherScenario(scenario.OpenStackScenario):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @atomic.action_timer(\"watcher.create_audit_template\")"},{"line_number":23,"context_line":"    def _create_audit_template(self, goal, strategy):"},{"line_number":24,"context_line":"        \"\"\"Create Audit Template in DB"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        :param goal: UUID Goal"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_465ae351","line":23,"updated":"2016-07-22 11:37:22.000000000","message":"lets call variables like goal_id to help us understand what is inside without reading docstring. Of cause the same for strategy","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class WatcherScenario(scenario.OpenStackScenario):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @atomic.action_timer(\"watcher.create_audit_template\")"},{"line_number":23,"context_line":"    def _create_audit_template(self, goal, strategy):"},{"line_number":24,"context_line":"        \"\"\"Create Audit Template in DB"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        :param goal: UUID Goal"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_7625e7ac","line":23,"in_reply_to":"dada55a8_465ae351","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        return self.admin_clients(\"watcher\").audit_template.create("},{"line_number":31,"context_line":"            goal\u003dgoal,"},{"line_number":32,"context_line":"            strategy\u003dstrategy,"},{"line_number":33,"context_line":"            name\u003dself.generate_random_name())"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @atomic.action_timer(\"watcher.delete_audit_template\")"},{"line_number":36,"context_line":"    def _delete_audit_template(self, audit_template):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_21aa3986","line":33,"updated":"2016-07-22 11:37:22.000000000","message":"there is more parameter like host_aggregate and extra. Maybe the first one will be not very useful but I believe the second one will be needed for you in the future","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        return self.admin_clients(\"watcher\").audit_template.create("},{"line_number":31,"context_line":"            goal\u003dgoal,"},{"line_number":32,"context_line":"            strategy\u003dstrategy,"},{"line_number":33,"context_line":"            name\u003dself.generate_random_name())"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @atomic.action_timer(\"watcher.delete_audit_template\")"},{"line_number":36,"context_line":"    def _delete_audit_template(self, audit_template):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_6cd23a36","line":33,"in_reply_to":"dada55a8_21aa3986","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e13fc404d42dc1f42e99c8916771d020c88abb8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016: Servionica LLC."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_bc04b217","line":1,"updated":"2016-08-07 15:56:53.000000000","message":"Please remove this line","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"c4cec355325cbcf062a5b049ad7c924b981e1eb8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016: Servionica LLC."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_1bcb2b74","line":1,"in_reply_to":"bacf61ea_bc04b217","updated":"2016-08-08 15:15:08.000000000","message":"Done","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"}],"rally/plugins/openstack/types.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7c2fe4c455ef695141ef5ca7a704a69b2f6420d8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        raise exceptions.InvalidScenarioArgument("},{"line_number":167,"context_line":"            \"Neutron network with name \u0027{name}\u0027 not found\".format("},{"line_number":168,"context_line":"                name\u003dresource_config.get(\"name\")))"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"@plugin.configure(name\u003d\"watcher_strategy\")"},{"line_number":172,"context_line":"class WatcherStrategy(types.ResourceType):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_ec90e244","line":169,"updated":"2016-07-14 22:07:16.000000000","message":"Those changes require unit tests too","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"82352dadacb33a368f451bffa3f2ae7bca6e845c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        raise exceptions.InvalidScenarioArgument("},{"line_number":167,"context_line":"            \"Neutron network with name \u0027{name}\u0027 not found\".format("},{"line_number":168,"context_line":"                name\u003dresource_config.get(\"name\")))"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"@plugin.configure(name\u003d\"watcher_strategy\")"},{"line_number":172,"context_line":"class WatcherStrategy(types.ResourceType):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_0cb56ecf","line":169,"in_reply_to":"1aa78d24_ec90e244","updated":"2016-07-14 22:08:01.000000000","message":"Sorry. My mistake","commit_id":"943e785f2b75d00b6450c71483fc640c7d44bd7f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            watcherclient \u003d clients.watcher()"},{"line_number":186,"context_line":"            resource_id \u003d types._id_from_name("},{"line_number":187,"context_line":"                resource_config\u003dresource_config,"},{"line_number":188,"context_line":"                resources\u003dwatcherclient.strategy.list(),"},{"line_number":189,"context_line":"                typename\u003d\"strategy\","},{"line_number":190,"context_line":"                id_attr\u003d\"uuid\")"},{"line_number":191,"context_line":"        return resource_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_c107dd7f","line":188,"updated":"2016-07-22 11:37:22.000000000","message":"We must pass 0 to the list to be sure that we will not get unexpected error.\nhttps://github.com/openstack/python-watcherclient/blob/bc572e70dc282dec1fb8697009627653a6992451/watcherclient/v1/goal.py#L40","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            watcherclient \u003d clients.watcher()"},{"line_number":186,"context_line":"            resource_id \u003d types._id_from_name("},{"line_number":187,"context_line":"                resource_config\u003dresource_config,"},{"line_number":188,"context_line":"                resources\u003dwatcherclient.strategy.list(),"},{"line_number":189,"context_line":"                typename\u003d\"strategy\","},{"line_number":190,"context_line":"                id_attr\u003d\"uuid\")"},{"line_number":191,"context_line":"        return resource_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_36624fd9","line":188,"in_reply_to":"dada55a8_c107dd7f","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            watcherclient \u003d clients.watcher()"},{"line_number":209,"context_line":"            resource_id \u003d types._id_from_name("},{"line_number":210,"context_line":"                resource_config\u003dresource_config,"},{"line_number":211,"context_line":"                resources\u003dwatcherclient.goal.list(),"},{"line_number":212,"context_line":"                typename\u003d\"goal\","},{"line_number":213,"context_line":"                id_attr\u003d\"uuid\")"},{"line_number":214,"context_line":"        return resource_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_e12941f4","line":211,"updated":"2016-07-22 11:37:22.000000000","message":"We must pass 0 to the list to be sure that we will not get unexpected error","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            watcherclient \u003d clients.watcher()"},{"line_number":209,"context_line":"            resource_id \u003d types._id_from_name("},{"line_number":210,"context_line":"                resource_config\u003dresource_config,"},{"line_number":211,"context_line":"                resources\u003dwatcherclient.goal.list(),"},{"line_number":212,"context_line":"                typename\u003d\"goal\","},{"line_number":213,"context_line":"                id_attr\u003d\"uuid\")"},{"line_number":214,"context_line":"        return resource_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_769a07c7","line":211,"in_reply_to":"dada55a8_e12941f4","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e13fc404d42dc1f42e99c8916771d020c88abb8b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            watcherclient \u003d clients.watcher()"},{"line_number":186,"context_line":"            resource_id \u003d types._id_from_name("},{"line_number":187,"context_line":"                resource_config\u003dresource_config,"},{"line_number":188,"context_line":"                resources\u003dwatcherclient.strategy.list(limit\u003d0),"},{"line_number":189,"context_line":"                typename\u003d\"strategy\","},{"line_number":190,"context_line":"                id_attr\u003d\"uuid\")"},{"line_number":191,"context_line":"        return resource_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_d2bced07","line":188,"updated":"2016-08-07 15:56:53.000000000","message":"as well as in 211","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"c4cec355325cbcf062a5b049ad7c924b981e1eb8","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            watcherclient \u003d clients.watcher()"},{"line_number":186,"context_line":"            resource_id \u003d types._id_from_name("},{"line_number":187,"context_line":"                resource_config\u003dresource_config,"},{"line_number":188,"context_line":"                resources\u003dwatcherclient.strategy.list(limit\u003d0),"},{"line_number":189,"context_line":"                typename\u003d\"strategy\","},{"line_number":190,"context_line":"                id_attr\u003d\"uuid\")"},{"line_number":191,"context_line":"        return resource_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_d0ecd291","line":188,"in_reply_to":"bacf61ea_d2bced07","updated":"2016-08-08 15:15:08.000000000","message":"Done","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e13fc404d42dc1f42e99c8916771d020c88abb8b","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            watcherclient \u003d clients.watcher()"},{"line_number":209,"context_line":"            resource_id \u003d types._id_from_name("},{"line_number":210,"context_line":"                resource_config\u003dresource_config,"},{"line_number":211,"context_line":"                resources\u003dwatcherclient.goal.list(limit\u003d0),"},{"line_number":212,"context_line":"                typename\u003d\"goal\","},{"line_number":213,"context_line":"                id_attr\u003d\"uuid\")"},{"line_number":214,"context_line":"        return resource_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_32cbc9a5","line":211,"updated":"2016-08-07 15:56:53.000000000","message":"Could we get goal directly by name?\nhttps://github.com/openstack/python-watcherclient/blob/7b55f92e11b79369254a9c5c9042f46a9b1b4b50/watcherclient/v1/goal.py#L31","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"c4cec355325cbcf062a5b049ad7c924b981e1eb8","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            watcherclient \u003d clients.watcher()"},{"line_number":209,"context_line":"            resource_id \u003d types._id_from_name("},{"line_number":210,"context_line":"                resource_config\u003dresource_config,"},{"line_number":211,"context_line":"                resources\u003dwatcherclient.goal.list(limit\u003d0),"},{"line_number":212,"context_line":"                typename\u003d\"goal\","},{"line_number":213,"context_line":"                id_attr\u003d\"uuid\")"},{"line_number":214,"context_line":"        return resource_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_f0e756aa","line":211,"in_reply_to":"bacf61ea_32cbc9a5","updated":"2016-08-08 15:15:08.000000000","message":"Done","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"}],"tests/unit/plugins/openstack/scenarios/watcher/test_basic.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        scenario.create_audit_template_and_delete(\"goal\", \"strategy\")"},{"line_number":29,"context_line":"        scenario._create_audit_template.assert_called_once_with(\"goal\","},{"line_number":30,"context_line":"                                                                \"strategy\")"},{"line_number":31,"context_line":"        scenario._delete_audit_template.assert_called_once_with(mock.ANY)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_5cd0f4f7","line":31,"updated":"2016-07-22 11:37:22.000000000","message":"Why mock.Any? Please specify return value of _create_audit_template and check that it called here","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        scenario.create_audit_template_and_delete(\"goal\", \"strategy\")"},{"line_number":29,"context_line":"        scenario._create_audit_template.assert_called_once_with(\"goal\","},{"line_number":30,"context_line":"                                                                \"strategy\")"},{"line_number":31,"context_line":"        scenario._delete_audit_template.assert_called_once_with(mock.ANY)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_0748b75a","line":31,"in_reply_to":"dada55a8_5cd0f4f7","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"}],"tests/unit/plugins/openstack/scenarios/watcher/test_utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        mock_goal \u003d mock.Mock()"},{"line_number":30,"context_line":"        mock_strategy \u003d mock.Mock()"},{"line_number":31,"context_line":"        watcher_scenario \u003d utils.WatcherScenario(self.context)"},{"line_number":32,"context_line":"        watcher_scenario._create_audit_template(mock_goal, mock_strategy)"},{"line_number":33,"context_line":"        self.admin_clients("},{"line_number":34,"context_line":"            \"watcher\").audit_template.create.assert_called_once_with("},{"line_number":35,"context_line":"            goal\u003dmock_goal, strategy\u003dmock_strategy, name\u003dmock.ANY)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_17401707","line":32,"updated":"2016-07-22 11:37:22.000000000","message":"I think we may pass here fake strings and delete two lines(29,30) watcher_scenario._create_audit_template(\"fake_goal\", \"fake_strategy\")","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        mock_goal \u003d mock.Mock()"},{"line_number":30,"context_line":"        mock_strategy \u003d mock.Mock()"},{"line_number":31,"context_line":"        watcher_scenario \u003d utils.WatcherScenario(self.context)"},{"line_number":32,"context_line":"        watcher_scenario._create_audit_template(mock_goal, mock_strategy)"},{"line_number":33,"context_line":"        self.admin_clients("},{"line_number":34,"context_line":"            \"watcher\").audit_template.create.assert_called_once_with("},{"line_number":35,"context_line":"            goal\u003dmock_goal, strategy\u003dmock_strategy, name\u003dmock.ANY)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_077437fb","line":32,"in_reply_to":"dada55a8_17401707","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        watcher_scenario._create_audit_template(mock_goal, mock_strategy)"},{"line_number":33,"context_line":"        self.admin_clients("},{"line_number":34,"context_line":"            \"watcher\").audit_template.create.assert_called_once_with("},{"line_number":35,"context_line":"            goal\u003dmock_goal, strategy\u003dmock_strategy, name\u003dmock.ANY)"},{"line_number":36,"context_line":"        self._test_atomic_action_timer(watcher_scenario.atomic_actions(),"},{"line_number":37,"context_line":"                                       \"watcher.create_audit_template\")"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_fc70c8de","line":35,"updated":"2016-07-22 11:37:22.000000000","message":"Please mock return value of generate_name() and check that it called here","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        watcher_scenario._create_audit_template(mock_goal, mock_strategy)"},{"line_number":33,"context_line":"        self.admin_clients("},{"line_number":34,"context_line":"            \"watcher\").audit_template.create.assert_called_once_with("},{"line_number":35,"context_line":"            goal\u003dmock_goal, strategy\u003dmock_strategy, name\u003dmock.ANY)"},{"line_number":36,"context_line":"        self._test_atomic_action_timer(watcher_scenario.atomic_actions(),"},{"line_number":37,"context_line":"                                       \"watcher.create_audit_template\")"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_675ff375","line":35,"in_reply_to":"dada55a8_fc70c8de","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2d8d181f6724b351a468b81a90795a099a259a61","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_delete_audit_template(self):"},{"line_number":40,"context_line":"        watcher_scenario \u003d utils.WatcherScenario(self.context)"},{"line_number":41,"context_line":"        watcher_scenario._delete_audit_template(self.audit_template)"},{"line_number":42,"context_line":"        self.admin_clients("},{"line_number":43,"context_line":"            \"watcher\").audit_template.delete.assert_called_once_with("},{"line_number":44,"context_line":"            self.audit_template)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_b785cb5a","line":41,"updated":"2016-07-22 11:37:22.000000000","message":"I think we may pass here fake string and delete one line(26th)\nwatcher_scenario._delete_audit_template(\"fake_audit_template\")","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e1bd0913ac0de9ed642c8caa9cbbc340c880da63","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_delete_audit_template(self):"},{"line_number":40,"context_line":"        watcher_scenario \u003d utils.WatcherScenario(self.context)"},{"line_number":41,"context_line":"        watcher_scenario._delete_audit_template(self.audit_template)"},{"line_number":42,"context_line":"        self.admin_clients("},{"line_number":43,"context_line":"            \"watcher\").audit_template.delete.assert_called_once_with("},{"line_number":44,"context_line":"            self.audit_template)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_47646f48","line":41,"in_reply_to":"dada55a8_b785cb5a","updated":"2016-08-03 12:00:57.000000000","message":"Done","commit_id":"bc90c8995d87a4f8c279748c067a39cdf8273167"}],"tests/unit/plugins/openstack/test_types.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e13fc404d42dc1f42e99c8916771d020c88abb8b","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                                                      resource_config)"},{"line_number":346,"context_line":"        self.assertEqual(self.strategy.uuid, strategy_id)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def test_transform_by_name_no_match(self):"},{"line_number":349,"context_line":"        resource_config \u003d {\"name\": \"dummy-1\"}"},{"line_number":350,"context_line":"        self.assertRaises(exceptions.InvalidScenarioArgument,"},{"line_number":351,"context_line":"                          types.WatcherStrategy.transform,"},{"line_number":352,"context_line":"                          self.clients, resource_config)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def test_transform_by_name_match_multiple(self):"},{"line_number":355,"context_line":"        resource_config \u003d {\"name\": \"dummy-2\"}"},{"line_number":356,"context_line":"        self.assertRaises(exceptions.InvalidScenarioArgument,"},{"line_number":357,"context_line":"                          types.WatcherStrategy.transform, self.clients,"},{"line_number":358,"context_line":"                          resource_config)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"class WatcherGoalTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_32274964","line":358,"range":{"start_line":348,"start_character":0,"end_line":358,"end_character":42},"updated":"2016-08-07 15:56:53.000000000","message":"as well as in 389","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e13fc404d42dc1f42e99c8916771d020c88abb8b","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                                                  resource_config)"},{"line_number":377,"context_line":"        self.assertEqual(self.strategy.uuid, strategy_id)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def test_transform_by_name_no_match(self):"},{"line_number":380,"context_line":"        resource_config \u003d {\"name\": \"dummy-1\"}"},{"line_number":381,"context_line":"        self.assertRaises(exceptions.InvalidScenarioArgument,"},{"line_number":382,"context_line":"                          types.WatcherGoal.transform,"},{"line_number":383,"context_line":"                          self.clients, resource_config)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def test_transform_by_name_match_multiple(self):"},{"line_number":386,"context_line":"        resource_config \u003d {\"name\": \"dummy-2\"}"},{"line_number":387,"context_line":"        self.assertRaises(exceptions.InvalidScenarioArgument,"},{"line_number":388,"context_line":"                          types.WatcherGoal.transform, self.clients,"},{"line_number":389,"context_line":"                          resource_config)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_f23011a0","line":389,"range":{"start_line":379,"start_character":4,"end_line":389,"end_character":2},"updated":"2016-08-07 15:56:53.000000000","message":"Lets use here the power of ddt module","commit_id":"4b28ad6fc425a04c0da367d5941fbfcd5d61bb83"}]}
