)]}'
{"etc/rally/rally.conf.sample":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"96a1d54d55ade4df670c3cd805e32427713e36f3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# configuration is set in the configuration file and other logging"},{"line_number":23,"context_line":"# configuration options are ignored (for example,"},{"line_number":24,"context_line":"# logging_context_format_string). (string value)"},{"line_number":25,"context_line":"# Note: This option can be changed without restarting."},{"line_number":26,"context_line":"# Deprecated group/name - [DEFAULT]/log_config"},{"line_number":27,"context_line":"#log_config_append \u003d \u003cNone\u003e"},{"line_number":28,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1aa78d24_245dfa48","line":25,"updated":"2016-07-14 14:25:15.000000000","message":"This is not clear - what does mean \"reatarting\"? Rally does not have daemon mode yet","commit_id":"156708be3e85e6558d6ac1a6b9f119f1cb9faf43"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"7afb121e3683444145ae759d19b08e39d002b40e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# configuration is set in the configuration file and other logging"},{"line_number":23,"context_line":"# configuration options are ignored (for example,"},{"line_number":24,"context_line":"# logging_context_format_string). (string value)"},{"line_number":25,"context_line":"# Note: This option can be changed without restarting."},{"line_number":26,"context_line":"# Deprecated group/name - [DEFAULT]/log_config"},{"line_number":27,"context_line":"#log_config_append \u003d \u003cNone\u003e"},{"line_number":28,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fad55976_80315fef","line":25,"in_reply_to":"1aa78d24_245dfa48","updated":"2016-07-15 18:18:52.000000000","message":"Removed","commit_id":"156708be3e85e6558d6ac1a6b9f119f1cb9faf43"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"96a1d54d55ade4df670c3cd805e32427713e36f3","unresolved":false,"context_lines":[{"line_number":257,"context_line":"#manila_share_delete_poll_interval \u003d 2.0"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# A timeout in seconds for an environment deploy (integer value)"},{"line_number":260,"context_line":"# Deprecated group/name - [benchmark]/deploy_environment_timeout"},{"line_number":261,"context_line":"#murano_deploy_environment_timeout \u003d 1200"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"# Deploy environment check interval in seconds (integer value)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1aa78d24_e7077416","line":260,"updated":"2016-07-14 14:25:15.000000000","message":"How is this change related to the patch?\nIt is better to move unrelated changes to another patch","commit_id":"156708be3e85e6558d6ac1a6b9f119f1cb9faf43"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"7afb121e3683444145ae759d19b08e39d002b40e","unresolved":false,"context_lines":[{"line_number":257,"context_line":"#manila_share_delete_poll_interval \u003d 2.0"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# A timeout in seconds for an environment deploy (integer value)"},{"line_number":260,"context_line":"# Deprecated group/name - [benchmark]/deploy_environment_timeout"},{"line_number":261,"context_line":"#murano_deploy_environment_timeout \u003d 1200"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"# Deploy environment check interval in seconds (integer value)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fad55976_e04c9b78","line":260,"in_reply_to":"1aa78d24_e7077416","updated":"2016-07-15 18:18:52.000000000","message":"ditto","commit_id":"156708be3e85e6558d6ac1a6b9f119f1cb9faf43"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"96a1d54d55ade4df670c3cd805e32427713e36f3","unresolved":false,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"# DEPRECATED: The file name to use with SQLite. (string value)"},{"line_number":540,"context_line":"# Deprecated group/name - [DEFAULT]/sqlite_db"},{"line_number":541,"context_line":"# This option is deprecated for removal."},{"line_number":542,"context_line":"# Its value may be silently ignored in the future."},{"line_number":543,"context_line":"# Reason: Should use config option connection or slave_connection to"},{"line_number":544,"context_line":"# connect the database."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1aa78d24_a799ecd2","line":541,"updated":"2016-07-14 14:25:15.000000000","message":"How is this related to Watcher?","commit_id":"156708be3e85e6558d6ac1a6b9f119f1cb9faf43"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"7afb121e3683444145ae759d19b08e39d002b40e","unresolved":false,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"# DEPRECATED: The file name to use with SQLite. (string value)"},{"line_number":540,"context_line":"# Deprecated group/name - [DEFAULT]/sqlite_db"},{"line_number":541,"context_line":"# This option is deprecated for removal."},{"line_number":542,"context_line":"# Its value may be silently ignored in the future."},{"line_number":543,"context_line":"# Reason: Should use config option connection or slave_connection to"},{"line_number":544,"context_line":"# connect the database."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fad55976_005c4f24","line":541,"in_reply_to":"1aa78d24_a799ecd2","updated":"2016-07-15 18:18:52.000000000","message":"ditto","commit_id":"156708be3e85e6558d6ac1a6b9f119f1cb9faf43"}],"rally-jobs/rally-watcher.yaml":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3755f8f54089b1bd03a8f5d348e0e028ffb663d5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"                name: \"dummy\""},{"line_number":15,"context_line":"            strategy:"},{"line_number":16,"context_line":"                name: \"dummy\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  Watcher.create_audit_template_and_delete:"},{"line_number":19,"context_line":"    -"},{"line_number":20,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_c10fc886","line":17,"updated":"2016-07-14 14:04:37.000000000","message":"SLA is missing\n\n    sla:\n      failure_rate:\n        max: 0","commit_id":"156708be3e85e6558d6ac1a6b9f119f1cb9faf43"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"7afb121e3683444145ae759d19b08e39d002b40e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"                name: \"dummy\""},{"line_number":15,"context_line":"            strategy:"},{"line_number":16,"context_line":"                name: \"dummy\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  Watcher.create_audit_template_and_delete:"},{"line_number":19,"context_line":"    -"},{"line_number":20,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fad55976_a59f555e","line":17,"in_reply_to":"1aa78d24_c10fc886","updated":"2016-07-15 18:18:52.000000000","message":"Done","commit_id":"156708be3e85e6558d6ac1a6b9f119f1cb9faf43"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3755f8f54089b1bd03a8f5d348e0e028ffb663d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1aa78d24_e18124c5","line":53,"updated":"2016-07-14 14:04:37.000000000","message":"Please add SLA here as well","commit_id":"156708be3e85e6558d6ac1a6b9f119f1cb9faf43"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"7afb121e3683444145ae759d19b08e39d002b40e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fad55976_859cd16a","line":53,"in_reply_to":"1aa78d24_e18124c5","updated":"2016-07-15 18:18:52.000000000","message":"Done","commit_id":"156708be3e85e6558d6ac1a6b9f119f1cb9faf43"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"29d5ecc7da53bdbf0d636c099cf5a347e8b9ce18","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        type: \"constant\""},{"line_number":6,"context_line":"        times: 10"},{"line_number":7,"context_line":"        concurrency: 2"},{"line_number":8,"context_line":"      context:"},{"line_number":9,"context_line":"        audit_templates:"},{"line_number":10,"context_line":"          audit_templates_per_admin: 1"},{"line_number":11,"context_line":"          fill_strategy: \"random\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_4a5b0155","line":8,"updated":"2016-08-19 15:31:11.000000000","message":"Please return deleted users context section","commit_id":"10e4d01c2e7dd5fe35aa1e84f94dfdd49b34135c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"29d5ecc7da53bdbf0d636c099cf5a347e8b9ce18","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        concurrency: 2"},{"line_number":8,"context_line":"      context:"},{"line_number":9,"context_line":"        audit_templates:"},{"line_number":10,"context_line":"          audit_templates_per_admin: 1"},{"line_number":11,"context_line":"          fill_strategy: \"random\""},{"line_number":12,"context_line":"          params:"},{"line_number":13,"context_line":"            - goal:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_3ef886e5","line":10,"updated":"2016-08-19 15:31:11.000000000","message":"Also lets use more then 1 audit templates per admin to test how it works with multiple","commit_id":"10e4d01c2e7dd5fe35aa1e84f94dfdd49b34135c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"29d5ecc7da53bdbf0d636c099cf5a347e8b9ce18","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      context:"},{"line_number":9,"context_line":"        audit_templates:"},{"line_number":10,"context_line":"          audit_templates_per_admin: 1"},{"line_number":11,"context_line":"          fill_strategy: \"random\""},{"line_number":12,"context_line":"          params:"},{"line_number":13,"context_line":"            - goal:"},{"line_number":14,"context_line":"                  name: \"dummy\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_deb97230","line":11,"updated":"2016-08-19 15:31:11.000000000","message":"lets change here fill_strategy usage to round_robin. To test it on the gate","commit_id":"10e4d01c2e7dd5fe35aa1e84f94dfdd49b34135c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"29d5ecc7da53bdbf0d636c099cf5a347e8b9ce18","unresolved":false,"context_lines":[{"line_number":36,"context_line":"          max: 0"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  Watcher.list_audit_templates:"},{"line_number":39,"context_line":"    -"},{"line_number":40,"context_line":"      runner:"},{"line_number":41,"context_line":"        type: \"constant\""},{"line_number":42,"context_line":"        times: 10"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_5e09022c","line":39,"updated":"2016-08-19 15:31:11.000000000","message":"as well as 8th line","commit_id":"10e4d01c2e7dd5fe35aa1e84f94dfdd49b34135c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"29d5ecc7da53bdbf0d636c099cf5a347e8b9ce18","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      runner:"},{"line_number":41,"context_line":"        type: \"constant\""},{"line_number":42,"context_line":"        times: 10"},{"line_number":43,"context_line":"        concurrency: 1"},{"line_number":44,"context_line":"      context:"},{"line_number":45,"context_line":"        audit_templates:"},{"line_number":46,"context_line":"          audit_templates_per_admin: 1"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_5e574202","line":43,"updated":"2016-08-19 15:31:11.000000000","message":"increase it to 2","commit_id":"10e4d01c2e7dd5fe35aa1e84f94dfdd49b34135c"}],"rally/plugins/openstack/context/watcher/audit_templates.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"106c99e88303caa99584cd00ed65448278dfc478","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Enter context: `Audit Templates`\"))"},{"line_number":63,"context_line":"    def setup(self):"},{"line_number":64,"context_line":"        watcher_scenario \u003d watcher_utils.WatcherScenario("},{"line_number":65,"context_line":"            {\"admin\": self.context[\"admin\"], \"task\": self.context[\"task\"]})"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        clients \u003d osclients.Clients(self.context[\"admin\"][\"credential\"])"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_3780fbf4","line":65,"updated":"2016-08-11 14:02:42.000000000","message":"this should be initialized in the loop by tenants\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/manila/manila_share_networks.py#L140","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"24e26c4346a497c076a777c635da445b8dcd5a4b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Enter context: `Audit Templates`\"))"},{"line_number":63,"context_line":"    def setup(self):"},{"line_number":64,"context_line":"        watcher_scenario \u003d watcher_utils.WatcherScenario("},{"line_number":65,"context_line":"            {\"admin\": self.context[\"admin\"], \"task\": self.context[\"task\"]})"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        clients \u003d osclients.Clients(self.context[\"admin\"][\"credential\"])"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_97e602e6","line":65,"in_reply_to":"9ad45d7e_3780fbf4","updated":"2016-08-11 14:50:32.000000000","message":"Audit Template isn\u0027t tenant resource, only the admin can see audit templates","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"106c99e88303caa99584cd00ed65448278dfc478","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        clients \u003d osclients.Clients(self.context[\"admin\"][\"credential\"])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.context[\"audit_templates\"] \u003d []"},{"line_number":70,"context_line":"        for template in self.config:"},{"line_number":71,"context_line":"            goal \u003d template[\"goal\"]"},{"line_number":72,"context_line":"            strategy \u003d template[\"strategy\"]"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_d7dfdf37","line":70,"updated":"2016-08-11 14:02:42.000000000","message":"You should iterate through tenants\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/glance/images.py#L88\nAlso I don\u0027t think that this is scale approach. You are going to write by hand config for each audit_template. But this is wrong. What if I want to create 100,1000,1000000 audit templates?)","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"4eab7729d2425ce67a6288d742dbd320f63415e9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        clients \u003d osclients.Clients(self.context[\"admin\"][\"credential\"])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.context[\"audit_templates\"] \u003d []"},{"line_number":70,"context_line":"        for template in self.config:"},{"line_number":71,"context_line":"            goal \u003d template[\"goal\"]"},{"line_number":72,"context_line":"            strategy \u003d template[\"strategy\"]"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_2936a4e7","line":70,"in_reply_to":"9ad45d7e_d7dfdf37","updated":"2016-08-12 12:16:56.000000000","message":"As we have discussed this context here http://eavesdrop.openstack.org/irclogs/%23openstack-rally/%23openstack-rally.2016-08-11.log.html#t2016-08-11T14:50:41 we can create 2 and more audit templates with the same goal and strategy.","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"106c99e88303caa99584cd00ed65448278dfc478","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            audit_template \u003d watcher_scenario._create_audit_template("},{"line_number":80,"context_line":"                goal_id, strategy_id)"},{"line_number":81,"context_line":"            self.context[\"audit_templates\"].append(audit_template.uuid)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Exit context: `Audit Templates`\"))"},{"line_number":84,"context_line":"    def cleanup(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_57676fb6","line":81,"updated":"2016-08-11 14:02:42.000000000","message":"As this is tenant resource then you should add it into\nself.context[tenant][tenant_id][aud..]","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"4eab7729d2425ce67a6288d742dbd320f63415e9","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            audit_template \u003d watcher_scenario._create_audit_template("},{"line_number":80,"context_line":"                goal_id, strategy_id)"},{"line_number":81,"context_line":"            self.context[\"audit_templates\"].append(audit_template.uuid)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Exit context: `Audit Templates`\"))"},{"line_number":84,"context_line":"    def cleanup(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_69309ce9","line":81,"in_reply_to":"9ad45d7e_57676fb6","updated":"2016-08-12 12:16:56.000000000","message":"ditto","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bc9356f7309d9a4dcf4cab55eec40ca68cd35da6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Enter context: `Audit Templates`\"))"},{"line_number":66,"context_line":"    def setup(self):"},{"line_number":67,"context_line":"        watcher_scenario \u003d watcher_utils.WatcherScenario("},{"line_number":68,"context_line":"            {\"admin\": self.context[\"admin\"], \"task\": self.context[\"task\"]})"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        clients \u003d osclients.Clients(self.context[\"admin\"][\"credential\"])"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_f486cbd9","line":68,"updated":"2016-08-16 12:23:14.000000000","message":"Also you forgot to pass api_context section. Link to the example see in patchset #8","commit_id":"b8d5499999310db8fdc98dff6ed494b431df73e4"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"16cd191ad8e32a2f64de8877ec60a94b8449a64b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Enter context: `Audit Templates`\"))"},{"line_number":66,"context_line":"    def setup(self):"},{"line_number":67,"context_line":"        watcher_scenario \u003d watcher_utils.WatcherScenario("},{"line_number":68,"context_line":"            {\"admin\": self.context[\"admin\"], \"task\": self.context[\"task\"]})"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        clients \u003d osclients.Clients(self.context[\"admin\"][\"credential\"])"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_03269314","line":68,"in_reply_to":"3ac371cc_f486cbd9","updated":"2016-08-18 08:19:53.000000000","message":"Done","commit_id":"b8d5499999310db8fdc98dff6ed494b431df73e4"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bc9356f7309d9a4dcf4cab55eec40ca68cd35da6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        clients \u003d osclients.Clients(self.context[\"admin\"][\"credential\"])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.context[\"audit_templates\"] \u003d []"},{"line_number":73,"context_line":"        for template in self.config:"},{"line_number":74,"context_line":"            goal \u003d template[\"goal\"]"},{"line_number":75,"context_line":"            strategy \u003d template[\"strategy\"]"},{"line_number":76,"context_line":"            extra \u003d template.get(\"extra\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_74165bf2","line":73,"updated":"2016-08-16 12:23:14.000000000","message":"Okey. We have talked in irc chat that this is bad approach. That we could create multiple audit templates with the same goal and strategy(and its could be needed to create 1000 audit templates by context) thus we should create self.config[\"audit_templates\"] times audit template only with different names. Methought that we\u0027ve agreed... But now I saw the same approach. Could you comment?","commit_id":"b8d5499999310db8fdc98dff6ed494b431df73e4"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"16cd191ad8e32a2f64de8877ec60a94b8449a64b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        clients \u003d osclients.Clients(self.context[\"admin\"][\"credential\"])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.context[\"audit_templates\"] \u003d []"},{"line_number":73,"context_line":"        for template in self.config:"},{"line_number":74,"context_line":"            goal \u003d template[\"goal\"]"},{"line_number":75,"context_line":"            strategy \u003d template[\"strategy\"]"},{"line_number":76,"context_line":"            extra \u003d template.get(\"extra\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_4d455cb1","line":73,"in_reply_to":"3ac371cc_74165bf2","updated":"2016-08-18 08:19:53.000000000","message":"My mistake. I\u0027ve added iteration by audit_templates_per_admin field.","commit_id":"b8d5499999310db8fdc98dff6ed494b431df73e4"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"64296bafb6683a0ca5d755247ebd12630ac3b250","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    \"extra\": {"},{"line_number":62,"context_line":"                        \"type\": \"object\""},{"line_number":63,"context_line":"                    },"},{"line_number":64,"context_line":"                    \"audit_templates_per_admin\": {"},{"line_number":65,"context_line":"                        \"type\": \"integer\","},{"line_number":66,"context_line":"                        \"minimum\": 1"},{"line_number":67,"context_line":"                    }"},{"line_number":68,"context_line":"                },"},{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_a670260c","line":67,"range":{"start_line":64,"start_character":20,"end_line":67,"end_character":21},"updated":"2016-08-18 10:54:58.000000000","message":"This should be removed. You\u0027ve already use this parameter one level higher(and its normal)","commit_id":"8558084a90151e28491d230c8fb51e2a4e47494b"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"da2ccf64cdd3c2bbe1794e0773041642db35f8a1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    \"extra\": {"},{"line_number":62,"context_line":"                        \"type\": \"object\""},{"line_number":63,"context_line":"                    },"},{"line_number":64,"context_line":"                    \"audit_templates_per_admin\": {"},{"line_number":65,"context_line":"                        \"type\": \"integer\","},{"line_number":66,"context_line":"                        \"minimum\": 1"},{"line_number":67,"context_line":"                    }"},{"line_number":68,"context_line":"                },"},{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_a9447949","line":67,"range":{"start_line":64,"start_character":20,"end_line":67,"end_character":21},"in_reply_to":"3ac371cc_a670260c","updated":"2016-08-18 11:02:11.000000000","message":"Done","commit_id":"8558084a90151e28491d230c8fb51e2a4e47494b"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"64296bafb6683a0ca5d755247ebd12630ac3b250","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                },"},{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"        },"},{"line_number":71,"context_line":"        \"additionalProperties\": True,"},{"line_number":72,"context_line":"        \"required\": [\"params\"]"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_c6f6025c","line":71,"updated":"2016-08-18 10:54:58.000000000","message":"Why its true? It should be false. We don\u0027t use additional parameters somehow","commit_id":"8558084a90151e28491d230c8fb51e2a4e47494b"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"da2ccf64cdd3c2bbe1794e0773041642db35f8a1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                },"},{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"        },"},{"line_number":71,"context_line":"        \"additionalProperties\": True,"},{"line_number":72,"context_line":"        \"required\": [\"params\"]"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_49598534","line":71,"in_reply_to":"3ac371cc_c6f6025c","updated":"2016-08-18 11:02:11.000000000","message":"If it is false then I have this error: Additional properties are not allowed (\u0027audit_templates_per_admin\u0027, \u0027fill_strategy\u0027, \u0027params\u0027 were unexpected)","commit_id":"8558084a90151e28491d230c8fb51e2a4e47494b"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"64296bafb6683a0ca5d755247ebd12630ac3b250","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        clients \u003d osclients.Clients(self.context[\"admin\"][\"credential\"])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.context[\"audit_templates\"] \u003d []"},{"line_number":92,"context_line":"        for i in range(self.config[\"audit_templates_per_admin\"]):"},{"line_number":93,"context_line":"            cfg_size \u003d len(self.config)"},{"line_number":94,"context_line":"            if self.config[\"fill_strategy\"] \u003d\u003d \"round_robin\":"},{"line_number":95,"context_line":"                audit_params \u003d self.config[\"params\"][i % cfg_size]"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_c6d562e5","line":92,"updated":"2016-08-18 10:54:58.000000000","message":"please use six.moves.range. I told this previously\u003d)","commit_id":"8558084a90151e28491d230c8fb51e2a4e47494b"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"da2ccf64cdd3c2bbe1794e0773041642db35f8a1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        clients \u003d osclients.Clients(self.context[\"admin\"][\"credential\"])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.context[\"audit_templates\"] \u003d []"},{"line_number":92,"context_line":"        for i in range(self.config[\"audit_templates_per_admin\"]):"},{"line_number":93,"context_line":"            cfg_size \u003d len(self.config)"},{"line_number":94,"context_line":"            if self.config[\"fill_strategy\"] \u003d\u003d \"round_robin\":"},{"line_number":95,"context_line":"                audit_params \u003d self.config[\"params\"][i % cfg_size]"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_e94af153","line":92,"in_reply_to":"3ac371cc_c6d562e5","updated":"2016-08-18 11:02:11.000000000","message":"Done","commit_id":"8558084a90151e28491d230c8fb51e2a4e47494b"}],"rally/plugins/openstack/scenarios/watcher/basic.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"106c99e88303caa99584cd00ed65448278dfc478","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        audit_template_uuid \u003d self.context[\"audit_templates\"][0]"},{"line_number":69,"context_line":"        audit \u003d self._create_audit(audit_template_uuid)"},{"line_number":70,"context_line":"        self._launch_audit(audit)"},{"line_number":71,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":72,"context_line":"        self._delete_audit(audit)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_32d5a9e7","line":71,"updated":"2016-08-11 14:02:42.000000000","message":"Don\u0027t use hand written sleep for waiting of resource creation. We have https://github.com/openstack/rally/blob/master/rally/task/utils.py#L175 for that purpose","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"4eab7729d2425ce67a6288d742dbd320f63415e9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        audit_template_uuid \u003d self.context[\"audit_templates\"][0]"},{"line_number":69,"context_line":"        audit \u003d self._create_audit(audit_template_uuid)"},{"line_number":70,"context_line":"        self._launch_audit(audit)"},{"line_number":71,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":72,"context_line":"        self._delete_audit(audit)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_bb03ffbd","line":71,"in_reply_to":"9ad45d7e_32d5a9e7","updated":"2016-08-12 12:16:56.000000000","message":"wait_for_status is used in _launch_audit method already. sleep_between will be removed.","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"eb9793fb07f0469d1024c118affdd34c74432574","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        audit_template_uuid \u003d self.context[\"audit_templates\"][0]"},{"line_number":83,"context_line":"        audit \u003d self._create_audit(audit_template_uuid)"},{"line_number":84,"context_line":"        self._launch_audit(audit)"},{"line_number":85,"context_line":"        self._delete_audit(audit)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_07c8da73","line":84,"updated":"2016-08-24 19:47:08.000000000","message":"and this line should be deleted","commit_id":"691defe5ee1f03d402bbc3d2af34e1a49bb44571"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"3783b62aebc7ecb60d09fa643201339f7e8ada6d","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        audit_template_uuid \u003d self.context[\"audit_templates\"][0]"},{"line_number":83,"context_line":"        audit \u003d self._create_audit(audit_template_uuid)"},{"line_number":84,"context_line":"        self._launch_audit(audit)"},{"line_number":85,"context_line":"        self._delete_audit(audit)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_1cf145ce","line":84,"in_reply_to":"1ac06dbe_07c8da73","updated":"2016-08-24 21:25:39.000000000","message":"Done","commit_id":"691defe5ee1f03d402bbc3d2af34e1a49bb44571"}],"rally/plugins/openstack/scenarios/watcher/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"106c99e88303caa99584cd00ed65448278dfc478","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @atomic.action_timer(\"watcher.list_audit_templates\")"},{"line_number":60,"context_line":"    def _list_audit_templates(self):"},{"line_number":61,"context_line":"        return self.admin_clients(\"watcher\").audit_template.list()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @atomic.action_timer(\"watcher.create_audit\")"},{"line_number":64,"context_line":"    def _create_audit(self, audit_template_uuid):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_322ac9db","line":61,"updated":"2016-08-11 14:02:42.000000000","message":"https://github.com/openstack/python-watcherclient/blob/master/watcherclient/v1/audit_template.py#L37 here is more parameters please pass all of them.","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"4eab7729d2425ce67a6288d742dbd320f63415e9","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @atomic.action_timer(\"watcher.list_audit_templates\")"},{"line_number":60,"context_line":"    def _list_audit_templates(self):"},{"line_number":61,"context_line":"        return self.admin_clients(\"watcher\").audit_template.list()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @atomic.action_timer(\"watcher.create_audit\")"},{"line_number":64,"context_line":"    def _create_audit(self, audit_template_uuid):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_c69ff763","line":61,"in_reply_to":"9ad45d7e_322ac9db","updated":"2016-08-12 12:16:56.000000000","message":"Done","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"106c99e88303caa99584cd00ed65448278dfc478","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @atomic.action_timer(\"watcher.delete_audit\")"},{"line_number":83,"context_line":"    def _delete_audit(self, audit):"},{"line_number":84,"context_line":"        self.admin_clients(\"watcher\").audit.delete(audit.uuid)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_f259518f","line":84,"updated":"2016-08-11 14:02:42.000000000","message":"Do we need to wait it too?","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"24e26c4346a497c076a777c635da445b8dcd5a4b","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @atomic.action_timer(\"watcher.delete_audit\")"},{"line_number":83,"context_line":"    def _delete_audit(self, audit):"},{"line_number":84,"context_line":"        self.admin_clients(\"watcher\").audit.delete(audit.uuid)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_f1e14e2b","line":84,"in_reply_to":"9ad45d7e_f259518f","updated":"2016-08-11 14:50:32.000000000","message":"Done","commit_id":"256692217e41d3226efdc59a515b5f45dd6b2d45"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bc9356f7309d9a4dcf4cab55eec40ca68cd35da6","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @atomic.action_timer(\"watcher.delete_audit\")"},{"line_number":87,"context_line":"    def _delete_audit(self, audit):"},{"line_number":88,"context_line":"        self.admin_clients(\"watcher\").audit.delete(audit.uuid)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_540d1f3d","line":88,"updated":"2016-08-16 12:23:14.000000000","message":"Roman Vasilets\nDo we need to wait it too?\nAug 11 5:02 PM\nAlexander Chadin\nAug 11 5:50 PM\nDone\nSo what is the answer?) I guess this means no","commit_id":"b8d5499999310db8fdc98dff6ed494b431df73e4"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"16cd191ad8e32a2f64de8877ec60a94b8449a64b","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @atomic.action_timer(\"watcher.delete_audit\")"},{"line_number":87,"context_line":"    def _delete_audit(self, audit):"},{"line_number":88,"context_line":"        self.admin_clients(\"watcher\").audit.delete(audit.uuid)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_bd984179","line":88,"in_reply_to":"3ac371cc_540d1f3d","updated":"2016-08-18 08:19:53.000000000","message":"We\u0027ve decided to leave it as is","commit_id":"b8d5499999310db8fdc98dff6ed494b431df73e4"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"eb9793fb07f0469d1024c118affdd34c74432574","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            audit_type\u003d\"ONESHOT\")"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @atomic.action_timer(\"watcher.launch_audit\")"},{"line_number":74,"context_line":"    def _launch_audit(self, audit):"},{"line_number":75,"context_line":"        utils.wait_for_status("},{"line_number":76,"context_line":"            audit,"},{"line_number":77,"context_line":"            ready_statuses\u003d[\"SUCCEEDED\"],"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_47b932ec","line":74,"updated":"2016-08-24 19:47:08.000000000","message":"Sorry that I\u0027ve noticed that late but every our atomic should be finished call to api of watcher. In our example wait for lauch audit should be in _create_audit code should be look like:\nhttp://paste.openstack.org/show/563122/","commit_id":"691defe5ee1f03d402bbc3d2af34e1a49bb44571"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"3783b62aebc7ecb60d09fa643201339f7e8ada6d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            audit_type\u003d\"ONESHOT\")"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @atomic.action_timer(\"watcher.launch_audit\")"},{"line_number":74,"context_line":"    def _launch_audit(self, audit):"},{"line_number":75,"context_line":"        utils.wait_for_status("},{"line_number":76,"context_line":"            audit,"},{"line_number":77,"context_line":"            ready_statuses\u003d[\"SUCCEEDED\"],"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_3cbec1d4","line":74,"in_reply_to":"1ac06dbe_47b932ec","updated":"2016-08-24 21:25:39.000000000","message":"Done","commit_id":"691defe5ee1f03d402bbc3d2af34e1a49bb44571"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b95470841374982ac541393a9e4343422c2f070f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            audit_type\u003d\"ONESHOT\")"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @atomic.action_timer(\"watcher.launch_audit\")"},{"line_number":74,"context_line":"    def _launch_audit(self, audit):"},{"line_number":75,"context_line":"        utils.wait_for_status("},{"line_number":76,"context_line":"            audit,"},{"line_number":77,"context_line":"            ready_statuses\u003d[\"SUCCEEDED\"],"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_a7690628","line":74,"in_reply_to":"1ac06dbe_47b932ec","updated":"2016-08-24 19:52:37.000000000","message":"there was a bug. This is the right one http://paste.openstack.org/show/563125/","commit_id":"691defe5ee1f03d402bbc3d2af34e1a49bb44571"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"3783b62aebc7ecb60d09fa643201339f7e8ada6d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            audit_type\u003d\"ONESHOT\")"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @atomic.action_timer(\"watcher.launch_audit\")"},{"line_number":74,"context_line":"    def _launch_audit(self, audit):"},{"line_number":75,"context_line":"        utils.wait_for_status("},{"line_number":76,"context_line":"            audit,"},{"line_number":77,"context_line":"            ready_statuses\u003d[\"SUCCEEDED\"],"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_7cb839e6","line":74,"in_reply_to":"1ac06dbe_a7690628","updated":"2016-08-24 21:25:39.000000000","message":"Done","commit_id":"691defe5ee1f03d402bbc3d2af34e1a49bb44571"}],"tests/ci/osresources.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"106c99e88303caa99584cd00ed65448278dfc478","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    def list_goals(self):"},{"line_number":222,"context_line":"        return self.client.goal.list()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def list_action_plans(self):"},{"line_number":225,"context_line":"        return self.client.action_plan.list()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def list_actions(self):"},{"line_number":228,"context_line":"        return self.client.action.list()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"class CloudResources(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_124a2526","side":"PARENT","line":228,"range":{"start_line":224,"start_character":7,"end_line":228,"end_character":38},"updated":"2016-08-11 14:02:42.000000000","message":"Why did you delete those methods?","commit_id":"7d640d2312d1a06e3292f52257c40c0a65873ce1"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"4eab7729d2425ce67a6288d742dbd320f63415e9","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    def list_goals(self):"},{"line_number":222,"context_line":"        return self.client.goal.list()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def list_action_plans(self):"},{"line_number":225,"context_line":"        return self.client.action_plan.list()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def list_actions(self):"},{"line_number":228,"context_line":"        return self.client.action.list()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"class CloudResources(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_ff5b9af4","side":"PARENT","line":228,"range":{"start_line":224,"start_character":7,"end_line":228,"end_character":38},"in_reply_to":"9ad45d7e_124a2526","updated":"2016-08-12 12:16:56.000000000","message":"There were some problems with these methods, now everything is ok.","commit_id":"7d640d2312d1a06e3292f52257c40c0a65873ce1"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bc9356f7309d9a4dcf4cab55eec40ca68cd35da6","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    def list_goals(self):"},{"line_number":222,"context_line":"        return self.client.goal.list()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def list_strategies(self):"},{"line_number":225,"context_line":"        return self.client.strategy.list()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def list_action_plans(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_afca4018","line":224,"updated":"2016-08-16 12:23:14.000000000","message":"http://logs.openstack.org/04/341604/10/experimental/gate-rally-dsvm-watcher-rally/fb3926b/console.html#_2016-08-16_08_34_12_877118\n\nLooks like attribute that was inherited from ResourceManager should be overriden. See line 34. I guess that id should be changed to uuid and you could remove redundant and add possible keys","commit_id":"b8d5499999310db8fdc98dff6ed494b431df73e4"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"16cd191ad8e32a2f64de8877ec60a94b8449a64b","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    def list_goals(self):"},{"line_number":222,"context_line":"        return self.client.goal.list()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def list_strategies(self):"},{"line_number":225,"context_line":"        return self.client.strategy.list()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def list_action_plans(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_3d8bb120","line":224,"in_reply_to":"3ac371cc_afca4018","updated":"2016-08-18 08:19:53.000000000","message":"Done","commit_id":"b8d5499999310db8fdc98dff6ed494b431df73e4"}]}
