)]}'
{"rally/api.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"53f3868ae49ccf2a46f246cbdf1c682da54fe780","unresolved":false,"context_lines":[{"line_number":371,"context_line":"class Verification(object):"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    @staticmethod"},{"line_number":374,"context_line":"    def _check_tempest_tree_existence(verifier):"},{"line_number":375,"context_line":"        if not os.path.exists(verifier.path()):"},{"line_number":376,"context_line":"            msg \u003d _(\"Tempest tree for \""},{"line_number":377,"context_line":"                    \"deployment \u0027%s\u0027 not found! \") % verifier.deployment"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_d28e3f26","line":374,"updated":"2016-07-25 13:54:26.000000000","message":"If I\u0027m not wrong this is called after each tempest.Tempest() why its not inside?","commit_id":"9111cc8974edc0cc457e1f1cc6754b7a766a8be0"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"53f3868ae49ccf2a46f246cbdf1c682da54fe780","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        deployment_uuid \u003d objects.Deployment.get(deployment)[\"uuid\"]"},{"line_number":520,"context_line":"        verifier \u003d tempest.Tempest(deployment_uuid, system_wide\u003dsystem_wide)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        cls._check_tempest_tree_existence(verifier)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        return verifier.list_plugins()"},{"line_number":525,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_570c0142","line":522,"updated":"2016-07-25 13:54:26.000000000","message":"Those three lines duplicated at 533, 550, 564 and partly at 501 line. Also lines 519-520 used numerous of times here. Lets use power of functions here)\nFor example create get_verifier()","commit_id":"9111cc8974edc0cc457e1f1cc6754b7a766a8be0"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"4da83260d97c79100161826d093096dfa0c352ed","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        deployment_uuid \u003d objects.Deployment.get(deployment)[\"uuid\"]"},{"line_number":520,"context_line":"        verifier \u003d tempest.Tempest(deployment_uuid, system_wide\u003dsystem_wide)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        cls._check_tempest_tree_existence(verifier)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        return verifier.list_plugins()"},{"line_number":525,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_ed59e15c","line":522,"in_reply_to":"dada55a8_570c0142","updated":"2016-07-25 14:25:18.000000000","message":"I would prefer to do it in another patch.","commit_id":"9111cc8974edc0cc457e1f1cc6754b7a766a8be0"}],"rally/cli/commands/verify.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"53f3868ae49ccf2a46f246cbdf1c682da54fe780","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                        \"not in Tempest virtual env\","},{"line_number":503,"context_line":"                   required\u003dFalse, action\u003d\"store_true\")"},{"line_number":504,"context_line":"    @envutils.with_default_deployment(cli_arg_name\u003d\"deployment\")"},{"line_number":505,"context_line":"    def listplugins(self, deployment\u003dNone, system_wide\u003dFalse):"},{"line_number":506,"context_line":"        \"\"\"List all installed Tempest plugins."},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        :param deployment: UUID or name of a deployment"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_724953b7","line":505,"updated":"2016-07-25 13:54:26.000000000","message":"Lets call it list_plugins now without futher deprecation listplugin in favor list_plugins","commit_id":"9111cc8974edc0cc457e1f1cc6754b7a766a8be0"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"53f3868ae49ccf2a46f246cbdf1c682da54fe780","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        :param system_wide: List all plugins installed in the local env or"},{"line_number":510,"context_line":"                            in Tempest virtual env"},{"line_number":511,"context_line":"        \"\"\""},{"line_number":512,"context_line":"        print(api.Verification.list_tempest_plugins(deployment, system_wide))"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    @cliutils.args(\"--deployment\", dest\u003d\"deployment\", type\u003dstr, required\u003dFalse,"},{"line_number":515,"context_line":"                   metavar\u003d\"\u003cuuid\u003e\", help\u003d\"UUID or name of a deployment\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_b2df4b0b","line":512,"updated":"2016-07-25 13:54:26.000000000","message":"Please use i18n","commit_id":"9111cc8974edc0cc457e1f1cc6754b7a766a8be0"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"4da83260d97c79100161826d093096dfa0c352ed","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        :param system_wide: List all plugins installed in the local env or"},{"line_number":510,"context_line":"                            in Tempest virtual env"},{"line_number":511,"context_line":"        \"\"\""},{"line_number":512,"context_line":"        print(api.Verification.list_tempest_plugins(deployment, system_wide))"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    @cliutils.args(\"--deployment\", dest\u003d\"deployment\", type\u003dstr, required\u003dFalse,"},{"line_number":515,"context_line":"                   metavar\u003d\"\u003cuuid\u003e\", help\u003d\"UUID or name of a deployment\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_edaba11c","line":512,"in_reply_to":"dada55a8_b2df4b0b","updated":"2016-07-25 14:25:18.000000000","message":"It looks like we don\u0027t need to use i18n here because the output is a table like this:\n\n\n+----------------------------+--------------------------------------------+\n|            Name            |                 EntryPoint                 |\n+----------------------------+--------------------------------------------+\n| hello-world-tempest-plugin | hello_world_tempest_plugin.plugin:MyPlugin |\n+----------------------------+--------------------------------------------+","commit_id":"9111cc8974edc0cc457e1f1cc6754b7a766a8be0"}]}
