)]}'
{"rally-jobs/rally.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":405,"context_line":"          min_iterations: 10"},{"line_number":406,"context_line":"          sigmas: 10"},{"line_number":407,"context_line":"        performance_degradation:"},{"line_number":408,"context_line":"          max_degradation: 50"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    -"},{"line_number":411,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dada55a8_c60338b7","line":408,"updated":"2016-07-24 22:18:48.000000000","message":"This test only that plugin don\u0027t raise and errors during the execution. But we also should check that it works as intended.\nPlease add functional test https://github.com/openstack/rally/blob/master/tests/functional/test_cli_task.py#L858 to see that this plugin stop scenario execution as it should","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":405,"context_line":"          min_iterations: 10"},{"line_number":406,"context_line":"          sigmas: 10"},{"line_number":407,"context_line":"        performance_degradation:"},{"line_number":408,"context_line":"          max_degradation: 50"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    -"},{"line_number":411,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dada55a8_c7e48ce1","line":408,"in_reply_to":"dada55a8_c60338b7","updated":"2016-07-26 11:55:24.000000000","message":"Done","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"3e34bf7aa2923c5012f888857f695656936b789b","unresolved":false,"context_lines":[{"line_number":405,"context_line":"          min_iterations: 10"},{"line_number":406,"context_line":"          sigmas: 10"},{"line_number":407,"context_line":"        performance_degradation:"},{"line_number":408,"context_line":"          max_degradation: 50"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    -"},{"line_number":411,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_c897968e","line":408,"updated":"2016-07-29 13:24:03.000000000","message":"what is the metric of \"degradation\" we use here? What \"50\" means?\n\nIt is better to use more descriptive names for the parameter,  for example, add \"_percents\"","commit_id":"4837a8b5edcbe6d609d48813c18429217363a4fe"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"8e2e33b556bdd73622f348fe987b84320f41fb65","unresolved":false,"context_lines":[{"line_number":405,"context_line":"          min_iterations: 10"},{"line_number":406,"context_line":"          sigmas: 10"},{"line_number":407,"context_line":"        performance_degradation:"},{"line_number":408,"context_line":"          max_degradation: 50"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    -"},{"line_number":411,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_9e22f4ff","line":408,"in_reply_to":"bacf61ea_c897968e","updated":"2016-07-29 14:01:03.000000000","message":"Ok, we decided to save this naming scheme (the same as in spec)... Let\u0027s merge it as is.","commit_id":"4837a8b5edcbe6d609d48813c18429217363a4fe"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"15b42d96ae0fed277715bbf9622706748f1487e3","unresolved":false,"context_lines":[{"line_number":406,"context_line":"          sigmas: 10"},{"line_number":407,"context_line":"        performance_degradation:"},{"line_number":408,"context_line":"          max_degradation: 50"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    -"},{"line_number":411,"context_line":"      args:"},{"line_number":412,"context_line":"        sleep: 0.25"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_c785ffad","line":409,"updated":"2016-08-03 11:58:42.000000000","message":"It worth to note that this change tests Dummy.dummy scenario but not PD SLA itself! In other words, we do not sure that this SLA will actually fire if degradation is \u003e50%.\n\nI think that it functional test (tests/functional/test_cli_task.py) should be added to this patch as well","commit_id":"4837a8b5edcbe6d609d48813c18429217363a4fe"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a0166506812f0de794c23c117de42a238f4e856a","unresolved":false,"context_lines":[{"line_number":406,"context_line":"          sigmas: 10"},{"line_number":407,"context_line":"        performance_degradation:"},{"line_number":408,"context_line":"          max_degradation: 50"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    -"},{"line_number":411,"context_line":"      args:"},{"line_number":412,"context_line":"        sleep: 0.25"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_ee6f1efa","line":409,"in_reply_to":"bacf61ea_3d720ee4","updated":"2016-08-03 22:49:59.000000000","message":"You are right! Thank you","commit_id":"4837a8b5edcbe6d609d48813c18429217363a4fe"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"288bb5f6a675c483a566ef967f4193332501010d","unresolved":false,"context_lines":[{"line_number":406,"context_line":"          sigmas: 10"},{"line_number":407,"context_line":"        performance_degradation:"},{"line_number":408,"context_line":"          max_degradation: 50"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    -"},{"line_number":411,"context_line":"      args:"},{"line_number":412,"context_line":"        sleep: 0.25"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_3d720ee4","line":409,"in_reply_to":"bacf61ea_c785ffad","updated":"2016-08-03 21:14:01.000000000","message":"Already there - https://review.openstack.org/#/c/344982/3/tests/functional/test_cli_task.py","commit_id":"4837a8b5edcbe6d609d48813c18429217363a4fe"}],"rally/common/streaming_algorithms.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"15b42d96ae0fed277715bbf9622706748f1487e3","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        return self._count"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"class DegradationComputation(StreamingAlgorithm):"},{"line_number":212,"context_line":"    \"\"\"Calculates degradation from a stream of numbers"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    Finds min and max values from a stream and then calculates"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_47cbcf1e","line":211,"updated":"2016-08-03 11:58:42.000000000","message":"It would be better to propose this class in separate patch","commit_id":"4837a8b5edcbe6d609d48813c18429217363a4fe"}],"rally/plugins/common/sla/performance_degradation.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from rally.task import sla"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class DegradationCalculation(object):"},{"line_number":31,"context_line":"    def __init__(self):"},{"line_number":32,"context_line":"        self.min_duration \u003d streaming_algorithms.MinComputation()"},{"line_number":33,"context_line":"        self.max_duration \u003d streaming_algorithms.MaxComputation()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c6be98fe","line":30,"updated":"2016-07-24 22:18:48.000000000","message":"This class should be in file with streaming algorithms","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from rally.task import sla"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class DegradationCalculation(object):"},{"line_number":31,"context_line":"    def __init__(self):"},{"line_number":32,"context_line":"        self.min_duration \u003d streaming_algorithms.MinComputation()"},{"line_number":33,"context_line":"        self.max_duration \u003d streaming_algorithms.MaxComputation()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_dc5db6ed","line":30,"in_reply_to":"dada55a8_c6be98fe","updated":"2016-07-26 11:55:24.000000000","message":"Done","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        max_result \u003d self.max_duration.result()"},{"line_number":50,"context_line":"        if min_result is None or max_result is None:"},{"line_number":51,"context_line":"            return 0.0"},{"line_number":52,"context_line":"        return (max_result / min_result - 1) * 100.0"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@sla.configure(name\u003d\"performance_degradation\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_0e849d08","line":52,"updated":"2016-07-24 22:18:48.000000000","message":"here could be division by zero","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        max_result \u003d self.max_duration.result()"},{"line_number":50,"context_line":"        if min_result is None or max_result is None:"},{"line_number":51,"context_line":"            return 0.0"},{"line_number":52,"context_line":"        return (max_result / min_result - 1) * 100.0"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@sla.configure(name\u003d\"performance_degradation\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_dc0496c7","line":52,"in_reply_to":"dada55a8_0e849d08","updated":"2016-07-26 11:55:24.000000000","message":"Protected with raising error on addition of zero value","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return (max_result / min_result - 1) * 100.0"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@sla.configure(name\u003d\"performance_degradation\")"},{"line_number":56,"context_line":"class PerformanceDegradation(sla.SLA):"},{"line_number":57,"context_line":"    \"\"\"Calculates perfomance degradation based on iteration time"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_060550c1","line":55,"updated":"2016-07-24 22:18:48.000000000","message":"We could give more informative name for plugin max_perf_degradation","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return (max_result / min_result - 1) * 100.0"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@sla.configure(name\u003d\"performance_degradation\")"},{"line_number":56,"context_line":"class PerformanceDegradation(sla.SLA):"},{"line_number":57,"context_line":"    \"\"\"Calculates perfomance degradation based on iteration time"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_dfead573","line":55,"in_reply_to":"dada55a8_060550c1","updated":"2016-07-26 11:55:24.000000000","message":"Spec requires to use this name\nhttps://github.com/openstack/rally/blob/master/doc/specs/in-progress/sla_pd_plugin.rst","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@sla.configure(name\u003d\"performance_degradation\")"},{"line_number":56,"context_line":"class PerformanceDegradation(sla.SLA):"},{"line_number":57,"context_line":"    \"\"\"Calculates perfomance degradation based on iteration time"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    This SLA plugin finds minimum and maximum duration of"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_666d2c99","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":28},"updated":"2016-07-24 22:18:48.000000000","message":"I\u0027d rather rename it to MaxPerformanceDegradation","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    This SLA plugin finds minimum and maximum duration of"},{"line_number":60,"context_line":"    iterations completed without errors during Rally task execution."},{"line_number":61,"context_line":"    Assuming that minimum duration is 100%, it calculates"},{"line_number":62,"context_line":"    performance degradation against maximum duration."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    CONFIG_SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_064b99b1","line":61,"updated":"2016-07-24 22:18:48.000000000","message":"\"duration is 100%\" - I\u0027m confused. I thought that units of duration is float, not percents. Okey, I\u0027ve guessed.\nWhat is the units of max degradation? \nIf this is percent, then https://en.wikipedia.org/wiki/Percentage \"In mathematics, a percentage is a number or ratio expressed as a fraction of 100\" but schema allows us to specify any number bigger or equal then 0.","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    This SLA plugin finds minimum and maximum duration of"},{"line_number":60,"context_line":"    iterations completed without errors during Rally task execution."},{"line_number":61,"context_line":"    Assuming that minimum duration is 100%, it calculates"},{"line_number":62,"context_line":"    performance degradation against maximum duration."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    CONFIG_SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_ff9eb905","line":61,"in_reply_to":"dada55a8_064b99b1","updated":"2016-07-26 11:55:24.000000000","message":"max_degradation is percentage.\nhttps://en.wikipedia.org/wiki/Percentage#Percentage_increase_and_decrease\n\nSo it can be higher than 100.\n\ne.g. min duration is 30, max duration is 90.\nif 30 is 100%, then 90 is 300% so max duration is higher by 200% and then degradation is 200%","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def __init__(self, criterion_value):"},{"line_number":77,"context_line":"        super(PerformanceDegradation, self).__init__(criterion_value)"},{"line_number":78,"context_line":"        self.max_degradation \u003d self.criterion_value.get("},{"line_number":79,"context_line":"            \"max_degradation\", 100.0)"},{"line_number":80,"context_line":"        self.degradation \u003d DegradationCalculation()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_iteration(self, iteration):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_e660fca6","line":79,"updated":"2016-07-24 22:18:48.000000000","message":"What is the reason to choose 100 % degradation by default? I think we don\u0027t need default here and could compare against self.criterion_value","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def __init__(self, criterion_value):"},{"line_number":77,"context_line":"        super(PerformanceDegradation, self).__init__(criterion_value)"},{"line_number":78,"context_line":"        self.max_degradation \u003d self.criterion_value.get("},{"line_number":79,"context_line":"            \"max_degradation\", 100.0)"},{"line_number":80,"context_line":"        self.degradation \u003d DegradationCalculation()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_iteration(self, iteration):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_3c1b321e","line":79,"in_reply_to":"dada55a8_e660fca6","updated":"2016-07-26 11:55:24.000000000","message":"added to required values","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return self.success"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def details(self):"},{"line_number":94,"context_line":"        return (_(\"Current degradation: %.2f%% \""},{"line_number":95,"context_line":"                  \"(min duration: %.2f, max duration: %.2f) - %s\") %"},{"line_number":96,"context_line":"                 (self.degradation.result() or 0.0,"},{"line_number":97,"context_line":"                  self.degradation.min_duration.result() or 0.0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8b7789d3","line":94,"updated":"2016-07-24 22:18:48.000000000","message":"Please use https://github.com/openstack/rally/blob/master/rally/common/utils.py#L636 otherwise we could get problems with float formatting","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return self.success"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def details(self):"},{"line_number":94,"context_line":"        return (_(\"Current degradation: %.2f%% \""},{"line_number":95,"context_line":"                  \"(min duration: %.2f, max duration: %.2f) - %s\") %"},{"line_number":96,"context_line":"                 (self.degradation.result() or 0.0,"},{"line_number":97,"context_line":"                  self.degradation.min_duration.result() or 0.0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_dcd2d633","line":94,"in_reply_to":"dada55a8_8b7789d3","updated":"2016-07-26 11:55:24.000000000","message":"Done","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"}],"tests/unit/plugins/common/sla/test_performance_degradation.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tests.unit import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@ddt.ddt"},{"line_number":24,"context_line":"class PerformanceDegradationTestCase(test.TestCase):"},{"line_number":25,"context_line":"    def test_config_schema(self):"},{"line_number":26,"context_line":"        properties \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_a6fe04ac","line":23,"updated":"2016-07-24 22:18:48.000000000","message":"You streaming algorithm also should be tested","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tests.unit import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@ddt.ddt"},{"line_number":24,"context_line":"class PerformanceDegradationTestCase(test.TestCase):"},{"line_number":25,"context_line":"    def test_config_schema(self):"},{"line_number":26,"context_line":"        properties \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_3c469221","line":23,"in_reply_to":"dada55a8_a6fe04ac","updated":"2016-07-26 11:55:24.000000000","message":"Done","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        sla1.merge(sla2)"},{"line_number":69,"context_line":"        self.assertIs(sla1.success, result)"},{"line_number":70,"context_line":"        self.assertIs(sla1.result()[\"success\"], result)"},{"line_number":71,"context_line":"        self.assertEqual(sla1.status(), status)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_details(self):"},{"line_number":74,"context_line":"        sla \u003d perfdegr.PerformanceDegradation({\"max_degradation\": 50})"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_661b6c1d","line":71,"updated":"2016-07-24 22:18:48.000000000","message":"The same as in 81 line elsewhere in the file","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        sla1.merge(sla2)"},{"line_number":69,"context_line":"        self.assertIs(sla1.success, result)"},{"line_number":70,"context_line":"        self.assertIs(sla1.result()[\"success\"], result)"},{"line_number":71,"context_line":"        self.assertEqual(sla1.status(), status)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_details(self):"},{"line_number":74,"context_line":"        sla \u003d perfdegr.PerformanceDegradation({\"max_degradation\": 50})"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_fc435a11","line":71,"in_reply_to":"dada55a8_661b6c1d","updated":"2016-07-26 11:55:24.000000000","message":"Done","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.assertEqual(sla1.status(), status)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_details(self):"},{"line_number":74,"context_line":"        sla \u003d perfdegr.PerformanceDegradation({\"max_degradation\": 50})"},{"line_number":75,"context_line":"        for duration in [39.0, 30.0, 32.0]:"},{"line_number":76,"context_line":"            sla.add_iteration({\"duration\": duration})"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_26297438","line":74,"updated":"2016-07-24 22:18:48.000000000","message":"This line was repeated three times. It could be placed in setUp() method","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.assertEqual(sla1.status(), status)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_details(self):"},{"line_number":74,"context_line":"        sla \u003d perfdegr.PerformanceDegradation({\"max_degradation\": 50})"},{"line_number":75,"context_line":"        for duration in [39.0, 30.0, 32.0]:"},{"line_number":76,"context_line":"            sla.add_iteration({\"duration\": duration})"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_bc39e2a5","line":74,"in_reply_to":"dada55a8_26297438","updated":"2016-07-26 11:55:24.000000000","message":"Done","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4c8b079071661cf7534918db803d5ffdcf40bbf0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.assertEqual("},{"line_number":79,"context_line":"            sla.details(),"},{"line_number":80,"context_line":"            \"Current degradation: 30.00% \""},{"line_number":81,"context_line":"            \"(min duration: 30.00, max duration: 39.00) - Passed\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        sla.add_iteration({\"duration\": 66.5})"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_e62e3c41","line":81,"updated":"2016-07-24 22:18:48.000000000","message":"First should be expected value then actual, elsewhere in the file(only for assertEqual)","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ace63841969bb89a33af2b0687b34868ee52fc01","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.assertEqual("},{"line_number":79,"context_line":"            sla.details(),"},{"line_number":80,"context_line":"            \"Current degradation: 30.00% \""},{"line_number":81,"context_line":"            \"(min duration: 30.00, max duration: 39.00) - Passed\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        sla.add_iteration({\"duration\": 66.5})"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_dc3656b3","line":81,"in_reply_to":"dada55a8_e62e3c41","updated":"2016-07-26 11:55:24.000000000","message":"Done","commit_id":"4efb92a687cf3493df0896849ddf7fa55cf8d3e2"}]}
