)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2eaae69d0918b01914c42abfe22b05e5084bb895","unresolved":false,"context_lines":[{"line_number":12,"context_line":"* Old validators wrapped into new plugin class"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"spec: pluggable_validators.rst"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5580667778cf0978c77ead577db1ce014a424e1e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1a1ced50_fb1c0e15","line":15,"updated":"2017-03-20 17:30:37.000000000","message":"Co-Authored-By: Anton Studenov \u003castudenov@mirantis.com\u003e","commit_id":"1203ada022b4424160407b648395afd0c009ec71"}],"rally/common/validation.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cd972e08b9da7f1ae0b0970bcb5578816c57af0d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            plugin \u003d cls.get(name)"},{"line_number":117,"context_line":"        except exceptions.PluginNotFound as exc:"},{"line_number":118,"context_line":"            msg \u003d \"There is no %s plugin with name: \u0027%s\u0027\" % ("},{"line_number":119,"context_line":"                cls.__name__.lower(), name)"},{"line_number":120,"context_line":"            return [ValidationResult(is_valid\u003dFalse, msg\u003dmsg)]"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa31d9ce_fcaec783","line":117,"range":{"start_line":117,"start_character":40,"end_line":117,"end_character":47},"updated":"2017-02-13 14:40:12.000000000","message":"it is not used","commit_id":"6637d1fd1531b868d447012825c19cf84f8fec74"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aa8fffe3ec6496e888a4d5ff28ee85b6ed054218","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"class ValidatablePluginMixin(object):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @staticmethod"},{"line_number":108,"context_line":"    def _load_validators(plugin):"},{"line_number":109,"context_line":"        validators \u003d plugin._meta_get(\"validators\", default\u003d[])"},{"line_number":110,"context_line":"        return [(Validator.get(name), args, kwargs)"},{"line_number":111,"context_line":"                for name, args, kwargs in validators]"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_384b0cb2","line":108,"range":{"start_line":107,"start_character":4,"end_line":108,"end_character":33},"updated":"2017-03-20 17:30:11.000000000","message":"maybe it should be just classmethod?","commit_id":"1203ada022b4424160407b648395afd0c009ec71"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aa8fffe3ec6496e888a4d5ff28ee85b6ed054218","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                for name, args, kwargs in validators]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"},{"line_number":114,"context_line":"    def validate(cls, name, admin, users, config, plugin_cfg):"},{"line_number":115,"context_line":"        \"\"\"Execute all validators stored in meta of plugin."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        Iterate during all validators stored in the meta of Validator"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_7899041f","line":114,"range":{"start_line":114,"start_character":28,"end_line":114,"end_character":42},"updated":"2017-03-20 17:30:11.000000000","message":"actually, it is another hardcode.. we need to accept here creds dict like\n\n   {\"openstack\": {\"admin\": {...}, \"users\": []}, \"kubernetes\": {...}}","commit_id":"1203ada022b4424160407b648395afd0c009ec71"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aa8fffe3ec6496e888a4d5ff28ee85b6ed054218","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        and execute proper validate() method and add validation result"},{"line_number":119,"context_line":"        to the list."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param name: name of the plugin to validate"},{"line_number":122,"context_line":"        :param admin: admin credential plugin instance for current platform"},{"line_number":123,"context_line":"        :param users: user credentials for current platform"},{"line_number":124,"context_line":"        :param config: dict with configuration of specified workload"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_d8b11891","line":121,"range":{"start_line":121,"start_character":7,"end_line":121,"end_character":51},"updated":"2017-03-20 17:30:11.000000000","message":"There should be ability to transmit namespace of plugin alone with its name","commit_id":"1203ada022b4424160407b648395afd0c009ec71"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cc1d9e6ed1097947a595c68440216a3f038c27d2","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        and execute proper validate() method and add validation result"},{"line_number":119,"context_line":"        to the list."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param name: name of the plugin to validate"},{"line_number":122,"context_line":"        :param admin: admin credential plugin instance for current platform"},{"line_number":123,"context_line":"        :param users: user credentials for current platform"},{"line_number":124,"context_line":"        :param config: dict with configuration of specified workload"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_21a38701","line":121,"range":{"start_line":121,"start_character":7,"end_line":121,"end_character":51},"in_reply_to":"1a1ced50_d8b11891","updated":"2017-03-22 10:28:03.000000000","message":"you forgot to fix that comment","commit_id":"1203ada022b4424160407b648395afd0c009ec71"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aa8fffe3ec6496e888a4d5ff28ee85b6ed054218","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            # Load platform validators from each validator"},{"line_number":146,"context_line":"            validator_validators \u003d cls._load_validators(validator)"},{"line_number":147,"context_line":"            for v, vargs, vkwargs in validator_validators:"},{"line_number":148,"context_line":"                if issubclass(v, RequiredPlatformValidator):"},{"line_number":149,"context_line":"                    platform_validators.append((v, vargs, vkwargs))"},{"line_number":150,"context_line":"                else:"},{"line_number":151,"context_line":"                    raise exceptions.RallyException("},{"line_number":152,"context_line":"                        \"Only RequiredPlatformValidator can be added \""},{"line_number":153,"context_line":"                        \"to other validators as a validator\")"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        results \u003d []"},{"line_number":156,"context_line":"        for validators in [platform_validators, regular_validators]:"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_185ad04f","line":153,"range":{"start_line":148,"start_character":16,"end_line":153,"end_character":61},"updated":"2017-03-20 17:30:11.000000000","message":"we already have such check in \"add\" decorator. Aren\u0027t we?","commit_id":"1203ada022b4424160407b648395afd0c009ec71"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aa8fffe3ec6496e888a4d5ff28ee85b6ed054218","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                        \"to other validators as a validator\")"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        results \u003d []"},{"line_number":156,"context_line":"        for validators in [platform_validators, regular_validators]:"},{"line_number":157,"context_line":"            for validator_cls, args, kwargs in validators:"},{"line_number":158,"context_line":"                try:"},{"line_number":159,"context_line":"                    validator \u003d validator_cls(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_d82678cd","line":156,"range":{"start_line":156,"start_character":26,"end_line":156,"end_character":68},"updated":"2017-03-20 17:30:11.000000000","message":"nit: I prefer to use tuple in such cases :)","commit_id":"1203ada022b4424160407b648395afd0c009ec71"}],"rally/plugins/common/validators.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aa8fffe3ec6496e888a4d5ff28ee85b6ed054218","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            scenario \u003d scenario().run"},{"line_number":44,"context_line":"        args, _varargs, varkwargs, defaults \u003d inspect.getargspec(scenario)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        hint_msg \u003d (\" Use `rally plugin show --name %s` to display \""},{"line_number":47,"context_line":"                    \"scenario description.\" % name)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # scenario always accepts an instance of scenario cls as a first arg"},{"line_number":50,"context_line":"        missed_args \u003d args[1:]"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_fb0fae2b","line":47,"range":{"start_line":46,"start_character":8,"end_line":47,"end_character":51},"updated":"2017-03-20 17:30:11.000000000","message":"do not forget about namespace :)","commit_id":"1203ada022b4424160407b648395afd0c009ec71"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dd0958b71044f9a675f41ec3cbf994939c316b56","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        jsonschema.validate(plugin_cfg, plugin_cls.CONFIG_SCHEMA)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@validation.configure(name\u003d\"args\")"},{"line_number":32,"context_line":"class ArgsValidator(validation.Validator):"},{"line_number":33,"context_line":"    \"\"\"Scenario arguments validator\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_60442e1c","line":31,"range":{"start_line":31,"start_character":27,"end_line":31,"end_character":33},"updated":"2017-03-28 12:38:55.000000000","message":"let\u0027s name it in another way since we have a lot of validators which relates to arguments. Maybe \"args-spec\" or something like that","commit_id":"c92f8dcb4b019a130b23d63ba80c1640d84b0495"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dd0958b71044f9a675f41ec3cbf994939c316b56","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def validate(self, credentials, config, plugin_cls, plugin_cfg):"},{"line_number":36,"context_line":"        return self._validate_scenario_args(plugin_cls, config)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _validate_scenario_args(self, scenario, config):"},{"line_number":39,"context_line":"        name \u003d scenario.get_name()"},{"line_number":40,"context_line":"        namespace \u003d scenario.get_namespace()"},{"line_number":41,"context_line":"        if scenario.is_classbased:"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_20c18681","line":38,"range":{"start_line":38,"start_character":3,"end_line":38,"end_character":56},"updated":"2017-03-28 12:38:55.000000000","message":"why we need an additional method? let\u0027s merge it to validate.","commit_id":"c92f8dcb4b019a130b23d63ba80c1640d84b0495"}],"rally/task/validation.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cd972e08b9da7f1ae0b0970bcb5578816c57af0d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from rally.plugins.openstack import types as openstack_types"},{"line_number":33,"context_line":"from rally.task import types"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# TODO(boris-42): make the validators usable as a functions as well."},{"line_number":36,"context_line":"# At the moment validators can only be used as decorators."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# TODO(astudenov): remove after deprecating all old validators"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa31d9ce_3c13ffb9","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":58},"updated":"2017-02-13 14:40:12.000000000","message":"this comment is not valid anymore","commit_id":"6637d1fd1531b868d447012825c19cf84f8fec74"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aa8fffe3ec6496e888a4d5ff28ee85b6ed054218","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            return self._run_fn(config, admin)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _run_fn(self, config, admin, clients\u003dNone):"},{"line_number":61,"context_line":"        return (self.fn(config, admin, clients, *self.args, **self.kwargs) or"},{"line_number":62,"context_line":"                ValidationResult(True))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a1ced50_bbce16b2","line":61,"range":{"start_line":61,"start_character":32,"end_line":61,"end_character":37},"updated":"2017-03-20 17:30:11.000000000","message":"what about putting something which looks like deployment object? I mean {\"admin\": admin.to_dict()} to make change \"backward compatible\" and do not modify old validators?","commit_id":"1203ada022b4424160407b648395afd0c009ec71"}]}
