)]}'
{"rally/common/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"fb14088fc9d702f2dc2b33a356c77f1be399e0a1","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            return time.sleep(sleep_time)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        while sleep_time \u003e\u003d 0:"},{"line_number":493,"context_line":"            time.sleep(min(atomic_delay, sleep_time))"},{"line_number":494,"context_line":"            sleep_time -\u003d atomic_delay"},{"line_number":495,"context_line":"    else:"},{"line_number":496,"context_line":"        raise ValueError(\"sleep_time should be \u003e\u003d 0\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_a4575b25","line":493,"updated":"2016-08-12 12:12:21.000000000","message":"As this loop would be called numerous of times I don\u0027t like change from simple sleep() to sleep() + cost of min operation it will increase execution time","commit_id":"e7c7bb652ed3eab4bb0c311e8324d59f595b2401"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"12352faacaf5cb16022552610873d3f2939a4d7b","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        while sleep_time \u003e\u003d atomic_delay:"},{"line_number":493,"context_line":"            time.sleep(atomic_delay)"},{"line_number":494,"context_line":"            sleep_time -\u003d atomic_delay"},{"line_number":495,"context_line":"        time.sleep(sleep_time)"},{"line_number":496,"context_line":"    else:"},{"line_number":497,"context_line":"        raise ValueError(\"sleep_time should be \u003e\u003d 0\")"},{"line_number":498,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_d5615713","line":495,"updated":"2016-08-12 13:00:41.000000000","message":"I run this script multiple times http://ideone.com/zp6SGO and what I get:\nrvasilets@rvasilets-pc:~$ python test.py\n16.930011034\n16.8593709469\nrvasilets@rvasilets-pc:~$ python test.py\n16.8768148422\n16.8982360363\nrvasilets@rvasilets-pc:~$ python test.py\n16.0875630379\n15.9909191132\nrvasilets@rvasilets-pc:~$ python test.py\n16.9972438812\n16.9122960567\nrvasilets@rvasilets-pc:~$ python test.py\n16.6606528759\n16.056210041\nrvasilets@rvasilets-pc:~$ python test.py\n15.9816091061\n15.9642307758\nrvasilets@rvasilets-pc:~$ python test.py\n16.2687489986\n16.1168789864\nrvasilets@rvasilets-pc:~$ python test.py\n16.2089500427\n16.0880320072\nAs the rule  you change is slower then the snippet in master. I agree that its simpler but its not too difficult to read that it needs to be simplified","commit_id":"dfc869add7290ca2780e6f2f391ce876b888a56a"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"d5fb75309698c60f74c694a37c4520145cdf2598","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        while sleep_time \u003e\u003d atomic_delay:"},{"line_number":493,"context_line":"            time.sleep(atomic_delay)"},{"line_number":494,"context_line":"            sleep_time -\u003d atomic_delay"},{"line_number":495,"context_line":"        time.sleep(sleep_time)"},{"line_number":496,"context_line":"    else:"},{"line_number":497,"context_line":"        raise ValueError(\"sleep_time should be \u003e\u003d 0\")"},{"line_number":498,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_7c405336","line":495,"in_reply_to":"9ad45d7e_d5615713","updated":"2016-08-12 13:24:52.000000000","message":"Yes, there is no significant difference between both ways, but my point was to make code a bit smaller and readable. By the way actual time of sleep is much bigger than expected.","commit_id":"dfc869add7290ca2780e6f2f391ce876b888a56a"}]}
