)]}'
{"tests/unit/plugins/openstack/context/cinder/test_volumes.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"fa025a0923b7f3c781cdf731cfecddac18453ab6","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            users\u003dself.context[\"users\"],"},{"line_number":186,"context_line":"            api_versions\u003dapi_version)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_volume_type_invalid(self):"},{"line_number":189,"context_line":"        task_config \u003d {"},{"line_number":190,"context_line":"            \"size\": 1,"},{"line_number":191,"context_line":"            \"type\": -1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_9a7579cc","line":188,"updated":"2016-08-18 11:54:31.000000000","message":"This tests VolumeGenerator.CONFIG_SCHEMA property but not how the context works with this property.\n\nInstead, specify proper values to VolumeGenerator(\u003c...\u003e) and then call setup() to see if everything actually goes fine","commit_id":"5ae3f5ffb0c05f0209459bb2d550802fb476dafa"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"fa025a0923b7f3c781cdf731cfecddac18453ab6","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                          jsonschema.validate, task_config,"},{"line_number":197,"context_line":"                          volumes.VolumeGenerator.CONFIG_SCHEMA)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_volume_type_none(self):"},{"line_number":200,"context_line":"        task_config \u003d {"},{"line_number":201,"context_line":"            \"size\": 1,"},{"line_number":202,"context_line":"            \"type\": None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_95db8a7b","line":199,"updated":"2016-08-18 11:54:31.000000000","message":"Same here, there is no reason to test jsonschema behavior of CONFIG_SCHEMA. Instead, it is important to be sure that VolumeGenerator(\u003csome values\u003e).setup() runs without issues with specific config values set (and jsonschema works and is being tested behind the scenes in this case)","commit_id":"5ae3f5ffb0c05f0209459bb2d550802fb476dafa"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9ca2f026452896501ee3e01ee9b48fb34188947b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def test_setup(self, mock_cinder_scenario__create_volume, config,"},{"line_number":59,"context_line":"                   validation_raises\u003dNone):"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            volumes.VolumeGenerator.validate(config)"},{"line_number":62,"context_line":"        except Exception as e:"},{"line_number":63,"context_line":"            if not isinstance(e, validation_raises):"},{"line_number":64,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_40cbef72","line":61,"updated":"2016-08-19 13:08:27.000000000","message":"@Srinivas, I believe you do not mind that I\u0027ve submitted this patch set. Here I propose two important improvements:\n\n* using DDT (simplification and avoid code repetition)\n* checking jsonschema with volumes.VolumeGenerator.validate()\n\nNow there is a single test which does all the verifications and is flexible for adding new DDT cases","commit_id":"eb652bf58ff8ac76bec7cec3a84d2613b675178a"}]}