)]}'
{"rally/api.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c3dcd787cb05e2f95d4a6d31352db91d902c5856","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                                   in FINISHED, FAILED or ABORTED and"},{"line_number":365,"context_line":"                                   the force argument is not True"},{"line_number":366,"context_line":"        \"\"\""},{"line_number":367,"context_line":"        status \u003d None if force else objects.Task.get_status(task_uuid)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        # NOTE(amaretskiy): Delete stopped tasks without resistance"},{"line_number":370,"context_line":"        if status not in (None,"},{"line_number":371,"context_line":"                          consts.TaskStatus.ABORTED,"},{"line_number":372,"context_line":"                          consts.TaskStatus.FINISHED,"},{"line_number":373,"context_line":"                          consts.TaskStatus.FAILED):"},{"line_number":374,"context_line":"            status \u003d consts.TaskStatus.FINISHED"},{"line_number":375,"context_line":"        objects.Task.delete_by_uuid(task_uuid, status\u003dstatus)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_fbd1b8fc","line":374,"range":{"start_line":367,"start_character":0,"end_line":374,"end_character":47},"updated":"2016-09-22 23:06:24.000000000","message":"I suggest to rewrite this snippet. Of cause? looks like it works but its tricky to me.\nMy suggestion is:\nif forse:\n    objects.Task.delete_by_uuid(task_uuid, status\u003dNone)\nelse:\n   if objects.Task.get_status(task_uuid) in (None, consts.TaskStatus.ABORTED, consts.TaskStatus.FINISHED, consts.TaskStatus.FAILED):\n    objects.Task.delete_by_uuid(task_uuid, status\u003dconsts.TaskStatus.FINISHED)\n\nwithout any reverse logic and easy to read","commit_id":"2200cc2d01f1d1c6a38082b7053849ec925b6a84"}]}
