)]}'
{"rally-jobs/rally-mistral.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        concurrency: 10"},{"line_number":54,"context_line":"      context:"},{"line_number":55,"context_line":"        users:"},{"line_number":56,"context_line":"          tenants: 1"},{"line_number":57,"context_line":"          users_per_tenant: 1"},{"line_number":58,"context_line":"      sla:"},{"line_number":59,"context_line":"        failure_rate:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_f829239c","line":56,"updated":"2016-10-09 22:47:41.000000000","message":"please increase it to 2","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        concurrency: 10"},{"line_number":54,"context_line":"      context:"},{"line_number":55,"context_line":"        users:"},{"line_number":56,"context_line":"          tenants: 1"},{"line_number":57,"context_line":"          users_per_tenant: 1"},{"line_number":58,"context_line":"      sla:"},{"line_number":59,"context_line":"        failure_rate:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_a1b84376","line":56,"in_reply_to":"1a95cdbc_f829239c","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      context:"},{"line_number":55,"context_line":"        users:"},{"line_number":56,"context_line":"          tenants: 1"},{"line_number":57,"context_line":"          users_per_tenant: 1"},{"line_number":58,"context_line":"      sla:"},{"line_number":59,"context_line":"        failure_rate:"},{"line_number":60,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_181b2f82","line":57,"updated":"2016-10-09 22:47:41.000000000","message":"please increase it to 2","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      context:"},{"line_number":55,"context_line":"        users:"},{"line_number":56,"context_line":"          tenants: 1"},{"line_number":57,"context_line":"          users_per_tenant: 1"},{"line_number":58,"context_line":"      sla:"},{"line_number":59,"context_line":"        failure_rate:"},{"line_number":60,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_e1aecb2c","line":57,"in_reply_to":"1a95cdbc_181b2f82","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        concurrency: 10"},{"line_number":72,"context_line":"      context:"},{"line_number":73,"context_line":"        users:"},{"line_number":74,"context_line":"          tenants: 1"},{"line_number":75,"context_line":"          users_per_tenant: 1"},{"line_number":76,"context_line":"      sla:"},{"line_number":77,"context_line":"        failure_rate:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_381e2b70","line":74,"updated":"2016-10-09 22:47:41.000000000","message":"please increase it to 2","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        concurrency: 10"},{"line_number":72,"context_line":"      context:"},{"line_number":73,"context_line":"        users:"},{"line_number":74,"context_line":"          tenants: 1"},{"line_number":75,"context_line":"          users_per_tenant: 1"},{"line_number":76,"context_line":"      sla:"},{"line_number":77,"context_line":"        failure_rate:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_01aad718","line":74,"in_reply_to":"1a95cdbc_381e2b70","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      context:"},{"line_number":73,"context_line":"        users:"},{"line_number":74,"context_line":"          tenants: 1"},{"line_number":75,"context_line":"          users_per_tenant: 1"},{"line_number":76,"context_line":"      sla:"},{"line_number":77,"context_line":"        failure_rate:"},{"line_number":78,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_7814334c","line":75,"updated":"2016-10-09 22:47:41.000000000","message":"please increase it to 2","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      context:"},{"line_number":73,"context_line":"        users:"},{"line_number":74,"context_line":"          tenants: 1"},{"line_number":75,"context_line":"          users_per_tenant: 1"},{"line_number":76,"context_line":"      sla:"},{"line_number":77,"context_line":"        failure_rate:"},{"line_number":78,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_21a51346","line":75,"in_reply_to":"1a95cdbc_7814334c","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"rally/plugins/openstack/cleanup/resources.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"67f83ac497ef8c3b1c1b9ebc1c05d6b333b0056b","unresolved":false,"context_lines":[{"line_number":664,"context_line":""},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"@base.resource(\"mistral\", \"executions\", order\u003d1101, tenant_resource\u003dTrue)"},{"line_number":667,"context_line":"class MistralExecutions(SynchronizedDeletion, base.ResourceManager):"},{"line_number":668,"context_line":"    def delete(self):"},{"line_number":669,"context_line":"        self._manager().delete(self.raw_resource.name)"},{"line_number":670,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_5c7b5cf5","line":667,"updated":"2016-08-22 23:19:15.000000000","message":"please use an approach that used in 6774 line","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dd42565132d762914d661b55b0bc20e4e0dc0cb1","unresolved":false,"context_lines":[{"line_number":664,"context_line":""},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"@base.resource(\"mistral\", \"executions\", order\u003d1101, tenant_resource\u003dTrue)"},{"line_number":667,"context_line":"class MistralExecutions(SynchronizedDeletion, base.ResourceManager):"},{"line_number":668,"context_line":"    def delete(self):"},{"line_number":669,"context_line":"        self._manager().delete(self.raw_resource.name)"},{"line_number":670,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_5e1f425b","line":667,"in_reply_to":"1ac06dbe_5c7b5cf5","updated":"2016-08-24 18:15:35.000000000","message":"Done","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b2caecb593047c7f1ea05b8d1ee16d4749d1aee0","unresolved":false,"context_lines":[{"line_number":669,"context_line":""},{"line_number":670,"context_line":"@base.resource(\"mistral\", \"workflows\", order\u003dnext(_mistral_order),"},{"line_number":671,"context_line":"               tenant_resource\u003dTrue)"},{"line_number":672,"context_line":"class MistralWorkflows(SynchronizedDeletion, base.ResourceManager):"},{"line_number":673,"context_line":"    def delete(self):"},{"line_number":674,"context_line":"        self._manager().delete(self.raw_resource.name)"},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_94dfdf0b","line":672,"updated":"2016-08-30 23:17:22.000000000","message":"Please use Mixin class see an example in Keystone resource","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"649f1a61e521d6593d170acb89f7578c7d88f0f3","unresolved":false,"context_lines":[{"line_number":669,"context_line":""},{"line_number":670,"context_line":"@base.resource(\"mistral\", \"workflows\", order\u003dnext(_mistral_order),"},{"line_number":671,"context_line":"               tenant_resource\u003dTrue)"},{"line_number":672,"context_line":"class MistralWorkflows(SynchronizedDeletion, base.ResourceManager):"},{"line_number":673,"context_line":"    def delete(self):"},{"line_number":674,"context_line":"        self._manager().delete(self.raw_resource.name)"},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_9243486c","line":672,"in_reply_to":"fa7ab95a_94dfdf0b","updated":"2016-08-31 17:10:19.000000000","message":"I tried...","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"}],"rally/plugins/openstack/scenarios/mistral/executions.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"67f83ac497ef8c3b1c1b9ebc1c05d6b333b0056b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @validation.required_clients(\"mistral\")"},{"line_number":30,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":31,"context_line":"    @validation.required_services(consts.Service.MISTRAL)"},{"line_number":32,"context_line":"    @scenario.configure()"},{"line_number":33,"context_line":"    def list_executions(self):"},{"line_number":34,"context_line":"        \"\"\"Scenario test mistral execution-list command."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_9ccf9428","line":32,"updated":"2016-08-22 23:19:15.000000000","message":"please add here mistral cleanup. We don\u0027t know what mistral will create during the list and this is the only guaranty","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dd42565132d762914d661b55b0bc20e4e0dc0cb1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @validation.required_clients(\"mistral\")"},{"line_number":30,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":31,"context_line":"    @validation.required_services(consts.Service.MISTRAL)"},{"line_number":32,"context_line":"    @scenario.configure()"},{"line_number":33,"context_line":"    def list_executions(self):"},{"line_number":34,"context_line":"        \"\"\"Scenario test mistral execution-list command."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_c1735714","line":32,"in_reply_to":"1ac06dbe_9ccf9428","updated":"2016-08-24 18:15:35.000000000","message":"What will mistral create during list?\nIn workbooks.py in the same directory there is no cleanup for list workbooks.\nWould you like me to add cleanup in both functions?","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"67f83ac497ef8c3b1c1b9ebc1c05d6b333b0056b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        This simple scenario tests the Mistral execution-list"},{"line_number":37,"context_line":"        command by listing all the executions."},{"line_number":38,"context_line":"        \"\"\""},{"line_number":39,"context_line":"        self._list_executions()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @types.convert(definition\u003d{\"type\": \"file\"})"},{"line_number":42,"context_line":"    @validation.file_exists(\"definition\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_3c3820ef","line":39,"updated":"2016-08-22 23:19:15.000000000","message":"Here is more parameters https://github.com/openstack/python-mistralclient/blob/master/mistralclient/api/v2/executions.py#L72","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dd42565132d762914d661b55b0bc20e4e0dc0cb1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        This simple scenario tests the Mistral execution-list"},{"line_number":37,"context_line":"        command by listing all the executions."},{"line_number":38,"context_line":"        \"\"\""},{"line_number":39,"context_line":"        self._list_executions()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @types.convert(definition\u003d{\"type\": \"file\"})"},{"line_number":42,"context_line":"    @validation.file_exists(\"definition\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_a1af3b2a","line":39,"in_reply_to":"1ac06dbe_3c3820ef","updated":"2016-08-24 18:15:35.000000000","message":"I would prefer to add other parameters in another commit if that is ok.","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"013148bb786b7b513f90c80c3c349cdfd608984c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @types.convert(definition\u003d{\"type\": \"file\"})"},{"line_number":42,"context_line":"    @validation.file_exists(\"definition\")"},{"line_number":43,"context_line":"    @validation.required_parameters(\"definition\")"},{"line_number":44,"context_line":"    @validation.required_clients(\"mistral\")"},{"line_number":45,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":46,"context_line":"    @validation.required_services(consts.Service.MISTRAL)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_2192b5f6","line":43,"updated":"2016-08-22 23:30:25.000000000","message":"The order of execution of decorators in python from outer to the inner. Thus 43th should be higher then convert and file_exists","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dd42565132d762914d661b55b0bc20e4e0dc0cb1","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @types.convert(definition\u003d{\"type\": \"file\"})"},{"line_number":42,"context_line":"    @validation.file_exists(\"definition\")"},{"line_number":43,"context_line":"    @validation.required_parameters(\"definition\")"},{"line_number":44,"context_line":"    @validation.required_clients(\"mistral\")"},{"line_number":45,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":46,"context_line":"    @validation.required_services(consts.Service.MISTRAL)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_f450cf0c","line":43,"in_reply_to":"1ac06dbe_2192b5f6","updated":"2016-08-24 18:15:35.000000000","message":"Done","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"67f83ac497ef8c3b1c1b9ebc1c05d6b333b0056b","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        This scenario is a very useful tool to measure the"},{"line_number":53,"context_line":"        \"mistral execution-create\" and \"mistral execution-delete\""},{"line_number":54,"context_line":"        commands performance."},{"line_number":55,"context_line":"        :param definition: string (yaml string) representation of given file"},{"line_number":56,"context_line":"                           content (Mistral workbook definition)"},{"line_number":57,"context_line":"        :param workflow_name: string the workflow name to execute. Should be"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_61d2ed5d","line":54,"updated":"2016-08-22 23:19:15.000000000","message":"I guess for that purpose will be useful to create workbook context to not to include their creation time(66th line) into that scenario","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dd42565132d762914d661b55b0bc20e4e0dc0cb1","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        This scenario is a very useful tool to measure the"},{"line_number":53,"context_line":"        \"mistral execution-create\" and \"mistral execution-delete\""},{"line_number":54,"context_line":"        commands performance."},{"line_number":55,"context_line":"        :param definition: string (yaml string) representation of given file"},{"line_number":56,"context_line":"                           content (Mistral workbook definition)"},{"line_number":57,"context_line":"        :param workflow_name: string the workflow name to execute. Should be"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_94c35b8a","line":54,"in_reply_to":"1ac06dbe_61d2ed5d","updated":"2016-08-24 18:15:35.000000000","message":"Yes, I hope I will have time to do it soon.","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"67f83ac497ef8c3b1c1b9ebc1c05d6b333b0056b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        if not workflow_name:"},{"line_number":70,"context_line":"            workflow_name \u003d six.next(six.iterkeys(wb_def[\"workflows\"]))"},{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            self.assertIn("},{"line_number":73,"context_line":"                workflow_name,"},{"line_number":74,"context_line":"                wb_def[\"workflows\"],"},{"line_number":75,"context_line":"                \"workflow \u0027{}\u0027 not found in the definition \u0027{}\u0027\".format("},{"line_number":76,"context_line":"                    workflow_name,"},{"line_number":77,"context_line":"                    definition"},{"line_number":78,"context_line":"                )"},{"line_number":79,"context_line":"            )"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        workflow_identifier \u003d \".\".join([wb.name, workflow_name])"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_3f33f2ac","line":79,"range":{"start_line":72,"start_character":11,"end_line":79,"end_character":13},"updated":"2016-08-22 23:19:15.000000000","message":"What is that? Asserts shouldn\u0027t be in scenarios","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dd42565132d762914d661b55b0bc20e4e0dc0cb1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        if not workflow_name:"},{"line_number":70,"context_line":"            workflow_name \u003d six.next(six.iterkeys(wb_def[\"workflows\"]))"},{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            self.assertIn("},{"line_number":73,"context_line":"                workflow_name,"},{"line_number":74,"context_line":"                wb_def[\"workflows\"],"},{"line_number":75,"context_line":"                \"workflow \u0027{}\u0027 not found in the definition \u0027{}\u0027\".format("},{"line_number":76,"context_line":"                    workflow_name,"},{"line_number":77,"context_line":"                    definition"},{"line_number":78,"context_line":"                )"},{"line_number":79,"context_line":"            )"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        workflow_identifier \u003d \".\".join([wb.name, workflow_name])"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_94a23b99","line":79,"range":{"start_line":72,"start_character":11,"end_line":79,"end_character":13},"in_reply_to":"1ac06dbe_3f33f2ac","updated":"2016-08-24 18:15:35.000000000","message":"The workflow_name parameter can be supplied by the user. The use case is - given a workbook with multiple workflows, user wants to execute a specific one.\n\nIn this usecase I wanted to make sure the workflow is indeed inside the workbook, so if the user passed something wrong (a workbook name that does not exist) we will know it here and stop the test.","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"013148bb786b7b513f90c80c3c349cdfd608984c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                )"},{"line_number":79,"context_line":"            )"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        workflow_identifier \u003d \".\".join([wb.name, workflow_name])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        ex \u003d self._create_execution(workflow_identifier)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_0102190b","line":81,"updated":"2016-08-22 23:30:25.000000000","message":"Notice that all resource names created by Rally in scenario should began with \"s_rally_\". This is rich through random generated name in utils see https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/mistral/utils.py#L39","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dd42565132d762914d661b55b0bc20e4e0dc0cb1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                )"},{"line_number":79,"context_line":"            )"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        workflow_identifier \u003d \".\".join([wb.name, workflow_name])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        ex \u003d self._create_execution(workflow_identifier)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_d4767305","line":81,"in_reply_to":"1ac06dbe_0102190b","updated":"2016-08-24 18:15:35.000000000","message":"I think it should be OK, since I used the same method we have in workbooks today.","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b2caecb593047c7f1ea05b8d1ee16d4749d1aee0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        This simple scenario tests the Mistral execution-list"},{"line_number":37,"context_line":"        command by listing all the executions."},{"line_number":38,"context_line":"        \"\"\""},{"line_number":39,"context_line":"        self._list_executions()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @validation.required_parameters(\"definition\")"},{"line_number":42,"context_line":"    @types.convert(definition\u003d{\"type\": \"file\"})"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_853084ea","line":39,"updated":"2016-08-30 23:17:22.000000000","message":"mistral client have more parameters here. We should pass them all","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"649f1a61e521d6593d170acb89f7578c7d88f0f3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        This simple scenario tests the Mistral execution-list"},{"line_number":37,"context_line":"        command by listing all the executions."},{"line_number":38,"context_line":"        \"\"\""},{"line_number":39,"context_line":"        self._list_executions()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @validation.required_parameters(\"definition\")"},{"line_number":42,"context_line":"    @types.convert(definition\u003d{\"type\": \"file\"})"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_a402ca6d","line":39,"in_reply_to":"fa7ab95a_853084ea","updated":"2016-08-31 17:10:19.000000000","message":"I will try, but if it will be to much work, I will just remove list_executions completely.","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b2caecb593047c7f1ea05b8d1ee16d4749d1aee0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":46,"context_line":"    @validation.required_services(consts.Service.MISTRAL)"},{"line_number":47,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"mistral\"]})"},{"line_number":48,"context_line":"    def create_execution_from_workbook_definition("},{"line_number":49,"context_line":"            self, definition, workflow_name\u003dNone, do_delete\u003dFalse):"},{"line_number":50,"context_line":"        \"\"\"Scenario tests execution creation and deletion."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_62761608","line":48,"updated":"2016-08-30 23:17:22.000000000","message":"Better to rename scenario to create_execution_from_workbook","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"649f1a61e521d6593d170acb89f7578c7d88f0f3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":46,"context_line":"    @validation.required_services(consts.Service.MISTRAL)"},{"line_number":47,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"mistral\"]})"},{"line_number":48,"context_line":"    def create_execution_from_workbook_definition("},{"line_number":49,"context_line":"            self, definition, workflow_name\u003dNone, do_delete\u003dFalse):"},{"line_number":50,"context_line":"        \"\"\"Scenario tests execution creation and deletion."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_1f3af1e7","line":48,"in_reply_to":"fa7ab95a_62761608","updated":"2016-08-31 17:10:19.000000000","message":"Done","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b2caecb593047c7f1ea05b8d1ee16d4749d1aee0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        if not workflow_name:"},{"line_number":70,"context_line":"            workflow_name \u003d six.next(six.iterkeys(wb_def[\"workflows\"]))"},{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            self.assertIn("},{"line_number":73,"context_line":"                workflow_name,"},{"line_number":74,"context_line":"                wb_def[\"workflows\"],"},{"line_number":75,"context_line":"                \"workflow \u0027{}\u0027 not found in the definition \u0027{}\u0027\".format("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_40c3cd37","line":72,"updated":"2016-08-30 23:17:22.000000000","message":"asserts shouldn\u0027t be in scenario. You shoild write validator for that purpose","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"649f1a61e521d6593d170acb89f7578c7d88f0f3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        if not workflow_name:"},{"line_number":70,"context_line":"            workflow_name \u003d six.next(six.iterkeys(wb_def[\"workflows\"]))"},{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            self.assertIn("},{"line_number":73,"context_line":"                workflow_name,"},{"line_number":74,"context_line":"                wb_def[\"workflows\"],"},{"line_number":75,"context_line":"                \"workflow \u0027{}\u0027 not found in the definition \u0027{}\u0027\".format("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_046c569b","line":72,"in_reply_to":"fa7ab95a_40c3cd37","updated":"2016-08-31 17:10:19.000000000","message":"Done","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b2caecb593047c7f1ea05b8d1ee16d4749d1aee0","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        workflow_identifier \u003d \".\".join([wb.name, workflow_name])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        ex \u003d self._create_execution(workflow_identifier)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if do_delete:"},{"line_number":86,"context_line":"            self._delete_workbook(wb.name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_22016e3a","line":83,"updated":"2016-08-30 23:17:22.000000000","message":"How the name will affect into the performance of _create_execution?","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"649f1a61e521d6593d170acb89f7578c7d88f0f3","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        workflow_identifier \u003d \".\".join([wb.name, workflow_name])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        ex \u003d self._create_execution(workflow_identifier)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if do_delete:"},{"line_number":86,"context_line":"            self._delete_workbook(wb.name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_e49f724e","line":83,"in_reply_to":"fa7ab95a_22016e3a","updated":"2016-08-31 17:10:19.000000000","message":"It will create an execution based on the workflow_identifier.\nAn execution execute the workflow.\n\nI think I didn\u0027t understand the question.","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ec53cdaec667fc984b5f6f9c2e95710b1788ad75","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":31,"context_line":"    @validation.required_services(consts.Service.MISTRAL)"},{"line_number":32,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"mistral\"]})"},{"line_number":33,"context_line":"    def list_executions(self, marker\u003d\"\", limit\u003dNone, sort_keys\u003d\"\","},{"line_number":34,"context_line":"                        sort_dirs\u003d\"\"):"},{"line_number":35,"context_line":"        \"\"\"Scenario test mistral execution-list command."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_2ed077f7","line":33,"updated":"2016-09-08 22:09:10.000000000","message":"We move all our scenarios into class base starting from current release. So please move them under classes. See an example https://review.openstack.org/#/c/365957/4/samples/plugins/scenario/scenario_plugin.py here and read there my comment","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4abb6d3f59c4b4a1c6b26b0017013aa942028934","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":31,"context_line":"    @validation.required_services(consts.Service.MISTRAL)"},{"line_number":32,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"mistral\"]})"},{"line_number":33,"context_line":"    def list_executions(self, marker\u003d\"\", limit\u003dNone, sort_keys\u003d\"\","},{"line_number":34,"context_line":"                        sort_dirs\u003d\"\"):"},{"line_number":35,"context_line":"        \"\"\"Scenario test mistral execution-list command."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_23eac80f","line":33,"in_reply_to":"9a89bdaa_2ed077f7","updated":"2016-09-22 13:28:53.000000000","message":"Done","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b5377a12abda75c2646e4ca4622817373c8484cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016: Nokia Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_572e74fb","line":1,"updated":"2016-10-08 22:41:36.000000000","message":"please remove this line in all files. It will be fast outdated","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016: Nokia Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_218ef3cf","line":1,"in_reply_to":"1a95cdbc_572e74fb","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            marker\u003dmarker,"},{"line_number":51,"context_line":"            limit\u003dlimit,"},{"line_number":52,"context_line":"            sort_keys\u003dsort_keys,"},{"line_number":53,"context_line":"            sort_dirs\u003dsort_dirs"},{"line_number":54,"context_line":"        )"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_5ba4d106","line":53,"updated":"2016-10-09 22:47:41.000000000","message":"this could be written in less lines","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            marker\u003dmarker,"},{"line_number":51,"context_line":"            limit\u003dlimit,"},{"line_number":52,"context_line":"            sort_keys\u003dsort_keys,"},{"line_number":53,"context_line":"            sort_dirs\u003dsort_dirs"},{"line_number":54,"context_line":"        )"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_81b5077f","line":53,"in_reply_to":"1a95cdbc_5ba4d106","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                          in \"create only\" mode."},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        wb \u003d self._create_workbook(definition)"},{"line_number":87,"context_line":"        wb_def \u003d yaml.safe_load(wb.definition)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if not workflow_name:"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_3ba1c5f8","line":86,"updated":"2016-10-09 22:47:41.000000000","message":"what we will get if definition is totally the mess?","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                          in \"create only\" mode."},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        wb \u003d self._create_workbook(definition)"},{"line_number":87,"context_line":"        wb_def \u003d yaml.safe_load(wb.definition)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if not workflow_name:"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_4805dc0e","line":86,"in_reply_to":"1a95cdbc_3ba1c5f8","updated":"2016-10-10 11:39:23.000000000","message":"Here are 2 examples:\nwhen workbook contains an unexpected \u0027@\u0027: http://paste.openstack.org/show/585159/\n\nwhen workbook contains wrong data (unsupported type): http://paste.openstack.org/show/585161/","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"rally/plugins/openstack/scenarios/mistral/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"67f83ac497ef8c3b1c1b9ebc1c05d6b333b0056b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @atomic.action_timer(\"mistral.list_executions\")"},{"line_number":54,"context_line":"    def _list_executions(self):"},{"line_number":55,"context_line":"        \"\"\"Gets list of existing executions.\"\"\""},{"line_number":56,"context_line":"        return self.clients(\"mistral\").executions.list()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @atomic.action_timer(\"mistral.create_execution\")"},{"line_number":59,"context_line":"    def _create_execution(self, workflow_identifier):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_4196d13f","line":56,"updated":"2016-08-22 23:19:15.000000000","message":"list() has more parameters. We should pass them all","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"67f83ac497ef8c3b1c1b9ebc1c05d6b333b0056b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            execution,"},{"line_number":72,"context_line":"            ready_statuses\u003d[\"SUCCESS\"],"},{"line_number":73,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":74,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return execution"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_618aed1c","line":74,"updated":"2016-08-22 23:19:15.000000000","message":"timeout should be added","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dd42565132d762914d661b55b0bc20e4e0dc0cb1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            execution,"},{"line_number":72,"context_line":"            ready_statuses\u003d[\"SUCCESS\"],"},{"line_number":73,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":74,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return execution"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_d492f3f5","line":74,"in_reply_to":"1ac06dbe_618aed1c","updated":"2016-08-24 18:15:35.000000000","message":"Done","commit_id":"c1b783c18e0f06ca34e5e6ffc9a25e883afe3b19"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b2caecb593047c7f1ea05b8d1ee16d4749d1aee0","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @atomic.action_timer(\"mistral.list_executions\")"},{"line_number":54,"context_line":"    def _list_executions(self):"},{"line_number":55,"context_line":"        \"\"\"Gets list of existing executions.\"\"\""},{"line_number":56,"context_line":"        return self.clients(\"mistral\").executions.list()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @atomic.action_timer(\"mistral.create_execution\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_c292824b","line":55,"updated":"2016-08-30 23:17:22.000000000","message":"you should document return by template\n:returns: blabla","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"649f1a61e521d6593d170acb89f7578c7d88f0f3","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @atomic.action_timer(\"mistral.list_executions\")"},{"line_number":54,"context_line":"    def _list_executions(self):"},{"line_number":55,"context_line":"        \"\"\"Gets list of existing executions.\"\"\""},{"line_number":56,"context_line":"        return self.clients(\"mistral\").executions.list()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @atomic.action_timer(\"mistral.create_execution\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_12aad819","line":55,"in_reply_to":"fa7ab95a_c292824b","updated":"2016-08-31 17:10:19.000000000","message":"Done","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b2caecb593047c7f1ea05b8d1ee16d4749d1aee0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        execution \u003d self.clients(\"mistral\").executions.create("},{"line_number":67,"context_line":"            workflow_identifier"},{"line_number":68,"context_line":"        )"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        execution \u003d utils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_22d08ef7","line":67,"updated":"2016-08-30 23:17:22.000000000","message":"As I saw https://github.com/openstack/python-mistralclient/blob/master/mistralclient/api/v2/executions.py#L45 here. This is just a string, so it should be generated by self.generate_random_name(). We are not allow custom names because this will be critical for our cleanup in the future","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"649f1a61e521d6593d170acb89f7578c7d88f0f3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        execution \u003d self.clients(\"mistral\").executions.create("},{"line_number":67,"context_line":"            workflow_identifier"},{"line_number":68,"context_line":"        )"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        execution \u003d utils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_870b087d","line":67,"in_reply_to":"fa7ab95a_22d08ef7","updated":"2016-08-31 17:10:19.000000000","message":"in this use case it is a concatenation of the workbook name (generated by rally) and the workflow name (custom string).\n\n\nso if the generated workbook name is s_rally_d40282cc_UYOZfJs7 and the workflow name defined by user in the workbook definition (and passed to rally in the workflow_name parameter) is my_workflow, then workflow_identifier will be s_rally_d40282cc_UYOZfJs7.wrapping_wf\n\nwhere can I read more on cleanup?","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b2caecb593047c7f1ea05b8d1ee16d4749d1aee0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            ready_statuses\u003d[\"SUCCESS\"],"},{"line_number":73,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":74,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":75,"context_line":"            timeout\u003d120"},{"line_number":76,"context_line":"        )"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return execution"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_c0cfdd26","line":75,"updated":"2016-08-30 23:17:22.000000000","message":"timeout value should be configured through oslo config","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"649f1a61e521d6593d170acb89f7578c7d88f0f3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            ready_statuses\u003d[\"SUCCESS\"],"},{"line_number":73,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":74,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":75,"context_line":"            timeout\u003d120"},{"line_number":76,"context_line":"        )"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return execution"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_72788490","line":75,"in_reply_to":"fa7ab95a_c0cfdd26","updated":"2016-08-31 17:10:19.000000000","message":"why? what am I missing?\nHow should oslo know how long should the execution run?\nI can pass a workflow with 10 minutes seep inside.","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ec53cdaec667fc984b5f6f9c2e95710b1788ad75","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            marker\u003dmarker,"},{"line_number":66,"context_line":"            limit\u003dlimit,"},{"line_number":67,"context_line":"            sort_keys\u003dsort_keys,"},{"line_number":68,"context_line":"            sort_dirs\u003dsort_dirs"},{"line_number":69,"context_line":"        )"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @atomic.action_timer(\"mistral.create_execution\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_c5b9aecd","line":68,"updated":"2016-09-08 22:09:10.000000000","message":"please make this return in 1-2 lines","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4abb6d3f59c4b4a1c6b26b0017013aa942028934","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            marker\u003dmarker,"},{"line_number":66,"context_line":"            limit\u003dlimit,"},{"line_number":67,"context_line":"            sort_keys\u003dsort_keys,"},{"line_number":68,"context_line":"            sort_dirs\u003dsort_dirs"},{"line_number":69,"context_line":"        )"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @atomic.action_timer(\"mistral.create_execution\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_f48e5026","line":68,"in_reply_to":"9a89bdaa_c5b9aecd","updated":"2016-09-22 13:28:53.000000000","message":"Done","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ec53cdaec667fc984b5f6f9c2e95710b1788ad75","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        execution \u003d self.clients(\"mistral\").executions.create("},{"line_number":80,"context_line":"            workflow_identifier"},{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        execution \u003d utils.wait_for_status("},{"line_number":84,"context_line":"            execution,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_a5dbca20","line":81,"range":{"start_line":81,"start_character":7,"end_line":81,"end_character":9},"updated":"2016-09-08 22:09:10.000000000","message":"please move it to 80th line","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4abb6d3f59c4b4a1c6b26b0017013aa942028934","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        execution \u003d self.clients(\"mistral\").executions.create("},{"line_number":80,"context_line":"            workflow_identifier"},{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        execution \u003d utils.wait_for_status("},{"line_number":84,"context_line":"            execution,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_14949c35","line":81,"range":{"start_line":81,"start_character":7,"end_line":81,"end_character":9},"in_reply_to":"9a89bdaa_a5dbca20","updated":"2016-09-22 13:28:53.000000000","message":"Done","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ec53cdaec667fc984b5f6f9c2e95710b1788ad75","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            ready_statuses\u003d[\"SUCCESS\"],"},{"line_number":86,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":87,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":88,"context_line":"            timeout\u003d120"},{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return execution"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_459f5e50","line":88,"updated":"2016-09-08 22:09:10.000000000","message":"It should be configured through oslo_config","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4abb6d3f59c4b4a1c6b26b0017013aa942028934","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            ready_statuses\u003d[\"SUCCESS\"],"},{"line_number":86,"context_line":"            failure_statuses\u003d[\"ERROR\"],"},{"line_number":87,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":88,"context_line":"            timeout\u003d120"},{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return execution"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_f42ad0e6","line":88,"in_reply_to":"9a89bdaa_459f5e50","updated":"2016-09-22 13:28:53.000000000","message":"please see the PS published. I copied the approach I saw in other projects.","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e47bf5980e8e55de47d8d852343d20f910393d81","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":"benchmark_group \u003d cfg.OptGroup(name\u003d\"benchmark\", title\u003d\"benchmark options\")"},{"line_number":32,"context_line":"CONF.register_opts(MISTRAL_BENCHMARK_OPTS, group\u003dbenchmark_group)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class MistralScenario(scenario.OpenStackScenario):"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_9fec3bc9","line":32,"range":{"start_line":32,"start_character":19,"end_line":32,"end_character":41},"updated":"2016-10-11 13:20:38.000000000","message":"it should be included in https://github.com/openstack/rally/blob/master/rally/common/opts.py and sample config file should be updated with `tox -e genconfig`","commit_id":"506579f8b539cf2b110d8e41c678ca94629d7c06"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"ad174db374efa05706117687095dc4327f800f2f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":"benchmark_group \u003d cfg.OptGroup(name\u003d\"benchmark\", title\u003d\"benchmark options\")"},{"line_number":32,"context_line":"CONF.register_opts(MISTRAL_BENCHMARK_OPTS, group\u003dbenchmark_group)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class MistralScenario(scenario.OpenStackScenario):"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_106f03c6","line":32,"range":{"start_line":32,"start_character":19,"end_line":32,"end_character":41},"in_reply_to":"fa6399be_9fec3bc9","updated":"2016-10-12 14:58:19.000000000","message":"Done","commit_id":"506579f8b539cf2b110d8e41c678ca94629d7c06"}],"rally/plugins/openstack/scenarios/mistral/workbooks.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b2caecb593047c7f1ea05b8d1ee16d4749d1aee0","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @validation.required_parameters(\"definition\")"},{"line_number":39,"context_line":"    @types.convert(definition\u003d{\"type\": \"file\"})"},{"line_number":40,"context_line":"    @validation.file_exists(\"definition\")"},{"line_number":41,"context_line":"    @validation.required_clients(\"mistral\")"},{"line_number":42,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":43,"context_line":"    @validation.required_services(consts.Service.MISTRAL)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_822b1a94","line":40,"updated":"2016-08-30 23:17:22.000000000","message":"Looks like file_exists should be higher then convert","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"649f1a61e521d6593d170acb89f7578c7d88f0f3","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @validation.required_parameters(\"definition\")"},{"line_number":39,"context_line":"    @types.convert(definition\u003d{\"type\": \"file\"})"},{"line_number":40,"context_line":"    @validation.file_exists(\"definition\")"},{"line_number":41,"context_line":"    @validation.required_clients(\"mistral\")"},{"line_number":42,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":43,"context_line":"    @validation.required_services(consts.Service.MISTRAL)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_12b9f82e","line":40,"in_reply_to":"fa7ab95a_822b1a94","updated":"2016-08-31 17:10:19.000000000","message":"Done","commit_id":"8e9cc0b1931598f21cc8452dd8e90e04bbeb396e"}],"rally/task/validation.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ec53cdaec667fc984b5f6f9c2e95710b1788ad75","unresolved":false,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"@validator"},{"line_number":726,"context_line":"def workbook_contains_workflow(config, clients, deployment, wb, wf):"},{"line_number":727,"context_line":"    \"\"\"Validate that workflow exist in workbook when workflow is passed"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    :param wb: parameter containing the workbook definition"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_8eba6309","line":726,"updated":"2016-09-08 22:09:10.000000000","message":"I\u0027d like to see more meaningful names for variable: workbook, workflow","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4abb6d3f59c4b4a1c6b26b0017013aa942028934","unresolved":false,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"@validator"},{"line_number":726,"context_line":"def workbook_contains_workflow(config, clients, deployment, wb, wf):"},{"line_number":727,"context_line":"    \"\"\"Validate that workflow exist in workbook when workflow is passed"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    :param wb: parameter containing the workbook definition"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_dfe88d19","line":726,"in_reply_to":"9a89bdaa_8eba6309","updated":"2016-09-22 13:28:53.000000000","message":"Done","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ec53cdaec667fc984b5f6f9c2e95710b1788ad75","unresolved":false,"context_lines":[{"line_number":726,"context_line":"def workbook_contains_workflow(config, clients, deployment, wb, wf):"},{"line_number":727,"context_line":"    \"\"\"Validate that workflow exist in workbook when workflow is passed"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    :param wb: parameter containing the workbook definition"},{"line_number":730,"context_line":"    :param wf: parameter containing the workflow name"},{"line_number":731,"context_line":"    \"\"\""},{"line_number":732,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_2e94f742","line":729,"updated":"2016-09-08 22:09:10.000000000","message":"Do this variable always be \"definition\" or it could differ?","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4abb6d3f59c4b4a1c6b26b0017013aa942028934","unresolved":false,"context_lines":[{"line_number":726,"context_line":"def workbook_contains_workflow(config, clients, deployment, wb, wf):"},{"line_number":727,"context_line":"    \"\"\"Validate that workflow exist in workbook when workflow is passed"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    :param wb: parameter containing the workbook definition"},{"line_number":730,"context_line":"    :param wf: parameter containing the workflow name"},{"line_number":731,"context_line":"    \"\"\""},{"line_number":732,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_7fda197a","line":729,"in_reply_to":"9a89bdaa_2e94f742","updated":"2016-09-22 13:28:53.000000000","message":"always","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ec53cdaec667fc984b5f6f9c2e95710b1788ad75","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    \"\"\"Validate that workflow exist in workbook when workflow is passed"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    :param wb: parameter containing the workbook definition"},{"line_number":730,"context_line":"    :param wf: parameter containing the workflow name"},{"line_number":731,"context_line":"    \"\"\""},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"    wf_name \u003d config.get(\"args\", {}).get(wf)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_ae9f2764","line":730,"updated":"2016-09-08 22:09:10.000000000","message":"Do this variable always be \"workflow_name\" or it could differ?","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4abb6d3f59c4b4a1c6b26b0017013aa942028934","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    \"\"\"Validate that workflow exist in workbook when workflow is passed"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    :param wb: parameter containing the workbook definition"},{"line_number":730,"context_line":"    :param wf: parameter containing the workflow name"},{"line_number":731,"context_line":"    \"\"\""},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"    wf_name \u003d config.get(\"args\", {}).get(wf)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_dfcfadb1","line":730,"in_reply_to":"9a89bdaa_ae9f2764","updated":"2016-09-22 13:28:53.000000000","message":"always","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ec53cdaec667fc984b5f6f9c2e95710b1788ad75","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        wb_path \u003d config.get(\"args\", {}).get(wb)"},{"line_number":736,"context_line":"        wb_path \u003d os.path.expanduser(wb_path)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        with open(wb_path, \"r\") as wb_def:"},{"line_number":739,"context_line":"            wb_def \u003d yaml.safe_load(wb_def)"},{"line_number":740,"context_line":"            if wf_name not in wb_def[\"workflows\"]:"},{"line_number":741,"context_line":"                raise ValueError("}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_0e13b30e","line":738,"updated":"2016-09-08 22:09:10.000000000","message":"wb_path could be None thus we will get an error. First we  should check that it is not None\nif","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4abb6d3f59c4b4a1c6b26b0017013aa942028934","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        wb_path \u003d config.get(\"args\", {}).get(wb)"},{"line_number":736,"context_line":"        wb_path \u003d os.path.expanduser(wb_path)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        with open(wb_path, \"r\") as wb_def:"},{"line_number":739,"context_line":"            wb_def \u003d yaml.safe_load(wb_def)"},{"line_number":740,"context_line":"            if wf_name not in wb_def[\"workflows\"]:"},{"line_number":741,"context_line":"                raise ValueError("}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_2535e045","line":738,"in_reply_to":"9a89bdaa_0e13b30e","updated":"2016-09-22 13:28:53.000000000","message":"Done","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ec53cdaec667fc984b5f6f9c2e95710b1788ad75","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        with open(wb_path, \"r\") as wb_def:"},{"line_number":739,"context_line":"            wb_def \u003d yaml.safe_load(wb_def)"},{"line_number":740,"context_line":"            if wf_name not in wb_def[\"workflows\"]:"},{"line_number":741,"context_line":"                raise ValueError("},{"line_number":742,"context_line":"                    \"workflow \u0027{}\u0027 not found in the definition \u0027{}\u0027\".format("},{"line_number":743,"context_line":"                        wf_name,"},{"line_number":744,"context_line":"                        wb_def"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_4e64dbe4","line":741,"updated":"2016-09-08 22:09:10.000000000","message":"Validators should return ValidationResult object not raise an exeption","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4abb6d3f59c4b4a1c6b26b0017013aa942028934","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        with open(wb_path, \"r\") as wb_def:"},{"line_number":739,"context_line":"            wb_def \u003d yaml.safe_load(wb_def)"},{"line_number":740,"context_line":"            if wf_name not in wb_def[\"workflows\"]:"},{"line_number":741,"context_line":"                raise ValueError("},{"line_number":742,"context_line":"                    \"workflow \u0027{}\u0027 not found in the definition \u0027{}\u0027\".format("},{"line_number":743,"context_line":"                        wf_name,"},{"line_number":744,"context_line":"                        wb_def"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_853cf430","line":741,"in_reply_to":"9a89bdaa_4e64dbe4","updated":"2016-09-22 13:28:53.000000000","message":"Done","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ec53cdaec667fc984b5f6f9c2e95710b1788ad75","unresolved":false,"context_lines":[{"line_number":741,"context_line":"                raise ValueError("},{"line_number":742,"context_line":"                    \"workflow \u0027{}\u0027 not found in the definition \u0027{}\u0027\".format("},{"line_number":743,"context_line":"                        wf_name,"},{"line_number":744,"context_line":"                        wb_def"},{"line_number":745,"context_line":"                    )"},{"line_number":746,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_ee7a0f77","line":744,"updated":"2016-09-08 22:09:10.000000000","message":"Please make it in 2 line less","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"4abb6d3f59c4b4a1c6b26b0017013aa942028934","unresolved":false,"context_lines":[{"line_number":741,"context_line":"                raise ValueError("},{"line_number":742,"context_line":"                    \"workflow \u0027{}\u0027 not found in the definition \u0027{}\u0027\".format("},{"line_number":743,"context_line":"                        wf_name,"},{"line_number":744,"context_line":"                        wb_def"},{"line_number":745,"context_line":"                    )"},{"line_number":746,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_608996ca","line":744,"in_reply_to":"9a89bdaa_ee7a0f77","updated":"2016-09-22 13:28:53.000000000","message":"Done","commit_id":"e33ed76224d595172d56326d6a8bdd7eef770dcc"}],"samples/tasks/scenarios/mistral/create-delete-execution-with-workflow-name.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            },"},{"line_number":14,"context_line":"            \"context\": {"},{"line_number":15,"context_line":"                \"users\": {"},{"line_number":16,"context_line":"                    \"tenants\": 1,"},{"line_number":17,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":18,"context_line":"                }"},{"line_number":19,"context_line":"            }"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_38054b10","line":16,"updated":"2016-10-09 22:47:41.000000000","message":"please increase it to 2","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            },"},{"line_number":14,"context_line":"            \"context\": {"},{"line_number":15,"context_line":"                \"users\": {"},{"line_number":16,"context_line":"                    \"tenants\": 1,"},{"line_number":17,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":18,"context_line":"                }"},{"line_number":19,"context_line":"            }"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_54649bb7","line":16,"in_reply_to":"1a95cdbc_38054b10","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"context\": {"},{"line_number":15,"context_line":"                \"users\": {"},{"line_number":16,"context_line":"                    \"tenants\": 1,"},{"line_number":17,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":18,"context_line":"                }"},{"line_number":19,"context_line":"            }"},{"line_number":20,"context_line":"        }"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_18024f0a","line":17,"updated":"2016-10-09 22:47:41.000000000","message":"please increase it to 2","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"context\": {"},{"line_number":15,"context_line":"                \"users\": {"},{"line_number":16,"context_line":"                    \"tenants\": 1,"},{"line_number":17,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":18,"context_line":"                }"},{"line_number":19,"context_line":"            }"},{"line_number":20,"context_line":"        }"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_945aa3f0","line":17,"in_reply_to":"1a95cdbc_18024f0a","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":18,"context_line":"                }"},{"line_number":19,"context_line":"            }"},{"line_number":20,"context_line":"        }"},{"line_number":21,"context_line":"    ]"},{"line_number":22,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_b50a4624","line":20,"updated":"2016-10-09 22:47:41.000000000","message":"please add sla section","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":17,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":18,"context_line":"                }"},{"line_number":19,"context_line":"            }"},{"line_number":20,"context_line":"        }"},{"line_number":21,"context_line":"    ]"},{"line_number":22,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_f46be782","line":20,"in_reply_to":"1a95cdbc_b50a4624","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"samples/tasks/scenarios/mistral/create-delete-execution-with-workflow-name.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      context:"},{"line_number":13,"context_line":"        users:"},{"line_number":14,"context_line":"          tenants: 1"},{"line_number":15,"context_line":"          users_per_tenant: 1"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_780b5324","line":15,"updated":"2016-10-09 22:47:41.000000000","message":"same comments as in json","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      context:"},{"line_number":13,"context_line":"        users:"},{"line_number":14,"context_line":"          tenants: 1"},{"line_number":15,"context_line":"          users_per_tenant: 1"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_34caaf1b","line":15,"in_reply_to":"1a95cdbc_780b5324","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"samples/tasks/scenarios/mistral/create-delete-execution.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":17,"context_line":"                }"},{"line_number":18,"context_line":"            }"},{"line_number":19,"context_line":"        }"},{"line_number":20,"context_line":"    ]"},{"line_number":21,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_98165f4a","line":19,"updated":"2016-10-09 22:47:41.000000000","message":"the same as for previous sample","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":16,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":17,"context_line":"                }"},{"line_number":18,"context_line":"            }"},{"line_number":19,"context_line":"        }"},{"line_number":20,"context_line":"    ]"},{"line_number":21,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_b4debfda","line":19,"in_reply_to":"1a95cdbc_98165f4a","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"samples/tasks/scenarios/mistral/create-delete-execution.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      context:"},{"line_number":12,"context_line":"        users:"},{"line_number":13,"context_line":"          tenants: 1"},{"line_number":14,"context_line":"          users_per_tenant: 1"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_b8115b54","line":14,"updated":"2016-10-09 22:47:41.000000000","message":"the same as for previous sample","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      context:"},{"line_number":12,"context_line":"        users:"},{"line_number":13,"context_line":"          tenants: 1"},{"line_number":14,"context_line":"          users_per_tenant: 1"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_d4d98bf4","line":14,"in_reply_to":"1a95cdbc_b8115b54","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"samples/tasks/scenarios/mistral/create-execution-with-workflow-name.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"                    \"tenants\": 1,"},{"line_number":16,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":17,"context_line":"                }"},{"line_number":18,"context_line":"            }"},{"line_number":19,"context_line":"        }"},{"line_number":20,"context_line":"    ]"},{"line_number":21,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_d81c676c","line":18,"updated":"2016-10-09 22:47:41.000000000","message":"the same as for previous sample","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":15,"context_line":"                    \"tenants\": 1,"},{"line_number":16,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":17,"context_line":"                }"},{"line_number":18,"context_line":"            }"},{"line_number":19,"context_line":"        }"},{"line_number":20,"context_line":"    ]"},{"line_number":21,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_14e05395","line":18,"in_reply_to":"1a95cdbc_d81c676c","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"samples/tasks/scenarios/mistral/create-execution-with-workflow-name.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      context:"},{"line_number":12,"context_line":"        users:"},{"line_number":13,"context_line":"          tenants: 1"},{"line_number":14,"context_line":"          users_per_tenant: 1"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_f8176342","line":14,"updated":"2016-10-09 22:47:41.000000000","message":"the same as for previous sample","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      context:"},{"line_number":12,"context_line":"        users:"},{"line_number":13,"context_line":"          tenants: 1"},{"line_number":14,"context_line":"          users_per_tenant: 1"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_34f1cf6b","line":14,"in_reply_to":"1a95cdbc_f8176342","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"samples/tasks/scenarios/mistral/create-execution.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":16,"context_line":"                }"},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        }"},{"line_number":19,"context_line":"    ]"},{"line_number":20,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_18296f8a","line":18,"updated":"2016-10-09 22:47:41.000000000","message":"the same as for previous sample","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":15,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":16,"context_line":"                }"},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        }"},{"line_number":19,"context_line":"    ]"},{"line_number":20,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_54f49b59","line":18,"in_reply_to":"1a95cdbc_18296f8a","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"samples/tasks/scenarios/mistral/create-execution.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      context:"},{"line_number":11,"context_line":"        users:"},{"line_number":12,"context_line":"          tenants: 1"},{"line_number":13,"context_line":"          users_per_tenant: 1"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_382c6b98","line":13,"updated":"2016-10-09 22:47:41.000000000","message":"the same as for previous sample","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      context:"},{"line_number":11,"context_line":"        users:"},{"line_number":12,"context_line":"          tenants: 1"},{"line_number":13,"context_line":"          users_per_tenant: 1"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_94eaa372","line":13,"in_reply_to":"1a95cdbc_382c6b98","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"samples/tasks/scenarios/mistral/list-executions.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"                    \"tenants\": 1,"},{"line_number":12,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":13,"context_line":"                }"},{"line_number":14,"context_line":"            }"},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"    ]"},{"line_number":17,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_782273a4","line":14,"updated":"2016-10-09 22:47:41.000000000","message":"the same as for previous sample","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":11,"context_line":"                    \"tenants\": 1,"},{"line_number":12,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":13,"context_line":"                }"},{"line_number":14,"context_line":"            }"},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"    ]"},{"line_number":17,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a95cdbc_b405df46","line":14,"in_reply_to":"1a95cdbc_782273a4","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"samples/tasks/scenarios/mistral/list-executions.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      context:"},{"line_number":9,"context_line":"        users:"},{"line_number":10,"context_line":"          tenants: 1"},{"line_number":11,"context_line":"          users_per_tenant: 1"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_b8387bd4","line":11,"updated":"2016-10-09 22:47:41.000000000","message":"the same as for previous sample","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      context:"},{"line_number":9,"context_line":"        users:"},{"line_number":10,"context_line":"          tenants: 1"},{"line_number":11,"context_line":"          users_per_tenant: 1"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_f4fbe744","line":11,"in_reply_to":"1a95cdbc_b8387bd4","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"tests/unit/plugins/openstack/scenarios/mistral/test_executions.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# import ddt"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from rally.plugins.openstack.scenarios.mistral import executions"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_98b2df4a","line":16,"updated":"2016-10-09 22:47:41.000000000","message":"yeah, its reasonable to use it in this file","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# import ddt"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from rally.plugins.openstack.scenarios.mistral import executions"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_4d640eb8","line":16,"in_reply_to":"1a95cdbc_98b2df4a","updated":"2016-10-10 11:39:23.000000000","message":"Forgot to delete this line, will do so now.\nI originally wanted to use this module, but I didn\u0027t have time to find an example of how to use both @ddt.data and @mock.patch.","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"tests/unit/plugins/openstack/scenarios/mistral/test_utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"195fe4c90cc363dae3b4b544686d7fe89480a93d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        definition \u003d \"version: \\\"2.0\\\"\\nname: wb\""},{"line_number":38,"context_line":"        scenario \u003d utils.MistralScenario(context\u003dself.context)"},{"line_number":39,"context_line":"        self.assertEqual("},{"line_number":40,"context_line":"            scenario._create_workbook(definition),"},{"line_number":41,"context_line":"            self.clients(\"mistral\").workbooks.create.return_value"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        self._test_atomic_action_timer("}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_b83ddb2c","line":40,"updated":"2016-10-09 22:47:41.000000000","message":"wrong order of parameters of assertEqual all the where in the file","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"dc7be0fa6075c6ce36586a7a6ccd120133d9ee88","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        definition \u003d \"version: \\\"2.0\\\"\\nname: wb\""},{"line_number":38,"context_line":"        scenario \u003d utils.MistralScenario(context\u003dself.context)"},{"line_number":39,"context_line":"        self.assertEqual("},{"line_number":40,"context_line":"            scenario._create_workbook(definition),"},{"line_number":41,"context_line":"            self.clients(\"mistral\").workbooks.create.return_value"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        self._test_atomic_action_timer("}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_77fd196d","line":40,"in_reply_to":"1a95cdbc_b83ddb2c","updated":"2016-10-10 11:39:23.000000000","message":"Done","commit_id":"78789be0864cb421b515ab5ae715c73aa3b227be"}],"tests/unit/task/test_validation.py":[{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"9e8d4e83bcbcd669a88229231e37496f78c8f569","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        result \u003d validator("},{"line_number":372,"context_line":"            {\"args\": {\"share_proto\": share_proto}}, \"clients\", \"deployment\")"},{"line_number":373,"context_line":"        self.assertTrue(result.is_valid, result.msg)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def test_image_exists(self):"},{"line_number":376,"context_line":"        validator \u003d self._unwrap_validator(validation.image_exists, \"param\")"},{"line_number":377,"context_line":"        result \u003d validator({}, \"clients\", \"deployment\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_c9399043","line":374,"updated":"2016-08-31 17:15:23.000000000","message":"this deletion was by mistake, will get the code back in the next PS","commit_id":"fff80ad56fb8ba598ac65cb65655b3d8a9f0b8c2"}]}